June 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: osmo-bts-trx: fix spurious clock skew shutdown after self-compensation
by fixeria 30 Jun '26

30 Jun '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42855?usp=email ) Change subject: osmo-bts-trx: fix spurious clock skew shutdown after self-compensation ...................................................................... osmo-bts-trx: fix spurious clock skew shutdown after self-compensation When the BTS runs ahead of the transceiver (elapsed_fn < 0), trx_sched_clock() reschedules the timerfd to deliberately delay the next FN. osmo_timerfd_schedule() resets the timerfd and discards any accumulated expirations, but last_fn_timer.tv was left pointing at the previous callback. The next trx_fn_timer_cb() then measures elapsed_us all the way back to that previous callback - spanning the deliberate delay (or any OS stall that preceded us) - and falsely trips the "PC clock skew too high" check, shutting the BTS down for no good reason. Advance last_fn_timer.tv to the projected firing time of the rescheduled timer so that the next callback measures roughly one FN interval, as expected. Change-Id: Icdb7db8abe70258ae008d9514b6608bd74bb2881 AI-Assisted: yes (Claude) Related: OS#6794 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index a4585ae..261d37b 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -616,13 +616,20 @@ /* too many frames have been processed already */ if (elapsed_fn < 0) { struct timespec first = interval; - /* set clock to the time or last FN should have been - * transmitted. */ + /* set clock to the time our next FN has to be transmitted */ first.tv_nsec += (0 - elapsed_fn) * GSM_TDMA_FN_DURATION_nS; normalize_timespec(&first); LOGP(DL1C, LOGL_NOTICE, "We were %d FN faster than TRX, compensating\n", -elapsed_fn); - /* set time to the time our next FN has to be transmitted */ osmo_timerfd_schedule(&tcs->fn_timer_ofd, &first, &interval); + /* Advance last_fn_timer.tv to the projected firing time of the rescheduled + * timer (shifted back one interval). osmo_timerfd_schedule() resets the + * timerfd, discarding any accumulated expirations, so without this update + * trx_fn_timer_cb() would measure elapsed_us all the way back to the previous + * callback — spanning the deliberate delay or any OS stall that preceded us — + * and falsely trip the clock skew threshold. */ + tcs->last_fn_timer.tv = tv_now; + tcs->last_fn_timer.tv.tv_nsec += (0 - elapsed_fn) * GSM_TDMA_FN_DURATION_nS; + normalize_timespec(&tcs->last_fn_timer.tv); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icdb7db8abe70258ae008d9514b6608bd74bb2881 Gerrit-Change-Number: 42855 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in onomondo-eim[master]: asn1/SGP32Definitions: apply workarounds
by dexter 30 Jun '26

30 Jun '26

Attention is currently required from: jolly, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42870?usp=email ) Change subject: asn1/SGP32Definitions: apply workarounds ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > well, then include that checkpatch exception in the (previous) patch 😊 Thanks for the hint. -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Id90b005fc3c8c8f737b0c740d4c067f90842a1fe Gerrit-Change-Number: 42870 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Jun 2026 09:54:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: common: flush paging queue in nm_bts_fsm's NOTINSTALLED on_enter
by laforge 30 Jun '26

30 Jun '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42910?usp=email ) Change subject: common: flush paging queue in nm_bts_fsm's NOTINSTALLED on_enter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I109ab282986b68b68ba5c11859c44b771c0416fd Gerrit-Change-Number: 42910 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 09:54:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: oml: validate Intave Parameter range in SET BTS ATTR
by laforge 30 Jun '26

30 Jun '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42908?usp=email ) Change subject: oml: validate Intave Parameter range in SET BTS ATTR ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/42908/comment/afa1ad7a_f3b89ff8?usp… : PS1, Line 20: AI-Assisted: yes (Claude) > Pet-Assisted: yes (my cat laying by my side) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id4d3353d4397aaa2517091b020d38ee15e084e2c Gerrit-Change-Number: 42908 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 09:54:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: l1sap: fix duplicate RF RESOURCE INDICATION on clock bootstrap
by laforge 30 Jun '26

30 Jun '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42907?usp=email ) Change subject: l1sap: fix duplicate RF RESOURCE INDICATION on clock bootstrap ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42907?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6550178427b08e67c9763f0f37efff5b88960b1f Gerrit-Change-Number: 42907 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 09:53:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in onomondo-eim[master]: asn1/SGP32Definitions: upgrade ASN.1 spec to V.1.2
by dexter 30 Jun '26

30 Jun '26

Attention is currently required from: fixeria, jolly, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42869?usp=email ) Change subject: asn1/SGP32Definitions: upgrade ASN.1 spec to V.1.2 ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > @pmaier@sysmocom. […] Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Id4d217296f43846aa39f5dc7076465e2dab72a7c Gerrit-Change-Number: 42869 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 09:47:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XL] Change in onomondo-eim[master]: asn1/SGP32Definitions: upgrade ASN.1 spec to V.1.2
by dexter 30 Jun '26

30 Jun '26

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42869?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: asn1/SGP32Definitions: upgrade ASN.1 spec to V.1.2 ...................................................................... asn1/SGP32Definitions: upgrade ASN.1 spec to V.1.2 This replaces the existing SGP.32 V.1.0.1 ASN.1 spec with the unmodified, official SGP.32 V.1.2 spec. Unfortunately V.1.2 is not backward compatible to V.1.0.1. This means that the eIM application will still compile, but the result will be non-functional. The incompatibility problems will be addressed in the follow-up patches of this patchset. Change-Id: Id4d217296f43846aa39f5dc7076465e2dab72a7c Related: SYS#8100 --- A .checkpatch.conf M asn1/SGP32Definitions.asn1 2 files changed, 729 insertions(+), 636 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/69/42869/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Id4d217296f43846aa39f5dc7076465e2dab72a7c Gerrit-Change-Number: 42869 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: WIP: fixup for PCU_Tests: use PCUIF v.11 exclusively
by dexter 30 Jun '26

30 Jun '26

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34069?usp=email ) Change subject: WIP: fixup for PCU_Tests: use PCUIF v.11 exclusively ...................................................................... Abandoned this patch is no longer needed -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34069?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e72cbf4bcc2fc4fa305861bd7cf08e00ef7df1d Gerrit-Change-Number: 34069 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-ci[master]: jobs/{master,gerrit}: eim,ipa: wipe-workspace
by laforge 30 Jun '26

30 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42899?usp=email ) Change subject: jobs/{master,gerrit}: eim,ipa: wipe-workspace ...................................................................... jobs/{master,gerrit}: eim,ipa: wipe-workspace Set wipe-workspace for the onomondo-eim and onomondo-ipa jobs to true, so previous failures cannot influence new jenkins job runs. E.g. currently we had gerrit-onomondo-ipa-build failing with: + mkdir build mkdir: cannot create directory 'build': File exists Most existing jobs call scripts/osmo-clean-workspace.sh from osmo-ci.git at the beginning of their jenkins.sh instead of using wipe-workspace. But this doesn't have any advantage here while making jenkins.sh more complex. Let's use the built-in feature from jenkins here. Change-Id: If4ef5ab804b05ad630cfa770741fe6053fdfb637 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 10 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index a75d6be..9d40493 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -44,6 +44,7 @@ a4: !!python/tuple [default] combination_filter: '' sequential: false + wipe: false # most projects use osmo-clean-workspace.sh instead # most common build invocation # SYS_PTRACE is needed for ASAN (https://github.com/google/sanitizers/issues/764) # seccomp profile is needed for io_uring (OS#6405) @@ -196,9 +197,11 @@ - onomondo-eim: cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' pipeline_binpkgs: "" + wipe: true - onomondo-ipa: pipeline_binpkgs: "" + wipe: true - openggsn: a1_name: GTP @@ -863,7 +866,7 @@ refspec: $GERRIT_REFSPEC name: choosing-strategy: gerrit - wipe-workspace: false + wipe-workspace: '{obj:wipe}' skip-tag: true submodule: recursive: true diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 1900ffe..b59a923 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -17,6 +17,7 @@ a4: !!python/tuple [default] combination_filter: '' sequential: false + wipe: false # most projects use osmo-clean-workspace.sh instead # most common build invocation # SYS_PTRACE is needed for ASAN (https://github.com/google/sanitizers/issues/764) # seccomp profile is needed for io_uring (OS#6405) @@ -279,8 +280,11 @@ - onomondo-eim: cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' + wipe: true - - onomondo-ipa + - onomondo-ipa: + wipe: true + - osmo-bsc - osmo-bsc-nat @@ -746,7 +750,7 @@ - '$BRANCH' refspec: name: - wipe-workspace: false + wipe-workspace: '{obj:wipe}' skip-tag: true submodule: recursive: true -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If4ef5ab804b05ad630cfa770741fe6053fdfb637 Gerrit-Change-Number: 42899 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ci[master]: jobs/{master,gerrit}: eim,ipa: wipe-workspace
by laforge 30 Jun '26

30 Jun '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42899?usp=email ) Change subject: jobs/{master,gerrit}: eim,ipa: wipe-workspace ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If4ef5ab804b05ad630cfa770741fe6053fdfb637 Gerrit-Change-Number: 42899 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 09:34:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026