June 2026 - gerrit-log - lists.osmocom.org

[XS] Change in dahdi-linux[master]: drivers/dahdi/dahdi-base: fix linux 7.1 compat
by osmith 30 Jun '26

30 Jun '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email ) Change subject: drivers/dahdi/dahdi-base: fix linux 7.1 compat ...................................................................... drivers/dahdi/dahdi-base: fix linux 7.1 compat Adjust to the "code" argument of ppp_input_error() not existing anymore since abb0eb0b ("ppp: simplify input error handling"). Related: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… Change-Id: Ia17190e4bd8bcc480cbe98b55f930149e554a576 --- M drivers/dahdi/dahdi-base.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index a0238e6..657eb34 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -6394,7 +6394,11 @@ ppp_input(chan->ppp, skb); if (chan->do_ppp_error) { chan->do_ppp_error = 0; +#if LINUX_VERSION_CODE < KERNEL_VERSION(7, 1, 0) ppp_input_error(chan->ppp, 0); +#else + ppp_input_error(chan->ppp); +#endif } } #endif -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ia17190e4bd8bcc480cbe98b55f930149e554a576 Gerrit-Change-Number: 42904 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in dahdi-linux[master]: Adjust to strncpy removal in linux 7.2-rc1
by osmith 30 Jun '26

30 Jun '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42906?usp=email ) Change subject: Adjust to strncpy removal in linux 7.2-rc1 ...................................................................... Adjust to strncpy removal in linux 7.2-rc1 Related: https://docs.kernel.org/process/deprecated.html#strncpy Related: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… Change-Id: I860344fd23d5780fc588d19388ad91c6f6bcfc90 --- M drivers/dahdi/dahdi-base.c M drivers/dahdi/xpp/mmapbus.c M drivers/dahdi/xpp/mmapdrv.c 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index 657eb34..5067c02 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -5449,7 +5449,7 @@ */ continue; } - strncpy(vi.echo_canceller, ec_name, space); + strscpy(vi.echo_canceller, ec_name, sizeof(vi.echo_canceller)); space -= strlen(ec_name); if (space < 1) break; diff --git a/drivers/dahdi/xpp/mmapbus.c b/drivers/dahdi/xpp/mmapbus.c index ddf083f..72c402e 100644 --- a/drivers/dahdi/xpp/mmapbus.c +++ b/drivers/dahdi/xpp/mmapbus.c @@ -40,7 +40,7 @@ dev->dev.bus = &mmap_bus_type; dev->dev.parent = &mmap_bus; dev->dev.release = mmap_dev_release; - strncpy(dev->dev.bus_id, dev->name, BUS_ID_SIZE); + strscpy(dev->dev.bus_id, dev->name, sizeof(dev->dev.bus_id)); return device_register(&dev->dev); } EXPORT_SYMBOL(register_mmap_device); diff --git a/drivers/dahdi/xpp/mmapdrv.c b/drivers/dahdi/xpp/mmapdrv.c index 2e0e298..0124b92 100644 --- a/drivers/dahdi/xpp/mmapdrv.c +++ b/drivers/dahdi/xpp/mmapdrv.c @@ -572,8 +572,8 @@ ret = -ENOMEM; goto fail_xbus; } - strncpy(global_xbus->connector, "mmap", XBUS_DESCLEN); - strncpy(global_xbus->label, "mmap:0", LABEL_SIZE); + strscpy(global_xbus->connector, "mmap", sizeof(global_xbus->connector)); + strscpy(global_xbus->label, "mmap:0", sizeof(global_xbus->label)); xframe_queue_init(&txpool, 10, 200, "mmap_txpool", global_xbus); if (! -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42906?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I860344fd23d5780fc588d19388ad91c6f6bcfc90 Gerrit-Change-Number: 42906 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in dahdi-linux[master]: Adjust to strncpy removal in linux 7.2-rc1
by osmith 30 Jun '26

30 Jun '26

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42906?usp=email ) Change subject: Adjust to strncpy removal in linux 7.2-rc1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42906?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I860344fd23d5780fc588d19388ad91c6f6bcfc90 Gerrit-Change-Number: 42906 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 07:59:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/dahdi-base: fix linux 7.1 compat
by osmith 30 Jun '26

30 Jun '26

Attention is currently required from: laforge. osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email ) Change subject: drivers/dahdi/dahdi-base: fix linux 7.1 compat ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ia17190e4bd8bcc480cbe98b55f930149e554a576 Gerrit-Change-Number: 42904 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/dahdi-base: fix linux 7.1 compat
by osmith 30 Jun '26

30 Jun '26

Attention is currently required from: laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email ) Change subject: drivers/dahdi/dahdi-base: fix linux 7.1 compat ...................................................................... Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ia17190e4bd8bcc480cbe98b55f930149e554a576 Gerrit-Change-Number: 42904 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Jun 2026 07:58:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: Adjust to strncpy removal in linux 7.2-rc1
by daniel 30 Jun '26

30 Jun '26

Attention is currently required from: osmith. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42906?usp=email ) Change subject: Adjust to strncpy removal in linux 7.2-rc1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42906?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I860344fd23d5780fc588d19388ad91c6f6bcfc90 Gerrit-Change-Number: 42906 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 07:58:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/dahdi-base: fix linux 7.1 compat
by daniel 30 Jun '26

30 Jun '26

Attention is currently required from: laforge, osmith. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email ) Change subject: drivers/dahdi/dahdi-base: fix linux 7.1 compat ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ia17190e4bd8bcc480cbe98b55f930149e554a576 Gerrit-Change-Number: 42904 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Jun 2026 07:56:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: lint: ignore LINUX_VERSION_CODE
by daniel 30 Jun '26

30 Jun '26

Attention is currently required from: fixeria, osmith. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42905?usp=email ) Change subject: lint: ignore LINUX_VERSION_CODE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42905?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I82d64d43c04561b1643785cb71cfee92e513e560 Gerrit-Change-Number: 42905 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 07:55:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: common: reset lchan meas state in gsm_ts_release()
by fixeria 29 Jun '26

29 Jun '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42909?usp=email ) Change subject: common: reset lchan meas state in gsm_ts_release() ...................................................................... Patch Set 1: (1 comment) File src/common/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bts/+/42909/comment/3a16f824_2a68d0ac?usp… : PS1, Line 344: lchan_meas_reset(lchan); > imho this doesn't belong here, but inside lchan code/FSM triggered by gsm_lchan_release() above. `gsm_lchan_release()` returns early if `lchan->state == LCHAN_S_NONE` (not active), i.e. it's only resetting the state of active logical channels. I need the meas state to be reset for inactive channels too. I think we can move this `lchan_meas_reset()` call before the `lchan->state == LCHAN_S_NONE` check, so that the meas state is reset regardless of the state. What do you think? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I18dc9d30417b0c5b2e579660d4a087d93445f956 Gerrit-Change-Number: 42909 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2026 21:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: common: flush paging queue in nm_bts_fsm's NOTINSTALLED on_enter
by fixeria 29 Jun '26

29 Jun '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42910?usp=email ) Change subject: common: flush paging queue in nm_bts_fsm's NOTINSTALLED on_enter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I109ab282986b68b68ba5c11859c44b771c0416fd Gerrit-Change-Number: 42910 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2026 21:40:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026