June 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: common: stop buffering UL measurements when SACCH is deactivated
by fixeria 29 Jun '26

29 Jun '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email ) Change subject: common: stop buffering UL measurements when SACCH is deactivated ...................................................................... common: stop buffering UL measurements when SACCH is deactivated When the BSC sends RSL DEACT SACCH, the per-SACCH UL measurement drain stops (it runs on SACCH timing), but the producer in lchan_new_ul_meas() keeps appending the measurement contributions from every received TCH/SDCCH burst. After one SACCH period (104 frames) the 104-slot uplink measurement buffer fills up, yielding a flood of: NOTICE measurement.c:336 no space for uplink measurement, num_ul_meas=104 Add a bool sacch_active flag to gsm_lchan, set to true in the common l1sap_chan_act() and clear in l1sap_chan_deact_sacch(). Guard lchan_new_ul_meas() with this flag so that measurements are silently discarded while SACCH is inactive - there is nothing to drain the buffer and no SACCH channel on which to report the results to the BSC. Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7 AI-Assisted: yes (Claude) --- M include/osmo-bts/lchan.h M src/common/l1sap.c M src/common/measurement.c 3 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/42911/1 diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h index 071197d..909768d 100644 --- a/include/osmo-bts/lchan.h +++ b/include/osmo-bts/lchan.h @@ -210,6 +210,7 @@ * want_dl_sacch_active indicates whether dl SACCH should be activated on CHAN ACT. */ bool want_dl_sacch_active; + bool ul_sacch_active; /* UL SACCH measurements active (cleared by RSL DEACT SACCH) */ /* Number of different GsmL1_Sapi_t used in osmo_bts_sysmo is 23. * Currently we don't share these headers so this is a magic number. */ diff --git a/src/common/l1sap.c b/src/common/l1sap.c index f11bb2c..ae89d23 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -2982,6 +2982,7 @@ LOGPLCHAN(lchan, DL1C, LOGL_INFO, "Activating channel %s\n", rsl_chan_nr_str(chan_nr)); radio_link_timeout_reset(lchan); + lchan->ul_sacch_active = true; rc = l1sap_chan_act_dact_modify(trx, chan_nr, PRIM_INFO_ACTIVATE, 0); if (rc) @@ -3055,6 +3056,8 @@ LOGPLCHAN(lchan, DL1C, LOGL_INFO, "Deactivating SACCH on channel %s\n", rsl_chan_nr_str(chan_nr)); + lchan->ul_sacch_active = false; + return l1sap_chan_act_dact_modify(trx, chan_nr, PRIM_INFO_DEACTIVATE, 1); } diff --git a/src/common/measurement.c b/src/common/measurement.c index afbdc84..8bb3e6e 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -332,6 +332,11 @@ gsm_lchans_name(lchan->state), lchan->meas.num_ul_meas, fn_mod); } + /* No point buffering measurements when SACCH is deactivated: the drain + * runs on SACCH timing, so the buffer would fill up and overflow. */ + if (!lchan->ul_sacch_active) + return 0; + if (lchan->meas.num_ul_meas >= ARRAY_SIZE(lchan->meas.uplink)) { LOGPLCFN(lchan, fn, DMEAS, LOGL_NOTICE, "no space for uplink measurement, num_ul_meas=%d, fn_mod=%u\n", lchan->meas.num_ul_meas, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7 Gerrit-Change-Number: 42911 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/dahdi-base: fix linux 7.1 compat
by osmith 29 Jun '26

29 Jun '26

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email ) Change subject: drivers/dahdi/dahdi-base: fix linux 7.1 compat ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Passes for all except current linux master. See the follow-up patch for fixing what fails there. -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ia17190e4bd8bcc480cbe98b55f930149e554a576 Gerrit-Change-Number: 42904 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 29 Jun 2026 13:40:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in dahdi-linux[master]: Adjust to strncpy removal in linux 7.2-rc1
by osmith 29 Jun '26

29 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42906?usp=email ) Change subject: Adjust to strncpy removal in linux 7.2-rc1 ...................................................................... Adjust to strncpy removal in linux 7.2-rc1 Related: https://docs.kernel.org/process/deprecated.html#strncpy Related: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… Change-Id: I860344fd23d5780fc588d19388ad91c6f6bcfc90 --- M drivers/dahdi/dahdi-base.c M drivers/dahdi/xpp/mmapbus.c M drivers/dahdi/xpp/mmapdrv.c 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/06/42906/1 diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index 657eb34..5067c02 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -5449,7 +5449,7 @@ */ continue; } - strncpy(vi.echo_canceller, ec_name, space); + strscpy(vi.echo_canceller, ec_name, sizeof(vi.echo_canceller)); space -= strlen(ec_name); if (space < 1) break; diff --git a/drivers/dahdi/xpp/mmapbus.c b/drivers/dahdi/xpp/mmapbus.c index ddf083f..72c402e 100644 --- a/drivers/dahdi/xpp/mmapbus.c +++ b/drivers/dahdi/xpp/mmapbus.c @@ -40,7 +40,7 @@ dev->dev.bus = &mmap_bus_type; dev->dev.parent = &mmap_bus; dev->dev.release = mmap_dev_release; - strncpy(dev->dev.bus_id, dev->name, BUS_ID_SIZE); + strscpy(dev->dev.bus_id, dev->name, sizeof(dev->dev.bus_id)); return device_register(&dev->dev); } EXPORT_SYMBOL(register_mmap_device); diff --git a/drivers/dahdi/xpp/mmapdrv.c b/drivers/dahdi/xpp/mmapdrv.c index 2e0e298..0124b92 100644 --- a/drivers/dahdi/xpp/mmapdrv.c +++ b/drivers/dahdi/xpp/mmapdrv.c @@ -572,8 +572,8 @@ ret = -ENOMEM; goto fail_xbus; } - strncpy(global_xbus->connector, "mmap", XBUS_DESCLEN); - strncpy(global_xbus->label, "mmap:0", LABEL_SIZE); + strscpy(global_xbus->connector, "mmap", sizeof(global_xbus->connector)); + strscpy(global_xbus->label, "mmap:0", sizeof(global_xbus->label)); xframe_queue_init(&txpool, 10, 200, "mmap_txpool", global_xbus); if (! -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42906?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I860344fd23d5780fc588d19388ad91c6f6bcfc90 Gerrit-Change-Number: 42906 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: lint: ignore LINUX_VERSION_CODE
by osmith 29 Jun '26

29 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42905?usp=email ) Change subject: lint: ignore LINUX_VERSION_CODE ...................................................................... lint: ignore LINUX_VERSION_CODE When running the linter against dahdi-linux.git or potentially other repositories with out-of-tree linux kernel modules, it should not complain about the LINUX_VERSION_CODE being used there: > drivers/dahdi/dahdi-base.c:6397: WARNING:LINUX_VERSION_CODE: > LINUX_VERSION_CODE should be avoided, code should be for the version to > which it is merged Change-Id: I82d64d43c04561b1643785cb71cfee92e513e560 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/05/42905/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 50551b0..ec10b0c 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -68,6 +68,7 @@ # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html # * LINE_CONTINUATIONS: false positives # * LINE_SPACING: we don't always put a blank line after declarations +# * LINUX_VERSION_CODE: warns about using LINUX_VERSION_CODE, which doesn't make sense outside of the kernel # * LONG_LINE*: should be 120 chars, but exceptions are done often so don't fail here # * MACRO_WITH_FLOW_CONTROL: not followed # * MISSING_SPACE: warns about breaking strings at space characters, not useful for long strings of hex chars @@ -106,6 +107,7 @@ --ignore INITIALISED_STATIC \ --ignore LINE_CONTINUATIONS \ --ignore LINE_SPACING \ + --ignore LINUX_VERSION_CODE \ --ignore LONG_LINE \ --ignore LONG_LINE_COMMENT \ --ignore LONG_LINE_STRING \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42905?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I82d64d43c04561b1643785cb71cfee92e513e560 Gerrit-Change-Number: 42905 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/dahdi-base: fix linux 7.1 compat
by osmith 29 Jun '26

29 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email ) Change subject: drivers/dahdi/dahdi-base: fix linux 7.1 compat ...................................................................... drivers/dahdi/dahdi-base: fix linux 7.1 compat Adjust to the "code" argument of ppp_input_error() not existing anymore since abb0eb0b ("ppp: simplify input error handling"). Related: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… Change-Id: Ia17190e4bd8bcc480cbe98b55f930149e554a576 --- M drivers/dahdi/dahdi-base.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/04/42904/1 diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index a0238e6..657eb34 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -6394,7 +6394,11 @@ ppp_input(chan->ppp, skb); if (chan->do_ppp_error) { chan->do_ppp_error = 0; +#if LINUX_VERSION_CODE < KERNEL_VERSION(7, 1, 0) ppp_input_error(chan->ppp, 0); +#else + ppp_input_error(chan->ppp); +#endif } } #endif -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ia17190e4bd8bcc480cbe98b55f930149e554a576 Gerrit-Change-Number: 42904 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: src/utils.erl: format with erlfmt
by osmith 29 Jun '26

29 Jun '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42903?usp=email ) Change subject: src/utils.erl: format with erlfmt ...................................................................... src/utils.erl: format with erlfmt Keep the file consistent with the rest of the codebase by running 'rebar3 fmt -w' on it. Change-Id: I806c912a1bc82c26ecd23759a927f22328e743b9 --- M src/utils.erl 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/utils.erl b/src/utils.erl index d46dc2a..cbe0bf4 100644 --- a/src/utils.erl +++ b/src/utils.erl @@ -5,8 +5,15 @@ % Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH -module(utils). --export([binary_to_hex/1, hex_to_binary/1, join_binary_list/1, integer_to_bytes/1, lpad_binary/3, - get_priv_file_path/2, get_env_priv_file_path/2]). +-export([ + binary_to_hex/1, + hex_to_binary/1, + join_binary_list/1, + integer_to_bytes/1, + lpad_binary/3, + get_priv_file_path/2, + get_env_priv_file_path/2 +]). % Converts a single hex digit (e.g. <<"A">>) into its integer representation. hexstr_digit_to_int(HexDigit) -> -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I806c912a1bc82c26ecd23759a927f22328e743b9 Gerrit-Change-Number: 42903 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: contrib/jenkins: run 'rebar3 fmt --check'
by osmith 29 Jun '26

29 Jun '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42868?usp=email ) Change subject: contrib/jenkins: run 'rebar3 fmt --check' ...................................................................... contrib/jenkins: run 'rebar3 fmt --check' The pull request "v0.0.2" had a patch that formatted everything with erlfmt. Let's run it in CI to keep the style consistent. Related: https://github.com/onomondo/onomondo-eim/pull/10/commits/8bafdb3839d868d6bc… Change-Id: I271c90dace6e7b6f052b38054815e6dfcbfa60f5 --- M contrib/jenkins.sh 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index e39a69a..2d086b5 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -3,3 +3,13 @@ rebar3 compile rebar3 eunit + +if ! rebar3 fmt --check; then + rebar3 fmt -w + git diff + set +x + echo + echo "ERROR: please run 'rebar3 fmt -w' and re-submit the patch" + echo + exit 1 +fi -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I271c90dace6e7b6f052b38054815e6dfcbfa60f5 Gerrit-Change-Number: 42868 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: contrib/jenkins: run 'rebar3 fmt --check'
by fixeria 29 Jun '26

29 Jun '26

Attention is currently required from: dexter, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42868?usp=email ) Change subject: contrib/jenkins: run 'rebar3 fmt --check' ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I271c90dace6e7b6f052b38054815e6dfcbfa60f5 Gerrit-Change-Number: 42868 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2026 10:06:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-eim[master]: src/utils.erl: format with erlfmt
by fixeria 29 Jun '26

29 Jun '26

Attention is currently required from: dexter, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42903?usp=email ) Change subject: src/utils.erl: format with erlfmt ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I806c912a1bc82c26ecd23759a927f22328e743b9 Gerrit-Change-Number: 42903 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2026 10:06:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-eim[master]: src/utils.erl: format with erlfmt
by osmith 29 Jun '26

29 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42903?usp=email ) Change subject: src/utils.erl: format with erlfmt ...................................................................... src/utils.erl: format with erlfmt Keep the file consistent with the rest of the codebase by running 'rebar3 fmt -w' on it. Change-Id: I806c912a1bc82c26ecd23759a927f22328e743b9 --- M src/utils.erl 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/03/42903/1 diff --git a/src/utils.erl b/src/utils.erl index d46dc2a..cbe0bf4 100644 --- a/src/utils.erl +++ b/src/utils.erl @@ -5,8 +5,15 @@ % Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH -module(utils). --export([binary_to_hex/1, hex_to_binary/1, join_binary_list/1, integer_to_bytes/1, lpad_binary/3, - get_priv_file_path/2, get_env_priv_file_path/2]). +-export([ + binary_to_hex/1, + hex_to_binary/1, + join_binary_list/1, + integer_to_bytes/1, + lpad_binary/3, + get_priv_file_path/2, + get_env_priv_file_path/2 +]). % Converts a single hex digit (e.g. <<"A">>) into its integer representation. hexstr_digit_to_int(HexDigit) -> -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I806c912a1bc82c26ecd23759a927f22328e743b9 Gerrit-Change-Number: 42903 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026