June 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-dev[master]: src/grd: use origin url to get get host + project
by fixeria 29 Jun '26

29 Jun '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/42902?usp=email ) Change subject: src/grd: use origin url to get get host + project ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/42902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ib2b201e5238ba7036c6121e8875ee85c73da8751 Gerrit-Change-Number: 42902 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2026 09:55:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-dev[master]: src/grd: use sys.exit
by fixeria 29 Jun '26

29 Jun '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/42901?usp=email ) Change subject: src/grd: use sys.exit ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/42901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I95db013e36242d5126ce07b8a392e6dc0a0ecfdd Gerrit-Change-Number: 42901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2026 09:54:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-dev[master]: src/grd: use sys.exit
by daniel 29 Jun '26

29 Jun '26

Attention is currently required from: osmith. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/42901?usp=email ) Change subject: src/grd: use sys.exit ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/42901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I95db013e36242d5126ce07b8a392e6dc0a0ecfdd Gerrit-Change-Number: 42901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2026 09:54:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-dev[master]: src/grd: apply ruff formatter
by fixeria 29 Jun '26

29 Jun '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/42900?usp=email ) Change subject: src/grd: apply ruff formatter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/42900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Id8da8e6b3325c8301276fd164ba218e8c5a95951 Gerrit-Change-Number: 42900 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2026 09:53:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-dev[master]: src/grd: apply ruff formatter
by daniel 29 Jun '26

29 Jun '26

Attention is currently required from: fixeria, osmith. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/42900?usp=email ) Change subject: src/grd: apply ruff formatter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/42900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Id8da8e6b3325c8301276fd164ba218e8c5a95951 Gerrit-Change-Number: 42900 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2026 09:53:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-eim[master]: contrib/jenkins: run 'rebar3 fmt --check'
by osmith 29 Jun '26

29 Jun '26

Attention is currently required from: dexter, fixeria, osmith. Hello Jenkins Builder, dexter, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42868?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by fixeria, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: contrib/jenkins: run 'rebar3 fmt --check' ...................................................................... contrib/jenkins: run 'rebar3 fmt --check' The pull request "v0.0.2" had a patch that formatted everything with erlfmt. Let's run it in CI to keep the style consistent. Related: https://github.com/onomondo/onomondo-eim/pull/10/commits/8bafdb3839d868d6bc… Change-Id: I271c90dace6e7b6f052b38054815e6dfcbfa60f5 --- M contrib/jenkins.sh 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/68/42868/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I271c90dace6e7b6f052b38054815e6dfcbfa60f5 Gerrit-Change-Number: 42868 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/{master,gerrit}: eim,ipa: wipe-workspace
by fixeria 29 Jun '26

29 Jun '26

Attention is currently required from: dexter, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42899?usp=email ) Change subject: jobs/{master,gerrit}: eim,ipa: wipe-workspace ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If4ef5ab804b05ad630cfa770741fe6053fdfb637 Gerrit-Change-Number: 42899 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2026 09:41:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-dev[master]: src/grd: use sys.exit
by osmith 29 Jun '26

29 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/42901?usp=email ) Change subject: src/grd: use sys.exit ...................................................................... src/grd: use sys.exit The exit function is a constant from the site module, which "should not be used in programs". Replace it with sys.exit() Related: https://docs.python.org/3/library/constants.html#constants-added-by-the-sit… Change-Id: I95db013e36242d5126ce07b8a392e6dc0a0ecfdd --- M src/grd 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/01/42901/1 diff --git a/src/grd b/src/grd index 64de140..d86225d 100755 --- a/src/grd +++ b/src/grd @@ -8,8 +8,9 @@ import json import os import subprocess -import urllib.request +import sys import urllib.parse +import urllib.request def get_topdir(): @@ -22,14 +23,14 @@ ).stdout.rstrip() except subprocess.CalledProcessError: print("ERROR: not running inside a git repository") - exit(1) + sys.exit(1) def get_config_path(): ret = f"{get_topdir()}/.gitreview" if not os.path.exists(ret): print(f"ERROR: config not found: {ret}") - exit(1) + sys.exit(1) return ret @@ -72,7 +73,7 @@ try: return subprocess.run(cmd, check=True) except subprocess.CalledProcessError: - exit(1) + sys.exit(1) def git_cherry_pick_fetch_head(): @@ -82,7 +83,7 @@ try: return subprocess.run(cmd, check=True) except subprocess.CalledProcessError: - exit(1) + sys.exit(1) def git_checkout_fetch_head(patch_id, rev): @@ -92,7 +93,7 @@ try: return subprocess.run(cmd, check=True) except subprocess.CalledProcessError: - exit(1) + sys.exit(1) desc = "git review download: fetch and checkout a patch from gerrit" -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/42901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I95db013e36242d5126ce07b8a392e6dc0a0ecfdd Gerrit-Change-Number: 42901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-dev[master]: src/grd: apply ruff formatter
by osmith 29 Jun '26

29 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/42900?usp=email ) Change subject: src/grd: apply ruff formatter ...................................................................... src/grd: apply ruff formatter The src/grd script is not part of the default "include" pattern as the script does not end in ".py" (it used to be a shell script earlier). Add it to the config explicitly and run "ruff format". Change-Id: Id8da8e6b3325c8301276fd164ba218e8c5a95951 --- M .ruff.toml M src/grd 2 files changed, 35 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/00/42900/1 diff --git a/.ruff.toml b/.ruff.toml index 6c2df50..c673c3a 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -6,6 +6,10 @@ "osmo-cn-latest/provision-hlr.py", "sysmobts-calib.py", ] +include = [ + "*.py", + "src/grd", +] [lint] # E741: Ambiguous variable name: `l` diff --git a/src/grd b/src/grd index e149c6f..64de140 100755 --- a/src/grd +++ b/src/grd @@ -14,9 +14,12 @@ def get_topdir(): try: - return subprocess.run(["git", "rev-parse", "--show-toplevel"], - check=True, capture_output=True, - encoding="UTF-8").stdout.rstrip() + return subprocess.run( + ["git", "rev-parse", "--show-toplevel"], + check=True, + capture_output=True, + encoding="UTF-8", + ).stdout.rstrip() except subprocess.CalledProcessError: print("ERROR: not running inside a git repository") exit(1) @@ -71,8 +74,9 @@ except subprocess.CalledProcessError: exit(1) + def git_cherry_pick_fetch_head(): - cmd = ["git", "cherry-pick", "FETCH_HEAD"]; + cmd = ["git", "cherry-pick", "FETCH_HEAD"] print(f"+ {' '.join(cmd)}") try: @@ -80,6 +84,7 @@ except subprocess.CalledProcessError: exit(1) + def git_checkout_fetch_head(patch_id, rev): cmd = ["git", "checkout", "-B", f"gerrit/{patch_id}_{rev}", "FETCH_HEAD"] print(f"+ {' '.join(cmd)}") @@ -92,14 +97,28 @@ desc = "git review download: fetch and checkout a patch from gerrit" parser = argparse.ArgumentParser(description=desc) -parser.add_argument("patch_id", type=int, - help="gerrit review ID") -parser.add_argument("-c", "--cherry-pick", action="store_true", - help="cherry-pick into current branch instead of " - "fetching into a branch") -parser.add_argument("-r", "--revision", type=int, - help="patchset revision, default is latest") -parser.add_argument("-v", "--verbose", action="store_true") +parser.add_argument( + "patch_id", + type=int, + help="gerrit review ID", +) +parser.add_argument( + "-c", + "--cherry-pick", + action="store_true", + help="cherry-pick into current branch instead of fetching into a branch", +) +parser.add_argument( + "-r", + "--revision", + type=int, + help="patchset revision, default is latest", +) +parser.add_argument( + "-v", + "--verbose", + action="store_true", +) args = parser.parse_args() host, project = get_config() -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/42900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Id8da8e6b3325c8301276fd164ba218e8c5a95951 Gerrit-Change-Number: 42900 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-dev[master]: src/grd: use origin url to get get host + project
by osmith 29 Jun '26

29 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/42902?usp=email ) Change subject: src/grd: use origin url to get get host + project ...................................................................... src/grd: use origin url to get get host + project For most projects we can get the gerrit host and project from the git remote URL already. Do this when a git repository has no ".gitreview" file so it works even if the file is not present. Change-Id: Ib2b201e5238ba7036c6121e8875ee85c73da8751 --- M src/grd 1 file changed, 28 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/02/42902/1 diff --git a/src/grd b/src/grd index d86225d..3c0cf3f 100755 --- a/src/grd +++ b/src/grd @@ -28,14 +28,38 @@ def get_config_path(): ret = f"{get_topdir()}/.gitreview" - if not os.path.exists(ret): - print(f"ERROR: config not found: {ret}") - sys.exit(1) - return ret + return ret if os.path.exists(ret) else None + + +def exit_gerrit_host_project_unknown(): + print("ERROR: failed to get gerrit host and project") + print("Consider adding a .gitreview file:") + print(" [gerrit]") + print(" host=gerrit.osmocom.org") + print(" project=…") + sys.exit(1) + + +def get_config_from_origin_url(): + url = subprocess.run( + ["git", "config", "--get", "remote.origin.url"], + check=True, + capture_output=True, + encoding="UTF-8", + ).stdout.rstrip() + + if not url.startswith("https://gerrit.osmocom.org/"): + exit_gerrit_host_project_unknown() + + host = url.split("/")[2] + project = "/".join(url.split("/")[3:]) + return host, project def get_config(): config_path = get_config_path() + if not config_path: + return get_config_from_origin_url() config = configparser.ConfigParser() config.read(config_path) return config["gerrit"]["host"], config["gerrit"]["project"] -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/42902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ib2b201e5238ba7036c6121e8875ee85c73da8751 Gerrit-Change-Number: 42902 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026