June 2026 - gerrit-log - lists.osmocom.org

[L] Change in pysim[master]: add test_configurable_parameters.py
by laforge 18 Jun '26

18 Jun '26

Attention is currently required from: fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40823?usp=email ) Change subject: add test_configurable_parameters.py ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia55f0d11f8197ca15a948a83a34b3488acf1a0b4 Gerrit-Change-Number: 40823 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jun 2026 11:00:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: CCID: Add testenv.cfg to run tests using testenv
by laforge 18 Jun '26

18 Jun '26

Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42827?usp=email ) Change subject: CCID: Add testenv.cfg to run tests using testenv ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97c9da414facf438aa28d5200c4152730ff763a2 Gerrit-Change-Number: 42827 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 18 Jun 2026 10:57:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a...
by laforge 18 Jun '26

18 Jun '26

Attention is currently required from: fixeria, neels, pespin. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42829?usp=email ) Change subject: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 ...................................................................... Patch Set 4: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42829/comment/027bb27d_c5579098?usp=em… : PS4, Line 1737: So, when SUCI-CalcInfo for USIM in DF.SAIP contains both key types, : # then no profile-A or B services need to be requested explicitly. Your arguments/facts do not contradict my statement. Your comment claims > So, when SUCI-CalcInfo for USIM in DF.SAIP contains both key types, > then no profile-A or B services need to be requested explicitly. And this is what I'm contesting. If the SUCI-CalcInfo contains both key types, then we *must* require both A and B. The cellular network determines if and when which of the keys shall be sued, and if the MNO has issued an eSIM containing both A and B then they expect both of those to be operational. Otherwise that eSIM will fail every time one of the not-supported keys is requested to be used. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 Gerrit-Change-Number: 42829 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jun 2026 10:56:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ccid-firmware[master]: 7816fsm: Handle unexpected procedure bytes gracefully
by jolly 18 Jun '26

18 Jun '26

jolly has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email ) Change subject: 7816fsm: Handle unexpected procedure bytes gracefully ...................................................................... Patch Set 3: (1 comment) File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776/comment/43dc1b35_b8… : PS1, Line 1376: ISO7816_E_TPDU_FAILED_IND > given that ewild is on holidays fro some time: can you try to do this in an incremental patch yourse […] ack. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic53814540775f902fce644a5565a7bd2f177a7fe Gerrit-Change-Number: 42776 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 18 Jun 2026 10:54:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ccid-firmware[master]: 7816fsm: Handle unexpected procedure bytes gracefully
by laforge 18 Jun '26

18 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email ) Change subject: 7816fsm: Handle unexpected procedure bytes gracefully ...................................................................... 7816fsm: Handle unexpected procedure bytes gracefully Dispatch TPDU_FAILED_IND and don't assert for wrong procedure bytes. Closes:SYS#8050 Change-Id: Ic53814540775f902fce644a5565a7bd2f177a7fe --- M ccid_common/iso7816_fsm.c 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/ccid_common/iso7816_fsm.c b/ccid_common/iso7816_fsm.c index 4e4c2b1..9899e16 100644 --- a/ccid_common/iso7816_fsm.c +++ b/ccid_common/iso7816_fsm.c @@ -1398,8 +1398,11 @@ card_uart_ctrl(ip->uart, CUART_CTL_RX_TIMER_HINT, 1); osmo_fsm_inst_state_chg(fi, TPDU_S_RX_SINGLE, 0, 0); } - } else - OSMO_ASSERT(0); + } else { + LOGPFSML(fi, LOGL_ERROR, "Unexpected byte 0x%02x in procedure state (INS=0x%02x)\n", byte, tpduh->ins); + osmo_fsm_inst_state_chg(fi, TPDU_S_DONE, 0, 0); + osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_TPDU_FAILED_IND, tfp->tpdu); + } break; default: OSMO_ASSERT(0); @@ -1616,7 +1619,8 @@ S(TPDU_S_RX_SINGLE) | S(TPDU_S_TX_REMAINING) | S(TPDU_S_TX_SINGLE) | - S(TPDU_S_SW2), + S(TPDU_S_SW2) | + S(TPDU_S_DONE), .action = tpdu_s_procedure_action, }, [TPDU_S_TX_REMAINING] = { -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic53814540775f902fce644a5565a7bd2f177a7fe Gerrit-Change-Number: 42776 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ccid-firmware[master]: 7816fsm: Handle unexpected procedure bytes gracefully
by laforge 18 Jun '26

18 Jun '26

Attention is currently required from: Hoernchen, jolly, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email ) Change subject: 7816fsm: Handle unexpected procedure bytes gracefully ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS1: > I didn't bother formatting it because we never commited the updated rules nor the guards around the […] Done File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776/comment/90ce301f_ee… : PS1, Line 1376: ISO7816_E_TPDU_FAILED_IND > I suggest to introduce a new error event here. […] given that ewild is on holidays fro some time: can you try to do this in an incremental patch yourself, plase? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic53814540775f902fce644a5565a7bd2f177a7fe Gerrit-Change-Number: 42776 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 18 Jun 2026 10:53:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ccid-firmware[master]: 7816fsm: Handle unexpected procedure bytes gracefully
by laforge 18 Jun '26

18 Jun '26

Attention is currently required from: Hoernchen, jolly, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email ) Change subject: 7816fsm: Handle unexpected procedure bytes gracefully ...................................................................... Patch Set 2: Code-Review+1 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic53814540775f902fce644a5565a7bd2f177a7fe Gerrit-Change-Number: 42776 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 18 Jun 2026 10:52:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: shut down on stale clock indication from transceiver
by laforge 18 Jun '26

18 Jun '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42851?usp=email ) Change subject: osmo-bts-trx: shut down on stale clock indication from transceiver ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If787ab7ed70aa2dcb0389ceb58620c2302c3431a Gerrit-Change-Number: 42851 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jun 2026 10:50:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: osmo-bts-trx: reset BTS GSM time on clock (re)start
by laforge 18 Jun '26

18 Jun '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42850?usp=email ) Change subject: osmo-bts-trx: reset BTS GSM time on clock (re)start ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id8da126e460d3846a3be5bdb271553457fdd0590 Gerrit-Change-Number: 42850 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jun 2026 10:50:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-pcap[master]: tls: fix broken certificate hostname verification
by laforge 18 Jun '26

18 Jun '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42849?usp=email ) Change subject: tls: fix broken certificate hostname verification ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: If64950a698bfcfbf556a37ef1be3e68abc124384 Gerrit-Change-Number: 42849 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jun 2026 10:49:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026