Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42881?usp=email )
Change subject: esipa_rest_utils: add support for PSMOs added in SGP.32 V.1.2
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42881?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I03cdd70065a83dfc611d614cf32d817c13fad347
Gerrit-Change-Number: 42881
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Jun 2026 17:58:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42880?usp=email )
Change subject: rest_api: move "required" member to the correct level
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/onomondo-eim/+/42880/comment/fc954550_17cbf1c8… :
PS1, Line 10: lavel
level
https://gerrit.osmocom.org/c/onomondo-eim/+/42880/comment/6500609f_048ec83a… :
PS1, Line 12: on the same level as the "properties" member
mh? In some locations you find it on the same level as properties, but thta is incorrect and hence it should be on the same level as properties? that contradicts itself.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42880?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I07d51d0e809a718144bd51a6540ab51187bb4daa
Gerrit-Change-Number: 42880
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Jun 2026 17:58:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42879?usp=email )
Change subject: rest_api: revert json schema re-formatting
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File contrib/rest_api_info_schema.json:
https://gerrit.osmocom.org/c/onomondo-eim/+/42879/comment/3ce26835_fa4fbd2d… :
PS1, Line 43:
this line now uses tabs while others uses spacing? I guess it should standardize on either or. Looks like code above uses spaces only, while code further below and in the other file is tabs-only? Looks like chaos.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42879?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I2361891875a8e190fff7003196c2df76fd877080
Gerrit-Change-Number: 42879
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Jun 2026 17:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42834?usp=email )
Change subject: esipa_rest_utils: fix searchCritera.profileClass type conversion
......................................................................
esipa_rest_utils: fix searchCritera.profileClass type conversion
We currently use utils:hex_to_integer to convert the ProfileClass,
which is supposedly a string, to integer. However, hex_to_inteteger
does not exist and when looking into the related JSON schema
definition of we see that the profileClass member is already defined
as integer. This means that ProfileClass already arrives as integer
and can be used as it is. removing the hex_to_integer call solves
the problem.
Change-Id: I4bd223dbef00be9c800539b8d0dc9a84e3e93b73
Related: SYS#8100
---
M src/esipa_rest_utils.erl
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/esipa_rest_utils.erl b/src/esipa_rest_utils.erl
index 21fa3b3..efbf985 100644
--- a/src/esipa_rest_utils.erl
+++ b/src/esipa_rest_utils.erl
@@ -61,7 +61,7 @@
}};
{[{<<"profileClass">>, ProfileClass}]} ->
{listProfileInfo, #{
- searchCriteria => {profileClass, utils:hex_to_integer(ProfileClass)},
+ searchCriteria => {profileClass, ProfileClass},
tagList => utils:hex_to_binary(TagList)
}};
_ ->
@@ -76,7 +76,7 @@
{listProfileInfo, #{searchCriteria => {iccid, utils:hex_to_binary(Iccid)}}};
{[{<<"profileClass">>, ProfileClass}]} ->
{listProfileInfo, #{
- searchCriteria => {profileClass, utils:hex_to_integer(ProfileClass)}
+ searchCriteria => {profileClass, ProfileClass}
}};
_ ->
logger:error("REST: order with bad listProfilesInfo PSMO: ~p~n", [Psmo]),
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42834?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I4bd223dbef00be9c800539b8d0dc9a84e3e93b73
Gerrit-Change-Number: 42834
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>