Attention is currently required from: dexter.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42834?usp=email )
Change subject: esipa_rest_utils: fix searchCritera.profileClass type conversion
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42834?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I4bd223dbef00be9c800539b8d0dc9a84e3e93b73
Gerrit-Change-Number: 42834
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Jun 2026 15:51:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42831?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: onomondo_eim_app/cosmetic: add a space between version and the version number
......................................................................
onomondo_eim_app/cosmetic: add a space between version and the version number
Change-Id: Ib6b215b0ae5157150b541b34803135cbf0733695
Related: SYS#7093
---
M src/onomondo_eim_app.erl
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, approved
dexter: Verified
diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl
index 498e36a..5394ef5 100644
--- a/src/onomondo_eim_app.erl
+++ b/src/onomondo_eim_app.erl
@@ -94,7 +94,7 @@
start(_Type, _Args) ->
{ok, Vsn} = application:get_key(onomondo_eim, vsn),
- logger:notice("eIM! version:~s~n", [Vsn]),
+ logger:notice("eIM! version: ~s~n", [Vsn]),
% Startup database
ok = mnesia_db:init(),
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42831?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ib6b215b0ae5157150b541b34803135cbf0733695
Gerrit-Change-Number: 42831
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42831?usp=email )
Change subject: onomondo_eim_app/cosmetic: add a space between version and the version number
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42831?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ib6b215b0ae5157150b541b34803135cbf0733695
Gerrit-Change-Number: 42831
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 16 Jun 2026 13:22:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, jolly.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42830?usp=email )
Change subject: certificates: fix certificate location, make sure cert/key files are readable
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42830?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ie09d746a6e28ac6fee3e00dfa32cb01f8a7b947e
Gerrit-Change-Number: 42830
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Jun 2026 13:21:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42834?usp=email )
Change subject: esipa_rest_utils: fix searchCritera.profileClass type conversion
......................................................................
esipa_rest_utils: fix searchCritera.profileClass type conversion
We currently use utils:hex_to_integer to convert the ProfileClass,
which is supposedly a string, to integer. However, hex_to_inteteger
does not exist and when looking into the related JSON schema
definition of we see that the profileClass member is already defined
as integer. This means that ProfileClass already arrives as integer
and can be used as it is. removing the hex_to_integer call solves
the problem.
Change-Id: I4bd223dbef00be9c800539b8d0dc9a84e3e93b73
---
M src/esipa_rest_utils.erl
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/34/42834/1
diff --git a/src/esipa_rest_utils.erl b/src/esipa_rest_utils.erl
index 21fa3b3..efbf985 100644
--- a/src/esipa_rest_utils.erl
+++ b/src/esipa_rest_utils.erl
@@ -61,7 +61,7 @@
}};
{[{<<"profileClass">>, ProfileClass}]} ->
{listProfileInfo, #{
- searchCriteria => {profileClass, utils:hex_to_integer(ProfileClass)},
+ searchCriteria => {profileClass, ProfileClass},
tagList => utils:hex_to_binary(TagList)
}};
_ ->
@@ -76,7 +76,7 @@
{listProfileInfo, #{searchCriteria => {iccid, utils:hex_to_binary(Iccid)}}};
{[{<<"profileClass">>, ProfileClass}]} ->
{listProfileInfo, #{
- searchCriteria => {profileClass, utils:hex_to_integer(ProfileClass)}
+ searchCriteria => {profileClass, ProfileClass}
}};
_ ->
logger:error("REST: order with bad listProfilesInfo PSMO: ~p~n", [Psmo]),
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42834?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I4bd223dbef00be9c800539b8d0dc9a84e3e93b73
Gerrit-Change-Number: 42834
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42833?usp=email )
Change subject: certificates: add checks to make sure cert and key files are readable
......................................................................
Abandoned
there is now a better implementation in a different patch.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42833?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Icaea4aae6188bcdecbc44558aefd2609706be56f
Gerrit-Change-Number: 42833
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42832?usp=email )
Change subject: onomondo_eim_app: display current working directory
......................................................................
Abandoned
since we are now reading from the priv directory, this is probably of minor importance.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42832?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I89d46bac2ff7022b5c5929252e0090a6d77af733
Gerrit-Change-Number: 42832
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Attention is currently required from: fixeria, jolly.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42830?usp=email )
Change subject: config/sys.config: fix certificate paths
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Usually all misc files go to the `priv` directory - this is a standard place for auxiliary files in […]
Hmm, thats new to me. I didn't know about the priv directory. So, this is definitely something that needs cleanup. I will try to fix this now within this patch. - Thanks for the hint!
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42830?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ie09d746a6e28ac6fee3e00dfa32cb01f8a7b947e
Gerrit-Change-Number: 42830
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Jun 2026 08:48:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: dexter.
jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42832?usp=email )
Change subject: onomondo_eim_app: display current working directory
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42832?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I89d46bac2ff7022b5c5929252e0090a6d77af733
Gerrit-Change-Number: 42832
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Jun 2026 08:44:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes