August 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-sgsn[master]: iu_rnc: Split iu_rnc_register API into 2 steps

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email ) Change subject: iu_rnc: Split iu_rnc_register API into 2 steps ...................................................................... Patch Set 1: (2 comments) File src/sgsn/gprs_ranap.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40973/comment/71031275_b6739d95?us… : PS1, Line 377: > empty newline. Done File src/sgsn/iu_rnc.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40973/comment/3c9f52f6_dc34496a?us… : PS1, Line 80: if (rnc) { > (I don't know SCCP very well). […] Yes good point, I didn't think about that scenario with hnbgw. I'll need to take that into account when improving the existing code, since that's something different from other programs eg. osmo-msc. In any case afaiu I'm not really changing any existing logic in this commit. But I agree the existing logic may be flawed. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3761cc539c63a7ed680b04bb8136a43d397c10aa Gerrit-Change-Number: 40973 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 29 Aug 2025 12:46:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 2 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use separate install dir for --asan

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40979?usp=email ) Change subject: testenv: use separate install dir for --asan ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic75452b75d4c3ee8045b68353830b5532e1ce90e Gerrit-Change-Number: 40979 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Aug 2025 12:41:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 2 days

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: --targets: fix subdir projects

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email ) Change subject: gen_makefile: --targets: fix subdir projects ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I136f0d9cd982653b109005aeb35885b6f015eec8 Gerrit-Change-Number: 40978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Aug 2025 12:38:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 2 days

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: enable upf latest

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40977?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: enable upf latest ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia148d627d5f02e165354665e0b1629cf5e3f330a Gerrit-Change-Number: 40977 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Aug 2025 12:36:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 2 days

1
0
0 0

[XS] Change in osmo-sgsn[master]: ranap: Create iu_rnc upon rx RESET

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40976?usp=email ) Change subject: ranap: Create iu_rnc upon rx RESET ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iaf31271feb4d88881382ed8594d0d8e20e22b194 Gerrit-Change-Number: 40976 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Aug 2025 10:08:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-sgsn[master]: ranap: Improve error handling in Rx RESET

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email ) Change subject: ranap: Improve error handling in Rx RESET ...................................................................... Patch Set 1: (2 comments) File src/sgsn/gprs_ranap.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40975/comment/1d6b992e_93dfd770?us… : PS1, Line 332: /* Send CL RANAP message over SCCP: */ > Connectionless. […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40975/comment/31b39420_a7bca811?us… : PS1, Line 679: if (ies->presenceMask & ERRORINDICATIONIES_RANAP_CN_DOMAININDICATOR_PRESENT) { > According to specs the field is marked as "O" (optional), hence also why code from ASN1 files genera […] For reference: 25.413 Release 17, Annex A 1.1: Rules for RANAP messages that shall contain the CN Domain Indicator IE Based on the principles described in TS 25.401 [3], the following rules can be deduced: 1) The following RANAP messages initiating a connection oriented signalling connection shall contain the CN Domain Indicator IE: INITIAL UE MESSAGE message and RELOCATION REQUEST message. 2) Any RANAP message belonging to class 1 procedures and which uses connectionless signalling shall contain the CN Domain Indicator IE. 3) The following RANAP messages belonging to class 2 procedures and using connectionless signalling shall contain the CN Domain Indicator IE: PAGING message and ERROR INDICATION message, the OVERLOAD message in DL direction (see chapter 8.25.3.1) may contain the CN Domain Indicator IE. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2a53e10c3903992a42d081e3ec300fbdb9b3c34c Gerrit-Change-Number: 40975 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Aug 2025 10:07:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 2 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use separate install dir for --asan

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40979?usp=email ) Change subject: testenv: use separate install dir for --asan ...................................................................... testenv: use separate install dir for --asan The --asan flag builds all Osmocom components with address sanitizer enabled. Use a separate install dir from the non-asan version to ensure we don't end up with using non-asan versions. (A separate make dir is already used.) Bump make_dir_version to avoid having markers for already installed binaries / libraries in the make dir, which are invalid now for asan-builds as we switched the install dir. Fixes: c3657172 ("testenv: add run --asan") Change-Id: Ic75452b75d4c3ee8045b68353830b5532e1ce90e --- M _testenv/testenv/cmd.py 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/40979/1 diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index 2cc590a..d637129 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -12,7 +12,7 @@ install_dir = None make_dir = None # osmo-dev make dir version, bump when making incompatible changes -make_dir_version = 3 +make_dir_version = 4 def distro_cache_suffix(): @@ -33,6 +33,8 @@ install_dir = "/" else: install_dir = os.path.join(testenv.args.cache, "podman/install") + if testenv.args.asan: + install_dir += "-asan" install_dir += distro_cache_suffix() else: install_dir = os.path.join(testenv.args.cache, "host/install") -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic75452b75d4c3ee8045b68353830b5532e1ce90e Gerrit-Change-Number: 40979 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-sgsn[master]: iu_rnc: Split iu_rnc_register API into 2 steps

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email ) Change subject: iu_rnc: Split iu_rnc_register API into 2 steps ...................................................................... Patch Set 1: (1 comment) File src/sgsn/iu_rnc.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40973/comment/8bddce33_6965041d?us… : PS1, Line 80: if (rnc) { > yes the relation is: SGSN talks to each RNC/HNBGW through RANAP, which in turn is transported over S […] (I don't know SCCP very well). If I'm not mistaken, there is a RNC id per HNB and there are usally many HNB per HNBGW, correct? Aren't those reachable under the same SCCP address? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3761cc539c63a7ed680b04bb8136a43d397c10aa Gerrit-Change-Number: 40973 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Aug 2025 09:56:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 2 days

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: --targets: fix subdir projects

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email ) Change subject: gen_makefile: --targets: fix subdir projects ...................................................................... gen_makefile: --targets: fix subdir projects Some projects are in subdirectories of git repositories, such as simtrace2_host, or osmocom-bb_layer23. When filtering the targets to be added to the Makefile, we must also add the main projects of such projects in subdirectories, so Makefile rules like the following work: .make.simtrace2_host.clone: .make.simtrace2.clone Fix for: make: *** No rule to make target '.make.simtrace2.clone', needed by '.make.simtrace2_host.clone'. Stop. Fixes: 1d13c9d7 ("gen_makefile: add --targets") Change-Id: I136f0d9cd982653b109005aeb35885b6f015eec8 --- M gen_makefile.py M tests/test_gen_makefile.py 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/78/40978/1 diff --git a/gen_makefile.py b/gen_makefile.py index 4730c59..3885e10 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -243,6 +243,12 @@ print() sys.exit(1) + # simtrace2_host -> simtrace2 + if "_" in project: + project_main = project.split("_")[0] + if project_main in projects_deps and project_main not in ret: + queue += [project_main] + deps = projects_deps[project] ret[project] = deps diff --git a/tests/test_gen_makefile.py b/tests/test_gen_makefile.py index 6232003..622f6e7 100644 --- a/tests/test_gen_makefile.py +++ b/tests/test_gen_makefile.py @@ -67,10 +67,11 @@ def test_gen_makefile_with_targets_arg(tmp_path): - run_cmd(["./gen_makefile.py", "-m", tmp_path, "--targets", "trxcon,osmo-mgw"], cwd=osmo_dev_path) + run_cmd(["./gen_makefile.py", "-m", tmp_path, "--targets", "trxcon,osmo-mgw,simtrace2_host"], cwd=osmo_dev_path) run_cmd("grep -q '^osmocom-bb_trxcon_files :=' Makefile", cwd=tmp_path, shell=True) run_cmd("grep -q '^osmo-mgw_files :=' Makefile", cwd=tmp_path, shell=True) run_cmd("grep -q '^libosmocore_files :=' Makefile", cwd=tmp_path, shell=True) + run_cmd("grep -q '^simtrace2_files :=' Makefile", cwd=tmp_path, shell=True) run_cmd("! grep -q '^osmo-bts_files :=' Makefile", cwd=tmp_path, shell=True) run_cmd("! grep -q '^osmo-s1gw_files :=' Makefile", cwd=tmp_path, shell=True) run_cmd("! grep -q '^open5gs_files :=' Makefile", cwd=tmp_path, shell=True) -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I136f0d9cd982653b109005aeb35885b6f015eec8 Gerrit-Change-Number: 40978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 weeks, 2 days

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: enable upf latest

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40977?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: enable upf latest ...................................................................... jobs/ttcn3-testsuites-testenv: enable upf latest All tests are passing with upf latest now, so enable it. Change-Id: Ia148d627d5f02e165354665e0b1629cf5e3f330a --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/77/40977/1 diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index 4140ddd..40309a0 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -300,7 +300,6 @@ testsuite: upf args: -b osmocom:latest timer: H 12 * * * - disabled: true - ttcn3-s1gw-test-latest: # ~2 min testsuite: s1gw -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia148d627d5f02e165354665e0b1629cf5e3f330a Gerrit-Change-Number: 40977 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 weeks, 2 days

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025