Attention is currently required from: neels, pespin, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
......................................................................
Patch Set 18:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/c681e679_fca4667c
PS18, Line 7: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
The commit message contains nothing about bumping the PCUIF version.
Such changes should definitely be reflected in the commit log, IMO.
File include/osmocom/pcu/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/76c17bd0_245e4ec4
PS18, Line 43: PCU_IF_SAPI_PCH_DT
Didn't we agree that in the new PCUIF version there will be only one way to send DL
blocks over PCH and the message will always contain TLLI now. I remember Pau complaining
that having several ways to do the same thing is a mess. My understanding is that there
should be only `PCU_IF_SAPI_PCH` in the new version and it shall always contain a TLLI.
Ah, now I see comments from Pau and your response about backwards compatibility.
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/8fddec62_fdec130c
PS18, Line 273: is send
typo: is sent
File src/bts.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/4ec80c15_17cafdc2
PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen,
ms_paging_group(tbf_ms(tbf)));
... PCU will become incompatible with osmo-bts
Yes, this is expected and desired when you bump the PCUIF version.
As far as I remember we decided to add a deprecation
warning and upgrade osmo-bts later.
It was discussed *before* we came to a conclusion that bumping the PCUIF version is needed
after all. The point was to prevent the user from running an old version of osmo-pcu,
which does not support and ignores the new E1 configuration messages.
... lets not get blocked by the BTS part and keep
compatibility for now
Ok, now I see the reason why you're keeping the old messages and backwards
compatibility (nothing in the commit message explains that). But what would it take to get
this implemented in osmo-bts? I can quickly help you with that, so we just bump the PCUIF
version and be done with it. I think 1h would be enough for me to implement this on the
BTS side.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/31145
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f
Gerrit-Change-Number: 31145
Gerrit-PatchSet: 18
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 19:10:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment