Attention is currently required from: neels, pespin, dexter.
4 comments:
Commit Message:
Patch Set #18, Line 7: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
The commit message contains nothing about bumping the PCUIF version.
Such changes should definitely be reflected in the commit log, IMO.
File include/osmocom/pcu/pcuif_proto.h:
Patch Set #18, Line 43: PCU_IF_SAPI_PCH_DT
Didn't we agree that in the new PCUIF version there will be only one way to send DL blocks over PCH and the message will always contain TLLI now. I remember Pau complaining that having several ways to do the same thing is a mess. My understanding is that there should be only `PCU_IF_SAPI_PCH` in the new version and it shall always contain a TLLI.
Ah, now I see comments from Pau and your response about backwards compatibility.
Patch Set #18, Line 273: is send
typo: is sent
File src/bts.cpp:
Patch Set #17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));
... PCU will become incompatible with osmo-bts
Yes, this is expected and desired when you bump the PCUIF version.
As far as I remember we decided to add a deprecation warning and upgrade osmo-bts later.
It was discussed *before* we came to a conclusion that bumping the PCUIF version is needed after all. The point was to prevent the user from running an old version of osmo-pcu, which does not support and ignores the new E1 configuration messages.
... lets not get blocked by the BTS part and keep compatibility for now
Ok, now I see the reason why you're keeping the old messages and backwards compatibility (nothing in the commit message explains that). But what would it take to get this implemented in osmo-bts? I can quickly help you with that, so we just bump the PCUIF version and be done with it. I think 1h would be enough for me to implement this on the BTS side.
To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.