October 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs: gerrit/master: run pysim with new image
by osmith 23 Oct '26

23 Oct '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/43967?usp=email ) Change subject: jobs: gerrit/master: run pysim with new image ...................................................................... jobs: gerrit/master: run pysim with new image I've made a split pysim-build image (from debian-trixie-build) to fix a conflict while installing dependencies. Use the new image. Related: OS#7111 Depends: docker-playground I2da5fb928d20c27f373606a8aa7bccefa40c09ce Change-Id: I34b622d3d367510a6343088bb3a80f950944bdd6 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml M jobs/registry-rebuild-upload.yml 3 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/67/43967/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 034d02b..0f6807e 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -101,6 +101,7 @@ docker_img_android: 'registry.osmocom.org/osmocom-build/debian-bookworm-android' docker_img_aram_applet: 'registry.osmocom.org/osmocom-build/debian-bookworm-aram-applet' docker_img_rp2040: 'registry.osmocom.org/osmocom-build/debian-bookworm-rp2040' + docker_img_pysim: 'registry.osmocom.org/osmocom-build/pysim' timeout_cmd: '/usr/bin/timeout 30m' wrapper_cmd: '{timeout_cmd} /osmo-ci/scripts/wrapper_core_bt_on_error.sh' cmd: '{docker_run_ccache} {docker_img} {wrapper_cmd} /build/contrib/jenkins.sh' @@ -572,7 +573,7 @@ *) {docker_run} \ -e JOB_TYPE="$JOB_TYPE" \ - {docker_img} \ + {docker_img_pysim} \ {timeout_cmd} /build/contrib/jenkins.sh ;; esac diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index a0c0ad7..d1ace34 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -84,6 +84,7 @@ docker_img_android: 'registry.osmocom.org/osmocom-build/debian-bookworm-android' docker_img_aram_applet: 'registry.osmocom.org/osmocom-build/debian-bookworm-aram-applet' docker_img_rp2040: 'registry.osmocom.org/osmocom-build/debian-bookworm-rp2040' + docker_img_pysim: 'registry.osmocom.org/osmocom-build/pysim-build' timeout_cmd: '/usr/bin/timeout 30m' wrapper_cmd: '{timeout_cmd} /osmo-ci/scripts/wrapper_core_bt_on_error.sh' cmd: '{docker_run_ccache} {docker_img} {wrapper_cmd} /build/contrib/jenkins.sh' @@ -667,7 +668,7 @@ *) {docker_run} \ -e JOB_TYPE="$JOB_TYPE" \ - {docker_img} \ + {docker_img_pysim} \ {timeout_cmd} /build/contrib/jenkins.sh ;; esac diff --git a/jobs/registry-rebuild-upload.yml b/jobs/registry-rebuild-upload.yml index 21d1335..9244970 100644 --- a/jobs/registry-rebuild-upload.yml +++ b/jobs/registry-rebuild-upload.yml @@ -9,6 +9,8 @@ image: "debian-bookworm-aram-applet" - registry-rebuild-upload-rp2040: image: "debian-bookworm-rp2040" + - registry-rebuild-upload-pysim-build: + image: "pysim-build" - job-template: name: '{job-name}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I34b622d3d367510a6343088bb3a80f950944bdd6 Gerrit-Change-Number: 43967 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in docker-playground[master]: pysim-build: split out from debian-trixie-build
by osmith 23 Oct '26

23 Oct '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/43966?usp=email ) Change subject: pysim-build: split out from debian-trixie-build ...................................................................... pysim-build: split out from debian-trixie-build Installing pysim dependencies via pip --break-system-packages into the debian-trixie-build image now causes a conflict that aborts building the image: + pip3 install --break-system-packages git+https://github.com/eriwen/lcov-to-cobertura-xml.git@028da3798355d0260c6… git+https://github.com/osmocom/sphinx-argparse@inside-classes#egg=sphinx-ar… git+https://github.com/podshumok/python-smpplib.git ruff sphinx sphinxcontrib-napoleon -r /tmp/pysim_requirements.txt Attempting uninstall: Pygments Found existing installation: Pygments 2.18.0 error: uninstall-no-record-file × Cannot uninstall Pygments 2.18.0 ╰─> The package's contents are unknown: no RECORD file was found for Pygments. hint: The package was installed by debian. You should check if it can uninstall the package. We don't explicitly install pygments via apt beforehand, the conflicting version of it is apparently needed by another package we install. Resolve this by splitting everything pysim related into a separate container. The more weird dependencies in there are needed for building manuals. Related: OS#7111 Change-Id: I2da5fb928d20c27f373606a8aa7bccefa40c09ce --- M debian-trixie-build/Dockerfile A pysim-build/Dockerfile A pysim-build/Makefile 3 files changed, 61 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/66/43966/1 diff --git a/debian-trixie-build/Dockerfile b/debian-trixie-build/Dockerfile index 58cd9c1..a562d31 100644 --- a/debian-trixie-build/Dockerfile +++ b/debian-trixie-build/Dockerfile @@ -189,19 +189,8 @@ # Install pip dependencies (alphabetic order) # break-system-packages: inside docker it's fine to install pkgs system-wide -# lcov-to-cobertura-xml: use this commit as the latest version fails: -# https://github.com/eriwen/lcov-to-cobertura-xml/issues/63 -ADD https://gitea.osmocom.org/sim-card/pysim/raw/branch/master/requirements.txt /tmp/pysim_requirements.txt -RUN set -x && \ - cat /tmp/pysim_requirements.txt && \ - pip3 install --break-system-packages \ - 'git+https://github.com/eriwen/lcov-to-cobertura-xml.git@028da3798355d0260c6…' \ - 'git+https://github.com/osmocom/sphinx-argparse@inside-classes#egg=sphinx-ar…' \ - 'git+https://github.com/podshumok/python-smpplib.git' \ - 'ruff' \ - 'sphinx' \ - 'sphinxcontrib-napoleon' \ - -r /tmp/pysim_requirements.txt +RUN pip3 install --break-system-packages \ + 'ruff' # Install osmo-python-tests ADD https://gerrit.osmocom.org/plugins/gitiles/python/osmo-python-tests/+/maste… /tmp/osmo-python-tests-commit diff --git a/pysim-build/Dockerfile b/pysim-build/Dockerfile new file mode 100644 index 0000000..2951c2f --- /dev/null +++ b/pysim-build/Dockerfile @@ -0,0 +1,56 @@ +# Used by pysim master and gerrit jobs +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=debian:trixie +FROM ${REGISTRY}/${UPSTREAM_DISTRO} + +# Arguments used after FROM must be specified again +ARG UID + +# Configure build user +RUN useradd --uid=${UID} -d /build -m build + +# Install packages from Debian repositories (alphabetic order) +RUN set -x && \ + apt-get update && \ + apt-get install -y --no-install-recommends \ + ca-certificates \ + gcc \ + ghostscript \ + git \ + latexmk \ + libpcsclite-dev \ + make \ + openssh-client \ + pylint \ + python3-dev \ + python3-pip \ + python3-virtualenv \ + rsync \ + tex-gyre \ + texlive-latex-extra \ + texlive-latex-recommended \ + tshark \ + && \ + apt-get clean + +# Install osmo-ci.git/scripts to /usr/local/bin +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-ci/+/master?format=TEXT /tmp/osmo-ci-commit +RUN set -x && \ + git clone --depth=1 https://gerrit.osmocom.org/osmo-ci osmo-ci && \ + cp -v osmo-ci/scripts/*.* /usr/local/bin && \ + rm -rf osmo-ci + +# Install pip dependencies (alphabetic order) +# break-system-packages: inside docker it's fine to install pkgs system-wide +# lcov-to-cobertura-xml: use this commit as the latest version fails: +# https://github.com/eriwen/lcov-to-cobertura-xml/issues/63 +ADD https://gitea.osmocom.org/sim-card/pysim/raw/branch/master/requirements.txt /tmp/pysim_requirements.txt +RUN set -x && \ + cat /tmp/pysim_requirements.txt && \ + pip3 install --break-system-packages \ + 'git+https://github.com/eriwen/lcov-to-cobertura-xml.git@028da3798355d0260c6…' \ + 'git+https://github.com/osmocom/sphinx-argparse@inside-classes#egg=sphinx-ar…' \ + 'git+https://github.com/podshumok/python-smpplib.git' \ + 'sphinx' \ + 'sphinxcontrib-napoleon' \ + -r /tmp/pysim_requirements.txt diff --git a/pysim-build/Makefile b/pysim-build/Makefile new file mode 100644 index 0000000..bbbc0f3 --- /dev/null +++ b/pysim-build/Makefile @@ -0,0 +1,3 @@ +UPSTREAM_DISTRO=debian:trixie +DISTRO=debian-trixie +include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/43966?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2da5fb928d20c27f373606a8aa7bccefa40c09ce Gerrit-Change-Number: 43966 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: ausf,udm,udr,smf: Add func helpers to connect+send HTTP2_Msg
by pespin 23 Oct '26

23 Oct '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43965?usp=email ) Change subject: ausf,udm,udr,smf: Add func helpers to connect+send HTTP2_Msg ...................................................................... ausf,udm,udr,smf: Add func helpers to connect+send HTTP2_Msg This way we decrease lines and complexity of function calls which are repeated for almost every procedure. This way we also enclose multiple mp_* variables further in one place. Change-Id: I5db2254c3b67af5bfca7e744f3c07e58410befc5 --- M ausf/ConnHdlr.ttcn M smf/SMF_Session_CT_5G.ttcn M smf/SMF_Tests.ttcn M udm/ConnHdlr.ttcn M udr/ConnHdlr.ttcn 5 files changed, 60 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/43965/1 diff --git a/ausf/ConnHdlr.ttcn b/ausf/ConnHdlr.ttcn index 386c544..dacfa1d 100644 --- a/ausf/ConnHdlr.ttcn +++ b/ausf/ConnHdlr.ttcn @@ -90,6 +90,17 @@ f_http2_server_emu_unregister(f_http2_server_path_match(), idx := HTTP2_CONN_SCP); } +function f_http2_adapter_connect_ausf(integer idx := 0) +runs on ConnHdlr { + f_http2_adapter_connect(mp_ausf_hostname, mp_ausf_sbi_port, mp_amf_local_ip, idx := idx); +} + +function f_http2_adapter_connect_send_ausf(template (value) HTTP2_Msg http2_msg, integer idx := 0) +runs on ConnHdlr { + f_http2_adapter_connect_ausf(idx := idx); + f_http2_adapter_send(http2_msg); +} + /******************************************** * SCP /*******************************************/ @@ -146,8 +157,7 @@ servingNetworkName := g_pars.serving_network); http2_tx := f_n12_prepare_post_ue_authentications(valueof(auth_info)); - f_http2_adapter_connect(mp_ausf_hostname, mp_ausf_sbi_port, mp_amf_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_ausf(http2_tx, idx := http2_tx.conn_id); as_Nudm_UEAU_post_generate_auth_data(); @@ -213,8 +223,7 @@ conf_data := ts_ConfirmationData(resStar := ts_ResStar("")); http2_tx := f_n12_prepare_put_5g_aka_confirmation(valueof(conf_data)); - f_http2_adapter_connect(mp_ausf_hostname, mp_ausf_sbi_port, mp_amf_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_ausf(http2_tx, idx := http2_tx.conn_id); as_Nudm_UEAU_post_auth_events(); diff --git a/smf/SMF_Session_CT_5G.ttcn b/smf/SMF_Session_CT_5G.ttcn index 03d172c..ff77dad 100644 --- a/smf/SMF_Session_CT_5G.ttcn +++ b/smf/SMF_Session_CT_5G.ttcn @@ -69,6 +69,17 @@ f_http2_server_emu_unregister(f_http2_server_path_match(), idx := HTTP2_CONN_SCP); } +function f_http2_adapter_connect_smf(integer idx := 0) +runs on SMF_Session_CT { + f_http2_adapter_connect(mp_smf_hostname, mp_smf_sbi_port, mp_amf_local_ip, idx := idx); +} + +function f_http2_adapter_connect_send_smf(template (value) HTTP2_Msg http2_msg, integer idx := 0) +runs on SMF_Session_CT { + f_http2_adapter_connect_smf(idx := idx); + f_http2_adapter_send(http2_msg); +} + /******************************************** * SCP /*******************************************/ @@ -220,7 +231,7 @@ http2_tx := f_n11_prepare_create_sm_context_pdu_sess_establishment(); - f_http2_adapter_connect(mp_smf_hostname, mp_smf_sbi_port, mp_amf_local_ip, idx := http2_tx.conn_id); + f_http2_adapter_connect_smf(idx := http2_tx.conn_id); /////////// START MUTUAL EXCLUSION ZONE //////////// /* This code block cannot be executed by more than one component at a time because @@ -344,9 +355,7 @@ var octetstring ngap_enc := f_ngap_pdu_gen_PDUSessionResourceSetupResponseTransfer(); http2_tx := f_n11_prepare_update_sm_context(valueof(sm_ctx_update), ngap_enc); - - f_http2_adapter_connect(mp_smf_hostname, mp_smf_sbi_port, mp_amf_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_smf(http2_tx, idx := http2_tx.conn_id); /* SMF updates RAN GTPU IP addr+TEID info on UPF: */ as_pfcp_sess_mod_req(); @@ -376,9 +385,7 @@ var octetstring ngap_enc := enc_NGAP_PDUSessionResourceReleaseResponseTransfer(valueof(m_pDUSessionResourceReleaseResponseTransfer())); http2_tx := f_n11_prepare_update_sm_context(valueof(sm_ctx_update), ngap_enc, omit); - - f_http2_adapter_connect(mp_smf_hostname, mp_smf_sbi_port, mp_amf_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_smf(http2_tx, idx := http2_tx.conn_id); /* Successful answer with no content: */ as_http2_adapter_receive(http2_rx, tr_HTTP2_Msg_204_No_Content(), idx := http2_tx.conn_id); @@ -399,9 +406,7 @@ var octetstring ngnas_enc := f_ng_nas_gen_session_release_complete(); http2_tx := f_n11_prepare_update_sm_context(valueof(sm_ctx_update), omit, ngnas_enc); - - f_http2_adapter_connect(mp_smf_hostname, mp_smf_sbi_port, mp_amf_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_smf(http2_tx, idx := http2_tx.conn_id); /* Successful answer with no content: */ as_http2_adapter_receive(http2_rx, tr_HTTP2_Msg_204_No_Content(), idx := http2_tx.conn_id); @@ -468,8 +473,7 @@ var octetstring ngap_enc := f_ngap_pdu_gen_PDUSessionResourceSetupResponseTransfer(); http2_tx := f_n11_prepare_release_sm_context(valueof(sm_ctx_rel), ngap_enc); - f_http2_adapter_connect(mp_smf_hostname, mp_smf_sbi_port, mp_amf_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_smf(http2_tx, idx := http2_tx.conn_id); /* SMF deletes PDU Session on UPF: */ as_pfcp_sess_del_req(); diff --git a/smf/SMF_Tests.ttcn b/smf/SMF_Tests.ttcn index c9945c9..14003d2 100644 --- a/smf/SMF_Tests.ttcn +++ b/smf/SMF_Tests.ttcn @@ -835,8 +835,7 @@ f_PFCPEM_subscribe_seid(c_SEID0); http2_tx := f_n11_prepare_create_sm_context_pdu_sess_establishment(); - f_http2_adapter_connect(mp_smf_hostname, mp_smf_sbi_port, mp_amf_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_smf(http2_tx, idx := http2_tx.conn_id); /* PCF: register to rx generic path. We take advantage of the fact that * we are inside a mutual exclusion zone, so only one session can be here at a time. */ diff --git a/udm/ConnHdlr.ttcn b/udm/ConnHdlr.ttcn index 89bc0d9..ea0df46 100644 --- a/udm/ConnHdlr.ttcn +++ b/udm/ConnHdlr.ttcn @@ -89,6 +89,17 @@ f_http2_server_emu_unregister(f_http2_server_path_match(), idx := HTTP2_CONN_SCP); } +function f_http2_adapter_connect_udm(integer idx := 0) +runs on ConnHdlr { + f_http2_adapter_connect(mp_udm_hostname, mp_udm_sbi_port, mp_ausf_local_ip, idx := idx); +} + +function f_http2_adapter_connect_send_udm(template (value) HTTP2_Msg http2_msg, integer idx := 0) +runs on ConnHdlr { + f_http2_adapter_connect_udm(idx := idx); + f_http2_adapter_send(http2_msg); +} + /******************************************** * SCP /*******************************************/ @@ -145,8 +156,7 @@ ausfInstanceId := g_pars.ausf_instance_id); http2_tx := f_n13_prepare_generate_auth_data(valueof(auth_info_req)); - f_http2_adapter_connect(mp_udm_hostname, mp_udm_sbi_port, mp_ausf_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_udm(http2_tx, idx := http2_tx.conn_id); as_Nudr_DR_get_authentication_subscription(); @@ -211,8 +221,7 @@ servingNetworkName := g_pars.serving_network); http2_tx := f_n13_prepare_auth_events(valueof(auth_event)); - f_http2_adapter_connect(mp_udm_hostname, mp_udm_sbi_port, mp_ausf_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_udm(http2_tx, idx := http2_tx.conn_id); as_Nudr_DR_put_authentication_status(); @@ -283,8 +292,7 @@ servingNetworkName := g_pars.serving_network); http2_tx := f_n13_prepare_individual_auth_event(auth_event); - f_http2_adapter_connect(mp_udm_hostname, mp_udm_sbi_port, mp_ausf_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_udm(http2_tx, idx := http2_tx.conn_id); /* FIXME: This is probably incorrect, it should send a DELETE, but it's what open5gs-udmd is sending right now... * See https://github.com/open5gs/open5gs/issues/4896 */ diff --git a/udr/ConnHdlr.ttcn b/udr/ConnHdlr.ttcn index 9ca68dc..d3eb4cc 100644 --- a/udr/ConnHdlr.ttcn +++ b/udr/ConnHdlr.ttcn @@ -90,6 +90,18 @@ f_http2_server_emu_unregister(f_http2_server_path_match(), idx := HTTP2_CONN_SCP); } + +function f_http2_adapter_connect_udr(integer idx := 0) +runs on ConnHdlr { + f_http2_adapter_connect(mp_udr_hostname, mp_udr_sbi_port, mp_udm_local_ip, idx := idx); +} + +function f_http2_adapter_connect_send_udr(template (value) HTTP2_Msg http2_msg, integer idx := 0) +runs on ConnHdlr { + f_http2_adapter_connect_udr(idx := idx); + f_http2_adapter_send(http2_msg); +} + /******************************************** * SCP /*******************************************/ @@ -157,8 +169,7 @@ var template (present) HTTP2_Msg http2_exp_rx; http2_tx := f_n35_prepare_get_authentication_subscription(); - f_http2_adapter_connect(mp_udr_hostname, mp_udr_sbi_port, mp_udm_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_udr(http2_tx, idx := http2_tx.conn_id); /* 3GPP TS 29.505 Table 5.2.2.3.1-3 */ http2_exp_rx := @@ -222,8 +233,7 @@ var template (present) HTTP2_Msg http2_exp_rx; http2_tx := f_n35_prepare_patch_authentication_subscription(patch_item_li); - f_http2_adapter_connect(mp_udr_hostname, mp_udr_sbi_port, mp_udm_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_udr(http2_tx, idx := http2_tx.conn_id); /* 3GPP TS 29.505 Table 5.2.2.3.2-3 */ http2_exp_rx := @@ -283,8 +293,7 @@ ratType := ts_RatType(NR)); http2_tx := f_n35_prepare_put_amf_3gpp_access(acc_reg); - f_http2_adapter_connect(mp_udr_hostname, mp_udr_sbi_port, mp_udm_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_udr(http2_tx, idx := http2_tx.conn_id); /* 3GPP TS 29.505 Table 5.2.6.3.1-3 */ http2_exp_rx := @@ -336,8 +345,7 @@ var template (present) HTTP2_Msg http2_exp_rx; http2_tx := f_n35_prepare_patch_amf_3gpp_access(patch_item_li); - f_http2_adapter_connect(mp_udr_hostname, mp_udr_sbi_port, mp_udm_local_ip, idx := http2_tx.conn_id); - f_http2_adapter_send(http2_tx); + f_http2_adapter_connect_send_udr(http2_tx, idx := http2_tx.conn_id); /* 3GPP TS 29.505 Table 5.2.6.3.2-3 */ http2_exp_rx := -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5db2254c3b67af5bfca7e744f3c07e58410befc5 Gerrit-Change-Number: 43965 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce ausf testsuite
by pespin 23 Oct '26

23 Oct '26

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Introduce ausf testsuite ...................................................................... Introduce ausf testsuite Introduce a new "ausf" testsuite which runs against open5gs-ausfd. Start with a single test which already contains most of the infrastructure needed and makes it easy to extend later on. Related: SYS#7073 Change-Id: Ife5af76587b4416767535875e27b02236ee5e1d9 --- M Makefile A ausf/AUSF_Tests.cfg A ausf/AUSF_Tests.default A ausf/AUSF_Tests.ttcn A ausf/ConnHdlr.ttcn A ausf/README.md A ausf/expected-results.xml A ausf/gen_links.sh A ausf/open5gs-ausf.yaml A ausf/regen_makefile.sh A ausf/testenv.cfg A ausf/testsrcdir.cfg A library/TS29509_Nausf_UEAuthentication_Templates.ttcn 13 files changed, 732 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/43960/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife5af76587b4416767535875e27b02236ee5e1d9 Gerrit-Change-Number: 43960 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce ausf testsuite
by osmith 23 Oct '26

23 Oct '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960?usp=email ) Change subject: Introduce ausf testsuite ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife5af76587b4416767535875e27b02236ee5e1d9 Gerrit-Change-Number: 43960 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Oct 2026 14:01:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap: Add SUA spec references regarding TCAP routing
by pespin 23 Oct '26

23 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43903?usp=email ) Change subject: tcap: Add SUA spec references regarding TCAP routing ...................................................................... tcap: Add SUA spec references regarding TCAP routing It seems most of TCAP routing we have implemented is somehow documented in RFC3868 (SUA). The main difference is that we are implementing TCAP routing on top of SCCPLite (IPA/SCCP) instead. Change-Id: I9c1806570529e1568c5f65152b4bb298f19afe14 --- M src/tcap_as_loadshare.c M src/tcap_trans_tracking.c 2 files changed, 41 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 2e8d86a..12a482c 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -505,17 +505,35 @@ switch (as->cfg.loadshare.tcap.unroutable_tcap_msg) { case SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS: + /* RFC3868 A.3.1 Connectionless Transport: + * "load sharing is only possible for the first message in a + * TCAP dialogue (TC_Begin, TC_Query, TC_Unidirectional) [...] + * unless the ASPs are able to share state and maintain sequenced + * delivery. To this end, the SGP needs to know the TID + * allocation policy of the ASPs in a single AS". + * + * Hence, if UNROUTABLE_LOAD_SHARE_AS is configured, allocation + * policy "State sharing" at the peer is assumed. */ asp = select_asp_tcap_enabled_rr(as); if (asp) rc = 0; break; case SS7_AS_TCAP_UNROUTABLE_ROUTE_FALLBACK: + /* RFC3868 A.2: + * "Replicated relay points: in normal circumstances, the path + * from SEP to ASP will always go via the same SGP when + * in-sequence-delivery is requested. However, linkset failures + * may cause MTP to reroute to the other SG." */ /* No ASP selection. Try to route the SCCP msg to the fallback DPC */ rc = asp_loadshare_tcap_route_fallback(as, mtp3_rtlb, sccp_msg); if (!rc) /* rc == 0 would require a valid asp, use > 0 to drop the msg, but don't send an error back if needed */ rc = 1; break; case SS7_AS_TCAP_UNROUTABLE_REJECT_UDTS: + /* RFC3868 4.7.3.1 TCAP traffic: + * "If an ASP is not available, the SG may generate (X)UDTS + * "routing failure", if the return option is used." */ + /* fall-through */ default: /* default case, asp stays NULL, will reject when returning -ENOKEY */ rc = -ENOKEY; @@ -632,6 +650,11 @@ goto out_free_sua; } + /* RFC3868 4.7.3.1 TCAP traffic: + * "Messages not containing a destination (or "responding") TID, i.e., + * Query, Begin, Unidirectional, are loadshared among the available + * ASPs. Any scheme permitting a fair load distribution among the ASPs + * is allowed (e.g., round robin)." */ asp = select_asp_tcap_enabled_rr(as); if (asp) { rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_SELECTED); @@ -651,6 +674,9 @@ goto out_free_sua; } + /* RFC3868 4.7.3.1 TCAP traffic: + * "When a destination TID is present, the SG extracts the label and + * selects the ASP that corresponds with it." */ asp = tcap_trans_track_continue(as, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); if (!asp) { LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP Continue, dtid %u/otid %u, using tcap route", parsed.dtid, parsed.otid); @@ -794,6 +820,14 @@ uint8_t data[0]; } __attribute__((packed)); +/* This message is similar to provided "TID Label" in SUA ASP ACTIVATE, + * since there's no ASP management messages such as ASP ACTIVATE in IPA. + * + * RFC3868 A.3.1: "Fixed range of TIDs per ASP in the AS. [...] + * This information may be provisioned in the SG, or may be dynamically + * exchanged via the ASP_Active message." + * See also RFC3868 4.7.2.1. Association Setup, ASP going active + */ struct ipa_tcap_routing_add_range { uint32_t tid_start; uint32_t tid_end; @@ -907,6 +941,7 @@ LOGPASP(asp, DLTCAP, LOGL_INFO, "Rx: TCAP Add Range command: seq: %u pc: %u ssn: %u [%u-%u]\n", osmo_ntohl(hdr->seq), tcar.pc, tcar.ssn, tcar.tid_start, tcar.tid_end); + /* RFC3868 4.7.2.1 "The SG has to perform some trivial plausibility checks on the parameters" */ tcrng = tcap_overlap_tid(as, tcar.pc, tcar.ssn, tcar.tid_start, tcar.tid_end); if (tcrng) { LOGPASP(asp, DLTCAP, LOGL_ERROR, "New TCAP Range overlaps with existing range to ASP %s [%u-%u]. Rejecting Add Range Command seq: %u pc: %u ssn: %u [%u-%u]\n", diff --git a/src/tcap_trans_tracking.c b/src/tcap_trans_tracking.c index 421ad7b..d88a12b 100644 --- a/src/tcap_trans_tracking.c +++ b/src/tcap_trans_tracking.c @@ -21,6 +21,12 @@ * */ +/* RFC3868 4.7.2 Support for Loadsharing: + * "the loadsharing scheme used at the SG must make sure that messages continuing or ending the + * transactions/connections arrive at the same ASP where the initial message (TC_Query, TC_Begin, + * CR) was sent to/received from." +*/ + #include <stdint.h> #include <osmocom/core/msgb.h> -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9c1806570529e1568c5f65152b4bb298f19afe14 Gerrit-Change-Number: 43903 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-gprs[master]: sndcp_xid: use reasonable static buffer size
by pespin 23 Oct '26

23 Oct '26

Attention is currently required from: dexter. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/43963?usp=email ) Change subject: sndcp_xid: use reasonable static buffer size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43963?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic8e7719063d87e5328ebf503e9a43325bb07acf8 Gerrit-Change-Number: 43963 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Oct 2026 13:34:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-gprs[master]: sndcp_xid: fix length check in gprs_sndcp_compile_xid
by pespin 23 Oct '26

23 Oct '26

Attention is currently required from: dexter. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email ) Change subject: sndcp_xid: fix length check in gprs_sndcp_compile_xid ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/43962/comment/ab202557_c2bc2dc6… : PS2, Line 16: This patch has been orted from: ported from -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I38844155027673d90079c84df5cfd85053f48656 Gerrit-Change-Number: 43962 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Oct 2026 13:34:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-gprs[master]: sndcp_xid: fix length check in gprs_sndcp_compile_xid
by pespin 23 Oct '26

23 Oct '26

Attention is currently required from: dexter. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email ) Change subject: sndcp_xid: fix length check in gprs_sndcp_compile_xid ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I38844155027673d90079c84df5cfd85053f48656 Gerrit-Change-Number: 43962 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Oct 2026 13:34:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: f_TC_pcu_tx_ul_block_req(): target the block after the next one
by pespin 23 Oct '26

23 Oct '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43964?usp=email ) Change subject: bts: f_TC_pcu_tx_ul_block_req(): target the block after the next one ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie77761c472ba14ad17414c347e1aed140a3295e8 Gerrit-Change-Number: 43964 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Oct 2026 13:33:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log October 2026