Attention is currently required from: dexter, fixeria, lynxis lazus.
pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email )
Change subject: gprs_sndcp_xid: replace OSMO_ASSERT with if and return
......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2:
Only a couple minor changes, once fixed +1 from me.
File src/sgsn/gprs_sndcp_xid.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/504d7254_c6ad9517?us… :
PS2, Line 379: if (params->p3t < 0 || params->p3t > 65535 || params->p3t < 2 * params->p1t)
better enclose (2*params->p1t) into parenthesis? also below in line 388.
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/6d7a1408_e07bc7be?us… :
PS2, Line 623: } else if (rc > 0) {
no need for "} else" here (early return), remove it.
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/c78d9b40_baeededa?us… :
PS2, Line 636: } else if (rc > 0) {
no need for "} else" here (early return), remove it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia570b27a3670fed3aeb4779840292c5d216a1102
Gerrit-Change-Number: 43958
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Oct 2026 13:30:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by osmith
Change subject: Introduce ausf testsuite
......................................................................
Introduce ausf testsuite
Introduce a new "ausf" testsuite which runs against open5gs-ausfd.
Start with a single test which already contains most of the
infrastructure needed and makes it easy to extend later on.
Related: SYS#7073
Change-Id: Ife5af76587b4416767535875e27b02236ee5e1d9
---
M Makefile
A ausf/AUSF_Tests.cfg
A ausf/AUSF_Tests.default
A ausf/AUSF_Tests.ttcn
A ausf/ConnHdlr.ttcn
A ausf/README.md
A ausf/expected-results.xml
A ausf/gen_links.sh
A ausf/open5gs-ausf.yaml
A ausf/regen_makefile.sh
A ausf/testenv.cfg
A ausf/testsrcdir.cfg
A library/TS29509_Nausf_UEAuthentication_Templates.ttcn
13 files changed, 732 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/43960/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ife5af76587b4416767535875e27b02236ee5e1d9
Gerrit-Change-Number: 43960
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email )
Change subject: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases
......................................................................
Patch Set 7:
(1 comment)
File eim/eIM_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904/comment/02da5c17_37f4… :
PS7, Line 1241: private function f_TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_SM_DPp_pb_certificate(charstring id)
setverdict(fail): pass -> fail reason: "unexpected REST lookup result from eIM", new component reason: "unexpected REST lookup result from eIM"
I am using this patch ontop of osmo-ttcn3-hacks master and your pmaier/wip branch at onomondo-eim.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e
Gerrit-Change-Number: 43904
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Oct 2026 13:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43964?usp=email )
Change subject: bts: f_TC_pcu_tx_ul_block_req(): target the block after the next one
......................................................................
bts: f_TC_pcu_tx_ul_block_req(): target the block after the next one
trxcon sends the L1CTL DL BLOCK.ind after the last burst of a block
has been received, while the Uplink bursts are scheduled in advance
(see '--trx-advance', default 2). Thus it's already too late to
target the block following the received one: trxcon drops such
UL BLOCK.req as stale, and TC_pcu_data_ind_lqual_cb fails with
"Timeout waiting for PCUIF_DATA.ind".
Fix this by targeting the block after the next one. While at it,
use the existing f_next_pdtch_block() instead of open-coding the
TDMA Fn calculation.
Change-Id: Ie77761c472ba14ad17414c347e1aed140a3295e8
---
M bts/BTS_Tests.ttcn
1 file changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/43964/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 719d8e3..719a9fa 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -5335,21 +5335,19 @@
T.start(1.0);
alt {
[] as_l1ctl_dl_block_ind(block_ind, tn := tn, usf := usf) {
- var integer fn := block_ind.hdr.fn;
+ var GsmFrameNumber fn := block_ind.hdr.fn;
/* Ignore PTCCH/D blocks, their Fn is too far away */
if (fn mod 104 == 12) {
repeat;
}
- /* Every fn % 13 == 12 we have either a PTCCH or an IDLE slot, thus
- * every fn % 13 == 8 we add 5 frames, or 4 frames othrwise. The
- * resulting value is first fn of the next block. */
- if (fn mod 13 == 8) {
- fn := (fn + 5) mod (2048 * 51 * 26);
- } else {
- fn := (fn + 4) mod (2048 * 51 * 26);
- }
+ /* Skip the next block, target the one after it.
+ * The DL BLOCK.ind is sent by trxcon after the last burst of a block
+ * has been received, while the Uplink bursts are scheduled in advance,
+ * so it's already too late to target the block following the received
+ * one. Hence the UL BLOCK.req targets the block after the next one. */
+ fn := f_next_pdtch_block(f_next_pdtch_block(fn));
L1CTL.send(ts_L1CTL_GPRS_UL_BLOCK_REQ(fn, block_ind.hdr.tn, data));
return {fn, block_ind.hdr.tn};
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43964?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie77761c472ba14ad17414c347e1aed140a3295e8
Gerrit-Change-Number: 43964
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>