Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960?usp=email )
Change subject: Introduce ausf testsuite
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960/comment/97d03250_dbd4… :
PS2, Line 9: Introduce a new "udr" testsuite which runs against open5gs-udrd.
```suggestion
Introduce a new "ausf" testsuite which runs against open5gs-ausfd.
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ife5af76587b4416767535875e27b02236ee5e1d9
Gerrit-Change-Number: 43960
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Oct 2026 12:27:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus, pespin.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email )
Change subject: gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> @pmaier@sysmocom.de fyi: the libosmo-gprs.git sndcp was initially imported from osmo-sgsn. […]
Thanks for the hint. I have portet this patch over now, see: https://gerrit.osmocom.org/c/libosmo-gprs/+/43962
I will do the same with the other patches once they are ready.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I977946a036f96d4dee2656bef048e2618198db40
Gerrit-Change-Number: 43953
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 23 Oct 2026 12:25:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email
to look at the new patch set (#2).
Change subject: sndcp_xid: fix length check in gprs_sndcp_compile_xid
......................................................................
sndcp_xid: fix length check in gprs_sndcp_compile_xid
The function gprs_sndcp_compile_xid gets an output buffer (dst) and
a length (dst_maxlen), but unfortunately, the length is not checked
before data is written to the output buffer (tlv_put).
The problem was reported by osmocom.org user tsato
(see related ticket)
This patch has been orted from:
osmo-sgsn.git I977946a036f96d4dee2656bef048e2618198db40
Related: OS#7095
Change-Id: I38844155027673d90079c84df5cfd85053f48656
---
M src/sndcp/sndcp_xid.c
M tests/sndcp/sndcp_xid_test.c
M tests/sndcp/sndcp_xid_test.ok
3 files changed, 41 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/62/43962/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I38844155027673d90079c84df5cfd85053f48656
Gerrit-Change-Number: 43962
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932?usp=email )
Change subject: Introduce udm testsuite
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File udm/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932/comment/4388dfe2_408c… :
PS3, Line 38: import from UDM_Tests all
> There's tons of places where mp_* are used, ie. in every […]
I still find this confusing, but not going to block you. I didn't know that `import ... all` also imports the module parameters. Specifying the module they belong to explicitly would have been cleaner, even though more verbose.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a2a055ee81c889de00ef86f8562425862ea5e3
Gerrit-Change-Number: 43932
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Oct 2026 11:46:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960?usp=email )
Change subject: Introduce ausf testsuite
......................................................................
Introduce ausf testsuite
Introduce a new "udr" testsuite which runs against open5gs-udrd.
Start with a single test which already contains most of the
infrastructure needed and makes it easy to extend later on.
Related: SYS#7073
Change-Id: Ife5af76587b4416767535875e27b02236ee5e1d9
---
M Makefile
A ausf/AUSF_Tests.cfg
A ausf/AUSF_Tests.default
A ausf/AUSF_Tests.ttcn
A ausf/ConnHdlr.ttcn
A ausf/README.md
A ausf/expected-results.xml
A ausf/gen_links.sh
A ausf/open5gs-ausf.yaml
A ausf/regen_makefile.sh
A ausf/testenv.cfg
A ausf/testsrcdir.cfg
A library/TS29509_Nausf_UEAuthentication_Templates.ttcn
13 files changed, 732 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/43960/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43960?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ife5af76587b4416767535875e27b02236ee5e1d9
Gerrit-Change-Number: 43960
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder