October 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: proxy: clck_gen_timer_cb(): sanitize expire_count
by fixeria 01 Oct '26

01 Oct '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/43736?usp=email ) Change subject: proxy: clck_gen_timer_cb(): sanitize expire_count ...................................................................... proxy: clck_gen_timer_cb(): sanitize expire_count The number of timer expirations read from the timerfd is used as the loop boundary. It is already bounded indirectly by the PC clock skew check, but let's also check it explicitly against the same CLCK_GEN_MAX_FN_SKEW limit. Change-Id: I55f736c9bff58034c197f876206efc817da30204 Fixes: CID#564331 --- M proxy/src/clck_gen.c 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/proxy/src/clck_gen.c b/proxy/src/clck_gen.c index 39abc6c..2798b88 100644 --- a/proxy/src/clck_gen.c +++ b/proxy/src/clck_gen.c @@ -99,6 +99,16 @@ return 0; } + /* the number of expirations is also bounded by the skew limit */ + if (expire_count > CLCK_GEN_MAX_FN_SKEW) { + LOGP(DTRXC, LOGL_FATAL, + "Too many timer expirations (%" PRIu64 "): " + "stopping the TDMA clock generator\n", + expire_count); + clck_gen_stop(gen); + return 0; + } + while (expire_count-- > 0) { const struct proxy_trx *trx; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43736?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I55f736c9bff58034c197f876206efc817da30204 Gerrit-Change-Number: 43736 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: proxy: properly set .trx_num in {NOPE,BURST}.ind
by fixeria 01 Oct '26

01 Oct '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/43737?usp=email ) Change subject: proxy: properly set .trx_num in {NOPE,BURST}.ind ...................................................................... proxy: properly set .trx_num in {NOPE,BURST}.ind The .trx_num field shall indicate the destination channel number. Copying the value from the incoming {NOPE,BURST}.req is wrong. Change-Id: Ib748ed7b681b582fdfad829a1940d71148e63334 Fixes: 1f6f0559 ("proxy: implement burst forwarding (proxying) logic") Related: OS#6672 --- M proxy/src/burst_fwd.c 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/proxy/src/burst_fwd.c b/proxy/src/burst_fwd.c index f56f316..2c89107 100644 --- a/proxy/src/burst_fwd.c +++ b/proxy/src/burst_fwd.c @@ -44,8 +44,7 @@ #define OSMO_TRXD_F_COMMON_MASK ( \ OSMO_TRXD_F_NOPE_REQ | \ OSMO_TRXD_F_MOD_TYPE | \ - OSMO_TRXD_F_TS_INFO | \ - OSMO_TRXD_F_TRX_NUM \ + OSMO_TRXD_F_TS_INFO \ ) /*! The BURST.req copy wrapped in a queued struct msgb @@ -60,14 +59,14 @@ const struct osmo_trxd_burst_req *br) { struct osmo_trxd_burst_ind bi = { - .flags = br->flags & OSMO_TRXD_F_COMMON_MASK, + .flags = (br->flags & OSMO_TRXD_F_COMMON_MASK) | OSMO_TRXD_F_TRX_NUM, .fn = br->fn, .tn = br->tn, .burst_len = br->burst_len, .mod = br->mod, .tsc_set = br->tsc_set, .tsc = br->tsc, - .trx_num = br->trx_num, + .trx_num = dst_chan, }; /* TRXDv0/v1 BURST.req PDUs carry no MTS field at all, so the true @@ -175,7 +174,12 @@ struct proxy_trx_chan *c = &trx->chans[chan]; for (unsigned int tn = 0; tn < PROXY_TRX_NUM_TS; tn++) { - c->ts[tn].bi = (struct osmo_trxd_burst_ind){ .fn = fn, .tn = tn }; + c->ts[tn].bi = (struct osmo_trxd_burst_ind){ + .flags = OSMO_TRXD_F_TRX_NUM, + .fn = fn, + .tn = tn, + .trx_num = chan, + }; path_sim_fill_nope(&c->ts[tn].bi, g_proxy_ctx->path_sim); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43737?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib748ed7b681b582fdfad829a1940d71148e63334 Gerrit-Change-Number: 43737 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: proxy: properly set .trx_num in {NOPE,BURST}.ind
by fixeria 01 Oct '26

01 Oct '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43737?usp=email ) Change subject: proxy: properly set .trx_num in {NOPE,BURST}.ind ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43737?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib748ed7b681b582fdfad829a1940d71148e63334 Gerrit-Change-Number: 43737 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Oct 2026 16:10:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: proxy: clck_gen_timer_cb(): sanitize expire_count
by fixeria 01 Oct '26

01 Oct '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43736?usp=email ) Change subject: proxy: clck_gen_timer_cb(): sanitize expire_count ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43736?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I55f736c9bff58034c197f876206efc817da30204 Gerrit-Change-Number: 43736 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Oct 2026 16:10:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: Add Cisco like DSCP configuration support
by jolly 01 Oct '26

01 Oct '26

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email ) Change subject: Add Cisco like DSCP configuration support ...................................................................... Patch Set 9: (8 comments) File src/ss7_asp.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/6792dac9_f0506… : PS7, Line 141: struct ss7_qos_class *qos; > ```suggestion […] Done File src/ss7_asp_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/49652e51_9c5bd… : PS7, Line 438: "Specify QoS Class of ASP\n" > Why changing this comment? It looks good as-is. Done File src/ss7_qos_class.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/9be60ddf_9c928… : PS7, Line 32: pointer to Application Server > ```suggestion […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/bebe2edd_6cd2e… : PS7, Line 50: pointer to Application Server > ```suggestion […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/82f7cc4a_b5fde… : PS7, Line 96: pointer to Application Server > ```suggestion […] Done File src/ss7_qos_class_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/b5aa525b_13f0a… : PS7, Line 100: CMD_ATTR_NODE_EXIT > Are you sure it's not IMMEDIATE? I don't see any node exit actions here. Done File src/ss7_xua_srv.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/d0a672b3_df0c9… : PS7, Line 30: struct ss7_qos_class *qos; > ```suggestion […] Done File src/ss7_xua_srv_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/aa5b0de6_3827f… : PS7, Line 185: CMD_ATTR_NODE_EXIT > Likewise, isn't it IMMEDIATE? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b Gerrit-Change-Number: 43667 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Oct 2026 09:26:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in libosmo-sigtran[master]: Add Cisco like DSCP configuration support
by jolly 01 Oct '26

01 Oct '26

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Add Cisco like DSCP configuration support ...................................................................... Add Cisco like DSCP configuration support Add Cisco like VTY configuration support for DSCP. QoS classes can be defined and configured per SS7 instance and the classes can be assigned to listener and connections like this: cs7 instance 0 qos class 3 qos-ip-dscp 36 ... asp myasp 2905 2905 m3ua qos-class 3 ... asp asp-srv-m3ua 2906 2905 m3ua qos-class 3 ... asp asp-clnt-m3ua 2905 2906 m3ua qos-class 3 ... Ensure that the ongoing listener or connection socket is updated whenever the QoS class is changed or deleted or its DSCP value is changed. Deprecated "ip-dscp" and "init-ip-dscp" configuration is still supported. When QoS class is assigned, the deprecated configuration is removed and vice versa. Update vty tests to the new VTY command layout and test the new VTY commands. Related: OS#6753 Depends-on: I06927855a173c5b6dbf5c93aa08ea75e1d9d5f37 (libosmocore) Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b --- M TODO-RELEASE M src/Makefile.am M src/ss7_asp.c M src/ss7_asp.h M src/ss7_asp_vty.c M src/ss7_instance.c M src/ss7_instance.h A src/ss7_qos_class.c A src/ss7_qos_class.h A src/ss7_qos_class_vty.c M src/ss7_vty.c M src/ss7_vty.h M src/ss7_xua_srv.c M src/ss7_xua_srv.h M src/ss7_xua_srv_vty.c M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty M tests/vty/vty_test_runner.py 18 files changed, 469 insertions(+), 52 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/67/43667/9 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b Gerrit-Change-Number: 43667 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log October 2026