October 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: OBS: remove update_obs_eclipse_titan.sh
by osmith 23 Oct '26

23 Oct '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43956?usp=email ) Change subject: OBS: remove update_obs_eclipse_titan.sh ...................................................................... OBS: remove update_obs_eclipse_titan.sh This script is outdated and not flexible enough to also handle the "optdir" versions of eclipse-titan we now have to install multiple versions at the same time. The wiki has been updated to have the direct steps that are necessary for updating titan, so remove this script. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Upgrading_eclipse… Change-Id: I39b8739c16c8bc2177a9ce4f269b946d64565aa4 --- D scripts/obs/update_obs_eclipse_titan.sh 1 file changed, 0 insertions(+), 47 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/obs/update_obs_eclipse_titan.sh b/scripts/obs/update_obs_eclipse_titan.sh deleted file mode 100755 index 2439777..0000000 --- a/scripts/obs/update_obs_eclipse_titan.sh +++ /dev/null @@ -1,47 +0,0 @@ -#!/bin/sh -e -# https://osmocom.org/projects/cellular-infrastructure/wiki/Upgrading_eclipse… -DIR="$(realpath "$(dirname "$0")")" -PROJ="$1" -GIT_URL="https://gitea.osmocom.org/osmith/titan.core" -CHECKOUT="$2" - -if [ $# != 2 ]; then - echo "usage:" - echo " update_obs_eclipse_titan.sh PROJ CHECKOUT" - echo "example:" - echo " update_obs_eclipse_titan.sh home:osmith:latest osmocom/11.0.0" - exit 1 -fi - -prepare_git_repo() { - cd "$DIR" - if ! [ -d _cache/eclipse-titan ]; then - mkdir -p _cache - git -C _cache clone "$GIT_URL" eclipse-titan - fi - - cd _cache/eclipse-titan - git fetch - git clean -fdx - git checkout -f -B "$CHECKOUT" - git reset --hard origin/"$CHECKOUT" -} - -update_obs_project() { - cd "$DIR" - ./update_obs_project.py \ - --apiurl https://obs.osmocom.org \ - --docker \ - --allow-unknown-package \ - --git-skip-checkout \ - --git-skip-fetch \ - "$PROJ" \ - eclipse-titan -} - -set -x -prepare_git_repo - -if [ -n "$PROJ" ]; then - update_obs_project -fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43956?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I39b8739c16c8bc2177a9ce4f269b946d64565aa4 Gerrit-Change-Number: 43956 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: add the Osmocom titan.core repository URL
by osmith 23 Oct '26

23 Oct '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43955?usp=email ) Change subject: OBS: add the Osmocom titan.core repository URL ...................................................................... OBS: add the Osmocom titan.core repository URL I'm reworking the documentation for upgrading the eclipse packages, as the previous documentation has become inaccurate and doesn't cover the "optdir" packages yet that we use to have multiple versions installed at the same time. Extend the OBS scripts to use https://gitea.osmocom.org/ttcn3/titan.core as URL if the package name starts with "eclipse-titan", so it can be updated in the future with the following command after updating the git repository: $ ./update_obs_project.py \ -d \ -a \ -f master \ -b osmocom/11.2.1-optdir \ osmocom:nightly \ eclipse-titan-optdir-11.2.1 The git repository is needed, because we have the debian packaging there and may want to add additional, Osmocom-specific fixes on top. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Upgrading_eclipse… Change-Id: Ida79ab2604e5053bdd7a11594ebb413e87cffda9 --- M scripts/obs/lib/config.py M scripts/obs/lib/git.py 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 60d641b..13ee47b 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -105,6 +105,7 @@ git_url_default = "https://gerrit.osmocom.org" # /project gets appended git_url_other = { + "eclipse-titan*": "https://gitea.osmocom.org/ttcn3/titan.core", "libosmo-dsp": "https://gitea.osmocom.org/sdr/libosmo-dsp", "libosmo-sccp-legacy": "https://gitea.osmocom.org/osmocom/libosmo-sccp-legacy", "neocon": "https://github.com/laf0rge/neocon", diff --git a/scripts/obs/lib/git.py b/scripts/obs/lib/git.py index 0194f77..007c6ab 100644 --- a/scripts/obs/lib/git.py +++ b/scripts/obs/lib/git.py @@ -1,6 +1,7 @@ #!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-or-later # Copyright 2022 sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> +import fnmatch import os import re import lib.config @@ -11,8 +12,9 @@ def get_repo_url(project): - if project in lib.config.git_url_other: - return lib.config.git_url_other[project] + for pattern, url in lib.config.git_url_other.items(): + if fnmatch.fnmatch(project, pattern): + return url return f"{lib.config.git_url_default}/{project}" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ida79ab2604e5053bdd7a11594ebb413e87cffda9 Gerrit-Change-Number: 43955 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: gprs_sndcp_xid: replace OSMO_ASSERT with if and return
by pespin 22 Oct '26

22 Oct '26

Attention is currently required from: dexter, fixeria, lynxis lazus. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email ) Change subject: gprs_sndcp_xid: replace OSMO_ASSERT with if and return ...................................................................... Patch Set 1: Code-Review-1 (4 comments) File src/sgsn/gprs_sndcp_xid.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/19ce2de6_fdf73681?us… : PS1, Line 172: if (params->f_max_time < 1) You can put all these checks in one if line please. https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/1eb106e6_38829ce1?us… : PS1, Line 249: if (params->max_cid < 0) Same, all these checks in one line. https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/3a7fbbd1_2f0c2579?us… : PS1, Line 481: } else if possible add {} here while at it. https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/94ca28c8_d54161a4?us… : PS1, Line 641: byte_counter += TLV_GROSS_LEN(sizeof(xid_version_number)); This looks like belonging to one of your previous patches, not this one. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia570b27a3670fed3aeb4779840292c5d216a1102 Gerrit-Change-Number: 43958 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Oct 2026 16:15:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: gprs_sndcp_xid: use reasonable static buffer size
by pespin 22 Oct '26

22 Oct '26

Attention is currently required from: dexter, lynxis lazus. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43957?usp=email ) Change subject: gprs_sndcp_xid: use reasonable static buffer size ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: If348e15a98fd6d28a1de08df57983bb710001d73 Gerrit-Change-Number: 43957 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Oct 2026 16:10:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid
by pespin 22 Oct '26

22 Oct '26

Attention is currently required from: dexter, lynxis lazus. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email ) Change subject: gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > @pmaier@sysmocom.de please have a look at potential same issues in libosmo-gprs. […] @pmaier@sysmocom.de fyi: the libosmo-gprs.git sndcp was initially imported from osmo-sgsn.git, modified/improved, and in the future we want to drop this osmo-sgsn.git code and use libosmo-gprs instead. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I977946a036f96d4dee2656bef048e2618198db40 Gerrit-Change-Number: 43953 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Oct 2026 16:10:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid
by pespin 22 Oct '26

22 Oct '26

Attention is currently required from: dexter, lynxis lazus. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email ) Change subject: gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: @pmaier@sysmocom.de please have a look at potential same issues in libosmo-gprs.git code (src/sndcp/sndcp_xid.c) and submit patches for it (referencing backporting from this osmo-sgsn.git one). -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I977946a036f96d4dee2656bef048e2618198db40 Gerrit-Change-Number: 43953 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Oct 2026 16:08:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: OBS: remove update_obs_eclipse_titan.sh
by pespin 22 Oct '26

22 Oct '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43956?usp=email ) Change subject: OBS: remove update_obs_eclipse_titan.sh ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43956?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I39b8739c16c8bc2177a9ce4f269b946d64565aa4 Gerrit-Change-Number: 43956 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Oct 2026 16:05:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: OBS: add the Osmocom titan.core repository URL
by pespin 22 Oct '26

22 Oct '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43955?usp=email ) Change subject: OBS: add the Osmocom titan.core repository URL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ida79ab2604e5053bdd7a11594ebb413e87cffda9 Gerrit-Change-Number: 43955 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Oct 2026 16:05:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: library/AbisOML_Types: tr_OML_MsgType: fix uninitialized 'len' field
by fixeria 22 Oct '26

22 Oct '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43959?usp=email ) Change subject: library/AbisOML_Types: tr_OML_MsgType: fix uninitialized 'len' field ...................................................................... library/AbisOML_Types: tr_OML_MsgType: fix uninitialized 'len' field This was caught while running BTS_Tests_OML with TITAN 11.2.1: BTS_Tests_OML.ttcn:348 Dynamic test case error: Matching with an uninitialized/unsupported integer template. Change-Id: Ie9e26a73faeb17bc68b439e13ee9d7dcd4abd2f0 Fixes: OS#7108 --- M library/AbisOML_Types.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/library/AbisOML_Types.ttcn b/library/AbisOML_Types.ttcn index 99ad252..0f7dfe2 100644 --- a/library/AbisOML_Types.ttcn +++ b/library/AbisOML_Types.ttcn @@ -790,6 +790,7 @@ modifies tr_OML_FOM_only := { u := { fom := { + len := ?, hdr := { msg_type := msg_type, obj_class := obj_class, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43959?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9e26a73faeb17bc68b439e13ee9d7dcd4abd2f0 Gerrit-Change-Number: 43959 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: library/AbisOML_Types: tr_OML_MsgType: fix uninitialized 'len' field
by osmith 22 Oct '26

22 Oct '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43959?usp=email ) Change subject: library/AbisOML_Types: tr_OML_MsgType: fix uninitialized 'len' field ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43959?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9e26a73faeb17bc68b439e13ee9d7dcd4abd2f0 Gerrit-Change-Number: 43959 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Oct 2026 15:09:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log October 2026