Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43948?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: Introduce udr testsuite
......................................................................
Introduce udr testsuite
Introduce a new "udr" testsuite which runs against open5gs-udrd.
Start with a couple tests which already contains most of the
infrastructure needed and makes it easy to extend later on.
Related: SYS#7073
Change-Id: I025c7e87e9a8308c084edc7a7da23c080a0dc970
---
M Makefile
M library/General_Types.ttcn
M library/JSON_Generic_Templates.ttcn
M library/TS29505_Subscription_Data_Templates.ttcn
A udr/ConnHdlr.ttcn
A udr/README.md
A udr/UDR_Tests.cfg
A udr/UDR_Tests.default
A udr/UDR_Tests.ttcn
A udr/create_test_subscribers.sh
A udr/expected-results.xml
A udr/gen_links.sh
A udr/mongod.conf
A udr/open5gs-udr.yaml
A udr/regen_makefile.sh
A udr/testenv.cfg
A udr/testsrcdir.cfg
17 files changed, 967 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/48/43948/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43948?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I025c7e87e9a8308c084edc7a7da23c080a0dc970
Gerrit-Change-Number: 43948
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, osmith.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: Introduce udm testsuite
......................................................................
Introduce udm testsuite
Introduce a new "udm" testsuite which runs against open5gs-udmd.
Start with a couple tests which already contains most of the
infrastructure needed and makes it easy to extend later on.
Related: SYS#7073
Change-Id: Ia9a2a055ee81c889de00ef86f8562425862ea5e3
---
M Makefile
A library/TS29503_Nudm_UEAU_Templates.ttcn
A library/TS29505_Subscription_Data_Templates.ttcn
M library/TS29571_CommonData_Templates.ttcn
M smf/gen_links.sh
A udm/ConnHdlr.ttcn
A udm/README.md
A udm/UDM_Tests.cfg
A udm/UDM_Tests.default
A udm/UDM_Tests.ttcn
A udm/create_test_subscribers.sh
A udm/expected-results.xml
A udm/gen_links.sh
A udm/mongod.conf
A udm/open5gs-udm.yaml
A udm/open5gs_prepare.sh
A udm/regen_makefile.sh
A udm/testenv.cfg
A udm/testsrcdir.cfg
19 files changed, 1,184 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/43932/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a2a055ee81c889de00ef86f8562425862ea5e3
Gerrit-Change-Number: 43932
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932?usp=email )
Change subject: Introduce udm testsuite
......................................................................
Patch Set 3:
(4 comments)
File udm/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932/comment/fdab578b_a1d6… :
PS3, Line 38: import from UDM_Tests all
> Ah, perhaps because you're using the module parameters. […]
There's tons of places where mp_* are used, ie. in every
f_http2_adapter_connect(). Since it's only one grep away to find it, I think we can skip the module prefix since it just works like this.
File udm/UDM_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932/comment/b6fa6711_c33e… :
PS3, Line 52: PFCP
> ```suggestion […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932/comment/44fa35bf_f13d… :
PS3, Line 130: setverdict(pass);
> `f_shutdown()` already does this.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932/comment/358866f5_77ec… :
PS3, Line 147: setverdict
> `f_shutdown()` already does this.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a2a055ee81c889de00ef86f8562425862ea5e3
Gerrit-Change-Number: 43932
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Oct 2026 11:16:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: jolly, laforge, pespin.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email )
Change subject: SGP23_Constants: use a reasonable default for sm_dp_oid
......................................................................
Patch Set 3:
(1 comment)
File library/Misc_Helpers.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930/comment/1b087a77_66a4… :
PS1, Line 166: function objid2char(objid oid) return charstring {
> I have seen your comment and didn't forget about it. I will address it now. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadf45954f18685c96d46b7df37c103eac3654332
Gerrit-Change-Number: 43930
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Oct 2026 09:44:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: jolly, laforge, pespin.
Hello Jenkins Builder, jolly, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: SGP23_Constants: use a reasonable default for sm_dp_oid
......................................................................
SGP23_Constants: use a reasonable default for sm_dp_oid
The function f_SGP23_ACTIVATION_CODE_2 takes a paramter sm_dp_oid,
which currently has no reasonable default value. Let's use the
default as defined in SGP.23.
Since the Activation Code requires the SM-DP+ OID in its human
readable form, this patch also adds a converter function that
converts an objid into a charstring.
Change-Id: Iadf45954f18685c96d46b7df37c103eac3654332
Related: SYS#8203
---
M library/Osmocom_Types.ttcn
M library/euicc/SGP23_Constants.ttcn
2 files changed, 22 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/43930/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadf45954f18685c96d46b7df37c103eac3654332
Gerrit-Change-Number: 43930
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly, laforge, pespin.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email )
Change subject: SGP23_Constants: use a reasonable default for sm_dp_oid
......................................................................
Patch Set 2:
(1 comment)
File library/Misc_Helpers.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930/comment/4596a8ee_0cae… :
PS1, Line 166: function objid2char(objid oid) return charstring {
> I see in Osmocom_Types. […]
I have seen your comment and didn't forget about it. I will address it now.
(I thought of putting the function into Osmocom_types.ttcn also, but I wasn't sure if this would be the right place.)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadf45954f18685c96d46b7df37c103eac3654332
Gerrit-Change-Number: 43930
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Oct 2026 09:34:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email )
Change subject: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e
Gerrit-Change-Number: 43904
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 23 Oct 2026 09:31:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932?usp=email )
Change subject: Introduce udm testsuite
......................................................................
Patch Set 3:
(1 comment)
File udm/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932/comment/f4624fa0_8430… :
PS3, Line 38: import from UDM_Tests all
> Can you explain why this import is needed? […]
Ah, perhaps because you're using the module parameters. Maybe it's better to use the absolute path when referencing them (e.g. `UDM_Tests.mp_imsi`)?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43932?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a2a055ee81c889de00ef86f8562425862ea5e3
Gerrit-Change-Number: 43932
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Oct 2026 09:13:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>