Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email )
Change subject: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases
......................................................................
Patch Set 7:
(1 comment)
File eim/eIM_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904/comment/02da5c17_37f4… :
PS7, Line 1241: private function f_TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_SM_DPp_pb_certificate(charstring id)
setverdict(fail): pass -> fail reason: "unexpected REST lookup result from eIM", new component reason: "unexpected REST lookup result from eIM"
I am using this patch ontop of osmo-ttcn3-hacks master and your pmaier/wip branch at onomondo-eim.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e
Gerrit-Change-Number: 43904
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Oct 2026 13:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43964?usp=email )
Change subject: bts: f_TC_pcu_tx_ul_block_req(): target the block after the next one
......................................................................
bts: f_TC_pcu_tx_ul_block_req(): target the block after the next one
trxcon sends the L1CTL DL BLOCK.ind after the last burst of a block
has been received, while the Uplink bursts are scheduled in advance
(see '--trx-advance', default 2). Thus it's already too late to
target the block following the received one: trxcon drops such
UL BLOCK.req as stale, and TC_pcu_data_ind_lqual_cb fails with
"Timeout waiting for PCUIF_DATA.ind".
Fix this by targeting the block after the next one. While at it,
use the existing f_next_pdtch_block() instead of open-coding the
TDMA Fn calculation.
Change-Id: Ie77761c472ba14ad17414c347e1aed140a3295e8
---
M bts/BTS_Tests.ttcn
1 file changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/43964/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 719d8e3..719a9fa 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -5335,21 +5335,19 @@
T.start(1.0);
alt {
[] as_l1ctl_dl_block_ind(block_ind, tn := tn, usf := usf) {
- var integer fn := block_ind.hdr.fn;
+ var GsmFrameNumber fn := block_ind.hdr.fn;
/* Ignore PTCCH/D blocks, their Fn is too far away */
if (fn mod 104 == 12) {
repeat;
}
- /* Every fn % 13 == 12 we have either a PTCCH or an IDLE slot, thus
- * every fn % 13 == 8 we add 5 frames, or 4 frames othrwise. The
- * resulting value is first fn of the next block. */
- if (fn mod 13 == 8) {
- fn := (fn + 5) mod (2048 * 51 * 26);
- } else {
- fn := (fn + 4) mod (2048 * 51 * 26);
- }
+ /* Skip the next block, target the one after it.
+ * The DL BLOCK.ind is sent by trxcon after the last burst of a block
+ * has been received, while the Uplink bursts are scheduled in advance,
+ * so it's already too late to target the block following the received
+ * one. Hence the UL BLOCK.req targets the block after the next one. */
+ fn := f_next_pdtch_block(f_next_pdtch_block(fn));
L1CTL.send(ts_L1CTL_GPRS_UL_BLOCK_REQ(fn, block_ind.hdr.tn, data));
return {fn, block_ind.hdr.tn};
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43964?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie77761c472ba14ad17414c347e1aed140a3295e8
Gerrit-Change-Number: 43964
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, lynxis lazus, pespin.
Hello Jenkins Builder, fixeria, lynxis lazus, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: gprs_sndcp_xid: replace OSMO_ASSERT with if and return
......................................................................
gprs_sndcp_xid: replace OSMO_ASSERT with if and return
The code around the function gprs_sndcp_compile_xid was written
under the assumption that the caller always supplies correct
input parameters because the caller has 100% control over the
input. However, this is a high standard and depending on how
the input is obtained errors may happen. In case of an error,
the whole process will crash due to the usage of OSMO_ASSERT.
When looking at the callers of gprs_sndcp_compile_xid, we can
see that they already check the return code. Also the return
type of gprs_sndcp_compile_xid is already int. We also do not
have any dynamically allocated memory. There is nothing
that would speak against returning a negative error code.
Let's replace each occurrence of OSMO_ASSERT with an if and
return an error code to the caller, so that the caller can
handle the problem gracefully.
Related: OS#7095
Change-Id: Ia570b27a3670fed3aeb4779840292c5d216a1102
---
M src/sgsn/gprs_sndcp_xid.c
1 file changed, 106 insertions(+), 78 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/58/43958/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia570b27a3670fed3aeb4779840292c5d216a1102
Gerrit-Change-Number: 43958
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: fixeria, lynxis lazus, pespin.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email )
Change subject: gprs_sndcp_xid: replace OSMO_ASSERT with if and return
......................................................................
Patch Set 2:
(4 comments)
File src/sgsn/gprs_sndcp_xid.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/eb337396_62a7c871?us… :
PS1, Line 172: if (params->f_max_time < 1)
> You can put all these checks in one if line please.
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/2437ddb1_735d5685?us… :
PS1, Line 249: if (params->max_cid < 0)
> Same, all these checks in one line.
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/6d9387cf_08c92050?us… :
PS1, Line 481: } else
> if possible add {} here while at it.
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/47c9bc62_329a0a23?us… :
PS1, Line 641: byte_counter += TLV_GROSS_LEN(sizeof(xid_version_number));
> This looks like belonging to one of your previous patches, not this one.
It removes the OSMO_ASSERT and takes over the style of the fix in the previous patch, but has technically nothing to do with it. The OSMO_ASSERT check also wasn't broken.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia570b27a3670fed3aeb4779840292c5d216a1102
Gerrit-Change-Number: 43958
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 23 Oct 2026 12:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/43963?usp=email )
Change subject: sndcp_xid: use reasonable static buffer size
......................................................................
sndcp_xid: use reasonable static buffer size
the output of gprs_sndcp_compile_xid is a buffer with TLV objects.
Each TLV object is generated into an internal buffer (comp_bytes)
before it is added to the output buffer using tlv_put. Since we
are using a TLV structure here, the fields cannot exceed a length
of 255. Using a buffer size of 512 is misleading.
This patch has been ported from:
osmo-sgsn.git If348e15a98fd6d28a1de08df57983bb710001d73
Related: OS#7095
Change-Id: Ic8e7719063d87e5328ebf503e9a43325bb07acf8
---
M src/sndcp/sndcp_xid.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/63/43963/1
diff --git a/src/sndcp/sndcp_xid.c b/src/sndcp/sndcp_xid.c
index 28e8928..a380206 100644
--- a/src/sndcp/sndcp_xid.c
+++ b/src/sndcp/sndcp_xid.c
@@ -560,7 +560,7 @@
{
int rc;
int byte_counter = 0;
- uint8_t comp_bytes[512];
+ uint8_t comp_bytes[256];
uint8_t xid_version_number[1];
OSMO_ASSERT(comp_fields);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43963?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ic8e7719063d87e5328ebf503e9a43325bb07acf8
Gerrit-Change-Number: 43963
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43961?usp=email )
Change subject: smf: Clean up SBI paths
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43961?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idf0ed2e95937fe9a331be577d01cee8d309eab01
Gerrit-Change-Number: 43961
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Oct 2026 12:29:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes