Attention is currently required from: fixeria, lynxis lazus, pespin.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email )
Change subject: gprs_sndcp_xid: replace OSMO_ASSERT with if and return ......................................................................
Patch Set 2:
(4 comments)
File src/sgsn/gprs_sndcp_xid.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/eb337396_62a7c871?usp... : PS1, Line 172: if (params->f_max_time < 1)
You can put all these checks in one if line please.
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/2437ddb1_735d5685?usp... : PS1, Line 249: if (params->max_cid < 0)
Same, all these checks in one line.
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/6d9387cf_08c92050?usp... : PS1, Line 481: } else
if possible add {} here while at it.
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/47c9bc62_329a0a23?usp... : PS1, Line 641: byte_counter += TLV_GROSS_LEN(sizeof(xid_version_number));
This looks like belonging to one of your previous patches, not this one.
It removes the OSMO_ASSERT and takes over the style of the fix in the previous patch, but has technically nothing to do with it. The OSMO_ASSERT check also wasn't broken.
-
dexter