Attention is currently required from: fixeria, lynxis lazus, pespin.

View Change

4 comments:

• File src/sgsn/gprs_sndcp_xid.c:

  • Patch Set #1, Line 172: if (params->f_max_time < 1)

    You can put all these checks in one if line please.

    Done

  • Patch Set #1, Line 249: if (params->max_cid < 0)

    Same, all these checks in one line.

    Done

  • Patch Set #1, Line 481: } else

    if possible add {} here while at it.

    Done

  • Patch Set #1, Line 641: byte_counter += TLV_GROSS_LEN(sizeof(xid_version_number));

    This looks like belonging to one of your previous patches, not this one.

    It removes the OSMO_ASSERT and takes over the style of the fix in the previous patch, but has technically nothing to do with it. The OSMO_ASSERT check also wasn't broken.

To view, visit change 43958. To unsubscribe, or for help writing mail filters, visit settings.