[S] Change in pysim[master]: personalization: SmspTpScAddr edits record 1 of EF.SMSP only
Attention is currently required from: dexter, laforge, neels, osmith. hampushellsberg has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43983?usp=email ) Change subject: personalization: SmspTpScAddr edits record 1 of EF.SMSP only ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/43983/comment/3c95e99a_a6048da8?usp=ema... : PS3, Line 651: if rec_len
I don't think "if rec_len" is the right predicate here. IMHO, it will always be true. […] You're right, it's always true here: the EF.SMSP templates are linear fixed with a record length, and slicing past the end just gives b''. I only meant to guard against rec_len being None, which can't happen for this file. I'd drop the condition and add a test with a one-record and a two-record EF.SMSP that checks the second record is kept. Would that work for you?
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/43983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1 Gerrit-Change-Number: 43983 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Sat, 31 Oct 2026 13:11:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org>
participants (1)
-
hampushellsberg