Attention is currently required from: dexter, laforge, neels, osmith.
1 comment:
File pySim/esim/saip/personalization.py:
Patch Set #3, Line 651: if rec_len
I don't think "if rec_len" is the right predicate here. IMHO, it will always be true. […]
You're right, it's always true here: the EF.SMSP templates are linear fixed with a record length, and slicing past the end just gives b''. I only meant to guard against rec_len being None, which can't happen for this file. I'd drop the condition and add a test with a one-record and a two-record EF.SMSP that checks the second record is kept. Would that work for you?
To view, visit change 43983. To unsubscribe, or for help writing mail filters, visit settings.