[S] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
Attention is currently required from: laforge. hampushellsberg has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/bf11fe54_b00f4a76?usp=ema... : PS1, Line 1156:
can't we deduct the SCP02/03/80 usage from the KVN? And then determine the length based on that? If […] As far as I can see there is only one length per SCP: 5 bytes for SCP80, 3 for SCP03 and 2 for SCP02, the same as the defaults in SAIP 8.6.3. So yes, the length could come from the KVN ranges in that table.
Two corner cases I'd like to align on before I upload the next patch set: - A counter on a KVN outside those ranges (the table says it's incomplete): should that raise, or would you allow an optional explicit length there? - A decoded counter whose length doesn't match its KVN: keep the decoded length, so decode and re-encode stay byte-identical, or re-encode with the length the KVN implies? What would you prefer? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 1 Gerrit-Owner: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Sat, 31 Oct 2026 13:08:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: hampushellsberg <hampushellsberg@gmail.com> Comment-In-Reply-To: laforge <laforge@osmocom.org>
participants (1)
-
hampushellsberg