[S] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
Attention is currently required from: hampushellsberg. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/3a919892_c0c7ee67?usp=ema... : PS1, Line 1156:
As far as I can see there is only one length per SCP: 5 bytes for SCP80, 3 for SCP03 and 2 for […] Case 1: I would say let's raise an exception so we as developers/maintainers get note of it and can extend/fix/update the table
Case 2: I would re-encode to what we believe is correct within the spec, and not try to copy+paste potentially invalid input. Thanks! In general, before you push an updated patch series: I would suggest to re-order the patch series to start with those that have positive review and no comments and end with those that still have no reviews or pending issues. This way we can hopefully merge the first patches soon without being blocked with those that still have some wokr to be done. This of course only applies as far as patches have no inter-dependencies/conflicts. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 1 Gerrit-Owner: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg@gmail.com> Gerrit-Comment-Date: Mon, 02 Nov 2026 10:00:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: hampushellsberg <hampushellsberg@gmail.com> Comment-In-Reply-To: laforge <laforge@osmocom.org>
participants (1)
-
laforge