Attention is currently required from: hampushellsberg.
1 comment:
File pySim/esim/saip/__init__.py:
As far as I can see there is only one length per SCP: 5 bytes for SCP80, 3 for SCP03 and 2 for […]
Case 1: I would say let's raise an exception so we as developers/maintainers get note of it and can extend/fix/update the table
Case 2: I would re-encode to what we believe is correct within the spec, and not try to copy+paste potentially invalid input.
Thanks!
In general, before you push an updated patch series: I would suggest to re-order the patch series to start with those that have positive review and no comments and end with those that still have no reviews or pending issues. This way we can hopefully merge the first patches soon without being blocked with those that still have some wokr to be done. This of course only applies as far as patches have no inter-dependencies/conflicts.
To view, visit change 44011. To unsubscribe, or for help writing mail filters, visit settings.