June 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Make sure MTP-PAUSE.ind is sent to SCCP when AS goes down

by pespin

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40488?usp=email ) Change subject: Make sure MTP-PAUSE.ind is sent to SCCP when AS goes down ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: @laforge@gnumonks.org this improves the current situation regarding receiving N-PCSTATE.ind in osmo-bsc, but doesn't fix it for 100% of the cases, because fully qualified routes are only added automatically/dynamically when DAVA is received at osmo-bsc. If other peers connect before osmo-bsc to the osmo-stp (or there's a direct conn bsc->msc), then we never actually receive a DAVA and hence there's no dynamic route applied. IMHO we need to modfy ss7_simple_ss7 somehow to make sure routes for all concerted DPCs are added, or that at least make sure those DPCs are added to the address-book and then lookup the address-book DPCs when AS becomes ianctive to also send indications up the stack for those. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0f28b049045fbea93fe91c99251e7aaa40c014e5 Gerrit-Change-Number: 40488 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jun 2025 12:48:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months

1
0
0 0

[M] Change in libosmo-sigtran[master]: Make sure MTP-PAUSE.ind is sent to SCCP when AS goes down

by pespin

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40488?usp=email ) Change subject: Make sure MTP-PAUSE.ind is sent to SCCP when AS goes down ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0f28b049045fbea93fe91c99251e7aaa40c014e5 Gerrit-Change-Number: 40488 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jun 2025 12:45:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

2 months

1
0
0 0

[M] Change in libosmo-sigtran[master]: xua_snm: Add fully qualified dynamic routes to track announced PCs

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40558?usp=email ) Change subject: xua_snm: Add fully qualified dynamic routes to track announced PCs ...................................................................... xua_snm: Add fully qualified dynamic routes to track announced PCs This allows building up a set of "concerned remote PCs" which can be used to indicate (MTP-PAUSE/RESUME.ind, N-PCSTATE.ind) upper layers that specific remote PCs went down eg. when a local AS becomes inactive (for instance because the last ASP SCTP/TCP link goes down). Change-Id: Icd72e7b15ea3f18c7d1a9a7c821d6d7f7ab11a96 --- M src/ss7_route_table.c M src/ss7_route_table.h M src/xua_snm.c 3 files changed, 63 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/58/40558/1 diff --git a/src/ss7_route_table.c b/src/ss7_route_table.c index f216cff..e59fd55 100644 --- a/src/ss7_route_table.c +++ b/src/ss7_route_table.c @@ -137,6 +137,41 @@ return NULL; } +/*! \brief Find a SS7 route for given destination point code + mask in given table via given AS. + * + * This function is used for route management procedures, not for packet routing lookup procedures! + */ +struct osmo_ss7_route * +ss7_route_table_find_route_by_dpc_mask_as(struct osmo_ss7_route_table *rtbl, uint32_t dpc, + uint32_t mask, const struct osmo_ss7_as *as, bool dynamic) +{ + struct osmo_ss7_combined_linkset *clset; + struct osmo_ss7_route *rt; + + OSMO_ASSERT(ss7_initialized); + + dpc = osmo_ss7_pc_normalize(&rtbl->inst->cfg.pc_fmt, dpc); + mask = osmo_ss7_pc_normalize(&rtbl->inst->cfg.pc_fmt, mask); + + /* we assume the combined_links are sorted by mask length, i.e. more + * specific combined links first, and less specific combined links with shorter + * mask later */ + llist_for_each_entry(clset, &rtbl->combined_linksets, list) { + if ((dpc & clset->cfg.mask) != clset->cfg.pc) + continue; + if (mask != clset->cfg.mask) + continue; + llist_for_each_entry(rt, &clset->routes, list) { + if (rt->dest.as != as) + continue; + if (rt->cfg.dyn_allocated != dynamic) + continue; + return rt; + } + } + return NULL; +} + struct osmo_ss7_combined_linkset * ss7_route_table_find_combined_linkset_by_dpc(struct osmo_ss7_route_table *rtbl, uint32_t dpc) { diff --git a/src/ss7_route_table.h b/src/ss7_route_table.h index 1155600..a128915 100644 --- a/src/ss7_route_table.h +++ b/src/ss7_route_table.h @@ -42,6 +42,9 @@ ss7_route_table_find_route_by_dpc_mask(struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, bool dynamic); struct osmo_ss7_route * +ss7_route_table_find_route_by_dpc_mask_as(struct osmo_ss7_route_table *rtbl, uint32_t dpc, + uint32_t mask, const struct osmo_ss7_as *as, bool dynamic); +struct osmo_ss7_route * ss7_route_table_lookup_route(struct osmo_ss7_route_table *rtbl, const struct osmo_ss7_route_label *rtlabel); struct osmo_ss7_combined_linkset * diff --git a/src/xua_snm.c b/src/xua_snm.c index 42361c9..d4c9a75 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -154,16 +154,36 @@ /* RFC4666 1.4.2.5: "maintain a dynamic table of available SGP routes * for the SS7 destinations, taking into account the SS7 destination * availability/restricted/congestion status received from the SGP "*/ -static void xua_snm_srm_pc_available(struct osmo_ss7_as *as, - const uint32_t *aff_pc, unsigned int num_aff_pc, - bool available) +static void xua_snm_srm_pc_available_single(struct osmo_ss7_as *as, uint32_t pc, bool available) { struct osmo_ss7_instance *s7i = as->inst; enum osmo_ss7_route_status new_status; + struct osmo_ss7_route *rt; new_status = available ? OSMO_SS7_ROUTE_STATUS_AVAILABLE : OSMO_SS7_ROUTE_STATUS_UNAVAILABLE; + /* Check if we already have a dynamic fully qualified route towards that AS: */ + rt = ss7_route_table_find_route_by_dpc_mask_as(s7i->rtable_system, pc, 0xffffff, as, true); + if (!rt) { + /* No dynamic fully qualified route found. Add dynamic fully + * squalified route and mark it as (un)available: */ + rt = ss7_route_create(s7i->rtable_system, pc, 0xffffff, true, as->cfg.name); + if (!rt) { + LOGPAS(as, DLSS7, LOGL_ERROR, "Unable to create dynamic route for pc=%u=%s status=%s\n", + pc, osmo_ss7_pointcode_print(s7i, pc), ss7_route_status_name(new_status)); + return; + } + ss7_route_update_route_status(rt, new_status); + /* No need to iterate over rtable below, since we know there was no route: */ + return; + } + ss7_route_table_update_route_status_by_as(s7i->rtable_system, new_status, as, pc); +} +static void xua_snm_srm_pc_available(struct osmo_ss7_as *as, + const uint32_t *aff_pc, unsigned int num_aff_pc, + bool available) +{ for (unsigned int i = 0; i < num_aff_pc; i++) { /* 32bit "Affected Point Code" consists of a 7-bit mask followed by 14/16/24-bit SS7 PC, * see RFC 4666 3.4.1 */ @@ -172,13 +192,13 @@ uint8_t mask = _aff_pc >> 24; if (!mask) { - ss7_route_table_update_route_status_by_as(s7i->rtable_system, new_status, as, pc); + xua_snm_srm_pc_available_single(as, pc, available); } else { /* Update only full DPC routes. */ uint32_t maskbits = (1 << mask) - 1; uint32_t fullpc; for (fullpc = (pc & ~maskbits); fullpc <= (pc | maskbits); fullpc++) - ss7_route_table_update_route_status_by_as(s7i->rtable_system, new_status, as, fullpc); + xua_snm_srm_pc_available_single(as, fullpc, available); } } } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icd72e7b15ea3f18c7d1a9a7c821d6d7f7ab11a96 Gerrit-Change-Number: 40558 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[S] Change in libosmo-sigtran[master]: route_table: Constify args of serveral APIs

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40559?usp=email ) Change subject: route_table: Constify args of serveral APIs ...................................................................... route_table: Constify args of serveral APIs Change-Id: I45387df6b6d598676cd8dcd152e1f8b4cd35bba4 --- M src/ss7_route_table.c M src/ss7_route_table.h 2 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/59/40559/1 diff --git a/src/ss7_route_table.c b/src/ss7_route_table.c index e59fd55..bd7b305 100644 --- a/src/ss7_route_table.c +++ b/src/ss7_route_table.c @@ -109,7 +109,7 @@ * This function is used for route management procedures, not for packet routing lookup procedures! */ struct osmo_ss7_route * -ss7_route_table_find_route_by_dpc_mask(struct osmo_ss7_route_table *rtbl, uint32_t dpc, +ss7_route_table_find_route_by_dpc_mask(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, bool dynamic) { struct osmo_ss7_combined_linkset *clset; @@ -142,7 +142,7 @@ * This function is used for route management procedures, not for packet routing lookup procedures! */ struct osmo_ss7_route * -ss7_route_table_find_route_by_dpc_mask_as(struct osmo_ss7_route_table *rtbl, uint32_t dpc, +ss7_route_table_find_route_by_dpc_mask_as(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, const struct osmo_ss7_as *as, bool dynamic) { struct osmo_ss7_combined_linkset *clset; @@ -173,7 +173,7 @@ } struct osmo_ss7_combined_linkset * -ss7_route_table_find_combined_linkset_by_dpc(struct osmo_ss7_route_table *rtbl, uint32_t dpc) +ss7_route_table_find_combined_linkset_by_dpc(const struct osmo_ss7_route_table *rtbl, uint32_t dpc) { struct osmo_ss7_combined_linkset *clset; @@ -192,7 +192,7 @@ } struct osmo_ss7_combined_linkset * -ss7_route_table_find_combined_linkset_by_dpc_mask(struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask) +ss7_route_table_find_combined_linkset_by_dpc_mask(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask) { struct osmo_ss7_combined_linkset *clset; @@ -213,7 +213,7 @@ } struct osmo_ss7_combined_linkset * -ss7_route_table_find_combined_linkset(struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, uint32_t prio) +ss7_route_table_find_combined_linkset(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, uint32_t prio) { struct osmo_ss7_combined_linkset *clset; @@ -244,7 +244,7 @@ return clset; } -void ss7_route_table_update_route_status_by_as(struct osmo_ss7_route_table *rtbl, enum osmo_ss7_route_status status, +void ss7_route_table_update_route_status_by_as(const struct osmo_ss7_route_table *rtbl, enum osmo_ss7_route_status status, const struct osmo_ss7_as *as, uint32_t dpc) { struct osmo_ss7_combined_linkset *clset; @@ -300,7 +300,7 @@ } struct osmo_ss7_route * -ss7_route_table_lookup_route(struct osmo_ss7_route_table *rtbl, const struct osmo_ss7_route_label *rtlabel) +ss7_route_table_lookup_route(const struct osmo_ss7_route_table *rtbl, const struct osmo_ss7_route_label *rtlabel) { struct osmo_ss7_combined_linkset *clset; struct osmo_ss7_route *rt; diff --git a/src/ss7_route_table.h b/src/ss7_route_table.h index a128915..5141c18 100644 --- a/src/ss7_route_table.h +++ b/src/ss7_route_table.h @@ -39,26 +39,26 @@ void ss7_route_table_destroy(struct osmo_ss7_route_table *rtbl); struct osmo_ss7_route * -ss7_route_table_find_route_by_dpc_mask(struct osmo_ss7_route_table *rtbl, uint32_t dpc, +ss7_route_table_find_route_by_dpc_mask(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, bool dynamic); struct osmo_ss7_route * -ss7_route_table_find_route_by_dpc_mask_as(struct osmo_ss7_route_table *rtbl, uint32_t dpc, +ss7_route_table_find_route_by_dpc_mask_as(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, const struct osmo_ss7_as *as, bool dynamic); struct osmo_ss7_route * -ss7_route_table_lookup_route(struct osmo_ss7_route_table *rtbl, const struct osmo_ss7_route_label *rtlabel); +ss7_route_table_lookup_route(const struct osmo_ss7_route_table *rtbl, const struct osmo_ss7_route_label *rtlabel); struct osmo_ss7_combined_linkset * -ss7_route_table_find_combined_linkset(struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, uint32_t prio); +ss7_route_table_find_combined_linkset(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, uint32_t prio); struct osmo_ss7_combined_linkset * ss7_route_table_find_or_create_combined_linkset(struct osmo_ss7_route_table *rtbl, uint32_t pc, uint32_t mask, uint32_t prio); struct osmo_ss7_combined_linkset * -ss7_route_table_find_combined_linkset_by_dpc(struct osmo_ss7_route_table *rtbl, uint32_t dpc); +ss7_route_table_find_combined_linkset_by_dpc(const struct osmo_ss7_route_table *rtbl, uint32_t dpc); struct osmo_ss7_combined_linkset * -ss7_route_table_find_combined_linkset_by_dpc_mask(struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask); +ss7_route_table_find_combined_linkset_by_dpc_mask(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask); struct osmo_ss7_combined_linkset * -ss7_route_table_find_combined_linkset(struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, uint32_t prio); +ss7_route_table_find_combined_linkset(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, uint32_t prio); -void ss7_route_table_update_route_status_by_as(struct osmo_ss7_route_table *rtbl, enum osmo_ss7_route_status status, +void ss7_route_table_update_route_status_by_as(const struct osmo_ss7_route_table *rtbl, enum osmo_ss7_route_status status, const struct osmo_ss7_as *as, uint32_t dpc); void ss7_route_table_del_routes_by_as(struct osmo_ss7_route_table *rtbl, struct osmo_ss7_as *as); void ss7_route_table_del_routes_by_linkset(struct osmo_ss7_route_table *rtbl, struct osmo_ss7_linkset *lset); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I45387df6b6d598676cd8dcd152e1f8b4cd35bba4 Gerrit-Change-Number: 40559 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[M] Change in libosmo-sigtran[master]: route_table: Introduce ss7_route_table_dpc_is_accessible() API

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40560?usp=email ) Change subject: route_table: Introduce ss7_route_table_dpc_is_accessible() API ...................................................................... route_table: Introduce ss7_route_table_dpc_is_accessible() API In some places we don't need to select/choose a specific route (hence requiring a loadshare decision and hence modifying state), but simply figure out whether there's an available route for a given rmeote PC. Change-Id: Ia3b2eb17afae71dc7cec34b521693e776fa3576d --- M src/sccp_scrc.c M src/ss7_route_table.c M src/ss7_route_table.h M src/xua_snm.c 4 files changed, 29 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/60/40560/1 diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c index ebc9a11..d7a6428 100644 --- a/src/sccp_scrc.c +++ b/src/sccp_scrc.c @@ -70,9 +70,8 @@ static bool dpc_accessible(struct osmo_sccp_instance *inst, uint32_t dpc) { struct osmo_ss7_instance *ss7 = inst->ss7; - struct osmo_ss7_route *rt; - struct osmo_ss7_route_label rtlabel; char buf_dpc[MAX_PC_STR_LEN]; + bool found; if (osmo_ss7_pc_is_local(ss7, dpc)) { LOGPSCI(inst, LOGL_DEBUG, "dpc_accessible(DPC=%u=%s): true (local)\n", @@ -80,22 +79,14 @@ return true; } - rtlabel = (struct osmo_ss7_route_label){ - .opc = 0, - .dpc = dpc, - .sls = 0, - }; + found = ss7_route_table_dpc_is_accessible(ss7->rtable_system, dpc); - rt = ss7_instance_lookup_route(ss7, &rtlabel); - if (!rt) { - LOGPSCI(inst, LOGL_INFO, "dpc_accessible(DPC=%u=%s): false\n", - dpc, osmo_ss7_pointcode_print_buf(buf_dpc, sizeof(buf_dpc), ss7, dpc)); - return false; - } + LOGPSCI(inst, found ? LOGL_DEBUG : LOGL_INFO, + "dpc_accessible(DPC=%u=%s): %s\n", + dpc, osmo_ss7_pointcode_print_buf(buf_dpc, sizeof(buf_dpc), ss7, dpc), + found ? "true" : "false"); + return found; - LOGPSCI(inst, LOGL_DEBUG, "dpc_accessible(DPC=%u=%s): true\n", - dpc, osmo_ss7_pointcode_print_buf(buf_dpc, sizeof(buf_dpc), ss7, dpc)); - return true; } static bool sccp_available(struct osmo_sccp_instance *inst, diff --git a/src/ss7_route_table.c b/src/ss7_route_table.c index bd7b305..16eb9bd 100644 --- a/src/ss7_route_table.c +++ b/src/ss7_route_table.c @@ -299,6 +299,8 @@ } } +/* Choose a specific route to transmit a packet. + * Note: This function potentially modifies loadsharing state context of chosen combined linkset. */ struct osmo_ss7_route * ss7_route_table_lookup_route(const struct osmo_ss7_route_table *rtbl, const struct osmo_ss7_route_label *rtlabel) { @@ -322,3 +324,20 @@ } return NULL; } + +/* Figure out whether a remote PC is accessible over any route in the routing table. + * Note: Unlike ss7_route_table_lookup_route(), this function is read-only and doesn't modify any state. */ +bool ss7_route_table_dpc_is_accessible(const struct osmo_ss7_route_table *rtbl, uint32_t dpc) +{ + struct osmo_ss7_combined_linkset *clset; + /* we assume the combined_links are sorted by mask length, i.e. more + * specific combined links first, and less specific combined links with shorter + * mask later */ + llist_for_each_entry(clset, &rtbl->combined_linksets, list) { + if ((dpc & clset->cfg.mask) != clset->cfg.pc) + continue; + if (ss7_combined_linkset_is_available(clset)) + return true; + } + return false; +} diff --git a/src/ss7_route_table.h b/src/ss7_route_table.h index 5141c18..582a8d3 100644 --- a/src/ss7_route_table.h +++ b/src/ss7_route_table.h @@ -46,6 +46,7 @@ uint32_t mask, const struct osmo_ss7_as *as, bool dynamic); struct osmo_ss7_route * ss7_route_table_lookup_route(const struct osmo_ss7_route_table *rtbl, const struct osmo_ss7_route_label *rtlabel); +bool ss7_route_table_dpc_is_accessible(const struct osmo_ss7_route_table *rtbl, uint32_t dpc); struct osmo_ss7_combined_linkset * ss7_route_table_find_combined_linkset(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, uint32_t prio); diff --git a/src/xua_snm.c b/src/xua_snm.c index d4c9a75..207b042 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -375,16 +375,10 @@ uint8_t mask = _aff_pc >> 24; bool is_available; - struct osmo_ss7_route_label rtlabel = { - .opc = xua->mtp.opc, /* Use OPC of received DAUD. */ - .dpc = pc, - .sls = 0, - }; - if (mask == 0) { /* one single point code */ /* Check if there's an "active" route available: */ - is_available = !!ss7_instance_lookup_route(s7i, &rtlabel); + is_available = ss7_route_table_dpc_is_accessible(s7i->rtable_system, pc); xua_tx_snm_available(asp, rctx, num_rctx, &aff_pc[i], 1, "Response to DAUD", is_available); @@ -397,8 +391,7 @@ uint32_t *aff_pc_avail = talloc_size(asp, sizeof(uint32_t)*(1 << mask)); uint32_t *aff_pc_unavail = talloc_size(asp, sizeof(uint32_t)*(1 << mask)); for (fullpc = (pc & ~maskbits); fullpc <= (pc | maskbits); fullpc++) { - rtlabel.dpc = fullpc; - is_available = !!ss7_instance_lookup_route(s7i, &rtlabel); + is_available = ss7_route_table_dpc_is_accessible(s7i->rtable_system, fullpc); if (is_available) aff_pc_avail[num_aff_pc_avail++] = htonl(fullpc); /* mask = 0 */ else -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia3b2eb17afae71dc7cec34b521693e776fa3576d Gerrit-Change-Number: 40560 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in libosmo-sigtran[master]: Move ss7_as_alloc() to correct header

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40555?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Move ss7_as_alloc() to correct header ...................................................................... Move ss7_as_alloc() to correct header Change-Id: I062ccf8d1ebd58b767652fb72cc056065749f2a5 --- M src/ss7_as.h M src/ss7_internal.h 2 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/55/40555/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I062ccf8d1ebd58b767652fb72cc056065749f2a5 Gerrit-Change-Number: 40555 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in libosmo-sigtran[master]: combined_linkset: Improve comment explaining ordering

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40552?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: combined_linkset: Improve comment explaining ordering ...................................................................... combined_linkset: Improve comment explaining ordering Change-Id: I0d148e11bf4d33ecdc5c99a5fb887a74c666eb52 --- M src/ss7_combined_linkset.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/52/40552/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0d148e11bf4d33ecdc5c99a5fb887a74c666eb52 Gerrit-Change-Number: 40552 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[M] Change in libosmo-sigtran[master]: Differentiate between dynamic and static routes

by pespin

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Differentiate between dynamic and static routes ...................................................................... Differentiate between dynamic and static routes Differentiation is important because for instance * It shall not be possible to delete dynamic routes over VTY "remove route" command. * Dynamic routes should not be stored in config, ie. not appear during "show running-config" or "write running-config". * During VTY "show cs7 instance 0 route", a "dyn" string keyword sohuld be displayed on each dynamic route row. Related: OS#6755 Change-Id: Ic6c6b46084a1e4063ebf1f5d13e0e03386bb4c45 --- M src/sccp_user.c M src/ss7_as_vty.c M src/ss7_route.c M src/ss7_route.h M src/ss7_route_table.c M src/ss7_route_table.h M src/ss7_vty.c M src/xua_as_fsm.c M src/xua_rkm.c M tests/ss7/ss7_test.c M tests/vty/osmo_stp_route_prio.vty 11 files changed, 85 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/43/40543/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic6c6b46084a1e4063ebf1f5d13e0e03386bb4c45 Gerrit-Change-Number: 40543 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in libosmo-sigtran[master]: Fix static str buf in osmo_ss7_route_print() too small

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40557?usp=email ) Change subject: Fix static str buf in osmo_ss7_route_print() too small ...................................................................... Fix static str buf in osmo_ss7_route_print() too small Related: Coverity CID#528692 Change-Id: I40c9ac38b60b01f64bec01ddd10a63759dbdec81 --- M src/ss7_route.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/57/40557/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I40c9ac38b60b01f64bec01ddd10a63759dbdec81 Gerrit-Change-Number: 40557 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

2 months

1
0
0 0

[XS] Change in libosmo-sigtran[master]: Fix static str buf in osmo_ss7_route_print() too small

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40557?usp=email ) Change subject: Fix static str buf in osmo_ss7_route_print() too small ...................................................................... Fix static str buf in osmo_ss7_route_print() too small Change-Id: I40c9ac38b60b01f64bec01ddd10a63759dbdec81 --- M src/ss7_route.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/57/40557/1 diff --git a/src/ss7_route.c b/src/ss7_route.c index c432c49..713cc6a 100644 --- a/src/ss7_route.c +++ b/src/ss7_route.c @@ -271,7 +271,7 @@ const char *osmo_ss7_route_print(const struct osmo_ss7_route *rt) { - static char buf[64]; + static char buf[MAX_PC_STR_LEN * 2 + 1]; struct osmo_strbuf sb = { .buf = buf, .len = sizeof(buf) }; char buf_pc[MAX_PC_STR_LEN]; const struct osmo_ss7_instance *inst = rt->rtable->inst; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I40c9ac38b60b01f64bec01ddd10a63759dbdec81 Gerrit-Change-Number: 40557 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2025