pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40552?usp=email )
Change subject: combined_linkset: Improve comment explaining ordering
......................................................................
combined_linkset: Improve comment explaining ordering
Change-Id: I0d148e11bf4d33ecdc5c99a5fb887a74c666eb52
---
M src/ss7_combined_linkset.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/52/40552/1
diff --git a/src/ss7_combined_linkset.c b/src/ss7_combined_linkset.c
index 6f4f506..eb19b85 100644
--- a/src/ss7_combined_linkset.c
+++ b/src/ss7_combined_linkset.c
@@ -73,7 +73,8 @@
* insert the route in the ordered list of routes. The list is sorted by
* mask length, so that the more specific (longer mask) routes are
* first, while the less specific routes with shorter masks are last.
- * Within the same mask length, the routes are ordered by priority.
+ * Within the same mask length, the routes are ordered by priority
+ * (where lower value means higher prio).
* Hence, the first matching route in a linear iteration is the most
* specific match.
*/
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40552?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I0d148e11bf4d33ecdc5c99a5fb887a74c666eb52
Gerrit-Change-Number: 40552
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40549?usp=email )
Change subject: xua_asp_fsm: Drop code branch never called in xUA ASP
......................................................................
xua_asp_fsm: Drop code branch never called in xUA ASP
ACTIVE state is only entered (xua_asp_fsm_active_onenter) from INACTIVE
state; it cannot be entered from DOWN state. Hence, went went_up would
always be false and the code never executed.
This code is indeed not used since we already make sure we start BEAT
procedure when entering INACTIVE state from DOWN state, and only disable
it when we go back to DOWN state.
Fixes: ce6b537fcc4c52a90d8072714ce41158524b3008
Change-Id: Ic0b8b4fbe31ab2e5206a4f4c7907868f20d2ef10
---
M src/xua_asp_fsm.c
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/49/40549/1
diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 26f3a78..86d86b7 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -695,12 +695,6 @@
{
struct xua_asp_fsm_priv *xafp = fi->priv;
struct osmo_ss7_asp *asp = xafp->asp;
- bool went_up = (prev_state == XUA_ASP_S_DOWN);
-
- if (went_up) {
- /* Now we are done with IPA handshake, Start Hearbeat Procedure, T(beat): */
- xua_t_beat_send(fi);
- }
dispatch_to_all_as(fi, XUA_ASPAS_ASP_ACTIVE_IND, asp);
}
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40549?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic0b8b4fbe31ab2e5206a4f4c7907868f20d2ef10
Gerrit-Change-Number: 40549
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, osmith, pespin.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: Differentiate between dynamic and static routes
......................................................................
Differentiate between dynamic and static routes
Differentiation is important because for instance
* It shall not be possible to delete dynamic routes over VTY
"remove route" command.
* Dynamic routes should not be stored in config, ie. not appear
during "show running-config" or "write running-config".
* During VTY "show cs7 instance 0 route", a "dyn" string keyword
sohuld be displayed on each dynamic route row.
Related: OS#6755
Change-Id: Ic6c6b46084a1e4063ebf1f5d13e0e03386bb4c45
---
M src/sccp_user.c
M src/ss7_as_vty.c
M src/ss7_route.c
M src/ss7_route.h
M src/ss7_route_table.c
M src/ss7_route_table.h
M src/ss7_vty.c
M src/xua_as_fsm.c
M src/xua_rkm.c
M tests/ss7/ss7_test.c
M tests/vty/osmo_stp_route_prio.vty
11 files changed, 76 insertions(+), 47 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/43/40543/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic6c6b46084a1e4063ebf1f5d13e0e03386bb4c45
Gerrit-Change-Number: 40543
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>