June 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: bsc: fix race condition in RSLEm

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40415?usp=email ) Change subject: bsc: fix race condition in RSLEm ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I012d4db05538d294a6b4aa85be4a40bb0bad28a3 Gerrit-Change-Number: 40415 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jun 2025 06:31:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: f_init(): print testcasename() in the IUT's logs

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40414?usp=email ) Change subject: bts: f_init(): print testcasename() in the IUT's logs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I16136f32d7143edfc1638e359ef5b1066c248732 Gerrit-Change-Number: 40414 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jun 2025 06:30:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: fix race condition in RSLEm

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40415?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bsc: fix race condition in RSLEm ...................................................................... bsc: fix race condition in RSLEm It may happen that the RSLEm component receives a DChan message earlier than we suspend the DChan processing. We saw this once: RSL for unknown Dchan BSC_Tests.ttcn:12769 BSC_Tests control part BSC_Tests.ttcn:5888 TC_ho_int_a5_4 testcase Let's guard against this by calling f_rslem_suspend() earlier. Change-Id: I012d4db05538d294a6b4aa85be4a40bb0bad28a3 --- M bsc/BSC_Tests.ttcn 1 file changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/40415/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I012d4db05538d294a6b4aa85be4a40bb0bad28a3 Gerrit-Change-Number: 40415 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: fix race condition in f_tc_ho_int()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40415?usp=email ) Change subject: bsc: fix race condition in f_tc_ho_int() ...................................................................... bsc: fix race condition in f_tc_ho_int() It may happen that the RSLEm component receives a Handover Command earlier than we suspend the DChan processing. We saw this once: RSL for unknown Dchan BSC_Tests.ttcn:12769 BSC_Tests control part BSC_Tests.ttcn:5888 TC_ho_int_a5_4 testcase Let's guard against this by calling f_rslem_suspend() earlier. Change-Id: I012d4db05538d294a6b4aa85be4a40bb0bad28a3 --- M bsc/BSC_Tests.ttcn 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/40415/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 1badaa5..54c9897 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -5781,10 +5781,11 @@ old_chan_nr := -, expect_target_tsc := c_BtsParams[1].tsc }; - /* issue hand-over command on VTY, from BTS 0 to BTS 1 */ - f_vty_handover(BSCVTY, 0, 0, g_chan_nr, 1); + /* temporarily suspend DChan processing on BTS1 to avoid race with RSLEM_register */ f_rslem_suspend(RSL1_PROC); + /* issue hand-over command on VTY, from BTS 0 to BTS 1 */ + f_vty_handover(BSCVTY, 0, 0, g_chan_nr, 1); /* From the MGW perspective, a handover is is characterized by * performing one MDCX operation with the MGW. So we expect to see -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I012d4db05538d294a6b4aa85be4a40bb0bad28a3 Gerrit-Change-Number: 40415 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: f_init(): print testcasename() in the IUT's logs

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40414?usp=email ) Change subject: bts: f_init(): print testcasename() in the IUT's logs ...................................................................... bts: f_init(): print testcasename() in the IUT's logs It's useful to see testcase names in the IUT's logs in some situations. For instance, when some testcase crashes the IUT. Change-Id: I16136f32d7143edfc1638e359ef5b1066c248732 Related: OS#6794 --- M bts/BTS_Tests.ttcn 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/40414/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index b49cb28..9c6f238 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -592,9 +592,11 @@ g_AllChannels := g_AllChannels & f_gen_chans_for_ts(tn, config); } + f_init_vty(id); + f_logp(BTSVTY, testcasename() & "() start"); + f_init_rsl(id); f_sleep(0.5); /* workaround for OS#3000 */ - f_init_vty(id); f_ipa_ctrl_start_client(mp_ctrl_ip, mp_ctrl_port); /* Send SI3 to the BTS, it is needed for various computations */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I16136f32d7143edfc1638e359ef5b1066c248732 Gerrit-Change-Number: 40414 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2025