June 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40548?usp=email ) Change subject: stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e158557dabdb7e94d1c00a6d67126f2d85bb4cd Gerrit-Change-Number: 40548 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 27 Jun 2025 13:33:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40548?usp=email ) Change subject: stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e158557dabdb7e94d1c00a6d67126f2d85bb4cd Gerrit-Change-Number: 40548 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Jun 2025 13:32:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[L] Change in ...osmo-s1gw[master]: enft_kpi: retrieve per-eNB traffic counters

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email ) Change subject: enft_kpi: retrieve per-eNB traffic counters ...................................................................... Patch Set 11: (1 comment) File config/sys.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/7c24a520_563c… : PS8, Line 24: %% {enft_kpi_enable, true}, %% whether to enable the NFT KPI module (default: false) > Naming is currently the least significant topic, sorry. […] Then please you or whoever takes care of this submit a follow-up patch before merging all this. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Gerrit-Change-Number: 40281 Gerrit-PatchSet: 11 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Jun 2025 13:32:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40548?usp=email ) Change subject: stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'll merge this in a few mins to avoid further regressions over the weekend. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e158557dabdb7e94d1c00a6d67126f2d85bb4cd Gerrit-Change-Number: 40548 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Jun 2025 13:31:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40548?usp=email ) Change subject: stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp ...................................................................... stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp The introduced function f_SCCP_UDT() had the calling+called param order swapped with regards to previous templates. Change the order to first have "calling" (src) and then "called" (dst) as already done in ts_SCCP_UDT. While at it, change the ts_SCCP_UDT params to accept template (value) to make it easier for callers. Fixes: b686e914b60d6e2486667fa8227576a70a86c909 Change-Id: I0e158557dabdb7e94d1c00a6d67126f2d85bb4cd --- M library/SCCP_Templates.ttcn M stp/STP_Tests_Common.ttcn M stp/STP_Tests_IPA_M3UA.ttcn 3 files changed, 11 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/48/40548/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e158557dabdb7e94d1c00a6d67126f2d85bb4cd Gerrit-Change-Number: 40548 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40548?usp=email ) Change subject: stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp ...................................................................... stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp The introduced function f_SCCP_UDT() had the calling+called param order swapped with regards to previous templates. Change the order to first have "calling" (src) and then "called" (dst) as already done in ts_SCCP_UDT. While at it, change the ts_SCCP_UDT params to accept template (value) to make it easier for callers. Change-Id: I0e158557dabdb7e94d1c00a6d67126f2d85bb4cd --- M library/SCCP_Templates.ttcn M stp/STP_Tests_Common.ttcn M stp/STP_Tests_IPA_M3UA.ttcn 3 files changed, 11 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/48/40548/1 diff --git a/library/SCCP_Templates.ttcn b/library/SCCP_Templates.ttcn index 8f84d83..6135af3 100644 --- a/library/SCCP_Templates.ttcn +++ b/library/SCCP_Templates.ttcn @@ -192,7 +192,8 @@ } } -template (value) PDU_SCCP ts_SCCP_UDT(SCCP_PAR_Address calling, SCCP_PAR_Address called, +template (value) PDU_SCCP ts_SCCP_UDT(template (value) SCCP_PAR_Address calling, + template (value) SCCP_PAR_Address called, template (value) octetstring data, template (value) BIT4 msg_hdl := '0000'B) := { unitdata := { @@ -201,8 +202,8 @@ pointer1 := 0, /* overwritten */ pointer2 := 0, /* overwritten */ pointer3 := 0, /* overwritten */ - calledPAddress := ConvertASPAddressToEncodedAddress_itu(called), - callingPAddress := ConvertASPAddressToEncodedAddress_itu(calling), + calledPAddress := ConvertASPAddressToEncodedAddress_itu(valueof(called)), + callingPAddress := ConvertASPAddressToEncodedAddress_itu(valueof(calling)), data := { paramLength := 0, data := data diff --git a/stp/STP_Tests_Common.ttcn b/stp/STP_Tests_Common.ttcn index 01e9ab6..557fa29 100644 --- a/stp/STP_Tests_Common.ttcn +++ b/stp/STP_Tests_Common.ttcn @@ -27,14 +27,14 @@ import from SCCPasp_Types all; import from SCCP_Emulation all; -function f_SCCP_UDT(template (value) SCCP_PAR_Address called := ts_SccpAddr_GT('1234'H), - template (value) SCCP_PAR_Address calling := ts_SccpAddr_GT('5678'H), +function f_SCCP_UDT(template (value) SCCP_PAR_Address calling := ts_SccpAddr_GT('5678'H), + template (value) SCCP_PAR_Address called := ts_SccpAddr_GT('1234'H), template (omit) octetstring data := omit) return octetstring { if (istemplatekind(data, "omit")) { data := f_rnd_octstring_rnd_len(100); } - var PDU_SCCP sccp := valueof(ts_SCCP_UDT(valueof(called), valueof(calling), valueof(data))); + var PDU_SCCP sccp := valueof(ts_SCCP_UDT(calling, called, valueof(data))); var octetstring sccp_enc := enc_PDU_SCCP(sccp); return sccp_enc; } diff --git a/stp/STP_Tests_IPA_M3UA.ttcn b/stp/STP_Tests_IPA_M3UA.ttcn index 1e45372..1def77f 100644 --- a/stp/STP_Tests_IPA_M3UA.ttcn +++ b/stp/STP_Tests_IPA_M3UA.ttcn @@ -154,16 +154,16 @@ f_M3UA_asp_up_act(0, omit, rctx_receiver); /* send a well-formed, encoded SCCP message via IPA */ - var octetstring data := f_rnd_octstring_rnd_len(100); - var SCCP_PAR_Address called := valueof(ts_SccpAddr_GT('1234'H)); var SCCP_PAR_Address calling := valueof(ts_SccpAddr_GT('5678'H)); - var octetstring sccp_enc := f_SCCP_UDT(called, calling, data); + var SCCP_PAR_Address called := valueof(ts_SccpAddr_GT('1234'H)); + var octetstring data := f_rnd_octstring_rnd_len(100); + var octetstring sccp_enc := f_SCCP_UDT(calling, called, data); f_IPA_send(0, sccp_enc); /* patch point codes into addresses */ called := valueof(ts_SccpAddr_PC_GT(oct2int(pc_receiver), '83'O, "mtp3_itu", '1234'H)); calling := valueof(ts_SccpAddr_PC_GT(oct2int(pc_sender), '83'O, "mtp3_itu", '5678'H)); - sccp_enc := f_SCCP_UDT(called, calling, data); + sccp_enc := f_SCCP_UDT(calling, called, data); /* expect to receive it via M3UA */ var template (present) M3UA_Protocol_Data rx_pd; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e158557dabdb7e94d1c00a6d67126f2d85bb4cd Gerrit-Change-Number: 40548 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[M] Change in libosmo-sigtran[master]: Differentiate between dynamic and static routes

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email ) Change subject: Differentiate between dynamic and static routes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/ss7_route.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543/comment/2606040b_55ecf… : PS1, Line 65: confing ```suggestion * they don't show up in eg "show running-config"; they can be listed using ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic6c6b46084a1e4063ebf1f5d13e0e03386bb4c45 Gerrit-Change-Number: 40543 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Jun 2025 13:30:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[L] Change in ...osmo-s1gw[master]: enft_kpi: retrieve per-eNB traffic counters

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email ) Change subject: enft_kpi: retrieve per-eNB traffic counters ...................................................................... Patch Set 11: (1 comment) File config/sys.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/47a01303_7523… : PS8, Line 24: %% {enft_kpi_enable, true}, %% whether to enable the NFT KPI module (default: false) > Naming stuff has not yet been addressed in version 11. Naming is currently the least significant topic, sorry. I would prefer to spend my limited cycles on more critical bits. If this is critical for the customer/sysmocom, I can work on renaming stuff in a subsequent patch. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Gerrit-Change-Number: 40281 Gerrit-PatchSet: 11 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Jun 2025 13:28:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in libosmo-sigtran[master]: as_vty: Fix 'traffic-mode loadshare' output in 'show running-config'

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40542?usp=email ) Change subject: as_vty: Fix 'traffic-mode loadshare' output in 'show running-config' ...................................................................... as_vty: Fix 'traffic-mode loadshare' output in 'show running-config' Change-Id: I09ca977885cc4af5caf58f8036285ab321d00b05 --- M src/ss7_as_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index 9c5f7e2..c7658d1 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -435,15 +435,15 @@ vty_out(vty, " asp %s%s", asp->cfg.name, VTY_NEWLINE); } if (as->cfg.mode_set_by_vty) { - vty_out(vty, " traffic-mode %s%s", osmo_ss7_as_traffic_mode_name(as->cfg.mode), VTY_NEWLINE); + vty_out(vty, " traffic-mode %s", osmo_ss7_as_traffic_mode_name(as->cfg.mode)); if (as->cfg.mode == OSMO_SS7_AS_TMOD_LOADSHARE) { if (as->cfg.loadshare.opc_sls) { vty_out(vty, " bindings sls opc-sls"); if (as->cfg.loadshare.opc_shift != 0) vty_out(vty, " opc-shift %u", as->cfg.loadshare.opc_shift); } - vty_out(vty, "%s", VTY_NEWLINE); } + vty_out(vty, "%s", VTY_NEWLINE); if (as->cfg.loadshare.sls_shift != 0) vty_out(vty, " sls-shift %u%s", as->cfg.loadshare.sls_shift, VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40542?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I09ca977885cc4af5caf58f8036285ab321d00b05 Gerrit-Change-Number: 40542 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[S] Change in libosmo-sigtran[master]: osmo_ss7_route_print(): Use osmo_ss7_pointcode_print_buf()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40541?usp=email ) Change subject: osmo_ss7_route_print(): Use osmo_ss7_pointcode_print_buf() ...................................................................... osmo_ss7_route_print(): Use osmo_ss7_pointcode_print_buf() Use the _buf() API here since it's easy and then we can make sure a user calling this function + osmo_ss7_pointcode_print() at the same time won't cause collisions writing in the same static buffer. Change-Id: I6a6104e2cc759e79afa6da57d512e6f8436bbb33 --- M src/ss7_route.c 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/ss7_route.c b/src/ss7_route.c index 7783f85..6350f71 100644 --- a/src/ss7_route.c +++ b/src/ss7_route.c @@ -263,16 +263,19 @@ const char *osmo_ss7_route_print(const struct osmo_ss7_route *rt) { + static char buf[64]; + struct osmo_strbuf sb = { .buf = buf, .len = sizeof(buf) }; + char buf_pc[MAX_PC_STR_LEN]; const struct osmo_ss7_instance *inst = rt->rtable->inst; unsigned int pc_width = osmo_ss7_pc_width(&inst->cfg.pc_fmt); - static char buf[64]; int rc = u32_masklen(rt->cfg.mask, pc_width); + OSMO_STRBUF_PRINTF(sb, "%s/", osmo_ss7_pointcode_print_buf(buf_pc, sizeof(buf_pc), inst, rt->cfg.pc)); + if (rc < 0) - snprintf(buf, sizeof(buf), "%s/%s", osmo_ss7_pointcode_print(inst, rt->cfg.pc), - osmo_ss7_pointcode_print2(inst, rt->cfg.mask)); + OSMO_STRBUF_PRINTF(sb, "%s", osmo_ss7_pointcode_print_buf(buf_pc, sizeof(buf_pc), inst, rt->cfg.mask)); else - snprintf(buf, sizeof(buf), "%s/%u", osmo_ss7_pointcode_print(inst, rt->cfg.pc), rc); + OSMO_STRBUF_PRINTF(sb, "%u", rc); return buf; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40541?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6a6104e2cc759e79afa6da57d512e6f8436bbb33 Gerrit-Change-Number: 40541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2025