January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH

by pespin

Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31112 ) Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Gerrit-Change-Number: 31112 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 15:09:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: trau_pcu_ericsson: fix broken length check

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31120 ) Change subject: trau_pcu_ericsson: fix broken length check ...................................................................... Patch Set 1: (1 comment) File src/trau/trau_pcu_ericsson.c: https://gerrit.osmocom.org/c/libosmo-abis/+/31120/comment/8883aca1_3d991ada PS1, Line 273: if (bits_len < offs) are you sure this shouldn't be bits_len <= offs? because if bits_len == offs, whtever you read will already be out of bounds. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9e0cd5d36c517b9198e0dc1bec0477a2ee2fb869 Gerrit-Change-Number: 31120 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 15:09:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: Try to work around coverity false positives in macros

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31118 ) Change subject: Try to work around coverity false positives in macros ...................................................................... Patch Set 1: (1 comment) File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31118/comment/68aac672_43eecdbe PS1, Line 498: // coverity[unsigned_compare:FALSE] > no, i did not. […] and furthermore it's not coverity specific, it serves any static analyzer. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I10e60b20c6f8092cf1ce09ebe501e739fd4a9479 Gerrit-Change-Number: 31118 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 15:07:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: Get rid of openbsc leftover references

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31116 ) Change subject: Get rid of openbsc leftover references ...................................................................... Get rid of openbsc leftover references Get rid of the global variable since it's only used once inside a function anyway. Change-Id: I0b4f536b16f3693ef16de8505036943c3a30b1df --- M src/host/layer23/src/common/main.c M src/host/layer23/src/mobile/main.c 2 files changed, 12 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/host/layer23/src/common/main.c b/src/host/layer23/src/common/main.c index 82bbc60..c456488 100644 --- a/src/host/layer23/src/common/main.c +++ b/src/host/layer23/src/common/main.c @@ -65,14 +65,6 @@ int quit = 0; struct gsmtap_inst *gsmtap_inst; -const char *openbsc_copyright = - "%s" - "%s\n" - "License GPLv2+: GNU GPL version 2 or later " - "<http://gnu.org/licenses/gpl.html>\n" - "This is free software: you are free to change and redistribute it.\n" - "There is NO WARRANTY, to the extent permitted by law.\n\n"; - static void print_usage(const char *app) { printf("Usage: %s\n", app); @@ -211,7 +203,12 @@ { struct l23_app_info *app; app = l23_app_info(); - printf(openbsc_copyright, + + printf("%s" + "%s\n" + "License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl.html>\n" + "This is free software: you are free to change and redistribute it.\n" + "There is NO WARRANTY, to the extent permitted by law.\n\n", app && app->copyright ? app->copyright : "", app && app->contribution ? app->contribution : ""); } diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c index 4627b25..8938e30 100644 --- a/src/host/layer23/src/mobile/main.c +++ b/src/host/layer23/src/mobile/main.c @@ -74,14 +74,6 @@ const char *debug_default = "DCS:DNB:DPLMN:DRR:DMM:DSIM:DCC:DMNCC:DSS:DLSMS:DPAG:DSUM:DSAP:DGPS:DMOB:DPRIM:DLUA:DGAPK"; -const char *openbsc_copyright = - "%s" - "%s\n" - "License GPLv2+: GNU GPL version 2 or later " - "<http://gnu.org/licenses/gpl.html>\n" - "This is free software: you are free to change and redistribute it.\n" - "There is NO WARRANTY, to the extent permitted by law.\n\n"; - static void print_usage(const char *app) { printf("Usage: %s\n", app); @@ -216,7 +208,12 @@ { struct l23_app_info *app; app = l23_app_info(); - printf(openbsc_copyright, + + printf("%s" + "%s\n" + "License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl.html>\n" + "This is free software: you are free to change and redistribute it.\n" + "There is NO WARRANTY, to the extent permitted by law.\n\n", app && app->copyright ? app->copyright : "", app && app->contribution ? app->contribution : ""); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0b4f536b16f3693ef16de8505036943c3a30b1df Gerrit-Change-Number: 31116 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH

by dexter

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31112 to look at the new patch set (#4). Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH ...................................................................... timeslot_fsm: Warn in case Ercisson RBS uses static PDCH The Ericsson RBS is a BTS that natively works with dynamic timeslots. This colides with the current understanding of static PDCH channels because the BTSs we support so far get thier static PDCH information on startup and then handle everything related internally. The BSC does not actively manage the channel in those cases. In the case of Ericsson we have to activate the PDCH via RSL like any other channel and the timeslot FSM has to manage it. Lets not add work arouds for this, lets just print and error message and use the BTS in the dynamic scheme as intended by the manufacturer. Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Related: OS#5198 --- M src/osmo-bsc/bts_trx.c 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/12/31112/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Gerrit-Change-Number: 31112 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH

by dexter

Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31112 ) Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/bts_trx.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31112/comment/ccc79925_5c8d9e5d PS3, Line 330: /* NOTE: A static PDCH is usually handled by the BTS/PCU internally, the BSC > I'd really move this comment inside the is_ericsson_bts() block since it's quite ericsson specific, […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Gerrit-Change-Number: 31112 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 14:55:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: coverity: Add many missing projects

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31119 ) Change subject: coverity: Add many missing projects ...................................................................... coverity: Add many missing projects Add the following projects to our coverity test job: osmo-pcap osmo-e1d osmo-e1-recorder osmo-upf osmo-isdntap osmo-uecups osmo-remsim Change-Id: Idee49aa4c15fcfb1a469db9e4978523af5608d70 --- M coverity/build_Osmocom.sh M coverity/prepare_source_Osmocom.sh M scripts/common.sh 3 files changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index 1c21046..4f5386e 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -122,3 +122,11 @@ build_osmocombb # SIMTrace host tools build_simtrace2 + +build_default osmo-pcap +build_default osmo-e1d +build_default osmo-e1-recorder +build_default osmo-upf +build_default osmo-isdntap +build_default osmo-uecups +build_default osmo-remsim diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 0ea829f..2ca7039 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -40,6 +40,13 @@ osmo-hnodeb osmo-hnbgw osmo-bsc-nat + osmo-pcap + osmo-e1d + osmo-e1-recorder + osmo-upf + osmo-isdntap + osmo-uecups + osmo-remsim " PROJECTS_DONT_BUILD_TEST=" diff --git a/scripts/common.sh b/scripts/common.sh index 23d58e7..72be4fc 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -126,6 +126,9 @@ osmo-gmr) echo "$OSMO_GIT_URL_GITEA"/satellite/"$1" ;; + osmo-isdntap) + echo "$OSMO_GIT_URL_GITEA"/retronetworking/"$1" + ;; *) echo "$OSMO_GIT_URL_GERRIT"/"$1" ;; -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idee49aa4c15fcfb1a469db9e4978523af5608d70 Gerrit-Change-Number: 31119 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: trau_pcu_ericsson: fix broken length check

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31120 ) Change subject: trau_pcu_ericsson: fix broken length check ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9e0cd5d36c517b9198e0dc1bec0477a2ee2fb869 Gerrit-Change-Number: 31120 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 14:40:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: Try to work around coverity false positives in macros

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31118 ) Change subject: Try to work around coverity false positives in macros ...................................................................... Patch Set 1: (1 comment) File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31118/comment/3d14f06a_14eae40b PS1, Line 498: // coverity[unsigned_compare:FALSE] > Did you thik about simply casting to int inside the macro? […] no, i did not. As I don't know if the pragma works as intended, I think the typecasting proposal has an even higher chance of success. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I10e60b20c6f8092cf1ce09ebe501e739fd4a9479 Gerrit-Change-Number: 31118 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 14:39:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: trau_pcu_ericsson: fix broken length check

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31120 ) Change subject: trau_pcu_ericsson: fix broken length check ...................................................................... trau_pcu_ericsson: fix broken length check The length check bits_len - offs < 0 does not work properly with unsigned variables. Lets rearange this so that it works. Change-Id: I9e0cd5d36c517b9198e0dc1bec0477a2ee2fb869 Fixes: CID#307058, CID#307057 --- M src/trau/trau_pcu_ericsson.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/20/31120/1 diff --git a/src/trau/trau_pcu_ericsson.c b/src/trau/trau_pcu_ericsson.c index 9292f23..852a3ac 100644 --- a/src/trau/trau_pcu_ericsson.c +++ b/src/trau/trau_pcu_ericsson.c @@ -270,7 +270,7 @@ * greater then the length of the bits */ if (bits_len > bits_map_len) return -EINVAL; - if (bits_len - offs < 0) + if (bits_len < offs) return -EINVAL; /* Advance to the position where the data is stored */ @@ -331,7 +331,7 @@ /* (see above) */ if (bits_len > bits_map_len) return -EINVAL; - if (bits_len - offs < 0) + if (bits_len < offs) return -EINVAL; /* Advance to the position where the data is located */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9e0cd5d36c517b9198e0dc1bec0477a2ee2fb869 Gerrit-Change-Number: 31120 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023