msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31091 )
Change subject: SI13: drop meaningless error check
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31091
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib1aeaa57ad0929fd2e1296737969d89485f0ac7b
Gerrit-Change-Number: 31091
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 26 Jan 2023 20:11:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31036 )
Change subject: Add SI10 support
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31036
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3a5da543f083f31e873c67b5ec1b5a439187d8f3
Gerrit-Change-Number: 31036
Gerrit-PatchSet: 9
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 18:44:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31080 )
Change subject: SI: add missing header
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
Gerrit-Change-Number: 31080
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 18:39:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/31080
to look at the new patch set (#2).
Change subject: SI: add missing header
......................................................................
SI: add missing header
Previous SI10 patch added function without exposing it via public header.
Let's fix this.
Fixes: 600d4eeab71665c0aec0a11a226d231f109534ca
Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
---
M include/osmocom/gsm/gsm48.h
M src/gsm/gsm48.c
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/31080/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
Gerrit-Change-Number: 31080
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria, pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31080 )
Change subject: SI: add missing header
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/01bd2acb_f0fdc14a
PS1, Line 12: Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
> Fixes: 600d4eeab71665c0aec0a11a226d231f109534ca
Done
File include/osmocom/gsm/gsm48.h:
https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/4b885ba5_421867fb
PS1, Line 38: const char *gsm48_rr_msg_type_short_name(uint8_t msgtype);
> Ack, I also find the current naming confusing. […]
It's never too late to rename smth - we have API versioning in place.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
Gerrit-Change-Number: 31080
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 17:19:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31089 )
Change subject: HO: use defined constant instead of magic number
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31089
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iabedc3a704ccc766f4490e3e621e7be83995a9c6
Gerrit-Change-Number: 31089
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 26 Jan 2023 17:07:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
cquirin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/31088 )
Change subject: Increasing max FIFO size for feature request 5875, adapting tests
......................................................................
Removed Code-Review+2 by cquirin <christoph.lauter(a)christoph-lauter.org>
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/31088
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Iae76d87cf436c80c005a2f8fce5a30f74f7e4545
Gerrit-Change-Number: 31088
Gerrit-PatchSet: 1
Gerrit-Owner: cquirin <christoph.lauter(a)christoph-lauter.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: cquirin <christoph.lauter(a)christoph-lauter.org>
Gerrit-MessageType: deleteVote
cquirin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/31073 )
Change subject: Increased the size of the FIFO/RIFO to 1600 frames (instead of 800) and changed the RIFO tests in such a manner that they do not hardcode the FIFO/RIFO size.
......................................................................
Abandoned
Newbie to the process: code not linted correctly, Change-IDs messed up
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/31073
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Iebfe10aaf5244901c6ac0f4f84ac75e7947b57b8
Gerrit-Change-Number: 31073
Gerrit-PatchSet: 1
Gerrit-Owner: cquirin <christoph.lauter(a)christoph-lauter.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: abandon
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31077 )
Change subject: modem: Initial integration of libosmo-gprs-rlcmac
......................................................................
Patch Set 4:
(1 comment)
File src/host/layer23/src/modem/llc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/0162fc54_674868e4
PS4, Line 145: osmo_static_assert
> I believe this assertion should be done in libosmo-gprs. […]
It cannot be done in the lib code because they don't depend on one another. It could be done in a unit test on top of here, but having the comment in the header of the libs is enough for now imho.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I0e628d9ddaa5ad6a205f07746d4176d1b8df7eb0
Gerrit-Change-Number: 31077
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 15:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31077 )
Change subject: modem: Initial integration of libosmo-gprs-rlcmac
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/host/layer23/src/modem/llc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/faaecc38_94ba6757
PS4, Line 145: osmo_static_assert
I believe this assertion should be done in libosmo-gprs.git instead (in the unit tests maybe), because both structs belong there? Not critical though.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I0e628d9ddaa5ad6a205f07746d4176d1b8df7eb0
Gerrit-Change-Number: 31077
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 15:28:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31066 )
Change subject: ts_51_011: Implement Extended BCD Coding
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File pySim/ts_51_011.py:
https://gerrit.osmocom.org/c/pysim/+/31066/comment/7c605ca1_69d6a9f0
PS2, Line 366: 'dialing_nr'/ExtendedBcdAdapter(BcdAdapter(Rpad(Bytes(10)))),
> yes, the ExtendedBcdAdapter is written in a way that it just translates the */# characters, and in o […]
But then it's not really a BcdAdapter, if it simply translates the */# characters? I don't want to block your work, but currently it looks cumbersome and confusing. Here is my proposal:
class ExtendedBcdAdapter(BcdAdapter):
"""convert a bytes() type to a string of BCD nibbles, replacing a/b with */# """
def _decode(self, obj, context, path):
obj = obj.lower().replace("a","*").replace("b","#")
return super()._decode(obj, context, path)
def _encode(self, obj, context, path):
obj = obj.replace("*","a").replace("#","b")
return super()._encode(obj, context, path)
With this implementation it can be used directly.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/31066
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ifcec13e9b296dba7bec34b7872192b7ce185c23c
Gerrit-Change-Number: 31066
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 15:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31086 )
Change subject: llc: Mark llc_is_user_data_frame() as static
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31086
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8e38a946c87142a09e0b49ea3160df1d5772b587
Gerrit-Change-Number: 31086
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 14:43:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin, msuraev.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31080 )
Change subject: SI: add missing header
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/755f2d7a_9aaf1ed9
PS1, Line 12: Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
Fixes: 600d4eeab71665c0aec0a11a226d231f109534ca
File include/osmocom/gsm/gsm48.h:
https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/35863964_4e970e33
PS1, Line 38: const char *gsm48_rr_msg_type_short_name(uint8_t msgtype);
> I wonder why isn't this named gsm48_rr_msg_short_name() following the existing ones.
Ack, I also find the current naming confusing. It may look like the function is returning a short name. I suggest to rename it, before it's too late. How about: gsm48_rr_short_pd_msg_name()?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
Gerrit-Change-Number: 31080
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 14:42:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 )
Change subject: hnbgw: add HNBAP port to ConnHdlr
......................................................................
Patch Set 1:
(1 comment)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085/comment/e40bd8a6_a87f…
PS1, Line 414: /* disconnect test_CT HNBAP[i], instead connect ConnHdlr.HNBAP to HNBAP[i] */
> Usually you have the test logic either in the test_CT or in the ConnHdlr. […]
because there may be tests currently spawning ConHdlr but still sending HNBAP from the test_CT, that's why I'm asking.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1e7ffded5bd9974c444dbb567b6afa643b5b2501
Gerrit-Change-Number: 31085
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 14:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 )
Change subject: hnbgw: add HNBGWVTY to ConnHdlr
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> AFAIU, to allow accessing the VTY from test logic running on ConnHdlr. […]
Yes sure, I'm just asking whether is this needed and how will it be used :)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic325fd5eb5134529012856c08336633c1413284d
Gerrit-Change-Number: 31084
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 14:37:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 )
Change subject: hnbgw: add HNBAP port to ConnHdlr
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085/comment/66df24a6_1f88…
PS1, Line 414: /* disconnect test_CT HNBAP[i], instead connect ConnHdlr.HNBAP to HNBAP[i] */
> Isn't this breaking existing tests which used test_CT HNBAP[i] ?
Usually you have the test logic either in the test_CT or in the ConnHdlr. Why would this break the test_CT ones? With this patch applied, the ConnHdlr spawned by this function gets exclusive access to one of the HNBAP ports (determined by pars.hnb_idx). Leaving an HNBAP port connected to the test_CT would require all HNBAP.send() operations to use explicit addressing...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1e7ffded5bd9974c444dbb567b6afa643b5b2501
Gerrit-Change-Number: 31085
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 14:31:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 )
Change subject: hnbgw: add HNBGWVTY to ConnHdlr
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
> Why do we need this? having one VTY instance per test isn't enough?
AFAIU, to allow accessing the VTY from test logic running on ConnHdlr.
Each ConnHdlr will have it's own TCP/VTY connection, not interfering with the others.
We have this in other testsuites too, check e.g. MSC_ConnHdlr in ttcn3-bsc-test.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic325fd5eb5134529012856c08336633c1413284d
Gerrit-Change-Number: 31084
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 14:20:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31087 )
Change subject: llc: Refactor code checking if PDU expired while dequeueing
......................................................................
llc: Refactor code checking if PDU expired while dequeueing
The previous function name was misleading since it was checking already
for more stuff than pdu containing user data.
Rename the function and move all checks on PDU in there instead of
having it half in one place and half in the other.
Change-Id: Ia0738caa1ccab5f78c2d49db582bdce96f18600a
---
M src/llc.c
1 file changed, 8 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/31087/1
diff --git a/src/llc.c b/src/llc.c
index c283146..7d39d61 100644
--- a/src/llc.c
+++ b/src/llc.c
@@ -80,9 +80,12 @@
llc->length += len;
}
-static bool llc_is_user_data_frame(const uint8_t *data, size_t len)
+static bool llc_pdu_can_be_discarded(const uint8_t *data, size_t len)
{
- if (len < 2)
+ const unsigned keep_small_thresh = 60;
+
+ /* Is the frame small, perhaps only a TCP ACK? */
+ if (len <= keep_small_thresh)
return false;
if ((data[0] & 0x0f) == 1 /* GPRS_SAPI_GMM */)
@@ -271,7 +274,6 @@
struct gprs_rlcmac_bts *bts = q->ms->bts;
struct gprs_pcu *pcu = bts->pcu;
struct timespec hyst_delta = {0, 0};
- const unsigned keep_small_thresh = 60;
enum gprs_llc_queue_prio prio;
if (pcu->vty.llc_discard_csec)
@@ -306,14 +308,9 @@
/* Hysteresis mode, try to discard LLC messages until
* the low water mark has been reached */
- /* Check whether to abort the hysteresis mode */
-
- /* Is the frame small, perhaps only a TCP ACK? */
- if (msg->len <= keep_small_thresh)
- break;
-
- /* Is it a GMM message? */
- if (!llc_is_user_data_frame(msg->data, msg->len))
+ /* Check whether to abort the hysteresis mode:
+ * Can the PDU be discarded according to its type? */
+ if (!llc_pdu_can_be_discarded(msg->data, msg->len))
break;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31087
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia0738caa1ccab5f78c2d49db582bdce96f18600a
Gerrit-Change-Number: 31087
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 )
Change subject: hnbgw: add HNBGWVTY to ConnHdlr
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Why do we need this? having one VTY instance per test isn't enough?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic325fd5eb5134529012856c08336633c1413284d
Gerrit-Change-Number: 31084
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 13:14:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment