Change in pysim[master]: gsm_r: EF_Predefined: Decode first record different from others
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31056 ) Change subject: gsm_r: EF_Predefined: Decode first record different from others ...................................................................... Patch Set 3: (2 comments) File pySim/gsm_r.py: https://gerrit.osmocom.org/c/pysim/+/31056/comment/f24ca68b_32990a70 PS2, Line 252: EF_Predefined
Done All class variables are accessible by class objects via self, as if they were set from __init__() or any other method. Accessing them via class name is possible, but might lead to errors e.g. in inherited classes redefining those class variables.
https://gerrit.osmocom.org/c/pysim/+/31056/comment/bfbe924b_b47dc53b PS2, Line 257: r = None
Done In Python (unlike C/C++), if/for/with statements do not have their own scope.
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/31056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib526f6c3c2ac9a945b8242e2e54536628376efc0 Gerrit-Change-Number: 31056 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Fri, 27 Jan 2023 22:16:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
fixeria