Attention is currently required from: laforge.
View Change
2 comments:
File pySim/gsm_r.py:
Patch Set #2, Line 252: EF_Predefined
Done
All class variables are accessible by class objects via self, as if they were set from __init__() or any other method. Accessing them via class name is possible, but might lead to errors e.g. in inherited classes redefining those class variables.
Patch Set #2, Line 257: r = None
Done
In Python (unlike C/C++), if/for/with statements do not have their own scope.
To view, visit change 31056. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib526f6c3c2ac9a945b8242e2e54536628376efc0
Gerrit-Change-Number: 31056
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Fri, 27 Jan 2023 22:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment