November 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: release-tarball-build-dist: fix permission errors

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30389 ) Change subject: release-tarball-build-dist: fix permission errors ...................................................................... release-tarball-build-dist: fix permission errors Run all commands inside the docker containers as a user with the same UID as on the host system, not as root. This is a good idea in general and also fixes permission problems when jenkins tries to wipe the workspace. Related: OS#5793 Change-Id: I0d949e5ab4b1a709d18a316def0a98c3b244457e --- M release-tarball-build-dist/Dockerfile 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved; Verified diff --git a/release-tarball-build-dist/Dockerfile b/release-tarball-build-dist/Dockerfile index 678efd4..dcfea51 100644 --- a/release-tarball-build-dist/Dockerfile +++ b/release-tarball-build-dist/Dockerfile @@ -1,6 +1,7 @@ ARG USER FROM $USER/debian-bullseye-obs-latest # Arguments used after FROM must be specified again +ARG UID RUN apt-get update && \ apt-get install -y --no-install-recommends \ @@ -71,3 +72,6 @@ xsltproc \ && \ apt-get clean + +RUN useradd --uid=${UID} -m user +USER user -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0d949e5ab4b1a709d18a316def0a98c3b244457e Gerrit-Change-Number: 30389 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: fix missing dir crash

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30388 ) Change subject: release-tarball-build-dist: fix missing dir crash ...................................................................... release-tarball-build-dist: fix missing dir crash Don't fail if no tarball was generated and therefore the _release_tarballs directory does not exist. Related: OS#5793 Change-Id: Ib7c551e5376776eb267140bc4b897d5bb1634cbc --- M release-tarball-build-dist/osmocom-release-tarballs.sh 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/release-tarball-build-dist/osmocom-release-tarballs.sh b/release-tarball-build-dist/osmocom-release-tarballs.sh index 8f3d3ac..40f8c5e 100644 --- a/release-tarball-build-dist/osmocom-release-tarballs.sh +++ b/release-tarball-build-dist/osmocom-release-tarballs.sh @@ -326,6 +326,11 @@ } upload() { + if ! [ -d _release_tarballs ]; then + echo "upload: no tarballs generated, nothing to do." + return + fi + cd _release_tarballs rsync -avz -e "$SSH_COMMAND" . releases@ftp.osmocom.org:web-files/ } -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib7c551e5376776eb267140bc4b897d5bb1634cbc Gerrit-Change-Number: 30388 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: fix permission errors

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30389 ) Change subject: release-tarball-build-dist: fix permission errors ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0d949e5ab4b1a709d18a316def0a98c3b244457e Gerrit-Change-Number: 30389 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 16:41:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: fix missing dir crash

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30388 ) Change subject: release-tarball-build-dist: fix missing dir crash ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib7c551e5376776eb267140bc4b897d5bb1634cbc Gerrit-Change-Number: 30388 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 16:41:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: move rsync into docker

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30386 ) Change subject: release-tarball-build-dist: move rsync into docker ...................................................................... release-tarball-build-dist: move rsync into docker Prepare to use ssh inside the docker container to check if tarballs already exist, see the next patch. Remove the '' around UserKnownHostsFile as using SSH_COMMAND in the next patch without rsync fails otherwise with: command-line: line 0: Bad configuration option: 'userknownhostsfile Change-Id: I6dfe5d587d05063c6cf2c9ec683e7b7e499b79c1 --- M release-tarball-build-dist/Dockerfile M release-tarball-build-dist/jenkins.sh A release-tarball-build-dist/known_hosts M release-tarball-build-dist/osmocom-release-tarballs.sh 4 files changed, 13 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/release-tarball-build-dist/Dockerfile b/release-tarball-build-dist/Dockerfile index dad9d0a..678efd4 100644 --- a/release-tarball-build-dist/Dockerfile +++ b/release-tarball-build-dist/Dockerfile @@ -67,6 +67,7 @@ make \ mscgen \ python3-nwdiag \ + rsync \ xsltproc \ && \ apt-get clean diff --git a/release-tarball-build-dist/jenkins.sh b/release-tarball-build-dist/jenkins.sh index 0177da8..d59aa15 100755 --- a/release-tarball-build-dist/jenkins.sh +++ b/release-tarball-build-dist/jenkins.sh @@ -8,21 +8,13 @@ docker run \ --rm=true \ -v "$PWD:/build" \ + -v "$(readlink -f $SSH_AUTH_SOCK)":/ssh-agent \ -w /osmo-ci \ -e KEEP_TEMP="$KEEP_TEMP" \ + -e SSH_AUTH_SOCK=/ssh-agent \ "$USER/release-tarball-build-dist" sh -e /build/osmocom-release-tarballs.sh if [ -z "$WORKSPACE" ]; then set +x echo "NOTE: not running on jenkins, skipping upload" fi - -cat > "$WORKSPACE/known_hosts" <<EOF -[ftp.osmocom.org]:48 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDDgQ9HntlpWNmh953a2Gc8NysKE4orOatVT1wQkyzhARnfYUerRuwyNr1GqMyBKdSI9amYVBXJIOUFcpV81niA7zQRUs66bpIMkE9/rHxBd81SkorEPOIS84W4vm3SZtuNqa+fADcqe88Hcb0ZdTzjKILuwi19gzrQyME2knHY71EOETe9Yow5RD2hTIpB5ecNxI0LUKDq+Ii8HfBvndPBIr0BWYDugckQ3Bocf+yn/tn2/GZieFEyFpBGF/MnLbAAfUKIdeyFRX7ufaiWWz5yKAfEhtziqdAGZaXNaLG6gkpy3EixOAy6ZXuTAk3b3Y0FUmDjhOHllbPmTOcKMry9 -[ftp.osmocom.org]:48 ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBPdWn1kEousXuKsZ+qJEZTt/NSeASxCrUfNDW3LWtH+d8Ust7ZuKp/vuyG+5pe5pwpPOgFu7TjN+0lVjYJVXH54= -[ftp.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX -EOF - -SSH_COMMAND="ssh -o 'UserKnownHostsFile=$WORKSPACE/known_hosts' -p 48" -cd _release_tarballs -rsync -avz --delete -e "$SSH_COMMAND" . releases@ftp.osmocom.org:web-files/ diff --git a/release-tarball-build-dist/known_hosts b/release-tarball-build-dist/known_hosts new file mode 100644 index 0000000..de29e93 --- /dev/null +++ b/release-tarball-build-dist/known_hosts @@ -0,0 +1,3 @@ +[ftp.osmocom.org]:48 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDDgQ9HntlpWNmh953a2Gc8NysKE4orOatVT1wQkyzhARnfYUerRuwyNr1GqMyBKdSI9amYVBXJIOUFcpV81niA7zQRUs66bpIMkE9/rHxBd81SkorEPOIS84W4vm3SZtuNqa+fADcqe88Hcb0ZdTzjKILuwi19gzrQyME2knHY71EOETe9Yow5RD2hTIpB5ecNxI0LUKDq+Ii8HfBvndPBIr0BWYDugckQ3Bocf+yn/tn2/GZieFEyFpBGF/MnLbAAfUKIdeyFRX7ufaiWWz5yKAfEhtziqdAGZaXNaLG6gkpy3EixOAy6ZXuTAk3b3Y0FUmDjhOHllbPmTOcKMry9 +[ftp.osmocom.org]:48 ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBPdWn1kEousXuKsZ+qJEZTt/NSeASxCrUfNDW3LWtH+d8Ust7ZuKp/vuyG+5pe5pwpPOgFu7TjN+0lVjYJVXH54= +[ftp.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX diff --git a/release-tarball-build-dist/osmocom-release-tarballs.sh b/release-tarball-build-dist/osmocom-release-tarballs.sh index 02b81a6..04b8350 100644 --- a/release-tarball-build-dist/osmocom-release-tarballs.sh +++ b/release-tarball-build-dist/osmocom-release-tarballs.sh @@ -6,6 +6,7 @@ # Environment variables: # * KEEP_TEMP: do not delete cloned repositories (use for development) # * PARALLEL_MAKE: -jN argument for make (default: -j5). +SSH_COMMAND="ssh -o UserKnownHostsFile=/build/known_hosts -p 48" OSMO_GIT_URL="https://git.osmocom.org" OSMO_RELEASE_REPOS=" libasn1c @@ -315,6 +316,11 @@ esac } +upload() { + cd _release_tarballs + rsync -avz --delete -e "$SSH_COMMAND" . releases@ftp.osmocom.org:web-files/ +} + remove_temp_dir mkdir -p "$TEMP/repos" echo "Temp dir: $TEMP" @@ -346,4 +352,5 @@ done remove_temp_dir +upload echo "done!" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6dfe5d587d05063c6cf2c9ec683e7b7e499b79c1 Gerrit-Change-Number: 30386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: check exists on server

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30387 ) Change subject: release-tarball-build-dist: check exists on server ...................................................................... release-tarball-build-dist: check exists on server Previously this job relied on always running on the same jenkins node, and having the previously built release tarballs in a workspace directory that does not get removed. It would only skip building a release tarball if the file already exists locally. As part of OS#5793 this job needs to be moved away from that jenkins node. When trying to run the job on a different node, it will build all release tarballs again which takes unnecessarsily long and actually fails on libosmocore-0.9.4 due to a missing python2. This probably happens because the job was refactored at some point and I didn't realize that the python2 dep is now missing as the previous tarballs existed. In general it doesn't make much sense to build previous release tarballs again and to always keep the legacy environments around for that. Change the code to check if a tarball exists on the server, and skip building the tarball in that case. Related: OS#5793 Related: https://jenkins.osmocom.org/jenkins/view/All%20no%20Gerrit/job/Osmocom-rele… Change-Id: I4b8c149c9cdbe7c613eea5d9be15794de5e5ddce --- M release-tarball-build-dist/osmocom-release-tarballs.sh 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/release-tarball-build-dist/osmocom-release-tarballs.sh b/release-tarball-build-dist/osmocom-release-tarballs.sh index 04b8350..8f3d3ac 100644 --- a/release-tarball-build-dist/osmocom-release-tarballs.sh +++ b/release-tarball-build-dist/osmocom-release-tarballs.sh @@ -191,6 +191,15 @@ fi } +get_existing_tarballs() { + if ! $SSH_COMMAND releases(a)ftp.osmocom.org -- \ + find web-files -name '*.tar.bz2' \ + > "$TEMP"/existing_tarballs; then + echo "ERROR: getting existing tarballs from remote failed!" + exit 1 + fi +} + # Clone an Osmocom repository to $TEMP/repos/$repo, clean it, checkout a tag. # $1: Osmocom repository (may end in subdir, e.g. simtrace2/host) # $2: tag (optional, default: master) @@ -318,13 +327,15 @@ upload() { cd _release_tarballs - rsync -avz --delete -e "$SSH_COMMAND" . releases@ftp.osmocom.org:web-files/ + rsync -avz -e "$SSH_COMMAND" . releases@ftp.osmocom.org:web-files/ } remove_temp_dir mkdir -p "$TEMP/repos" echo "Temp dir: $TEMP" +get_existing_tarballs + for repo in $OSMO_RELEASE_REPOS; do echo "$repo" tags="$(osmo_git_last_commits_tags "$repo" "all" | cut -d / -f 3)" @@ -342,7 +353,10 @@ echo " $tarball (ignored)" continue elif [ -e "$OUTPUT/$repo/$tarball" ]; then - echo " $tarball (exists)" + echo " $tarball (exists locally)" + continue + elif grep -q "^web-files/$repo/$tarball$" "$TEMP"/existing_tarballs; then + echo " $tarball (exists on server)" continue fi -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4b8c149c9cdbe7c613eea5d9be15794de5e5ddce Gerrit-Change-Number: 30387 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: order install pkgs

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30385 ) Change subject: release-tarball-build-dist: order install pkgs ...................................................................... release-tarball-build-dist: order install pkgs Change-Id: I059f400db20e858b379704363e32d39a7897984a --- M release-tarball-build-dist/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/release-tarball-build-dist/Dockerfile b/release-tarball-build-dist/Dockerfile index bc0215e..dad9d0a 100644 --- a/release-tarball-build-dist/Dockerfile +++ b/release-tarball-build-dist/Dockerfile @@ -31,6 +31,7 @@ libgtpnl-dev \ liblimesuite-dev \ libncurses5-dev \ + libnl-route-3-dev \ liboping-dev \ liborcania-dev \ libortp-dev \ @@ -40,7 +41,6 @@ libosmo-mgcp-client-dev \ libosmo-netif-dev \ libosmo-ranap-dev \ - libnl-route-3-dev \ libosmo-rua-dev \ libosmo-sccp-dev \ libosmo-sigtran-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I059f400db20e858b379704363e32d39a7897984a Gerrit-Change-Number: 30385 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: check exists on server

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30387 ) Change subject: release-tarball-build-dist: check exists on server ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4b8c149c9cdbe7c613eea5d9be15794de5e5ddce Gerrit-Change-Number: 30387 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 16:40:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: fix permission errors

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30389 ) Change subject: release-tarball-build-dist: fix permission errors ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0d949e5ab4b1a709d18a316def0a98c3b244457e Gerrit-Change-Number: 30389 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 16:40:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: fix missing dir crash

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30388 ) Change subject: release-tarball-build-dist: fix missing dir crash ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib7c551e5376776eb267140bc4b897d5bb1634cbc Gerrit-Change-Number: 30388 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 16:40:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: move rsync into docker

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30386 ) Change subject: release-tarball-build-dist: move rsync into docker ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6dfe5d587d05063c6cf2c9ec683e7b7e499b79c1 Gerrit-Change-Number: 30386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 16:40:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: order install pkgs

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30385 ) Change subject: release-tarball-build-dist: order install pkgs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I059f400db20e858b379704363e32d39a7897984a Gerrit-Change-Number: 30385 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 16:40:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: check exists on server

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30387 ) Change subject: release-tarball-build-dist: check exists on server ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4b8c149c9cdbe7c613eea5d9be15794de5e5ddce Gerrit-Change-Number: 30387 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 16:39:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: fix permission errors

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/30389 to look at the new patch set (#2). Change subject: release-tarball-build-dist: fix permission errors ...................................................................... release-tarball-build-dist: fix permission errors Run all commands inside the docker containers as a user with the same UID as on the host system, not as root. This is a good idea in general and also fixes permission problems when jenkins tries to wipe the workspace. Related: OS#5793 Change-Id: I0d949e5ab4b1a709d18a316def0a98c3b244457e --- M release-tarball-build-dist/Dockerfile 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/89/30389/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0d949e5ab4b1a709d18a316def0a98c3b244457e Gerrit-Change-Number: 30389 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: fix missing dir crash

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/30388 to look at the new patch set (#2). Change subject: release-tarball-build-dist: fix missing dir crash ...................................................................... release-tarball-build-dist: fix missing dir crash Don't fail if no tarball was generated and therefore the _release_tarballs directory does not exist. Related: OS#5793 Change-Id: Ib7c551e5376776eb267140bc4b897d5bb1634cbc --- M release-tarball-build-dist/osmocom-release-tarballs.sh 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/88/30388/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib7c551e5376776eb267140bc4b897d5bb1634cbc Gerrit-Change-Number: 30388 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: order install pkgs

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30385 ) Change subject: release-tarball-build-dist: order install pkgs ...................................................................... release-tarball-build-dist: order install pkgs Change-Id: I059f400db20e858b379704363e32d39a7897984a --- M release-tarball-build-dist/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/85/30385/1 diff --git a/release-tarball-build-dist/Dockerfile b/release-tarball-build-dist/Dockerfile index bc0215e..dad9d0a 100644 --- a/release-tarball-build-dist/Dockerfile +++ b/release-tarball-build-dist/Dockerfile @@ -31,6 +31,7 @@ libgtpnl-dev \ liblimesuite-dev \ libncurses5-dev \ + libnl-route-3-dev \ liboping-dev \ liborcania-dev \ libortp-dev \ @@ -40,7 +41,6 @@ libosmo-mgcp-client-dev \ libosmo-netif-dev \ libosmo-ranap-dev \ - libnl-route-3-dev \ libosmo-rua-dev \ libosmo-sccp-dev \ libosmo-sigtran-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I059f400db20e858b379704363e32d39a7897984a Gerrit-Change-Number: 30385 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: move rsync into docker

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30386 ) Change subject: release-tarball-build-dist: move rsync into docker ...................................................................... release-tarball-build-dist: move rsync into docker Prepare to use ssh inside the docker container to check if tarballs already exist, see the next patch. Remove the '' around UserKnownHostsFile as using SSH_COMMAND in the next patch without rsync fails otherwise with: command-line: line 0: Bad configuration option: 'userknownhostsfile Change-Id: I6dfe5d587d05063c6cf2c9ec683e7b7e499b79c1 --- M release-tarball-build-dist/Dockerfile M release-tarball-build-dist/jenkins.sh A release-tarball-build-dist/known_hosts M release-tarball-build-dist/osmocom-release-tarballs.sh 4 files changed, 13 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/86/30386/1 diff --git a/release-tarball-build-dist/Dockerfile b/release-tarball-build-dist/Dockerfile index dad9d0a..678efd4 100644 --- a/release-tarball-build-dist/Dockerfile +++ b/release-tarball-build-dist/Dockerfile @@ -67,6 +67,7 @@ make \ mscgen \ python3-nwdiag \ + rsync \ xsltproc \ && \ apt-get clean diff --git a/release-tarball-build-dist/jenkins.sh b/release-tarball-build-dist/jenkins.sh index 0177da8..d59aa15 100755 --- a/release-tarball-build-dist/jenkins.sh +++ b/release-tarball-build-dist/jenkins.sh @@ -8,21 +8,13 @@ docker run \ --rm=true \ -v "$PWD:/build" \ + -v "$(readlink -f $SSH_AUTH_SOCK)":/ssh-agent \ -w /osmo-ci \ -e KEEP_TEMP="$KEEP_TEMP" \ + -e SSH_AUTH_SOCK=/ssh-agent \ "$USER/release-tarball-build-dist" sh -e /build/osmocom-release-tarballs.sh if [ -z "$WORKSPACE" ]; then set +x echo "NOTE: not running on jenkins, skipping upload" fi - -cat > "$WORKSPACE/known_hosts" <<EOF -[ftp.osmocom.org]:48 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDDgQ9HntlpWNmh953a2Gc8NysKE4orOatVT1wQkyzhARnfYUerRuwyNr1GqMyBKdSI9amYVBXJIOUFcpV81niA7zQRUs66bpIMkE9/rHxBd81SkorEPOIS84W4vm3SZtuNqa+fADcqe88Hcb0ZdTzjKILuwi19gzrQyME2knHY71EOETe9Yow5RD2hTIpB5ecNxI0LUKDq+Ii8HfBvndPBIr0BWYDugckQ3Bocf+yn/tn2/GZieFEyFpBGF/MnLbAAfUKIdeyFRX7ufaiWWz5yKAfEhtziqdAGZaXNaLG6gkpy3EixOAy6ZXuTAk3b3Y0FUmDjhOHllbPmTOcKMry9 -[ftp.osmocom.org]:48 ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBPdWn1kEousXuKsZ+qJEZTt/NSeASxCrUfNDW3LWtH+d8Ust7ZuKp/vuyG+5pe5pwpPOgFu7TjN+0lVjYJVXH54= -[ftp.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX -EOF - -SSH_COMMAND="ssh -o 'UserKnownHostsFile=$WORKSPACE/known_hosts' -p 48" -cd _release_tarballs -rsync -avz --delete -e "$SSH_COMMAND" . releases@ftp.osmocom.org:web-files/ diff --git a/release-tarball-build-dist/known_hosts b/release-tarball-build-dist/known_hosts new file mode 100644 index 0000000..de29e93 --- /dev/null +++ b/release-tarball-build-dist/known_hosts @@ -0,0 +1,3 @@ +[ftp.osmocom.org]:48 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDDgQ9HntlpWNmh953a2Gc8NysKE4orOatVT1wQkyzhARnfYUerRuwyNr1GqMyBKdSI9amYVBXJIOUFcpV81niA7zQRUs66bpIMkE9/rHxBd81SkorEPOIS84W4vm3SZtuNqa+fADcqe88Hcb0ZdTzjKILuwi19gzrQyME2knHY71EOETe9Yow5RD2hTIpB5ecNxI0LUKDq+Ii8HfBvndPBIr0BWYDugckQ3Bocf+yn/tn2/GZieFEyFpBGF/MnLbAAfUKIdeyFRX7ufaiWWz5yKAfEhtziqdAGZaXNaLG6gkpy3EixOAy6ZXuTAk3b3Y0FUmDjhOHllbPmTOcKMry9 +[ftp.osmocom.org]:48 ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBPdWn1kEousXuKsZ+qJEZTt/NSeASxCrUfNDW3LWtH+d8Ust7ZuKp/vuyG+5pe5pwpPOgFu7TjN+0lVjYJVXH54= +[ftp.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX diff --git a/release-tarball-build-dist/osmocom-release-tarballs.sh b/release-tarball-build-dist/osmocom-release-tarballs.sh index 02b81a6..04b8350 100644 --- a/release-tarball-build-dist/osmocom-release-tarballs.sh +++ b/release-tarball-build-dist/osmocom-release-tarballs.sh @@ -6,6 +6,7 @@ # Environment variables: # * KEEP_TEMP: do not delete cloned repositories (use for development) # * PARALLEL_MAKE: -jN argument for make (default: -j5). +SSH_COMMAND="ssh -o UserKnownHostsFile=/build/known_hosts -p 48" OSMO_GIT_URL="https://git.osmocom.org" OSMO_RELEASE_REPOS=" libasn1c @@ -315,6 +316,11 @@ esac } +upload() { + cd _release_tarballs + rsync -avz --delete -e "$SSH_COMMAND" . releases@ftp.osmocom.org:web-files/ +} + remove_temp_dir mkdir -p "$TEMP/repos" echo "Temp dir: $TEMP" @@ -346,4 +352,5 @@ done remove_temp_dir +upload echo "done!" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6dfe5d587d05063c6cf2c9ec683e7b7e499b79c1 Gerrit-Change-Number: 30386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: check exists on server

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30387 ) Change subject: release-tarball-build-dist: check exists on server ...................................................................... release-tarball-build-dist: check exists on server Previously this job relied on always running on the same jenkins node, and having the previously built release tarballs in a workspace directory that does not get removed. It would only skip building a release tarball if the file already exists locally. As part of OS#5793 this job needs to be moved away from that jenkins node. When trying to run the job on a different node, it will build all release tarballs again which takes unnecessarsily long and actually fails on libosmocore-0.9.4 due to a missing python2. This probably happens because the job was refactored at some point and I didn't realize that the python2 dep is now missing as the previous tarballs existed. In general it doesn't make much sense to build previous release tarballs again and to always keep the legacy environments around for that. Change the code to check if a tarball exists on the server, and skip building the tarball in that case. Related: OS#5793 Related: https://jenkins.osmocom.org/jenkins/view/All%20no%20Gerrit/job/Osmocom-rele… Change-Id: I4b8c149c9cdbe7c613eea5d9be15794de5e5ddce --- M release-tarball-build-dist/osmocom-release-tarballs.sh 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/87/30387/1 diff --git a/release-tarball-build-dist/osmocom-release-tarballs.sh b/release-tarball-build-dist/osmocom-release-tarballs.sh index 04b8350..8f3d3ac 100644 --- a/release-tarball-build-dist/osmocom-release-tarballs.sh +++ b/release-tarball-build-dist/osmocom-release-tarballs.sh @@ -191,6 +191,15 @@ fi } +get_existing_tarballs() { + if ! $SSH_COMMAND releases(a)ftp.osmocom.org -- \ + find web-files -name '*.tar.bz2' \ + > "$TEMP"/existing_tarballs; then + echo "ERROR: getting existing tarballs from remote failed!" + exit 1 + fi +} + # Clone an Osmocom repository to $TEMP/repos/$repo, clean it, checkout a tag. # $1: Osmocom repository (may end in subdir, e.g. simtrace2/host) # $2: tag (optional, default: master) @@ -318,13 +327,15 @@ upload() { cd _release_tarballs - rsync -avz --delete -e "$SSH_COMMAND" . releases@ftp.osmocom.org:web-files/ + rsync -avz -e "$SSH_COMMAND" . releases@ftp.osmocom.org:web-files/ } remove_temp_dir mkdir -p "$TEMP/repos" echo "Temp dir: $TEMP" +get_existing_tarballs + for repo in $OSMO_RELEASE_REPOS; do echo "$repo" tags="$(osmo_git_last_commits_tags "$repo" "all" | cut -d / -f 3)" @@ -342,7 +353,10 @@ echo " $tarball (ignored)" continue elif [ -e "$OUTPUT/$repo/$tarball" ]; then - echo " $tarball (exists)" + echo " $tarball (exists locally)" + continue + elif grep -q "^web-files/$repo/$tarball$" "$TEMP"/existing_tarballs; then + echo " $tarball (exists on server)" continue fi -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4b8c149c9cdbe7c613eea5d9be15794de5e5ddce Gerrit-Change-Number: 30387 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarballs-build-dist: fix missing dir crash

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30388 ) Change subject: release-tarballs-build-dist: fix missing dir crash ...................................................................... release-tarballs-build-dist: fix missing dir crash Don't fail if no tarball was generated and therefore the _release_tarballs directory does not exist. Related: OS#5793 Change-Id: Ib7c551e5376776eb267140bc4b897d5bb1634cbc --- M release-tarball-build-dist/osmocom-release-tarballs.sh 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/88/30388/1 diff --git a/release-tarball-build-dist/osmocom-release-tarballs.sh b/release-tarball-build-dist/osmocom-release-tarballs.sh index 8f3d3ac..40f8c5e 100644 --- a/release-tarball-build-dist/osmocom-release-tarballs.sh +++ b/release-tarball-build-dist/osmocom-release-tarballs.sh @@ -326,6 +326,11 @@ } upload() { + if ! [ -d _release_tarballs ]; then + echo "upload: no tarballs generated, nothing to do." + return + fi + cd _release_tarballs rsync -avz -e "$SSH_COMMAND" . releases@ftp.osmocom.org:web-files/ } -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib7c551e5376776eb267140bc4b897d5bb1634cbc Gerrit-Change-Number: 30388 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: release-tarball-build-dist: fix permission errors

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30389 ) Change subject: release-tarball-build-dist: fix permission errors ...................................................................... release-tarball-build-dist: fix permission errors Run all commands inside the docker containers as a user with the same UID as on the host system, not as root. This is a good idea in general and also fixes permission problems when jenkins tries to wipe the workspace. Related: OS#5793 Change-Id: I0d949e5ab4b1a709d18a316def0a98c3b244457e --- M release-tarball-build-dist/Dockerfile 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/89/30389/1 diff --git a/release-tarball-build-dist/Dockerfile b/release-tarball-build-dist/Dockerfile index 678efd4..dcfea51 100644 --- a/release-tarball-build-dist/Dockerfile +++ b/release-tarball-build-dist/Dockerfile @@ -1,6 +1,7 @@ ARG USER FROM $USER/debian-bullseye-obs-latest # Arguments used after FROM must be specified again +ARG UID RUN apt-get update && \ apt-get install -y --no-install-recommends \ @@ -71,3 +72,6 @@ xsltproc \ && \ apt-get clean + +RUN useradd --uid=${UID} -m user +USER user -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0d949e5ab4b1a709d18a316def0a98c3b244457e Gerrit-Change-Number: 30389 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in dahdi-linux[master]: kernel 6.1 API change: netif_napi_add() uses weight==64 by default

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/30384 ) Change subject: kernel 6.1 API change: netif_napi_add() uses weight==64 by default ...................................................................... kernel 6.1 API change: netif_napi_add() uses weight==64 by default Change-Id: I7e70659e43c930a4c220eaef29cfb4e8d7a6eb0d --- M drivers/dahdi/voicebus/voicebus_net.c M drivers/dahdi/wctc4xxp/base.c 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/84/30384/1 diff --git a/drivers/dahdi/voicebus/voicebus_net.c b/drivers/dahdi/voicebus/voicebus_net.c index c17627c..c621b89 100644 --- a/drivers/dahdi/voicebus/voicebus_net.c +++ b/drivers/dahdi/voicebus/voicebus_net.c @@ -202,7 +202,12 @@ netdev->promiscuity = 0; netdev->flags |= IFF_NOARP; +#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 1, 0) + /* 64 is NAPI_POLL_WEIGHT, i.e. the default */ + netif_napi_add(netdev, &vb->napi, vb_net_poll); +#else netif_napi_add(netdev, &vb->napi, vb_net_poll, 64); +#endif skb_queue_head_init(&vb->captured_packets); res = register_netdev(netdev); diff --git a/drivers/dahdi/wctc4xxp/base.c b/drivers/dahdi/wctc4xxp/base.c index 223bbbd..90c4efc 100644 --- a/drivers/dahdi/wctc4xxp/base.c +++ b/drivers/dahdi/wctc4xxp/base.c @@ -656,7 +656,12 @@ netdev->promiscuity = 0; netdev->flags |= IFF_NOARP; +#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 1, 0) + /* 64 is NAPI_POLL_WEIGHT, i.e. the default */ + netif_napi_add(netdev, &wc->napi, &wctc4xxp_poll); +#else netif_napi_add(netdev, &wc->napi, &wctc4xxp_poll, 64); +#endif res = register_netdev(netdev); if (res) { -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/30384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I7e70659e43c930a4c220eaef29cfb4e8d7a6eb0d Gerrit-Change-Number: 30384 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: ttcn3-docker-run.sh: Use interface "up" flag, not operstate

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30383 ) Change subject: ttcn3-docker-run.sh: Use interface "up" flag, not operstate ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib5c3bbe470ce874217437c2518df5ae07f0d8301 Gerrit-Change-Number: 30383 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 15:09:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in libosmo-abis[master]: trau_sync: Add the V.110 sync pattern

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30375 ) Change subject: trau_sync: Add the V.110 sync pattern ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File include/osmocom/trau/trau_sync.h: https://gerrit.osmocom.org/c/libosmo-abis/+/30375/comment/6d9fe58c_76161e62 PS2, Line 5: enum osmo_tray_sync_pat_id { did you see this typo here? "tray". Do you mind submitting an extra patch for it? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3aab5c3f494f6ea2b11f3cf69fb09bc77ea941d8 Gerrit-Change-Number: 30375 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: integrate GAPK based audio (voice) I/O support

by pespin

Attention is currently required from: Hoernchen, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30337 ) Change subject: mobile: integrate GAPK based audio (voice) I/O support ...................................................................... Patch Set 6: (4 comments) File src/host/layer23/src/mobile/gapk_io.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/820c166b_77d5fcf1 PS6, Line 52: tch > we have msgb_dequeue_count() fro this. Ack https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/cede15b7_71f3dbd8 PS6, Line 90: ms > we have msgb_enqueue_count() for this. Ack https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/d4a44fe7_a3be7235 PS6, Line 525: ms > msgb_enqueue_count() Ack https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/4e5e71c9_845269e8 PS6, Line 561: tch > we have msgb_dequeue_count() for this. Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:51:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after...

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 ) Change subject: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after X2002 ...................................................................... Patch Set 2: (1 comment) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371/comment/cfc5a006_3491… PS2, Line 1094: for (i := 0; i < 10; i := i + 1) { : f_rx_rlcmac_dl_block(dl_block, fn); : : if (not match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL)) { : /* Received first data, starting processing: */ : break; : } : } > there seems to be a lot of copy+paste of this with the other 2 patches in this series. […] I thought about it, but decided to do it this way to avoid encapsulating more stuff, since in the end the last dl_block needs to be used by follow-up code. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If7121473a3580b40d3a658dc38b9bb1421196127 Gerrit-Change-Number: 30371 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:50:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in libosmocore[master]: WIP: create libosmoisdn sub-library

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30376 ) Change subject: WIP: create libosmoisdn sub-library ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: this is marked as Active but commit message states "WIP". -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 Gerrit-Change-Number: 30376 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:47:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): fix sprintf() formatting

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30378 ) Change subject: mobile: timeout_rr_meas(): fix sprintf() formatting ...................................................................... mobile: timeout_rr_meas(): fix sprintf() formatting Change-Id: Ia8a101005d027fb5d0ddc2566f92ab2060f21c36 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index b42ab3a..8e3b61b 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -655,9 +655,9 @@ gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); if (rr->state == GSM48_RR_ST_DEDICATED) { sprintf(text + strlen(text), " TA=%d pwr=%d", - rr->cd_now.ind_ta - set->alter_delay, - (set->alter_tx_power) ? set->alter_tx_power_value - : rr->cd_now.ind_tx_power); + rr->cd_now.ind_ta - set->alter_delay, + (set->alter_tx_power) ? set->alter_tx_power_value + : rr->cd_now.ind_tx_power); if (rsl_dec_chan_nr(rr->cd_now.chan_nr, &ch_type, &ch_subch, &ch_ts) == 0) { sprintf(text + strlen(text), " TS=%d", ch_ts); if (ch_type == RSL_CHAN_SDCCH8_ACCH -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia8a101005d027fb5d0ddc2566f92ab2060f21c36 Gerrit-Change-Number: 30378 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): use osmo_strbuf API

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30379 ) Change subject: mobile: timeout_rr_meas(): use osmo_strbuf API ...................................................................... mobile: timeout_rr_meas(): use osmo_strbuf API Change-Id: I0c505b753bcfb06d9f2f085d56d7d56fb1c44d50 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 16 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 8e3b61b..08242ee 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -636,34 +636,37 @@ struct gsm_settings *set = &rr->ms->settings; int rxlev, berr, snr; uint8_t ch_type, ch_subch, ch_ts; + struct osmo_strbuf sb; char text[256]; + sb = (struct osmo_strbuf) { .buf = text, .len = sizeof(text) }; + /* don't monitor if no cell is selected or if we scan neighbour cells */ if (!cs->selected || cs->neighbour) { - sprintf(text, "MON: not camping on serving cell"); + OSMO_STRBUF_PRINTF(sb, "MON: not camping on serving cell"); goto restart; } else if (!meas->frames) { - sprintf(text, "MON: no cell info"); + OSMO_STRBUF_PRINTF(sb, "MON: no cell info"); } else { rxlev = (meas->rxlev + meas->frames / 2) / meas->frames; berr = (meas->berr + meas->frames / 2) / meas->frames; snr = (meas->snr + meas->frames / 2) / meas->frames; - sprintf(text, "MON: f=%d lev=%s snr=%2d ber=%3d " - "LAI=%s %s %04x ID=%04x", cs->sel_arfcn, - gsm_print_rxlev(rxlev), snr, berr, - gsm_print_mcc(cs->sel_mcc), - gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); + OSMO_STRBUF_PRINTF(sb, "MON: f=%d lev=%s snr=%2d ber=%3d " + "LAI=%s %s %04x ID=%04x", cs->sel_arfcn, + gsm_print_rxlev(rxlev), snr, berr, + gsm_print_mcc(cs->sel_mcc), + gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); if (rr->state == GSM48_RR_ST_DEDICATED) { - sprintf(text + strlen(text), " TA=%d pwr=%d", - rr->cd_now.ind_ta - set->alter_delay, - (set->alter_tx_power) ? set->alter_tx_power_value - : rr->cd_now.ind_tx_power); + OSMO_STRBUF_PRINTF(sb, " TA=%d pwr=%d", + rr->cd_now.ind_ta - set->alter_delay, + (set->alter_tx_power) ? set->alter_tx_power_value + : rr->cd_now.ind_tx_power); if (rsl_dec_chan_nr(rr->cd_now.chan_nr, &ch_type, &ch_subch, &ch_ts) == 0) { - sprintf(text + strlen(text), " TS=%d", ch_ts); + OSMO_STRBUF_PRINTF(sb, " TS=%d", ch_ts); if (ch_type == RSL_CHAN_SDCCH8_ACCH || ch_type == RSL_CHAN_SDCCH4_ACCH || ch_type == RSL_CHAN_Lm_ACCHs) - sprintf(text + strlen(text), "/%d", ch_subch); + OSMO_STRBUF_PRINTF(sb, "/%d", ch_subch); } } else gsm322_meas(rr->ms, rxlev); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0c505b753bcfb06d9f2f085d56d7d56fb1c44d50 Gerrit-Change-Number: 30379 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): fix uninitialized variable

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30377 ) Change subject: mobile: timeout_rr_meas(): fix uninitialized variable ...................................................................... mobile: timeout_rr_meas(): fix uninitialized variable Change-Id: I956a1cafe9fed1a881574f59d0532e5cf931a1f7 Fixes: c9e579cea137fd147173434b7fa128d37685011 Fixes: CID#300084 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 41aa7b8..b42ab3a 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -654,11 +654,12 @@ gsm_print_mcc(cs->sel_mcc), gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); if (rr->state == GSM48_RR_ST_DEDICATED) { - sprintf(text + strlen(text), " TA=%d pwr=%d TS=%d", + sprintf(text + strlen(text), " TA=%d pwr=%d", rr->cd_now.ind_ta - set->alter_delay, (set->alter_tx_power) ? set->alter_tx_power_value - : rr->cd_now.ind_tx_power, ch_ts); + : rr->cd_now.ind_tx_power); if (rsl_dec_chan_nr(rr->cd_now.chan_nr, &ch_type, &ch_subch, &ch_ts) == 0) { + sprintf(text + strlen(text), " TS=%d", ch_ts); if (ch_type == RSL_CHAN_SDCCH8_ACCH || ch_type == RSL_CHAN_SDCCH4_ACCH || ch_type == RSL_CHAN_Lm_ACCHs) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I956a1cafe9fed1a881574f59d0532e5cf931a1f7 Gerrit-Change-Number: 30377 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): use osmo_strbuf API

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30379 ) Change subject: mobile: timeout_rr_meas(): use osmo_strbuf API ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0c505b753bcfb06d9f2f085d56d7d56fb1c44d50 Gerrit-Change-Number: 30379 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:45:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): fix uninitialized variable

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30377 ) Change subject: mobile: timeout_rr_meas(): fix uninitialized variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I956a1cafe9fed1a881574f59d0532e5cf931a1f7 Gerrit-Change-Number: 30377 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:45:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: ttcn3-docker-run.sh: Use interface "up" flag, not operstate

by fixeria

Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30383 ) Change subject: ttcn3-docker-run.sh: Use interface "up" flag, not operstate ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib5c3bbe470ce874217437c2518df5ae07f0d8301 Gerrit-Change-Number: 30383 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:44:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in libosmo-abis[master]: trau_sync: Add the V.110 sync pattern

by laforge

Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/30375 to look at the new patch set (#2). Change subject: trau_sync: Add the V.110 sync pattern ...................................................................... trau_sync: Add the V.110 sync pattern ITU-T V.110 is used in GSM CSD (Circuit Switched Data). The frames are rather similar to TRAU frames, so we can use the trau_sync code for it. This commit adds the related definition. Related: OS#4395 Change-Id: I3aab5c3f494f6ea2b11f3cf69fb09bc77ea941d8 --- M include/osmocom/trau/trau_sync.h M src/trau/trau_sync.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/75/30375/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3aab5c3f494f6ea2b11f3cf69fb09bc77ea941d8 Gerrit-Change-Number: 30375 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: ttcn3-docker-run.sh: Use interface "up" flag, not operstate

by daniel

Attention is currently required from: osmith, laforge. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30383 ) Change subject: ttcn3-docker-run.sh: Use interface "up" flag, not operstate ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib5c3bbe470ce874217437c2518df5ae07f0d8301 Gerrit-Change-Number: 30383 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:35:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: integrate GAPK based audio (voice) I/O support

by laforge

Attention is currently required from: Hoernchen, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30337 ) Change subject: mobile: integrate GAPK based audio (voice) I/O support ...................................................................... Patch Set 6: (4 comments) File src/host/layer23/src/mobile/gapk_io.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/2df3a128_6d8e08c7 PS6, Line 52: tch we have msgb_dequeue_count() fro this. https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/cb18daeb_a319501c PS6, Line 90: ms we have msgb_enqueue_count() for this. https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/8667c056_372d47bf PS6, Line 525: ms msgb_enqueue_count() https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/fa8c8238_511bfd55 PS6, Line 561: tch we have msgb_dequeue_count() for this. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:30:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: contrib/jenkins.sh: build libosmogapk for mobile app

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30366 ) Change subject: contrib/jenkins.sh: build libosmogapk for mobile app ...................................................................... Abandoned Squashed into Ib86b0746606c191573cc773f01172afbb52f33a9. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I63186c338612039a46459b04ffc7060d97e78279 Gerrit-Change-Number: 30366 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: integrate GAPK based audio (voice) I/O support

by fixeria

Attention is currently required from: Hoernchen, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30337 ) Change subject: mobile: integrate GAPK based audio (voice) I/O support ...................................................................... Patch Set 5: (3 comments) Patchset: PS5: > The question is what "suffices" vs the effort. […] Done File src/host/layer23/src/mobile/gapk_io.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/2b11fcb0_e1488491 PS5, Line 512: /* Serves both TCH frame I/O buffers */ > both TCH you mean TCH/H and TCH/F here? I mean both Uplink and Downlink. Clarified in the new patchset. https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/31dfc44c_79dfaa69 PS5, Line 528: ll > using llist_count() would probably be more easy to read/understand rather than open-coding it by han […] Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:58:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: integrate GAPK based audio (voice) I/O support

by fixeria

Attention is currently required from: Hoernchen, fixeria. Hello Jenkins Builder, Hoernchen, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337 to look at the new patch set (#6). Change subject: mobile: integrate GAPK based audio (voice) I/O support ...................................................................... mobile: integrate GAPK based audio (voice) I/O support This change introduces a new feature to the mobile application - audio I/O support, which allows the user to speak right from the host side running mobile through its ordinary mic and speakers. The audio I/O is based on libosmogapk [1][2], which in its turn uses the ALSA sound system for the playback and capture. This is a new optional dependency of mobile, which is automatically picked up if available during the build configuration. Whether to depend on it or not can be controlled using '--with-gapk-io'. The API offered by libosmogapk implies to use the processing chains, which generally consist of a source block, several processing blocks, and a sink block. The mobile app implements the following chains: - 'pq_audio_source' (voice capture -> frame encoding), - 'pq_audio_sink' (frame decoding -> voice playback). both taking/storing TCH frames from/to the following two buffers: - 'tch_fb_ul' - a buffer for to be played DL TCH frames, - 'tch_fb_dl' - a buffer for encoded UL TCH frames. The buffers are served by a new function gapk_io_dequeue(). [1] https://gitea.osmocom.org/osmocom/gapk/ [1] https://osmocom.org/projects/gapk Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 Related: OS#5599 --- M contrib/jenkins.sh M doc/examples/mobile/default.cfg M doc/examples/mobile/multi_ms.cfg M src/host/layer23/configure.ac M src/host/layer23/include/osmocom/bb/common/logging.h M src/host/layer23/include/osmocom/bb/common/osmocom_data.h M src/host/layer23/include/osmocom/bb/mobile/Makefile.am A src/host/layer23/include/osmocom/bb/mobile/gapk_io.h M src/host/layer23/include/osmocom/bb/mobile/settings.h M src/host/layer23/src/common/logging.c M src/host/layer23/src/mobile/Makefile.am M src/host/layer23/src/mobile/app_mobile.c A src/host/layer23/src/mobile/gapk_io.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/main.c M src/host/layer23/src/mobile/settings.c M src/host/layer23/src/mobile/voice.c M src/host/layer23/src/mobile/vty_interface.c 18 files changed, 771 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/37/30337/6 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 ) Change subject: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after X2002 ...................................................................... Patch Set 2: (1 comment) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371/comment/3f9f26cb_fce8… PS2, Line 1094: for (i := 0; i < 10; i := i + 1) { : f_rx_rlcmac_dl_block(dl_block, fn); : : if (not match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL)) { : /* Received first data, starting processing: */ : break; : } : } there seems to be a lot of copy+paste of this with the other 2 patches in this series. Wouldn't it make sense to have a function that does this? something like f_wait_for_rlcmac_dl_block_skip_dummy() or the like? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If7121473a3580b40d3a658dc38b9bb1421196127 Gerrit-Change-Number: 30371 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:54:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: TC_paging_cs_from_sgsn_*: Fix race condition between BSSGP tx an...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30374 ) Change subject: pcu: TC_paging_cs_from_sgsn_*: Fix race condition between BSSGP tx and RLCMAC rx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I30da93835c7738aefcd84691d83f39759dd4b599 Gerrit-Change-Number: 30374 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:52:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: TC_mt_ping_pong*: Fix race condition waiting for first DL data a...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30373 ) Change subject: pcu: TC_mt_ping_pong*: Fix race condition waiting for first DL data after X2002 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icc94eb0544226facddcd65be65a8a41bcfc662cc Gerrit-Change-Number: 30373 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:52:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: TC_dl_flow_more_blocks: Fix race condition waiting for first DL ...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30372 ) Change subject: pcu: TC_dl_flow_more_blocks: Fix race condition waiting for first DL data after X2002 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I67483bc423567d1fc98eb912ece1cf5cda746119 Gerrit-Change-Number: 30372 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:51:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 ) Change subject: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after X2002 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If7121473a3580b40d3a658dc38b9bb1421196127 Gerrit-Change-Number: 30371 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:24:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci: order nodes alphabetically

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30368 ) Change subject: jobs/update-osmo-ci: order nodes alphabetically ...................................................................... jobs/update-osmo-ci: order nodes alphabetically Make it easier to compare the list with: https://jenkins.osmocom.org/jenkins/computer/ Change-Id: I6e132c5768bf09271ffcfe8eec8311ff5d7e28df --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index a23c44d..6f41da1 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -6,18 +6,18 @@ type: slave name: label values: - - simtester - - host2-deb11build-ansible - build2-deb9build-ansible - build2-deb10build-ansible - build3-deb11build-ansible + - gtp0-deb9build + - gtp0-deb10fr + - host2-deb11build-ansible + - osmo-gsm-tester-prod + - osmo-gsm-tester-rnd - rpi4-raspbian11build-ansible-1 - rpi4-raspbian11build-ansible-2 - rpi4-raspbian11build-ansible-3 - - gtp0-deb9build - - gtp0-deb10fr - - osmo-gsm-tester-prod - - osmo-gsm-tester-rnd + - simtester properties: - build-discarder: days-to-keep: 30 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6e132c5768bf09271ffcfe8eec8311ff5d7e28df Gerrit-Change-Number: 30368 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: use binaries ssh credentials

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30380 ) Change subject: jobs/master-builds: use binaries ssh credentials ...................................................................... jobs/master-builds: use binaries ssh credentials Allow overriding the ssh agent credentials per repository, and use binaries_ftp.osmocom.org where needed. Use docs_ftp.osmocom.org instead of 97634b9d-a867-4f6d-825d-1da99813e93d so it's clear what the key is for. I generated a new one with the new ID. Fixes: OS#5798 Change-Id: I821968e09aaac3f6f6178de33fc909f81cb4abcb --- M jobs/master-builds.yml 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 17f576b..6a1ec09 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -49,6 +49,8 @@ trigger: email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org git_base_url: https://gerrit.osmocom.org + ssh: + - docs_ftp.osmocom.org # in alphabetical order repos: @@ -260,6 +262,9 @@ docker_img: 'registry.osmocom.org/$USER/fpga-build' cmd: 'docker pull {docker_img} && {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de 246tnt(a)gmail.com + ssh: + - binaries_ftp.osmocom.org + - docs_ftp.osmocom.org - osmo-fl2k: git_base_url: https://gitea.osmocom.org/sdr @@ -390,6 +395,9 @@ - osmo-asf4-dfu: cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org ewild(a)sysmocom.de + ssh: + - binaries_ftp.osmocom.org + - docs_ftp.osmocom.org - osmo-ccid-firmware: cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org ewild(a)sysmocom.de @@ -401,6 +409,9 @@ docker_img: '$USER/debian-bullseye-jenkins' cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de + ssh: + - binaries_ftp.osmocom.org + - docs_ftp.osmocom.org - osmo-e1d - osmo-cbc @@ -533,7 +544,6 @@ send-to-individuals: true wrappers: - ssh-agent-credentials: - users: - - 97634b9d-a867-4f6d-825d-1da99813e93d + users: '{obj:ssh}' # vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30380 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I821968e09aaac3f6f6178de33fc909f81cb4abcb Gerrit-Change-Number: 30380 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci: add build2-deb11build-ansible

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30369 ) Change subject: jobs/update-osmo-ci: add build2-deb11build-ansible ...................................................................... jobs/update-osmo-ci: add build2-deb11build-ansible Change-Id: Ief90b38d0a92f27c7ec37ffeb09dd3595b9d0baf --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 6f41da1..e566431 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -8,6 +8,7 @@ values: - build2-deb9build-ansible - build2-deb10build-ansible + - build2-deb11build-ansible - build3-deb11build-ansible - gtp0-deb9build - gtp0-deb10fr -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ief90b38d0a92f27c7ec37ffeb09dd3595b9d0baf Gerrit-Change-Number: 30369 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs: new naming scheme for ftp.osmocom.org keys

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30381 ) Change subject: jobs: new naming scheme for ftp.osmocom.org keys ...................................................................... jobs: new naming scheme for ftp.osmocom.org keys Use new ssh keys for ftp.osmocom.org with consistent naming scheme. It was not possible to use @ in the ID name for new IDs, so I've used an underscore instead. Change-Id: Id0cf70e70944cf1a1963e0046b1470a0485c05f8 --- M jobs/osmocom-api.yml M jobs/osmocom-release-tarballs.yml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/osmocom-api.yml b/jobs/osmocom-api.yml index f91779d..132a1d6 100644 --- a/jobs/osmocom-api.yml +++ b/jobs/osmocom-api.yml @@ -15,7 +15,7 @@ wrappers: - ssh-agent-credentials: users: - - api@osmocom + - api_ftp.osmocom.org parameters: - string: name: BRANCH diff --git a/jobs/osmocom-release-tarballs.yml b/jobs/osmocom-release-tarballs.yml index 3d11bd3..fad7462 100644 --- a/jobs/osmocom-release-tarballs.yml +++ b/jobs/osmocom-release-tarballs.yml @@ -42,6 +42,6 @@ wrappers: - ssh-agent-credentials: users: - - releases + - releases_ftp.osmocom.org # vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id0cf70e70944cf1a1963e0046b1470a0485c05f8 Gerrit-Change-Number: 30381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: update estimation code

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30304 ) Change subject: rate_ctr: update estimation code ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I07232e9ff8bd62403ae82d9bd60d967d40b54ebc Gerrit-Change-Number: 30304 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:09:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: use multiple timerfd

by laforge

Attention is currently required from: pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30303 ) Change subject: rate_ctr: use multiple timerfd ...................................................................... Patch Set 5: Code-Review-1 (1 comment) File src/rate_ctr.c: https://gerrit.osmocom.org/c/libosmocore/+/30303/comment/37b32e72_f776b47e PS3, Line 441: rc = rate_ctr_init_timer(&rate_ctr_timer_sec, &ts_interval_sec, rate_ctr_timer_cb_sec); > Influence timer ordering? I don't understand your question please rephrase. the point is: if there is one (per-second) timer that triggers all the updates, they are "atomic" from the point of stats/vty/ctrl interface. But if there re multiple timers like in this patch, you introduce the problems mentioned by pau. I tend to agree. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I78da7119bb745c38eed011b3a8452797a1bfe9d4 Gerrit-Change-Number: 30303 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:08:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: convert to timerfd

by laforge

Attention is currently required from: pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 ) Change subject: rate_ctr: convert to timerfd ...................................................................... Patch Set 4: Code-Review-1 (1 comment) File src/rate_ctr.c: https://gerrit.osmocom.org/c/libosmocore/+/30302/comment/6968897a_b224adf2 PS3, Line 359: timer_ticks++; > yes, but if a timer is lost due to the CPU being too loaded, you still want to tick the lost event I […] I agree with pau. I the "worst case" you can simply loop around the rate_ctr_group_intv(ctrg) below to make sure you call it expire_count times. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 Gerrit-Change-Number: 30302 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:06:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2024

2023

2022

gerrit-log November 2022