November 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-abis[master]: trau_sync: Fix typo tray_sync_pat_id -> trau_sync_pat_id

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30396 ) Change subject: trau_sync: Fix typo tray_sync_pat_id -> trau_sync_pat_id ...................................................................... trau_sync: Fix typo tray_sync_pat_id -> trau_sync_pat_id ... plus add a #define for compatibility with old source code. Change-Id: I472107bfbed10a8cadd4736ce84120b24a5579f8 --- M include/osmocom/trau/trau_sync.h M src/trau/trau_sync.c 2 files changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/96/30396/1 diff --git a/include/osmocom/trau/trau_sync.h b/include/osmocom/trau/trau_sync.h index ffda02a..c40727c 100644 --- a/include/osmocom/trau/trau_sync.h +++ b/include/osmocom/trau/trau_sync.h @@ -2,7 +2,10 @@ #include <osmocom/core/bits.h> #include <osmocom/core/fsm.h> -enum osmo_tray_sync_pat_id { +/* backwards compatibility */ +#define osmo_tray_sync_pat_id osmo_trau_sync_pat_id + +enum osmo_trau_sync_pat_id { OSMO_TRAU_SYNCP_16_FR_EFR, OSMO_TRAU_SYNCP_8_HR, OSMO_TRAU_SYNCP_8_AMR_LOW, @@ -15,7 +18,7 @@ struct osmo_fsm_inst * osmo_trau_sync_alloc(void *ctx, const char *name, frame_out_cb_t frame_out_cb, - enum osmo_tray_sync_pat_id pat_id, void *user_data); + enum osmo_trau_sync_pat_id pat_id, void *user_data); void osmo_trau_sync_rx_ubits(struct osmo_fsm_inst *fi, const ubit_t *bits, size_t n_bits); -void osmo_trau_sync_set_pat(struct osmo_fsm_inst *fi, enum osmo_tray_sync_pat_id pat_id); +void osmo_trau_sync_set_pat(struct osmo_fsm_inst *fi, enum osmo_trau_sync_pat_id pat_id); diff --git a/src/trau/trau_sync.c b/src/trau/trau_sync.c index b36e7c1..814ed88 100644 --- a/src/trau/trau_sync.c +++ b/src/trau/trau_sync.c @@ -492,7 +492,7 @@ struct osmo_fsm_inst * osmo_trau_sync_alloc(void *ctx, const char *name, frame_out_cb_t frame_out_cb, - enum osmo_tray_sync_pat_id pat_id, void *user_data) + enum osmo_trau_sync_pat_id pat_id, void *user_data) { struct trau_rx_sync_state *tss; struct osmo_fsm_inst *fi; @@ -523,7 +523,7 @@ return fi; } -void osmo_trau_sync_set_pat(struct osmo_fsm_inst *fi, enum osmo_tray_sync_pat_id pat_id) +void osmo_trau_sync_set_pat(struct osmo_fsm_inst *fi, enum osmo_trau_sync_pat_id pat_id) { struct trau_rx_sync_state *tss = fi->priv; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I472107bfbed10a8cadd4736ce84120b24a5579f8 Gerrit-Change-Number: 30396 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: update outdated vty copyright statement

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30395 ) Change subject: update outdated vty copyright statement ...................................................................... update outdated vty copyright statement Change-Id: I7af4bdecddda0b43f98855571942219e8ba00b64 --- M src/osmo-mgw/mgw_main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/95/30395/1 diff --git a/src/osmo-mgw/mgw_main.c b/src/osmo-mgw/mgw_main.c index 7a76210..d969fcc 100644 --- a/src/osmo-mgw/mgw_main.c +++ b/src/osmo-mgw/mgw_main.c @@ -83,7 +83,7 @@ const char *osmomgw_copyright = "Copyright (C) 2009-2010 Holger Freyther and On-Waves\r\n" - "Copyright (C) 2017 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>\r\n" + "Copyright (C) 2017-2022 by sysmocom s.f.m.c. GmbH\r\n" "Contributions by Pablo Neira Ayuso, Jacob Erlbeck, Neels Hofmeyr\r\n" "Philipp Maier\r\n\r\n" "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I7af4bdecddda0b43f98855571942219e8ba00b64 Gerrit-Change-Number: 30395 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: trau_sync: Add the V.110 sync pattern

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30375 ) Change subject: trau_sync: Add the V.110 sync pattern ...................................................................... Patch Set 2: (1 comment) File include/osmocom/trau/trau_sync.h: https://gerrit.osmocom.org/c/libosmo-abis/+/30375/comment/7847b092_2254a65e PS2, Line 5: enum osmo_tray_sync_pat_id { > can't do in a backwards compatible way. It's part of public API and osmo-mgw uses it. […] I'd do #define osmo_tray_sync_pat_id osmo_trau_sync_pat_id for backward compat and change the name. Let's not keep typos in API further in the future. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3aab5c3f494f6ea2b11f3cf69fb09bc77ea941d8 Gerrit-Change-Number: 30375 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 17:00:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmocom-release-tarballs: use any node

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30394 ) Change subject: jobs/osmocom-release-tarballs: use any node ...................................................................... jobs/osmocom-release-tarballs: use any node Prepare to retire build2-deb9build-ansible. With changes in the script, it doesn't need a persistent workspace anymore, it skips building source tarballs if they exist on the remote server. Depends: docker-playground I4b8c149c9cdbe7c613eea5d9be15794de5e5ddce Related: OS#5793 Change-Id: If56614caaa9c0c44419af596451d48c1970e9014 --- M jobs/osmocom-release-tarballs.yml 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/94/30394/1 diff --git a/jobs/osmocom-release-tarballs.yml b/jobs/osmocom-release-tarballs.yml index ee83ea4..458cd6d 100644 --- a/jobs/osmocom-release-tarballs.yml +++ b/jobs/osmocom-release-tarballs.yml @@ -29,12 +29,9 @@ url: https://gerrit.osmocom.org/docker-playground git-config-name: 'Jenkins Builder' git-config-email: 'jenkins(a)osmocom.org' - # Don't wipe workspace to keep generated release tarballs - wipe-workspace: false + wipe-workspace: true triggers: - timed: "@midnight" - # Limit to one specific builder (so we don't regenerate all tarballs when switching to another builder) - node: build2-deb9build-ansible publishers: - email: notify-every-unstable-build: true -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If56614caaa9c0c44419af596451d48c1970e9014 Gerrit-Change-Number: 30394 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmocom-release-tarballs: update clone url

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30393 ) Change subject: jobs/osmocom-release-tarballs: update clone url ...................................................................... jobs/osmocom-release-tarballs: update clone url Use gerrit.osmocom.org so we don't have a delay. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Git_infrastructure Change-Id: I4391016fda1584fa7d423521802458dca9b1b7ec --- M jobs/osmocom-release-tarballs.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/93/30393/1 diff --git a/jobs/osmocom-release-tarballs.yml b/jobs/osmocom-release-tarballs.yml index fad7462..ee83ea4 100644 --- a/jobs/osmocom-release-tarballs.yml +++ b/jobs/osmocom-release-tarballs.yml @@ -26,7 +26,7 @@ - git: branches: - '$BRANCH_DOCKER_PLAYGROUND' - url: https://gitea.osmocom.org/osmocom/docker-playground + url: https://gerrit.osmocom.org/docker-playground git-config-name: 'Jenkins Builder' git-config-email: 'jenkins(a)osmocom.org' # Don't wipe workspace to keep generated release tarballs -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4391016fda1584fa7d423521802458dca9b1b7ec Gerrit-Change-Number: 30393 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: scripts/osmocom-build-old…: skip openbsc 1.4.{0,1}

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30390 ) Change subject: scripts/osmocom-build-old…: skip openbsc 1.4.{0,1} ...................................................................... scripts/osmocom-build-old…: skip openbsc 1.4.{0,1} Don't attempt to build openbsc 1.4.0 and 1.4.1 in the osmocom-build-old-tags-against-master job, as it fails to build with a modern gcc with a potential null pointer dereference warning that gets treated as error. This was fixed in 1.4.2 with openbsc patch I93d816a20ba208e9fd32a1fc172a78ccd326e1ba. A more modern gcc gets used, as this job gets changed to not only run on jenkins nodes with debian 9 installed, but also more modern versions. This job does not run in docker, and since it still passes it doesn't seem worth changing that now. Related: OS#5793 Change-Id: Ibf4b66195fbd70a68d63929b156a9aac54a699bc --- M scripts/osmocom-build-old-tags-against-master.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/90/30390/1 diff --git a/scripts/osmocom-build-old-tags-against-master.sh b/scripts/osmocom-build-old-tags-against-master.sh index 71d5a1f..b6e6138 100755 --- a/scripts/osmocom-build-old-tags-against-master.sh +++ b/scripts/osmocom-build-old-tags-against-master.sh @@ -54,6 +54,8 @@ echo "1.0.0" # testsuite echo "1.3.1" # testsuite: libosmocore 6407c822ae0d45d047deb0dff095f028a90c1ecc echo "1.3.2" # testsuite: libosmocore 6407c822ae0d45d047deb0dff095f028a90c1ecc + echo "1.4.0" # error: potential null pointer dereference, fixed in 1.4.2 + echo "1.4.1" # error: potential null pointer dereference, fixed in 1.4.2 ;; osmo-bsc) # Depends on libosmo-legacy-mgcp, but missing LIBOSMOLEGACYMGCP_CFLAGS so we can't build it with -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibf4b66195fbd70a68d63929b156a9aac54a699bc Gerrit-Change-Number: 30390 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs: don't set node where it doesn't make sense

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30391 ) Change subject: jobs: don't set node where it doesn't make sense ...................................................................... jobs: don't set node where it doesn't make sense Remove the node attribute as these can run on any node. I've configured the three deb11 nodes with "Usage: Use this node as much as possible" instead of previously "Only build jobs with label expression matching this node", so simply not specifying a node is now possible. Previously it wouldn't have any node to run on as all of them were configured that way. Related: OS#5793 Change-Id: I2d67daf1cc7930649d097af23c18990cc3ae55fd --- M jobs/osmo-gsm-manuals-trigger.yml M jobs/registry-triggers.yml 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/91/30391/1 diff --git a/jobs/osmo-gsm-manuals-trigger.yml b/jobs/osmo-gsm-manuals-trigger.yml index bbb883f..0fca5a7 100644 --- a/jobs/osmo-gsm-manuals-trigger.yml +++ b/jobs/osmo-gsm-manuals-trigger.yml @@ -15,7 +15,6 @@ Roll out osmo-gsm-manuals to relevant build environments.<br> <br> Related: <a href="https://osmocom.org/issues/4912">OS#4912</a> - node: osmocom-master-debian9 scm: - git: url: https://gerrit.osmocom.org/osmo-gsm-manuals diff --git a/jobs/registry-triggers.yml b/jobs/registry-triggers.yml index dcdde85..823062b 100644 --- a/jobs/registry-triggers.yml +++ b/jobs/registry-triggers.yml @@ -12,7 +12,6 @@ name: 'registry-trigger-{repos}' description: | Update registry.osmocom.org after changes in {repos}. - node: osmocom-master-debian9 scm: - git: url: https://gerrit.osmocom.org/{repos} -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2d67daf1cc7930649d097af23c18990cc3ae55fd Gerrit-Change-Number: 30391 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs: don't limit to debian9

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30392 ) Change subject: jobs: don't limit to debian9 ...................................................................... jobs: don't limit to debian9 Related: OS#5793 Change-Id: Idcbbf766928964c4896aef7c6687ea7003203427 --- M jobs/gerrit-lint.yml M jobs/gerrit-verifications-dahdi.yml M jobs/master-builds-dahdi.yml M jobs/osmocom-api.yml M jobs/osmocom-build-tags-against-master.yml M jobs/osmocom-depcheck.yml M jobs/osmocom-list-commits.yml M jobs/registry-rebuild-upload-fpga-build.yml M jobs/registry-rebuild-upload-titan.yml M jobs/registry-update-base-images.yml 10 files changed, 11 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/92/30392/1 diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index dfdab5b..7b537b9 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -11,7 +11,7 @@ - job: name: 'gerrit-lint' project-type: freestyle - node: osmocom-gerrit-debian9 + node: osmocom-gerrit retry-count: 3 # scm checkout properties: - build-discarder: diff --git a/jobs/gerrit-verifications-dahdi.yml b/jobs/gerrit-verifications-dahdi.yml index 5343096..d594378 100644 --- a/jobs/gerrit-verifications-dahdi.yml +++ b/jobs/gerrit-verifications-dahdi.yml @@ -1,6 +1,5 @@ - project: name: gerrit-dahdi-linux - node: osmocom-gerrit-debian9 linux-ver: - "v4.19" - "v5.10" @@ -11,7 +10,7 @@ - job-template: name: 'gerrit-dahdi-linux-{linux-ver}' project-type: freestyle - node: osmocom-gerrit-debian9 + node: osmocom-gerrit concurrent: true retry-count: 0 # scm checkout properties: diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index e7c85b7..b152805 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -1,6 +1,5 @@ - project: name: master-builds-dahdi-linux - node: osmocom-gerrit-debian9 linux-ver: - "v4.19" - "v5.10" @@ -11,7 +10,7 @@ - job-template: name: 'master-dahdi-linux-{linux-ver}' project-type: freestyle - node: osmocom-master-debian9 + node: osmocom-master concurrent: true retry-count: 0 # scm checkout properties: diff --git a/jobs/osmocom-api.yml b/jobs/osmocom-api.yml index 132a1d6..cb5fecb 100644 --- a/jobs/osmocom-api.yml +++ b/jobs/osmocom-api.yml @@ -4,7 +4,7 @@ and uploads it to <a href="https://downloads.osmocom.org/api/latest/" >https://downloads.osmocom.org/api/latest/</a> name: Osmocom_API - node: osmocom-master-debian9 + node: osmocom-master project-type: freestyle publishers: - email: diff --git a/jobs/osmocom-build-tags-against-master.yml b/jobs/osmocom-build-tags-against-master.yml index 351aff2..91c3f64 100644 --- a/jobs/osmocom-build-tags-against-master.yml +++ b/jobs/osmocom-build-tags-against-master.yml @@ -11,7 +11,7 @@ description: | Build old releases of programs/libraries against "master of the day" libosmo* (<a href="https://osmocom.org/issues/3765">OS#3765</a>) - node: osmocom-master-debian9 + node: osmocom-master parameters: - string: name: BRANCH diff --git a/jobs/osmocom-depcheck.yml b/jobs/osmocom-depcheck.yml index 4ca04e2..27d2b94 100644 --- a/jobs/osmocom-depcheck.yml +++ b/jobs/osmocom-depcheck.yml @@ -12,7 +12,7 @@ Verifies that Osmocom programs really build with the dependency versions they claim to support in configure.ac. (Generated by job-builder) - node: osmocom-master-debian9 + node: osmocom-master parameters: - string: name: PROJECTS diff --git a/jobs/osmocom-list-commits.yml b/jobs/osmocom-list-commits.yml index 65bec81..0541002 100644 --- a/jobs/osmocom-list-commits.yml +++ b/jobs/osmocom-list-commits.yml @@ -11,7 +11,7 @@ description: | Generate and upload a list of Osmocom git repositories and their latest tag and commits. <b>The latest list is <a href="https://jenkins.osmocom.org/jenkins/job/Osmocom-list-commits/lastSuccessful…">here</a>.</b> - node: osmocom-master-debian9 + node: osmocom-master parameters: - string: name: BRANCH diff --git a/jobs/registry-rebuild-upload-fpga-build.yml b/jobs/registry-rebuild-upload-fpga-build.yml index dceb2c5..79fb9b2 100644 --- a/jobs/registry-rebuild-upload-fpga-build.yml +++ b/jobs/registry-rebuild-upload-fpga-build.yml @@ -8,7 +8,7 @@ name: registry-rebuild-upload-fpga-build description: | Rebuild + push fpga-build docker images in our private registry.osmocom.org - node: osmocom-master-debian9 + node: osmocom-master scm: - git: url: https://gerrit.osmocom.org/docker-playground diff --git a/jobs/registry-rebuild-upload-titan.yml b/jobs/registry-rebuild-upload-titan.yml index a21a088..1ba5a77 100644 --- a/jobs/registry-rebuild-upload-titan.yml +++ b/jobs/registry-rebuild-upload-titan.yml @@ -24,7 +24,7 @@ <ul> <li> <a href="https://osmocom.org/issues/5017">OS#5017</a> </ul> - node: osmocom-master-debian9 + node: osmocom-master scm: - 'osmocom-docker-playground' builders: @@ -48,7 +48,7 @@ <ul> <li>SYS#5765 </ul> - node: osmocom-master-debian9 + node: osmocom-master triggers: - reverse: jobs: diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index de5c448..d868655 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -12,7 +12,7 @@ <ul> <li> <a href="https://osmocom.org/issues/4839">OS#4839</a> </ul> - node: osmocom-master-debian9 + node: osmocom-master builders: - shell: | REGISTRY="registry.osmocom.org" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idcbbf766928964c4896aef7c6687ea7003203427 Gerrit-Change-Number: 30392 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: trau_sync: Add the V.110 sync pattern

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30375 ) Change subject: trau_sync: Add the V.110 sync pattern ...................................................................... Patch Set 2: (1 comment) File include/osmocom/trau/trau_sync.h: https://gerrit.osmocom.org/c/libosmo-abis/+/30375/comment/409c480e_68c14b5f PS2, Line 5: enum osmo_tray_sync_pat_id { > did you see this typo here? "tray". […] can't do in a backwards compatible way. It's part of public API and osmo-mgw uses it. Well, one could rename it and add a #define for source compatibility, but I'm wondering if it's really worth it and whether we might still get some fall-out? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3aab5c3f494f6ea2b11f3cf69fb09bc77ea941d8 Gerrit-Change-Number: 30375 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 16:48:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in dahdi-linux[master]: kernel 6.1 API change: netif_napi_add() uses weight==64 by default

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/30384 ) Change subject: kernel 6.1 API change: netif_napi_add() uses weight==64 by default ...................................................................... kernel 6.1 API change: netif_napi_add() uses weight==64 by default Change-Id: I7e70659e43c930a4c220eaef29cfb4e8d7a6eb0d --- M drivers/dahdi/voicebus/voicebus_net.c M drivers/dahdi/wctc4xxp/base.c 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/drivers/dahdi/voicebus/voicebus_net.c b/drivers/dahdi/voicebus/voicebus_net.c index c17627c..c621b89 100644 --- a/drivers/dahdi/voicebus/voicebus_net.c +++ b/drivers/dahdi/voicebus/voicebus_net.c @@ -202,7 +202,12 @@ netdev->promiscuity = 0; netdev->flags |= IFF_NOARP; +#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 1, 0) + /* 64 is NAPI_POLL_WEIGHT, i.e. the default */ + netif_napi_add(netdev, &vb->napi, vb_net_poll); +#else netif_napi_add(netdev, &vb->napi, vb_net_poll, 64); +#endif skb_queue_head_init(&vb->captured_packets); res = register_netdev(netdev); diff --git a/drivers/dahdi/wctc4xxp/base.c b/drivers/dahdi/wctc4xxp/base.c index 223bbbd..90c4efc 100644 --- a/drivers/dahdi/wctc4xxp/base.c +++ b/drivers/dahdi/wctc4xxp/base.c @@ -656,7 +656,12 @@ netdev->promiscuity = 0; netdev->flags |= IFF_NOARP; +#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 1, 0) + /* 64 is NAPI_POLL_WEIGHT, i.e. the default */ + netif_napi_add(netdev, &wc->napi, &wctc4xxp_poll); +#else netif_napi_add(netdev, &wc->napi, &wctc4xxp_poll, 64); +#endif res = register_netdev(netdev); if (res) { -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/30384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I7e70659e43c930a4c220eaef29cfb4e8d7a6eb0d Gerrit-Change-Number: 30384 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022