November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: mobile: gsm48_rr_tx_voice(): also permit TCH/H frames

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30333 ) Change subject: mobile: gsm48_rr_tx_voice(): also permit TCH/H frames ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I06e84ad47bafd4676af0e136b825e77471587b23 Gerrit-Change-Number: 30333 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 19:42:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: allow enabling/disabling handling of voice in the L1PHY

by laforge

Attention is currently required from: fixeria, pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30327 ) Change subject: mobile: allow enabling/disabling handling of voice in the L1PHY ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I131f213ef7c2736f7310f0183b83f3bc3064cd98 Gerrit-Change-Number: 30327 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 19:41:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: add MNCC handler selection to settings

by laforge

Attention is currently required from: fixeria, pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30326 ) Change subject: mobile: add MNCC handler selection to settings ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2df91c7a79ba5c39bc6ceae900ef649129dd0346 Gerrit-Change-Number: 30326 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 19:41:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): also print sub-slot for TCH/H

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30360 ) Change subject: mobile: timeout_rr_meas(): also print sub-slot for TCH/H ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I208c159ba610450e1850e601daa2712eef8c23e1 Gerrit-Change-Number: 30360 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 19:41:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: always check return value of rsl_tlv_parse()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30359 ) Change subject: layer23: always check return value of rsl_tlv_parse() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I13f2a97eeff78ca8ed7d0a2844e4fca430ec7768 Gerrit-Change-Number: 30359 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 19:40:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: always check return value of rsl_dec_chan_nr()

by laforge

Attention is currently required from: fixeria, pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30329 ) Change subject: layer23: always check return value of rsl_dec_chan_nr() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ab18bdaf41a29fcd32a7060668ef9db07b8cf7e Gerrit-Change-Number: 30329 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 19:40:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): also print sub-slot for TCH/H

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30360 ) Change subject: mobile: timeout_rr_meas(): also print sub-slot for TCH/H ...................................................................... mobile: timeout_rr_meas(): also print sub-slot for TCH/H Change-Id: I208c159ba610450e1850e601daa2712eef8c23e1 Related: OS#5599 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/60/30360/1 diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 2d89d7a..1c7036c 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -660,7 +660,8 @@ : rr->cd_now.ind_tx_power, ch_ts); if (rsl_dec_chan_nr(rr->cd_now.chan_nr, &ch_type, &ch_subch, &ch_ts) == 0) { if (ch_type == RSL_CHAN_SDCCH8_ACCH - || ch_type == RSL_CHAN_SDCCH4_ACCH) // TODO: TCH/H + || ch_type == RSL_CHAN_SDCCH4_ACCH + || ch_type == RSL_CHAN_Lm_ACCHs) sprintf(text + strlen(text), "/%d", ch_subch); } } else -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I208c159ba610450e1850e601daa2712eef8c23e1 Gerrit-Change-Number: 30360 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: always check return value of rsl_dec_chan_nr()

by fixeria

Attention is currently required from: pespin, msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30329 to look at the new patch set (#3). Change subject: layer23: always check return value of rsl_dec_chan_nr() ...................................................................... layer23: always check return value of rsl_dec_chan_nr() The rsl_dec_chan_nr() may fail to decode RSL channel number, so variables ch_type/chan_ss/chan_ts would remain uninitialized. Change-Id: I9ab18bdaf41a29fcd32a7060668ef9db07b8cf7e Related: OS#5599 --- M src/host/layer23/src/common/l1ctl.c M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/misc/app_ccch_scan.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/mobile/gsm48_rr.c 5 files changed, 146 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/29/30329/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ab18bdaf41a29fcd32a7060668ef9db07b8cf7e Gerrit-Change-Number: 30329 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: Don't use lsof

by laforge

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30313 ) Change subject: ttcn3-tcpdump-stop.sh: Don't use lsof ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Thanks for your input! Considering there is another +1 after your comment and that I'd rather not ad […] there was no additional +1 after my comment :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I38e132f49b0711d611d08b61c28b3092c991a191 Gerrit-Change-Number: 30313 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 19:21:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: always check return value of rsl_dec_chan_nr()

by fixeria

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30329 ) Change subject: layer23: always check return value of rsl_dec_chan_nr() ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: FYI: I found out that rsl_dec_chan_nr() is used in many places without checking the return value. This patch fixes all places, not only in the gsm48_rr_set_mode(). -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ab18bdaf41a29fcd32a7060668ef9db07b8cf7e Gerrit-Change-Number: 30329 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 19:13:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: always check return value of rsl_tlv_parse()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30359 ) Change subject: layer23: always check return value of rsl_tlv_parse() ...................................................................... layer23: always check return value of rsl_tlv_parse() Similar to rsl_dec_chan_nr(), this function may also fail, leaving the given struct tlv_parsed uninitialized. Change-Id: I13f2a97eeff78ca8ed7d0a2844e4fca430ec7768 Related: OS#5599 --- M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/misc/rslms.c M src/host/layer23/src/mobile/gsm48_rr.c 4 files changed, 20 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/30359/1 diff --git a/src/host/layer23/src/misc/app_cbch_sniff.c b/src/host/layer23/src/misc/app_cbch_sniff.c index 3ef1449..76d4537 100644 --- a/src/host/layer23/src/misc/app_cbch_sniff.c +++ b/src/host/layer23/src/misc/app_cbch_sniff.c @@ -111,7 +111,11 @@ DEBUGP(DRSL, "RSLms UNIT DATA IND chan_nr=0x%02x link_id=0x%02x\n", rllh->chan_nr, rllh->link_id); - rsl_tlv_parse(&tv, rllh->data, msgb_l2len(msg)-sizeof(*rllh)); + if (rsl_tlv_parse(&tv, rllh->data, msgb_l2len(msg) - sizeof(*rllh)) < 0) { + LOGP(DRSL, LOGL_ERROR, "%s(): rsl_tlv_parse() failed\n", __func__); + return -EINVAL; + } + if (!TLVP_PRESENT(&tv, RSL_IE_L3_INFO)) { DEBUGP(DRSL, "UNIT_DATA_IND without L3 INFO ?!?\n"); return -EIO; diff --git a/src/host/layer23/src/misc/cell_log.c b/src/host/layer23/src/misc/cell_log.c index 8b68c3c..eee008c 100644 --- a/src/host/layer23/src/misc/cell_log.c +++ b/src/host/layer23/src/misc/cell_log.c @@ -669,7 +669,11 @@ DEBUGP(DRSL, "RSLms UNIT DATA IND chan_nr=0x%02x link_id=0x%02x\n", rllh->chan_nr, rllh->link_id); - rsl_tlv_parse(&tv, rllh->data, msgb_l2len(msg)-sizeof(*rllh)); + if (rsl_tlv_parse(&tv, rllh->data, msgb_l2len(msg) - sizeof(*rllh)) < 0) { + LOGP(DRSL, LOGL_ERROR, "%s(): rsl_tlv_parse() failed\n", __func__); + return -EINVAL; + } + if (!TLVP_PRESENT(&tv, RSL_IE_L3_INFO)) { DEBUGP(DRSL, "UNIT_DATA_IND without L3 INFO ?!?\n"); return -EIO; diff --git a/src/host/layer23/src/misc/rslms.c b/src/host/layer23/src/misc/rslms.c index b729c1c..f7f6fcd 100644 --- a/src/host/layer23/src/misc/rslms.c +++ b/src/host/layer23/src/misc/rslms.c @@ -61,7 +61,11 @@ DEBUGP(DRSL, "RSLms UNIT DATA IND chan_nr=0x%02x link_id=0x%02x\n", rllh->chan_nr, rllh->link_id); - rsl_tlv_parse(&tv, rllh->data, msgb_l2len(msg)-sizeof(*rllh)); + if (rsl_tlv_parse(&tv, rllh->data, msgb_l2len(msg) - sizeof(*rllh)) < 0) { + LOGP(DRSL, LOGL_ERROR, "%s(): rsl_tlv_parse() failed\n", __func__); + return -EINVAL; + } + if (!TLVP_PRESENT(&tv, RSL_IE_L3_INFO)) { DEBUGP(DRSL, "UNIT_DATA_IND without L3 INFO ?!?\n"); return -EIO; diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 884e426..2d89d7a 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -4873,7 +4873,11 @@ DEBUGP(DRSL, "RSLms UNIT DATA IND chan_nr=0x%02x link_id=0x%02x\n", rllh->chan_nr, rllh->link_id); - rsl_tlv_parse(&tv, rllh->data, msgb_l2len(msg)-sizeof(*rllh)); + if (rsl_tlv_parse(&tv, rllh->data, msgb_l2len(msg) - sizeof(*rllh)) < 0) { + LOGP(DRSL, LOGL_ERROR, "%s(): rsl_tlv_parse() failed\n", __func__); + return -EINVAL; + } + if (!TLVP_PRESENT(&tv, RSL_IE_L3_INFO)) { DEBUGP(DRSL, "UNIT_DATA_IND without L3 INFO ?!?\n"); return -EIO; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I13f2a97eeff78ca8ed7d0a2844e4fca430ec7768 Gerrit-Change-Number: 30359 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: add MNCC handler selection to settings

by fixeria

Attention is currently required from: pespin, msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30326 to look at the new patch set (#2). Change subject: mobile: add MNCC handler selection to settings ...................................................................... mobile: add MNCC handler selection to settings Since the mobile application is potentially able to maintain multiple MS instances, it's better to have a possibility to choose an MNCC (Call Control) handler per each MS separately. This change removes the command-line option '-m', which was used for enabling the external MNCC. Now it's possible configure the MNCC handler for each MS via the VTY interface and settings. The following MNCC-handlers are available: - internal - built-in MNCC-handler (default); - external - external MNCC-handler via UNIX-socket (e.g. LCR); - dummy - dummy handler without CC support. Change-Id: I2df91c7a79ba5c39bc6ceae900ef649129dd0346 Related: OS#3400 --- M doc/examples/mobile/default.cfg M doc/examples/mobile/multi_ms.cfg M src/host/layer23/include/osmocom/bb/mobile/app_mobile.h M src/host/layer23/include/osmocom/bb/mobile/settings.h M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/main.c M src/host/layer23/src/mobile/mnccms.c M src/host/layer23/src/mobile/settings.c M src/host/layer23/src/mobile/vty_interface.c 9 files changed, 112 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/26/30326/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2df91c7a79ba5c39bc6ceae900ef649129dd0346 Gerrit-Change-Number: 30326 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: always check return value of rsl_dec_chan_nr()

by fixeria

Attention is currently required from: pespin, msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30329 to look at the new patch set (#2). Change subject: layer23: always check return value of rsl_dec_chan_nr() ...................................................................... layer23: always check return value of rsl_dec_chan_nr() The rsl_dec_chan_nr() may fail to decode RSL channel number, so variables ch_type/chan_ss/chan_ts would remain uninitialized. Change-Id: I9ab18bdaf41a29fcd32a7060668ef9db07b8cf7e Related: OS#5599 --- M src/host/layer23/src/common/l1ctl.c M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/misc/app_ccch_scan.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/mobile/gsm48_rr.c 5 files changed, 146 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/29/30329/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ab18bdaf41a29fcd32a7060668ef9db07b8cf7e Gerrit-Change-Number: 30329 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: allow enabling/disabling handling of voice in the L1PHY

by fixeria

Attention is currently required from: pespin, msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30327 to look at the new patch set (#2). Change subject: mobile: allow enabling/disabling handling of voice in the L1PHY ...................................................................... mobile: allow enabling/disabling handling of voice in the L1PHY Some L1PHY targets (e.g. Calypso based Mot C1xx phones) have built in microphone and speaker. Some targets do not have them. Currently we unconditionally instruct the L1PHY to handle TCH frames internally. Make this behavior configurable via the VTY interface. Change-Id: I131f213ef7c2736f7310f0183b83f3bc3064cd98 Related: OS#5599 --- M src/host/layer23/include/osmocom/bb/mobile/settings.h M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/settings.c M src/host/layer23/src/mobile/vty_interface.c 4 files changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/27/30327/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I131f213ef7c2736f7310f0183b83f3bc3064cd98 Gerrit-Change-Number: 30327 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: split gsm_send_voice() -> gsm_send_voice_{msg,frame}()

by fixeria

Attention is currently required from: msuraev. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30336 to look at the new patch set (#2). Change subject: mobile: split gsm_send_voice() -> gsm_send_voice_{msg,frame}() ...................................................................... mobile: split gsm_send_voice() -> gsm_send_voice_{msg,frame}() This is needed to avoid sending voice frames to the L1PHY without having to use MNCC specific struct gsm_data_frame. Change-Id: I37241555cd648a8e2b57fa072c708f93cd1ba5a9 Related: OS#5599 --- M src/host/layer23/include/osmocom/bb/mobile/voice.h M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/voice.c 3 files changed, 16 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/36/30336/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I37241555cd648a8e2b57fa072c708f93cd1ba5a9 Gerrit-Change-Number: 30336 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm48_rr_tx_voice(): also permit TCH/H frames

by fixeria

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30333 to look at the new patch set (#2). Change subject: mobile: gsm48_rr_tx_voice(): also permit TCH/H frames ...................................................................... mobile: gsm48_rr_tx_voice(): also permit TCH/H frames The idea behind checking the ch_type in gsm48_rr_tx_voice() was likely to prevent sending of the (LCR originated) Uplink TCH frames before the actual traffic channel is established/modified. The problem is that this check allows TCH/F frames, but not TCH/H. Most likely, TCH/H was forgotten or never tested. Fix this. Change-Id: I06e84ad47bafd4676af0e136b825e77471587b23 Related: OS#5599 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/33/30333/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I06e84ad47bafd4676af0e136b825e77471587b23 Gerrit-Change-Number: 30333 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm48_rr_tx_voice(): drop TCH/F channel limitation

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30333 ) Change subject: mobile: gsm48_rr_tx_voice(): drop TCH/F channel limitation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > the commit log states what the code does (obviously) but it fails to state *why*. […] I analyzed the code more carefully and came up with a conclusion that the check was added on purpose, but the RSL_CHAN_Lm_ACCHs was simply forgotten. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I06e84ad47bafd4676af0e136b825e77471587b23 Gerrit-Change-Number: 30333 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 28 Nov 2022 19:08:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm48_rr_set_mode(): print error if ch_type is not TCH

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30330 ) Change subject: mobile: gsm48_rr_set_mode(): print error if ch_type is not TCH ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4ab63c4ae4262c8166de37e4873fc3f1b8ec6fe7 Gerrit-Change-Number: 30330 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: abandon

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm48_rr_set_mode(): print error if ch_type is not TCH

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30330 ) Change subject: mobile: gsm48_rr_set_mode(): print error if ch_type is not TCH ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30330/comment/8f4f66ec_df3475a4 PS1, Line 3441: LOGP(DRR, LOGL_ERROR, "CHANNEL MODE MODIFY only applies " > That log message makes it clear that the channel is not TCH/* but it doesn't which channel it actual […] Actually, we should not be logging an error here because this function may get called not only for CHANNEL MODE MODIFY. In such cases it should simply return early, as it does. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4ab63c4ae4262c8166de37e4873fc3f1b8ec6fe7 Gerrit-Change-Number: 30330 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 18:21:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add OML tests for bts_setup_ramp

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356 ) Change subject: BSC_Tests: add OML tests for bts_setup_ramp ...................................................................... Patch Set 1: (1 comment) File bsc/BSC_Tests_OML.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356/comment/76cf418e_2298… PS1, Line 332: /* BTS: > Can you explain a bit what is all this? It documents how the OML could work. Copied over from BTS_Tests_OML.ttcn3. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0934ea26db359b0a6649c613f01de134a3a372ee Gerrit-Change-Number: 30356 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 18:05:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: split gsm_send_voice() -> gsm_send_voice_{msg,frame}()

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30336 ) Change subject: mobile: split gsm_send_voice() -> gsm_send_voice_{msg,frame}() ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/voice.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30336/comment/95a62c2f_c2853a39 PS1, Line 95: "gsm_send_voice, msg_type=0x%02x: not implemented\n", > It's better to update function name inside the log as well. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I37241555cd648a8e2b57fa072c708f93cd1ba5a9 Gerrit-Change-Number: 30336 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 17:59:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-gbproxy[master]: manual: Use combined/merged gb-ns2 chapter

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/30358 ) Change subject: manual: Use combined/merged gb-ns2 chapter ...................................................................... manual: Use combined/merged gb-ns2 chapter See https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30357 Depends: osmo-gsm-manuals I3c618e5af61b376435f400ef9c64245cec2f9b73 Change-Id: I881d8c2d400e47d9a39f8bd93668e1c3299e292f --- M doc/manuals/osmogbproxy-usermanual.adoc 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/osmogbproxy-usermanual.adoc b/doc/manuals/osmogbproxy-usermanual.adoc index 2a1b873..6bcba60 100644 --- a/doc/manuals/osmogbproxy-usermanual.adoc +++ b/doc/manuals/osmogbproxy-usermanual.adoc @@ -25,12 +25,6 @@ include::./common/chapters/gb-ns2.adoc[] -include::./common/chapters/gb-ns2-configuration.adoc[] - -include::./common/chapters/gb-ns2-configuration-timer.adoc[] - -include::./common/chapters/gb-ns2-maintenance.adoc[] - include::./common/chapters/control_if.adoc[] include::./common/chapters/counters-overview.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/30358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I881d8c2d400e47d9a39f8bd93668e1c3299e292f Gerrit-Change-Number: 30358 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add OML tests for bts_setup_ramp

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356 ) Change subject: BSC_Tests: add OML tests for bts_setup_ramp ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File bsc/BSC_Tests_OML.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356/comment/37fa2c90_d235… PS1, Line 332: /* BTS: Can you explain a bit what is all this? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0934ea26db359b0a6649c613f01de134a3a372ee Gerrit-Change-Number: 30356 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:58:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-gbproxy[master]: manual: Use combined/merged gb-ns2 chapter

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/30358 ) Change subject: manual: Use combined/merged gb-ns2 chapter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/30358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I881d8c2d400e47d9a39f8bd93668e1c3299e292f Gerrit-Change-Number: 30358 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:56:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-gbproxy[master]: manual: Use combined/merged gb-ns2 chapter

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/30358 ) Change subject: manual: Use combined/merged gb-ns2 chapter ...................................................................... manual: Use combined/merged gb-ns2 chapter See https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30357 Depends: osmo-gsm-manuals I3c618e5af61b376435f400ef9c64245cec2f9b73 Change-Id: I881d8c2d400e47d9a39f8bd93668e1c3299e292f --- M doc/manuals/osmogbproxy-usermanual.adoc 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/58/30358/1 diff --git a/doc/manuals/osmogbproxy-usermanual.adoc b/doc/manuals/osmogbproxy-usermanual.adoc index 2a1b873..6bcba60 100644 --- a/doc/manuals/osmogbproxy-usermanual.adoc +++ b/doc/manuals/osmogbproxy-usermanual.adoc @@ -25,12 +25,6 @@ include::./common/chapters/gb-ns2.adoc[] -include::./common/chapters/gb-ns2-configuration.adoc[] - -include::./common/chapters/gb-ns2-configuration-timer.adoc[] - -include::./common/chapters/gb-ns2-maintenance.adoc[] - include::./common/chapters/control_if.adoc[] include::./common/chapters/counters-overview.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/30358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I881d8c2d400e47d9a39f8bd93668e1c3299e292f Gerrit-Change-Number: 30358 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-gsm-manuals[master]: merge gb-ns2 "chapters" in one

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30357 ) Change subject: merge gb-ns2 "chapters" in one ...................................................................... merge gb-ns2 "chapters" in one The files gb-nsw-{configuration-timer,configuration,maintenance} were not actually chapters, but sub-chapters or sub-sub-chapters. This breaks our general idea that all of those files are top-level chapters. It also breaks asciidoc validation on Debian 11: asciidoc: WARNING: gb-ns2-configuration.adoc: line 1: section title out of sequence: expected level 1, got level 2 asciidoc: WARNING: gb-ns2-maintenance.adoc: line 6: section title out of sequence: expected level 2, got level 3 the only place where they were used was the osmo-gbproxy manual, and there in the exact sequenc in which I now merged them over here. Change-Id: I3c618e5af61b376435f400ef9c64245cec2f9b73 --- D common/chapters/gb-ns2-configuration-timer.adoc D common/chapters/gb-ns2-configuration.adoc D common/chapters/gb-ns2-maintenance.adoc M common/chapters/gb-ns2.adoc 4 files changed, 317 insertions(+), 314 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/common/chapters/gb-ns2-configuration-timer.adoc b/common/chapters/gb-ns2-configuration-timer.adoc deleted file mode 100644 index ab8585f..0000000 --- a/common/chapters/gb-ns2-configuration-timer.adoc +++ /dev/null @@ -1,36 +0,0 @@ -==== Gb/NS Timer configuration - -The NS protocol features a number of configurable timers. - -.List of configurable NS timers -|=== -|tns-block|(un)blocking timer timeout (secs) -|tns-block-retries|(un)blocking timer; number of retries -|tns-reset|reset timer timeout (secs) -|tns-reset-retries|reset timer; number of retries -|tns-test|test timer timeout (secs) -|tns-alive|alive timer timeout (secs) -|tns-alive-retries|alive timer; number of retries -|tsns-prov|SNS provision timeout (secs) used by all SNS auto configuration procedures. -|tsns-size-retries|SNS Size procedure; number of retries -|tsns-config-retries|SNS Config procedure; number of retries -|=== - -All timer can be configured by vty configuration - -.Example of timeouts ----- -ns - timer tns-block 3 - timer tns-block-retries 3 - timer tns-reset 3 - timer tns-reset-retries 3 - timer tns-test 30 - timer tns-alive 3 - timer tns-alive-retries 10 - timer tsns-prov 10 - timer tsns-size-retries 3 - timer tsns-config-retries 3 ----- - -// FIXME: ladder diagrams for every timer diff --git a/common/chapters/gb-ns2-configuration.adoc b/common/chapters/gb-ns2-configuration.adoc deleted file mode 100644 index 4397cf4..0000000 --- a/common/chapters/gb-ns2-configuration.adoc +++ /dev/null @@ -1,163 +0,0 @@ -=== Gb/NS configuration - -This section describes the configuration that libosmogb exposes via the -VTY and is valid for OsmoSGSN and OsmoGbProxy. - -==== Gb over Frame Relay over E1/T1 - -The Gb over Frame Relay over E1/T1 requires: - -* a hdlc interface -* a frame relay role (fr or frnet) -* the DLCI - -.Example: Gb over Frame Relay configuration #1 ----- -ns - bind fr sitea1 <1> - fr hdlc1 frnet <2> - nse 2001 <3> - nsvci fr sitea1 dlci 16 nsvci 11 ----- -<1> a Gb-over-FR bind with the name sitea1 -<2> connect the hdlc1 device with the role frnet to sitea1 -<3> one NSE (2001) with a single NS-VCI 11 on sitea1 with DLCI 16 - -.Example: Gb over Frame Relay configuration #2 ----- -ns - bind fr sitea1 <1> - fr hdlc1 frnet <2> - bind fr sitea2 - fr hdlc2 frnet - bind fr sitea3 - fr hdlc3 frnet - bind fr sitea4 - fr hdlc4 frnet - bind fr siteb1 - fr hdlc5 frnet - bind fr siteb2 - fr hdlc6 frnet - bind fr sitec1 - fr hdlc7 frnet - bind fr sitec2 - fr hdlc8 frnet - nse 2001 <3> - nsvci fr sitea1 dlci 16 nsvci 11 - nsvci fr sitea2 dlci 17 nsvci 12 - nsvci fr sitea3 dlci 18 nsvci 13 - nsvci fr sitea4 dlci 19 nsvci 14 - nse 2002 <4> - nsvci fr siteb5 dlci 20 nsvci 15 - nsvci fr siteb6 dlci 21 nsvci 16 - nse 2003 <5> - nsvc fr sitec7 dlci 22 nsvci 17 - nsvc fr sitec8 dlci 23 nsvci 18 ----- -<1> a Gb-over-FR bind with the name sitea1 -<2> connect the hdlc1 device with the role frnet to sitea1 -<3> one NSE (2001) with four NS-VCI (11..14) on sitea1..4 with their respective DLCI -<4> another NSE (2002) with two NS-VCI (15..16) on siteb1..2 with their respective DLCI -<5> another NSE (2003) with two NS-VCI (17..18) on sitec1..2 with their respective DLCI - - -==== Gb over IP "ip.access style" - -The Gb over IP "ip.access style" can be used with a dynamic configuration or with a -static configuration - -The static configuration requires to configure all endpoints on the BSS and SGSN. -In constrast the dynamic configuration allows the SGSN to have only a reduced configuration. - -===== Gb over IP "ip.access style" dynamic configuration - -.Example: Gb over IP/UDP ip.access style dynamic configuration (SGSN) ----- -ns - bind udp ran1 <1> - listen 10.100.1.1 23000 <2> - accept-ipaccess <3> ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.1.1:23000 -<3> accept unknown BSS of ip.access style - -.Example: Gb over IP/UDP "ip.access style" dynamic configuration (GbProxy as BSS) ----- -ns - bind udp ran1 <1> - listen 10.100.0.1 23000 <2> - nse 1001 <3> - nsvc ipa ran1 10.100.1.1 23000 nsvci 1001 ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.1.1:23000 -<3> accept unknown BSS of ip.access style - -NOTE: The OsmoPCU supports ip.access style Gb/NS but doesn't support this vty configuration because -it's receiving the configuration from the BTS/BSC. - -===== Gb over IP "ip.access style" static configuration - -.Example: Gb over IP/UDP "ip.access style" static configuration (BSS & SGSN) ----- -ns - bind udp ran1 <1> - listen 10.100.0.1 23000 <2> - nse 1001 <3> - nsvc ipa ran1 10.100.1.1 23000 nsvci 1001 ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.0.1:23000 -<3> NSE 1001 with nsvc 1001 as ip.access style - -NOTE: The OsmoPCU supports "ip.access style" Gb/NS but doesn't support this vty configuration because -it's receiving the configuration from the BTS/BSC. - - -==== Gb over IP 3GPP static configuration - -A static IP/UDP configuration without SNS as specified by 3GPP 48.016. - -.Example: Gb over IP/UDP static configuration BSS/SGSN ----- -ns - bind udp ran1 <1> - listen 10.100.0.1 23000 <2> - nse 1001 <3> - nsvc udp ran1 10.100.1.1 23000 signalling-weight 2 data-weight 2 - nsvc udp ran1 10.100.1.2 23000 <4> ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.0.1:23000 -<3> add NSE 1001 with 2 NSVC -<4> short configuration with default signalling and data weight of 1 - -==== Gb over IP 3GPP auto configuration as BSS - -IP/UDP auto-configuration with initial endpoints to an SGSN. -The auto-configuration will use the first bind to connect to the -first endpoint. If this fails Osmocom will iterate over all endpoints and binds to find -a working combination. - -.Example: Gb over IP/UDP auto-configuration as BSS ----- -ns - bind udp ran1 <1> - listen 10.100.0.1 23000 <2> - bind udp ran2 - listen 10.100.0.2 23000 - bind udp ran3 - listen 10.100.0.3 23000 - nse 1001 <3> - ip-sns-bind ran1 <4> - ip-sns-bind ran2 - ip-sns-remote 10.100.1.1 23000 <5> - ip-sns-remote 10.100.1.2 23000 ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.0.1:23000 -<3> add NSE 1001 with 2 initial SNS endpoints -<4> add ran1 to the list of available endpoints -<5> add 10.100.1.1 as initial endpoint - diff --git a/common/chapters/gb-ns2-maintenance.adoc b/common/chapters/gb-ns2-maintenance.adoc deleted file mode 100644 index ea99532..0000000 --- a/common/chapters/gb-ns2-maintenance.adoc +++ /dev/null @@ -1,115 +0,0 @@ -=== Gb/NS maintenance - -This section describes common maintenance procedures. - -[[ns2-nse-states]] -==== NSE states - -A NSE can have the following states: - -.NSE states -* ALIVE -* DEAD - -For FR, IPA: The NSE is ALIVE if there is at least one NSVC in state UNBLOCKED. -For IP-SNS/UDP: The NSE is ALIVE if there is at least one NSVC ALIVE and the sum of all ALIVE NSVCs signalling weights > 0 and data weights > 0. - -The state of the NSE is shown by vty. - -.show ns ----- -GbProxy# show ns nsei 1234 -NSEI 01234: UDP, DEAD <1> - FSM Instance Name: 'GPRS-NS2-SNS-BSS(NSE01234-SNS)[0x6120000012a0]', ID: 'NSE01234-SNS' - Log-Level: 'DEBUG', State: 'BSS_SIZE' - Timer: 1 - Maximum number of remote NS-VCs: 8192, IPv4 Endpoints: 8192, IPv6 Endpoints: 8192 - 1 NS-VC: - NSVCI none: DISABLED DYNAMIC data_weight=1 sig_weight=1 udp)[127.0.0.1]:23000<>[127.0.0.1]:22000 ----- -<1> NSE state - -==== NSVC states - -A NSVC can have the following states: - -.nsvc states -[options="header"] -|========================================================= -| State | transport UNITDATA | Description - -| DISABLED | No | Either the transport layer is unavailable (FR) or this NSVC is currently used by IP-SNS dynamic configuration. -| RESET | No | Sending out RESET PDU and awaiting data. -| BLOCKED | No* | The NSVC has been BLOCKED. * see 3GPP TS 48.016 § 7.2 exception -| UNBLOCKED/ALIVE | Yes | The NSVC transport UNITDATA. -| RECOVERING | No | The NSVC test procedure timed out. NSVC type is a IP-SNS which don't use RESET/BLOCK/UNBLOCK. - -|========================================================= - -[[fig-nsvc-states-reset-block]] -.Simplified state diagram for RESET BLOCK UNBLOCK NSVCs -[graphviz] ----- -include::gb-ns2-nsvc-states-reset-block.dot[] ----- - -[[fig-nsvc-states-alive]] -.Simplified state diagram for IP-SNS/UDP -[graphviz] ----- -include::gb-ns2-nsvc-states-alive.dot[] ----- - -==== Show information of a specific NSE - -The NSE 1234 has been configured for as BSS with IP-SNS configuration. - -.show ns on a dynamic configured IP-SNS NSE ----- -GbProxy# show ns nsei 1234 -NSEI 01234: UDP, DEAD <1> - FSM Instance Name: 'GPRS-NS2-SNS-BSS(NSE01234-SNS)[0x6120000012a0]', ID: 'NSE01234-SNS' - Log-Level: 'DEBUG', State: 'BSS_SIZE' <2> - Timer: 1 - Maximum number of remote NS-VCs: 8192, IPv4 Endpoints: 8192, IPv6 Endpoints: 8192 - 1 NS-VC: - NSVCI none: DISABLED DYNAMIC data_weight=1 sig_weight=1 udp)[127.0.0.1]:23000<>[127.0.0.1]:22000 ----- -<1> A UDP NSE. A NSE can be ALIVE or DEAD -<2> The SNS state. CONFIGURED and LOCAL_PROCEDURE are ALIVE states - -For description of NSE states see <<ns2-nse-states>>. - -.show ns on a frame relay NSE ----- -OsmoNSdummy# show ns nsei 02001 -NSEI 02001: FR, ALIVE <1> - 4 NS-VC: - NSVCI 00001: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet1 dlci: 16 <2> - NSVCI 00002: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet2 dlci: 17 <3> - NSVCI 00003: DISABLED PERSIST <4> data_weight=1 sig_weight=1 fr)netif: hdlcnet3 dlci: 18 - NSVCI 00004: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet4 dlci: 19 ----- -<1> A FR NSE. A NSE can be ALIVE or DEAD -<2> An unblocked NS-VC will be used for data and signalling. data and signalling weight are only relevant for UDP NSVC. -<3> NSVC is still blocked. -<4> A PERSIST NSVC is a configured via VTY. - -==== Blocking a NSVC - -.how to block a single NSVC ----- -OsmoNSdummy# show ns nsei 01234 -NSEI 01234: UDP, ALIVE since 0d 0h 41m 6s - 2 NS-VC: - NSVCI 01234: UNBLOCKED PERSIST udp)[127.0.0.1]:23000\<1234>[127.0.0.1]:22000 ALIVE since 0d 0h 2m 36s - NSVCI 01235: UNBLOCKED PERSIST udp)[127.0.0.1]:23001\<1235>[127.0.0.1]:22001 ALIVE since 0d 0h 41m 6s - -OsmoNSdummy# nsvc 1234 block -The NS-VC 01234 will be blocked. -OsmoNSdummy# show ns nsei 01234 -NSEI 01234: UDP, ALIVE since 0d 0h 42m 7s - 2 NS-VC: - NSVCI 01234: BLOCKED PERSIST udp)[127.0.0.1]:23000\<1234>[127.0.0.1]:22000 DEAD since 0d 0h 3m 37s - NSVCI 01235: UNBLOCKED PERSIST udp)[127.0.0.1]:23001\<1235>[127.0.0.1]:22001 ALIVE since 0d 0h 42m 7s ----- diff --git a/common/chapters/gb-ns2.adoc b/common/chapters/gb-ns2.adoc index 34943d3..925f515 100644 --- a/common/chapters/gb-ns2.adoc +++ b/common/chapters/gb-ns2.adoc @@ -179,3 +179,320 @@ A NS-VC is always bound to a NSE and the bind (NS-VL). The NSVC can be either persistent or dynamic. + +=== Gb/NS configuration + +This section describes the configuration that libosmogb exposes via the +VTY and is valid for OsmoSGSN and OsmoGbProxy. + +==== Gb over Frame Relay over E1/T1 + +The Gb over Frame Relay over E1/T1 requires: + +* a hdlc interface +* a frame relay role (fr or frnet) +* the DLCI + +.Example: Gb over Frame Relay configuration #1 +---- +ns + bind fr sitea1 <1> + fr hdlc1 frnet <2> + nse 2001 <3> + nsvci fr sitea1 dlci 16 nsvci 11 +---- +<1> a Gb-over-FR bind with the name sitea1 +<2> connect the hdlc1 device with the role frnet to sitea1 +<3> one NSE (2001) with a single NS-VCI 11 on sitea1 with DLCI 16 + +.Example: Gb over Frame Relay configuration #2 +---- +ns + bind fr sitea1 <1> + fr hdlc1 frnet <2> + bind fr sitea2 + fr hdlc2 frnet + bind fr sitea3 + fr hdlc3 frnet + bind fr sitea4 + fr hdlc4 frnet + bind fr siteb1 + fr hdlc5 frnet + bind fr siteb2 + fr hdlc6 frnet + bind fr sitec1 + fr hdlc7 frnet + bind fr sitec2 + fr hdlc8 frnet + nse 2001 <3> + nsvci fr sitea1 dlci 16 nsvci 11 + nsvci fr sitea2 dlci 17 nsvci 12 + nsvci fr sitea3 dlci 18 nsvci 13 + nsvci fr sitea4 dlci 19 nsvci 14 + nse 2002 <4> + nsvci fr siteb5 dlci 20 nsvci 15 + nsvci fr siteb6 dlci 21 nsvci 16 + nse 2003 <5> + nsvc fr sitec7 dlci 22 nsvci 17 + nsvc fr sitec8 dlci 23 nsvci 18 +---- +<1> a Gb-over-FR bind with the name sitea1 +<2> connect the hdlc1 device with the role frnet to sitea1 +<3> one NSE (2001) with four NS-VCI (11..14) on sitea1..4 with their respective DLCI +<4> another NSE (2002) with two NS-VCI (15..16) on siteb1..2 with their respective DLCI +<5> another NSE (2003) with two NS-VCI (17..18) on sitec1..2 with their respective DLCI + + +==== Gb over IP "ip.access style" + +The Gb over IP "ip.access style" can be used with a dynamic configuration or with a +static configuration + +The static configuration requires to configure all endpoints on the BSS and SGSN. +In constrast the dynamic configuration allows the SGSN to have only a reduced configuration. + +===== Gb over IP "ip.access style" dynamic configuration + +.Example: Gb over IP/UDP ip.access style dynamic configuration (SGSN) +---- +ns + bind udp ran1 <1> + listen 10.100.1.1 23000 <2> + accept-ipaccess <3> +---- +<1> create a IP/UDP bind with name ran1 +<2> bind to 10.100.1.1:23000 +<3> accept unknown BSS of ip.access style + +.Example: Gb over IP/UDP "ip.access style" dynamic configuration (GbProxy as BSS) +---- +ns + bind udp ran1 <1> + listen 10.100.0.1 23000 <2> + nse 1001 <3> + nsvc ipa ran1 10.100.1.1 23000 nsvci 1001 +---- +<1> create a IP/UDP bind with name ran1 +<2> bind to 10.100.1.1:23000 +<3> accept unknown BSS of ip.access style + +NOTE: The OsmoPCU supports ip.access style Gb/NS but doesn't support this vty configuration because +it's receiving the configuration from the BTS/BSC. + +===== Gb over IP "ip.access style" static configuration + +.Example: Gb over IP/UDP "ip.access style" static configuration (BSS & SGSN) +---- +ns + bind udp ran1 <1> + listen 10.100.0.1 23000 <2> + nse 1001 <3> + nsvc ipa ran1 10.100.1.1 23000 nsvci 1001 +---- +<1> create a IP/UDP bind with name ran1 +<2> bind to 10.100.0.1:23000 +<3> NSE 1001 with nsvc 1001 as ip.access style + +NOTE: The OsmoPCU supports "ip.access style" Gb/NS but doesn't support this vty configuration because +it's receiving the configuration from the BTS/BSC. + + +==== Gb over IP 3GPP static configuration + +A static IP/UDP configuration without SNS as specified by 3GPP 48.016. + +.Example: Gb over IP/UDP static configuration BSS/SGSN +---- +ns + bind udp ran1 <1> + listen 10.100.0.1 23000 <2> + nse 1001 <3> + nsvc udp ran1 10.100.1.1 23000 signalling-weight 2 data-weight 2 + nsvc udp ran1 10.100.1.2 23000 <4> +---- +<1> create a IP/UDP bind with name ran1 +<2> bind to 10.100.0.1:23000 +<3> add NSE 1001 with 2 NSVC +<4> short configuration with default signalling and data weight of 1 + +==== Gb over IP 3GPP auto configuration as BSS + +IP/UDP auto-configuration with initial endpoints to an SGSN. +The auto-configuration will use the first bind to connect to the +first endpoint. If this fails Osmocom will iterate over all endpoints and binds to find +a working combination. + +.Example: Gb over IP/UDP auto-configuration as BSS +---- +ns + bind udp ran1 <1> + listen 10.100.0.1 23000 <2> + bind udp ran2 + listen 10.100.0.2 23000 + bind udp ran3 + listen 10.100.0.3 23000 + nse 1001 <3> + ip-sns-bind ran1 <4> + ip-sns-bind ran2 + ip-sns-remote 10.100.1.1 23000 <5> + ip-sns-remote 10.100.1.2 23000 +---- +<1> create a IP/UDP bind with name ran1 +<2> bind to 10.100.0.1:23000 +<3> add NSE 1001 with 2 initial SNS endpoints +<4> add ran1 to the list of available endpoints +<5> add 10.100.1.1 as initial endpoint + + +==== Gb/NS Timer configuration + +The NS protocol features a number of configurable timers. + +.List of configurable NS timers +|=== +|tns-block|(un)blocking timer timeout (secs) +|tns-block-retries|(un)blocking timer; number of retries +|tns-reset|reset timer timeout (secs) +|tns-reset-retries|reset timer; number of retries +|tns-test|test timer timeout (secs) +|tns-alive|alive timer timeout (secs) +|tns-alive-retries|alive timer; number of retries +|tsns-prov|SNS provision timeout (secs) used by all SNS auto configuration procedures. +|tsns-size-retries|SNS Size procedure; number of retries +|tsns-config-retries|SNS Config procedure; number of retries +|=== + +All timer can be configured by vty configuration + +.Example of timeouts +---- +ns + timer tns-block 3 + timer tns-block-retries 3 + timer tns-reset 3 + timer tns-reset-retries 3 + timer tns-test 30 + timer tns-alive 3 + timer tns-alive-retries 10 + timer tsns-prov 10 + timer tsns-size-retries 3 + timer tsns-config-retries 3 +---- + +// FIXME: ladder diagrams for every timer + +=== Gb/NS maintenance + +This section describes common maintenance procedures. + +[[ns2-nse-states]] +==== NSE states + +A NSE can have the following states: + +.NSE states +* ALIVE +* DEAD + +For FR, IPA: The NSE is ALIVE if there is at least one NSVC in state UNBLOCKED. +For IP-SNS/UDP: The NSE is ALIVE if there is at least one NSVC ALIVE and the sum of all ALIVE NSVCs signalling weights > 0 and data weights > 0. + +The state of the NSE is shown by vty. + +.show ns +---- +GbProxy# show ns nsei 1234 +NSEI 01234: UDP, DEAD <1> + FSM Instance Name: 'GPRS-NS2-SNS-BSS(NSE01234-SNS)[0x6120000012a0]', ID: 'NSE01234-SNS' + Log-Level: 'DEBUG', State: 'BSS_SIZE' + Timer: 1 + Maximum number of remote NS-VCs: 8192, IPv4 Endpoints: 8192, IPv6 Endpoints: 8192 + 1 NS-VC: + NSVCI none: DISABLED DYNAMIC data_weight=1 sig_weight=1 udp)[127.0.0.1]:23000<>[127.0.0.1]:22000 +---- +<1> NSE state + +==== NSVC states + +A NSVC can have the following states: + +.nsvc states +[options="header"] +|========================================================= +| State | transport UNITDATA | Description + +| DISABLED | No | Either the transport layer is unavailable (FR) or this NSVC is currently used by IP-SNS dynamic configuration. +| RESET | No | Sending out RESET PDU and awaiting data. +| BLOCKED | No* | The NSVC has been BLOCKED. * see 3GPP TS 48.016 § 7.2 exception +| UNBLOCKED/ALIVE | Yes | The NSVC transport UNITDATA. +| RECOVERING | No | The NSVC test procedure timed out. NSVC type is a IP-SNS which don't use RESET/BLOCK/UNBLOCK. + +|========================================================= + +[[fig-nsvc-states-reset-block]] +.Simplified state diagram for RESET BLOCK UNBLOCK NSVCs +[graphviz] +---- +include::gb-ns2-nsvc-states-reset-block.dot[] +---- + +[[fig-nsvc-states-alive]] +.Simplified state diagram for IP-SNS/UDP +[graphviz] +---- +include::gb-ns2-nsvc-states-alive.dot[] +---- + +==== Show information of a specific NSE + +The NSE 1234 has been configured for as BSS with IP-SNS configuration. + +.show ns on a dynamic configured IP-SNS NSE +---- +GbProxy# show ns nsei 1234 +NSEI 01234: UDP, DEAD <1> + FSM Instance Name: 'GPRS-NS2-SNS-BSS(NSE01234-SNS)[0x6120000012a0]', ID: 'NSE01234-SNS' + Log-Level: 'DEBUG', State: 'BSS_SIZE' <2> + Timer: 1 + Maximum number of remote NS-VCs: 8192, IPv4 Endpoints: 8192, IPv6 Endpoints: 8192 + 1 NS-VC: + NSVCI none: DISABLED DYNAMIC data_weight=1 sig_weight=1 udp)[127.0.0.1]:23000<>[127.0.0.1]:22000 +---- +<1> A UDP NSE. A NSE can be ALIVE or DEAD +<2> The SNS state. CONFIGURED and LOCAL_PROCEDURE are ALIVE states + +For description of NSE states see <<ns2-nse-states>>. + +.show ns on a frame relay NSE +---- +OsmoNSdummy# show ns nsei 02001 +NSEI 02001: FR, ALIVE <1> + 4 NS-VC: + NSVCI 00001: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet1 dlci: 16 <2> + NSVCI 00002: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet2 dlci: 17 <3> + NSVCI 00003: DISABLED PERSIST <4> data_weight=1 sig_weight=1 fr)netif: hdlcnet3 dlci: 18 + NSVCI 00004: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet4 dlci: 19 +---- +<1> A FR NSE. A NSE can be ALIVE or DEAD +<2> An unblocked NS-VC will be used for data and signalling. data and signalling weight are only relevant for UDP NSVC. +<3> NSVC is still blocked. +<4> A PERSIST NSVC is a configured via VTY. + +==== Blocking a NSVC + +.how to block a single NSVC +---- +OsmoNSdummy# show ns nsei 01234 +NSEI 01234: UDP, ALIVE since 0d 0h 41m 6s + 2 NS-VC: + NSVCI 01234: UNBLOCKED PERSIST udp)[127.0.0.1]:23000\<1234>[127.0.0.1]:22000 ALIVE since 0d 0h 2m 36s + NSVCI 01235: UNBLOCKED PERSIST udp)[127.0.0.1]:23001\<1235>[127.0.0.1]:22001 ALIVE since 0d 0h 41m 6s + +OsmoNSdummy# nsvc 1234 block +The NS-VC 01234 will be blocked. +OsmoNSdummy# show ns nsei 01234 +NSEI 01234: UDP, ALIVE since 0d 0h 42m 7s + 2 NS-VC: + NSVCI 01234: BLOCKED PERSIST udp)[127.0.0.1]:23000\<1234>[127.0.0.1]:22000 DEAD since 0d 0h 3m 37s + NSVCI 01235: UNBLOCKED PERSIST udp)[127.0.0.1]:23001\<1235>[127.0.0.1]:22001 ALIVE since 0d 0h 42m 7s +---- -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I3c618e5af61b376435f400ef9c64245cec2f9b73 Gerrit-Change-Number: 30357 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-gsm-manuals[master]: merge gb-ns2 "chapters" in one

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30357 ) Change subject: merge gb-ns2 "chapters" in one ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I3c618e5af61b376435f400ef9c64245cec2f9b73 Gerrit-Change-Number: 30357 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:55:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm48_rr_set_mode(): check rc of rsl_dec_chan_nr()

by fixeria

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30329 ) Change subject: mobile: gsm48_rr_set_mode(): check rc of rsl_dec_chan_nr() ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30329/comment/97e25578_aeaffb84 PS1, Line 3435: LOGP(DRR, LOGL_ERROR, "Couldn't decode RSL channel number\n"); > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ab18bdaf41a29fcd32a7060668ef9db07b8cf7e Gerrit-Change-Number: 30329 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:52:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: allow enabling/disabling handling of voice in the L1PHY

by fixeria

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30327 ) Change subject: mobile: allow enabling/disabling handling of voice in the L1PHY ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30327/comment/3ca48b2d_cf0b4fcc PS1, Line 2837: "L1 PHY (e.g. Calypso DSP in Mot C1xx phones)\n" > Ack Done. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I131f213ef7c2736f7310f0183b83f3bc3064cd98 Gerrit-Change-Number: 30327 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:50:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-gsm-manuals[master]: merge gb-ns2 "chapters" in one

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30357 ) Change subject: merge gb-ns2 "chapters" in one ...................................................................... merge gb-ns2 "chapters" in one The files gb-nsw-{configuration-timer,configuration,maintenance} were not actually chapters, but sub-chapters or sub-sub-chapters. This breaks our general idea that all of those files are top-level chapters. It also breaks asciidoc validation on Debian 11: asciidoc: WARNING: gb-ns2-configuration.adoc: line 1: section title out of sequence: expected level 1, got level 2 asciidoc: WARNING: gb-ns2-maintenance.adoc: line 6: section title out of sequence: expected level 2, got level 3 the only place where they were used was the osmo-gbproxy manual, and there in the exact sequenc in which I now merged them over here. Change-Id: I3c618e5af61b376435f400ef9c64245cec2f9b73 --- D common/chapters/gb-ns2-configuration-timer.adoc D common/chapters/gb-ns2-configuration.adoc D common/chapters/gb-ns2-maintenance.adoc M common/chapters/gb-ns2.adoc 4 files changed, 317 insertions(+), 314 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/57/30357/1 diff --git a/common/chapters/gb-ns2-configuration-timer.adoc b/common/chapters/gb-ns2-configuration-timer.adoc deleted file mode 100644 index ab8585f..0000000 --- a/common/chapters/gb-ns2-configuration-timer.adoc +++ /dev/null @@ -1,36 +0,0 @@ -==== Gb/NS Timer configuration - -The NS protocol features a number of configurable timers. - -.List of configurable NS timers -|=== -|tns-block|(un)blocking timer timeout (secs) -|tns-block-retries|(un)blocking timer; number of retries -|tns-reset|reset timer timeout (secs) -|tns-reset-retries|reset timer; number of retries -|tns-test|test timer timeout (secs) -|tns-alive|alive timer timeout (secs) -|tns-alive-retries|alive timer; number of retries -|tsns-prov|SNS provision timeout (secs) used by all SNS auto configuration procedures. -|tsns-size-retries|SNS Size procedure; number of retries -|tsns-config-retries|SNS Config procedure; number of retries -|=== - -All timer can be configured by vty configuration - -.Example of timeouts ----- -ns - timer tns-block 3 - timer tns-block-retries 3 - timer tns-reset 3 - timer tns-reset-retries 3 - timer tns-test 30 - timer tns-alive 3 - timer tns-alive-retries 10 - timer tsns-prov 10 - timer tsns-size-retries 3 - timer tsns-config-retries 3 ----- - -// FIXME: ladder diagrams for every timer diff --git a/common/chapters/gb-ns2-configuration.adoc b/common/chapters/gb-ns2-configuration.adoc deleted file mode 100644 index 4397cf4..0000000 --- a/common/chapters/gb-ns2-configuration.adoc +++ /dev/null @@ -1,163 +0,0 @@ -=== Gb/NS configuration - -This section describes the configuration that libosmogb exposes via the -VTY and is valid for OsmoSGSN and OsmoGbProxy. - -==== Gb over Frame Relay over E1/T1 - -The Gb over Frame Relay over E1/T1 requires: - -* a hdlc interface -* a frame relay role (fr or frnet) -* the DLCI - -.Example: Gb over Frame Relay configuration #1 ----- -ns - bind fr sitea1 <1> - fr hdlc1 frnet <2> - nse 2001 <3> - nsvci fr sitea1 dlci 16 nsvci 11 ----- -<1> a Gb-over-FR bind with the name sitea1 -<2> connect the hdlc1 device with the role frnet to sitea1 -<3> one NSE (2001) with a single NS-VCI 11 on sitea1 with DLCI 16 - -.Example: Gb over Frame Relay configuration #2 ----- -ns - bind fr sitea1 <1> - fr hdlc1 frnet <2> - bind fr sitea2 - fr hdlc2 frnet - bind fr sitea3 - fr hdlc3 frnet - bind fr sitea4 - fr hdlc4 frnet - bind fr siteb1 - fr hdlc5 frnet - bind fr siteb2 - fr hdlc6 frnet - bind fr sitec1 - fr hdlc7 frnet - bind fr sitec2 - fr hdlc8 frnet - nse 2001 <3> - nsvci fr sitea1 dlci 16 nsvci 11 - nsvci fr sitea2 dlci 17 nsvci 12 - nsvci fr sitea3 dlci 18 nsvci 13 - nsvci fr sitea4 dlci 19 nsvci 14 - nse 2002 <4> - nsvci fr siteb5 dlci 20 nsvci 15 - nsvci fr siteb6 dlci 21 nsvci 16 - nse 2003 <5> - nsvc fr sitec7 dlci 22 nsvci 17 - nsvc fr sitec8 dlci 23 nsvci 18 ----- -<1> a Gb-over-FR bind with the name sitea1 -<2> connect the hdlc1 device with the role frnet to sitea1 -<3> one NSE (2001) with four NS-VCI (11..14) on sitea1..4 with their respective DLCI -<4> another NSE (2002) with two NS-VCI (15..16) on siteb1..2 with their respective DLCI -<5> another NSE (2003) with two NS-VCI (17..18) on sitec1..2 with their respective DLCI - - -==== Gb over IP "ip.access style" - -The Gb over IP "ip.access style" can be used with a dynamic configuration or with a -static configuration - -The static configuration requires to configure all endpoints on the BSS and SGSN. -In constrast the dynamic configuration allows the SGSN to have only a reduced configuration. - -===== Gb over IP "ip.access style" dynamic configuration - -.Example: Gb over IP/UDP ip.access style dynamic configuration (SGSN) ----- -ns - bind udp ran1 <1> - listen 10.100.1.1 23000 <2> - accept-ipaccess <3> ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.1.1:23000 -<3> accept unknown BSS of ip.access style - -.Example: Gb over IP/UDP "ip.access style" dynamic configuration (GbProxy as BSS) ----- -ns - bind udp ran1 <1> - listen 10.100.0.1 23000 <2> - nse 1001 <3> - nsvc ipa ran1 10.100.1.1 23000 nsvci 1001 ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.1.1:23000 -<3> accept unknown BSS of ip.access style - -NOTE: The OsmoPCU supports ip.access style Gb/NS but doesn't support this vty configuration because -it's receiving the configuration from the BTS/BSC. - -===== Gb over IP "ip.access style" static configuration - -.Example: Gb over IP/UDP "ip.access style" static configuration (BSS & SGSN) ----- -ns - bind udp ran1 <1> - listen 10.100.0.1 23000 <2> - nse 1001 <3> - nsvc ipa ran1 10.100.1.1 23000 nsvci 1001 ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.0.1:23000 -<3> NSE 1001 with nsvc 1001 as ip.access style - -NOTE: The OsmoPCU supports "ip.access style" Gb/NS but doesn't support this vty configuration because -it's receiving the configuration from the BTS/BSC. - - -==== Gb over IP 3GPP static configuration - -A static IP/UDP configuration without SNS as specified by 3GPP 48.016. - -.Example: Gb over IP/UDP static configuration BSS/SGSN ----- -ns - bind udp ran1 <1> - listen 10.100.0.1 23000 <2> - nse 1001 <3> - nsvc udp ran1 10.100.1.1 23000 signalling-weight 2 data-weight 2 - nsvc udp ran1 10.100.1.2 23000 <4> ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.0.1:23000 -<3> add NSE 1001 with 2 NSVC -<4> short configuration with default signalling and data weight of 1 - -==== Gb over IP 3GPP auto configuration as BSS - -IP/UDP auto-configuration with initial endpoints to an SGSN. -The auto-configuration will use the first bind to connect to the -first endpoint. If this fails Osmocom will iterate over all endpoints and binds to find -a working combination. - -.Example: Gb over IP/UDP auto-configuration as BSS ----- -ns - bind udp ran1 <1> - listen 10.100.0.1 23000 <2> - bind udp ran2 - listen 10.100.0.2 23000 - bind udp ran3 - listen 10.100.0.3 23000 - nse 1001 <3> - ip-sns-bind ran1 <4> - ip-sns-bind ran2 - ip-sns-remote 10.100.1.1 23000 <5> - ip-sns-remote 10.100.1.2 23000 ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.0.1:23000 -<3> add NSE 1001 with 2 initial SNS endpoints -<4> add ran1 to the list of available endpoints -<5> add 10.100.1.1 as initial endpoint - diff --git a/common/chapters/gb-ns2-maintenance.adoc b/common/chapters/gb-ns2-maintenance.adoc deleted file mode 100644 index ea99532..0000000 --- a/common/chapters/gb-ns2-maintenance.adoc +++ /dev/null @@ -1,115 +0,0 @@ -=== Gb/NS maintenance - -This section describes common maintenance procedures. - -[[ns2-nse-states]] -==== NSE states - -A NSE can have the following states: - -.NSE states -* ALIVE -* DEAD - -For FR, IPA: The NSE is ALIVE if there is at least one NSVC in state UNBLOCKED. -For IP-SNS/UDP: The NSE is ALIVE if there is at least one NSVC ALIVE and the sum of all ALIVE NSVCs signalling weights > 0 and data weights > 0. - -The state of the NSE is shown by vty. - -.show ns ----- -GbProxy# show ns nsei 1234 -NSEI 01234: UDP, DEAD <1> - FSM Instance Name: 'GPRS-NS2-SNS-BSS(NSE01234-SNS)[0x6120000012a0]', ID: 'NSE01234-SNS' - Log-Level: 'DEBUG', State: 'BSS_SIZE' - Timer: 1 - Maximum number of remote NS-VCs: 8192, IPv4 Endpoints: 8192, IPv6 Endpoints: 8192 - 1 NS-VC: - NSVCI none: DISABLED DYNAMIC data_weight=1 sig_weight=1 udp)[127.0.0.1]:23000<>[127.0.0.1]:22000 ----- -<1> NSE state - -==== NSVC states - -A NSVC can have the following states: - -.nsvc states -[options="header"] -|========================================================= -| State | transport UNITDATA | Description - -| DISABLED | No | Either the transport layer is unavailable (FR) or this NSVC is currently used by IP-SNS dynamic configuration. -| RESET | No | Sending out RESET PDU and awaiting data. -| BLOCKED | No* | The NSVC has been BLOCKED. * see 3GPP TS 48.016 § 7.2 exception -| UNBLOCKED/ALIVE | Yes | The NSVC transport UNITDATA. -| RECOVERING | No | The NSVC test procedure timed out. NSVC type is a IP-SNS which don't use RESET/BLOCK/UNBLOCK. - -|========================================================= - -[[fig-nsvc-states-reset-block]] -.Simplified state diagram for RESET BLOCK UNBLOCK NSVCs -[graphviz] ----- -include::gb-ns2-nsvc-states-reset-block.dot[] ----- - -[[fig-nsvc-states-alive]] -.Simplified state diagram for IP-SNS/UDP -[graphviz] ----- -include::gb-ns2-nsvc-states-alive.dot[] ----- - -==== Show information of a specific NSE - -The NSE 1234 has been configured for as BSS with IP-SNS configuration. - -.show ns on a dynamic configured IP-SNS NSE ----- -GbProxy# show ns nsei 1234 -NSEI 01234: UDP, DEAD <1> - FSM Instance Name: 'GPRS-NS2-SNS-BSS(NSE01234-SNS)[0x6120000012a0]', ID: 'NSE01234-SNS' - Log-Level: 'DEBUG', State: 'BSS_SIZE' <2> - Timer: 1 - Maximum number of remote NS-VCs: 8192, IPv4 Endpoints: 8192, IPv6 Endpoints: 8192 - 1 NS-VC: - NSVCI none: DISABLED DYNAMIC data_weight=1 sig_weight=1 udp)[127.0.0.1]:23000<>[127.0.0.1]:22000 ----- -<1> A UDP NSE. A NSE can be ALIVE or DEAD -<2> The SNS state. CONFIGURED and LOCAL_PROCEDURE are ALIVE states - -For description of NSE states see <<ns2-nse-states>>. - -.show ns on a frame relay NSE ----- -OsmoNSdummy# show ns nsei 02001 -NSEI 02001: FR, ALIVE <1> - 4 NS-VC: - NSVCI 00001: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet1 dlci: 16 <2> - NSVCI 00002: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet2 dlci: 17 <3> - NSVCI 00003: DISABLED PERSIST <4> data_weight=1 sig_weight=1 fr)netif: hdlcnet3 dlci: 18 - NSVCI 00004: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet4 dlci: 19 ----- -<1> A FR NSE. A NSE can be ALIVE or DEAD -<2> An unblocked NS-VC will be used for data and signalling. data and signalling weight are only relevant for UDP NSVC. -<3> NSVC is still blocked. -<4> A PERSIST NSVC is a configured via VTY. - -==== Blocking a NSVC - -.how to block a single NSVC ----- -OsmoNSdummy# show ns nsei 01234 -NSEI 01234: UDP, ALIVE since 0d 0h 41m 6s - 2 NS-VC: - NSVCI 01234: UNBLOCKED PERSIST udp)[127.0.0.1]:23000\<1234>[127.0.0.1]:22000 ALIVE since 0d 0h 2m 36s - NSVCI 01235: UNBLOCKED PERSIST udp)[127.0.0.1]:23001\<1235>[127.0.0.1]:22001 ALIVE since 0d 0h 41m 6s - -OsmoNSdummy# nsvc 1234 block -The NS-VC 01234 will be blocked. -OsmoNSdummy# show ns nsei 01234 -NSEI 01234: UDP, ALIVE since 0d 0h 42m 7s - 2 NS-VC: - NSVCI 01234: BLOCKED PERSIST udp)[127.0.0.1]:23000\<1234>[127.0.0.1]:22000 DEAD since 0d 0h 3m 37s - NSVCI 01235: UNBLOCKED PERSIST udp)[127.0.0.1]:23001\<1235>[127.0.0.1]:22001 ALIVE since 0d 0h 42m 7s ----- diff --git a/common/chapters/gb-ns2.adoc b/common/chapters/gb-ns2.adoc index 34943d3..925f515 100644 --- a/common/chapters/gb-ns2.adoc +++ b/common/chapters/gb-ns2.adoc @@ -179,3 +179,320 @@ A NS-VC is always bound to a NSE and the bind (NS-VL). The NSVC can be either persistent or dynamic. + +=== Gb/NS configuration + +This section describes the configuration that libosmogb exposes via the +VTY and is valid for OsmoSGSN and OsmoGbProxy. + +==== Gb over Frame Relay over E1/T1 + +The Gb over Frame Relay over E1/T1 requires: + +* a hdlc interface +* a frame relay role (fr or frnet) +* the DLCI + +.Example: Gb over Frame Relay configuration #1 +---- +ns + bind fr sitea1 <1> + fr hdlc1 frnet <2> + nse 2001 <3> + nsvci fr sitea1 dlci 16 nsvci 11 +---- +<1> a Gb-over-FR bind with the name sitea1 +<2> connect the hdlc1 device with the role frnet to sitea1 +<3> one NSE (2001) with a single NS-VCI 11 on sitea1 with DLCI 16 + +.Example: Gb over Frame Relay configuration #2 +---- +ns + bind fr sitea1 <1> + fr hdlc1 frnet <2> + bind fr sitea2 + fr hdlc2 frnet + bind fr sitea3 + fr hdlc3 frnet + bind fr sitea4 + fr hdlc4 frnet + bind fr siteb1 + fr hdlc5 frnet + bind fr siteb2 + fr hdlc6 frnet + bind fr sitec1 + fr hdlc7 frnet + bind fr sitec2 + fr hdlc8 frnet + nse 2001 <3> + nsvci fr sitea1 dlci 16 nsvci 11 + nsvci fr sitea2 dlci 17 nsvci 12 + nsvci fr sitea3 dlci 18 nsvci 13 + nsvci fr sitea4 dlci 19 nsvci 14 + nse 2002 <4> + nsvci fr siteb5 dlci 20 nsvci 15 + nsvci fr siteb6 dlci 21 nsvci 16 + nse 2003 <5> + nsvc fr sitec7 dlci 22 nsvci 17 + nsvc fr sitec8 dlci 23 nsvci 18 +---- +<1> a Gb-over-FR bind with the name sitea1 +<2> connect the hdlc1 device with the role frnet to sitea1 +<3> one NSE (2001) with four NS-VCI (11..14) on sitea1..4 with their respective DLCI +<4> another NSE (2002) with two NS-VCI (15..16) on siteb1..2 with their respective DLCI +<5> another NSE (2003) with two NS-VCI (17..18) on sitec1..2 with their respective DLCI + + +==== Gb over IP "ip.access style" + +The Gb over IP "ip.access style" can be used with a dynamic configuration or with a +static configuration + +The static configuration requires to configure all endpoints on the BSS and SGSN. +In constrast the dynamic configuration allows the SGSN to have only a reduced configuration. + +===== Gb over IP "ip.access style" dynamic configuration + +.Example: Gb over IP/UDP ip.access style dynamic configuration (SGSN) +---- +ns + bind udp ran1 <1> + listen 10.100.1.1 23000 <2> + accept-ipaccess <3> +---- +<1> create a IP/UDP bind with name ran1 +<2> bind to 10.100.1.1:23000 +<3> accept unknown BSS of ip.access style + +.Example: Gb over IP/UDP "ip.access style" dynamic configuration (GbProxy as BSS) +---- +ns + bind udp ran1 <1> + listen 10.100.0.1 23000 <2> + nse 1001 <3> + nsvc ipa ran1 10.100.1.1 23000 nsvci 1001 +---- +<1> create a IP/UDP bind with name ran1 +<2> bind to 10.100.1.1:23000 +<3> accept unknown BSS of ip.access style + +NOTE: The OsmoPCU supports ip.access style Gb/NS but doesn't support this vty configuration because +it's receiving the configuration from the BTS/BSC. + +===== Gb over IP "ip.access style" static configuration + +.Example: Gb over IP/UDP "ip.access style" static configuration (BSS & SGSN) +---- +ns + bind udp ran1 <1> + listen 10.100.0.1 23000 <2> + nse 1001 <3> + nsvc ipa ran1 10.100.1.1 23000 nsvci 1001 +---- +<1> create a IP/UDP bind with name ran1 +<2> bind to 10.100.0.1:23000 +<3> NSE 1001 with nsvc 1001 as ip.access style + +NOTE: The OsmoPCU supports "ip.access style" Gb/NS but doesn't support this vty configuration because +it's receiving the configuration from the BTS/BSC. + + +==== Gb over IP 3GPP static configuration + +A static IP/UDP configuration without SNS as specified by 3GPP 48.016. + +.Example: Gb over IP/UDP static configuration BSS/SGSN +---- +ns + bind udp ran1 <1> + listen 10.100.0.1 23000 <2> + nse 1001 <3> + nsvc udp ran1 10.100.1.1 23000 signalling-weight 2 data-weight 2 + nsvc udp ran1 10.100.1.2 23000 <4> +---- +<1> create a IP/UDP bind with name ran1 +<2> bind to 10.100.0.1:23000 +<3> add NSE 1001 with 2 NSVC +<4> short configuration with default signalling and data weight of 1 + +==== Gb over IP 3GPP auto configuration as BSS + +IP/UDP auto-configuration with initial endpoints to an SGSN. +The auto-configuration will use the first bind to connect to the +first endpoint. If this fails Osmocom will iterate over all endpoints and binds to find +a working combination. + +.Example: Gb over IP/UDP auto-configuration as BSS +---- +ns + bind udp ran1 <1> + listen 10.100.0.1 23000 <2> + bind udp ran2 + listen 10.100.0.2 23000 + bind udp ran3 + listen 10.100.0.3 23000 + nse 1001 <3> + ip-sns-bind ran1 <4> + ip-sns-bind ran2 + ip-sns-remote 10.100.1.1 23000 <5> + ip-sns-remote 10.100.1.2 23000 +---- +<1> create a IP/UDP bind with name ran1 +<2> bind to 10.100.0.1:23000 +<3> add NSE 1001 with 2 initial SNS endpoints +<4> add ran1 to the list of available endpoints +<5> add 10.100.1.1 as initial endpoint + + +==== Gb/NS Timer configuration + +The NS protocol features a number of configurable timers. + +.List of configurable NS timers +|=== +|tns-block|(un)blocking timer timeout (secs) +|tns-block-retries|(un)blocking timer; number of retries +|tns-reset|reset timer timeout (secs) +|tns-reset-retries|reset timer; number of retries +|tns-test|test timer timeout (secs) +|tns-alive|alive timer timeout (secs) +|tns-alive-retries|alive timer; number of retries +|tsns-prov|SNS provision timeout (secs) used by all SNS auto configuration procedures. +|tsns-size-retries|SNS Size procedure; number of retries +|tsns-config-retries|SNS Config procedure; number of retries +|=== + +All timer can be configured by vty configuration + +.Example of timeouts +---- +ns + timer tns-block 3 + timer tns-block-retries 3 + timer tns-reset 3 + timer tns-reset-retries 3 + timer tns-test 30 + timer tns-alive 3 + timer tns-alive-retries 10 + timer tsns-prov 10 + timer tsns-size-retries 3 + timer tsns-config-retries 3 +---- + +// FIXME: ladder diagrams for every timer + +=== Gb/NS maintenance + +This section describes common maintenance procedures. + +[[ns2-nse-states]] +==== NSE states + +A NSE can have the following states: + +.NSE states +* ALIVE +* DEAD + +For FR, IPA: The NSE is ALIVE if there is at least one NSVC in state UNBLOCKED. +For IP-SNS/UDP: The NSE is ALIVE if there is at least one NSVC ALIVE and the sum of all ALIVE NSVCs signalling weights > 0 and data weights > 0. + +The state of the NSE is shown by vty. + +.show ns +---- +GbProxy# show ns nsei 1234 +NSEI 01234: UDP, DEAD <1> + FSM Instance Name: 'GPRS-NS2-SNS-BSS(NSE01234-SNS)[0x6120000012a0]', ID: 'NSE01234-SNS' + Log-Level: 'DEBUG', State: 'BSS_SIZE' + Timer: 1 + Maximum number of remote NS-VCs: 8192, IPv4 Endpoints: 8192, IPv6 Endpoints: 8192 + 1 NS-VC: + NSVCI none: DISABLED DYNAMIC data_weight=1 sig_weight=1 udp)[127.0.0.1]:23000<>[127.0.0.1]:22000 +---- +<1> NSE state + +==== NSVC states + +A NSVC can have the following states: + +.nsvc states +[options="header"] +|========================================================= +| State | transport UNITDATA | Description + +| DISABLED | No | Either the transport layer is unavailable (FR) or this NSVC is currently used by IP-SNS dynamic configuration. +| RESET | No | Sending out RESET PDU and awaiting data. +| BLOCKED | No* | The NSVC has been BLOCKED. * see 3GPP TS 48.016 § 7.2 exception +| UNBLOCKED/ALIVE | Yes | The NSVC transport UNITDATA. +| RECOVERING | No | The NSVC test procedure timed out. NSVC type is a IP-SNS which don't use RESET/BLOCK/UNBLOCK. + +|========================================================= + +[[fig-nsvc-states-reset-block]] +.Simplified state diagram for RESET BLOCK UNBLOCK NSVCs +[graphviz] +---- +include::gb-ns2-nsvc-states-reset-block.dot[] +---- + +[[fig-nsvc-states-alive]] +.Simplified state diagram for IP-SNS/UDP +[graphviz] +---- +include::gb-ns2-nsvc-states-alive.dot[] +---- + +==== Show information of a specific NSE + +The NSE 1234 has been configured for as BSS with IP-SNS configuration. + +.show ns on a dynamic configured IP-SNS NSE +---- +GbProxy# show ns nsei 1234 +NSEI 01234: UDP, DEAD <1> + FSM Instance Name: 'GPRS-NS2-SNS-BSS(NSE01234-SNS)[0x6120000012a0]', ID: 'NSE01234-SNS' + Log-Level: 'DEBUG', State: 'BSS_SIZE' <2> + Timer: 1 + Maximum number of remote NS-VCs: 8192, IPv4 Endpoints: 8192, IPv6 Endpoints: 8192 + 1 NS-VC: + NSVCI none: DISABLED DYNAMIC data_weight=1 sig_weight=1 udp)[127.0.0.1]:23000<>[127.0.0.1]:22000 +---- +<1> A UDP NSE. A NSE can be ALIVE or DEAD +<2> The SNS state. CONFIGURED and LOCAL_PROCEDURE are ALIVE states + +For description of NSE states see <<ns2-nse-states>>. + +.show ns on a frame relay NSE +---- +OsmoNSdummy# show ns nsei 02001 +NSEI 02001: FR, ALIVE <1> + 4 NS-VC: + NSVCI 00001: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet1 dlci: 16 <2> + NSVCI 00002: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet2 dlci: 17 <3> + NSVCI 00003: DISABLED PERSIST <4> data_weight=1 sig_weight=1 fr)netif: hdlcnet3 dlci: 18 + NSVCI 00004: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet4 dlci: 19 +---- +<1> A FR NSE. A NSE can be ALIVE or DEAD +<2> An unblocked NS-VC will be used for data and signalling. data and signalling weight are only relevant for UDP NSVC. +<3> NSVC is still blocked. +<4> A PERSIST NSVC is a configured via VTY. + +==== Blocking a NSVC + +.how to block a single NSVC +---- +OsmoNSdummy# show ns nsei 01234 +NSEI 01234: UDP, ALIVE since 0d 0h 41m 6s + 2 NS-VC: + NSVCI 01234: UNBLOCKED PERSIST udp)[127.0.0.1]:23000\<1234>[127.0.0.1]:22000 ALIVE since 0d 0h 2m 36s + NSVCI 01235: UNBLOCKED PERSIST udp)[127.0.0.1]:23001\<1235>[127.0.0.1]:22001 ALIVE since 0d 0h 41m 6s + +OsmoNSdummy# nsvc 1234 block +The NS-VC 01234 will be blocked. +OsmoNSdummy# show ns nsei 01234 +NSEI 01234: UDP, ALIVE since 0d 0h 42m 7s + 2 NS-VC: + NSVCI 01234: BLOCKED PERSIST udp)[127.0.0.1]:23000\<1234>[127.0.0.1]:22000 DEAD since 0d 0h 3m 37s + NSVCI 01235: UNBLOCKED PERSIST udp)[127.0.0.1]:23001\<1235>[127.0.0.1]:22001 ALIVE since 0d 0h 42m 7s +---- -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I3c618e5af61b376435f400ef9c64245cec2f9b73 Gerrit-Change-Number: 30357 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: add MNCC handler selection to settings

by fixeria

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30326 ) Change subject: mobile: add MNCC handler selection to settings ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: > Typo in commit message: extarnal Done. Also fixed s/potentionally/potentially/. File src/host/layer23/src/mobile/app_mobile.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30326/comment/50b67a02_8a8bb98a PS1, Line 249: ms->mncc_entity.sock_state = mncc_sock_init(ms, ms->settings.mncc_socket_path); > So sock_state is used only if mncc_handler is "EXTERNAL"? Then better put it under ms->mncc_entity. […] There is a big room for improvements here, given that this project is not actively maintained since... idk how many years ago. I am not going to rework the existing mobile's structures unless it's really necessary. Feel free to submit a patch. File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30326/comment/34677460_cbf31875 PS1, Line 1665: DEFUN(cfg_ms_no_mncc_handler, cfg_ms_no_mncc_handler_cmd, > ACK, specifying the default above in the description (like you did) should be enough for the user to […] To stay consistent with the existing 'io-handler', which has both variants. I can remove the no-command if you guys insist, but honestly I see nothing wrong in having two variants. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2df91c7a79ba5c39bc6ceae900ef649129dd0346 Gerrit-Change-Number: 30326 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:49:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add OML tests for bts_setup_ramp

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356 ) Change subject: BSC_Tests: add OML tests for bts_setup_ramp ...................................................................... BSC_Tests: add OML tests for bts_setup_ramp The current BSC_Tests are using osmo-bts-omldummy to keep OML out of the test context. Add a new test file and component for OML tests. Change-Id: I0934ea26db359b0a6649c613f01de134a3a372ee --- M bsc/BSC_Tests.cfg A bsc/BSC_Tests_OML.ttcn M bsc/gen_links.sh M bsc/regen_makefile.sh 4 files changed, 377 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/30356/1 diff --git a/bsc/BSC_Tests.cfg b/bsc/BSC_Tests.cfg index 5765846..5ac91b6 100644 --- a/bsc/BSC_Tests.cfg +++ b/bsc/BSC_Tests.cfg @@ -18,6 +18,7 @@ BSC_Tests.control BSC_Tests_LCLS.control BSC_Tests_CBSP.control +#BSC_Tests_OML.control #BSC_Tests.TC_chan_act_noreply #BSC_Tests.TC_chan_act_ack_noest #BSC_Tests.TC_chan_act_ack_est_ind_noreply diff --git a/bsc/BSC_Tests_OML.ttcn b/bsc/BSC_Tests_OML.ttcn new file mode 100644 index 0000000..06bff9f --- /dev/null +++ b/bsc/BSC_Tests_OML.ttcn @@ -0,0 +1,374 @@ +module BSC_Tests_OML { + +/* Integration Tests for OsmoBTS A-bis OML (Organization & Maintenance Link) + * + * (C) 2019 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * Author: Alexander Couzens <acouzens(a)sysmocom.de> + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +/* The tests only require a BSC with VTY and OML to be present. */ + +import from General_Types all; +import from Osmocom_Types all; +import from AbisOML_Types all; +import from IPA_Emulation all; +import from IPA_Types all; +import from Misc_Helpers all; +import from Osmocom_VTY_Functions all; +import from TELNETasp_PortType all; + +import from BSC_Tests all; + +const integer NUM_TRX := 8; + +type record of uint16_t ArfcnList; +type record length(3) of IPA_CCM_Parameters IPA_CCM_Parameters_multiple; + +modulepar { + charstring mp_oml_ip := "127.0.0.1"; + integer mp_oml_port := 3002; + ArfcnList mp_arfcn := { 100, 101, 102, 103, 104, 105, 106, 107 }; + OML_FOM_T200 mp_t200 := { + sdcch_5ms := 30, + facch_f_5ms := 36, + facch_h_5ms := 36, + sacch_tch_sapi0_10ms := 168, + sacch_sdcch_10ms := 52, + sdcch_sapi3_5ms := 33, + sacch_rch_sapi3_10ms := 168 + }; + uint8_t mp_max_ta := 63; + uint8_t mp_load_threshold := 10; + uint8_t mp_load_ind_period := 1; + uint8_t mp_rach_b_thresh := 90; + uint16_t mp_loadavg_slots := 1000; + uint8_t mp_air_timer := 100; + uint8_t mp_ny1 := 10; + uint8_t mp_bsic := 63; + + IPA_CCM_Parameters_multiple mp_ccm_pars := { + { + ser_nr := "", + name := "", + location1 := "", + location2 := "", + equip_version := "", + sw_version := "", + ip_addr := "", + mac_addr := "", + unit_id := "1234/0/0", + osmo_rand := "" + }, + { + ser_nr := "", + name := "", + location1 := "", + location2 := "", + equip_version := "", + sw_version := "", + ip_addr := "", + mac_addr := "", + unit_id := "1235/0/0", + osmo_rand := "" + }, + { + ser_nr := "", + name := "", + location1 := "", + location2 := "", + equip_version := "", + sw_version := "", + ip_addr := "", + mac_addr := "", + unit_id := "1236/0/0", + osmo_rand := "" + } + }; +}; + +/* BSC side OML component */ +type component BTS_OML_CT { + /* IPA client */ + var IPA_Client client[3]; + + /* Port for OML */ + port IPA_OML_PT OML[3]; + + /* VTY */ + port TELNETasp_PT BSCVTY; + + /* As rxed by Get Attributes Response NM_ATT_MANUF_ID IE, see f_oml_getattr() */ + var bitstring g_bts_features[3]; + + /* global test case guard timer */ + timer T_oml_guard := 60.0; +}; + +private altstep as_Tguard() runs on BTS_OML_CT { + [] T_oml_guard.timeout { + setverdict(fail, "Timeout of T_guard"); + mtc.stop; + } +} + +private altstep as_IPA_evt(integer idx := 0) runs on BTS_OML_CT { + var ASP_IPA_Event evt; + [] OML[idx].receive(ASP_IPA_Event:?) -> value evt { + log("Ignoring ", evt); + repeat; + } +} + +function f_init_vty() runs on BTS_OML_CT { + if (BSCVTY.checkstate("Mapped")) { + /* skip initialization if already executed once */ + return; + } + map(self:BSCVTY, system:BSCVTY); + f_vty_set_prompts(BSCVTY); + f_vty_transceive(BSCVTY, "enable"); + + f_vty_enter_config(BSCVTY); + f_vty_transceive(BSCVTY, "bsc"); + f_vty_transceive(BSCVTY, "no bts-setup-ramping"); + f_vty_transceive(BSCVTY, "end"); +} + +function f_init_oml(charstring id, integer num_instance := 1) runs on BTS_OML_CT { + activate(as_Tguard()); + for (var uint8_t idx := 0; idx < num_instance; idx := idx + 1) { + client[idx].id := id & "-" & int2str(idx); + client[idx].vc_IPA := IPA_Emulation_CT.create(id & "-IPA-" & int2str(idx)) alive; + client[idx].ccm_pars := mp_ccm_pars[idx]; + + map(client[idx].vc_IPA:IPA_PORT, system:IPA); + connect(client[idx].vc_IPA:IPA_OML_PORT, self:OML[idx]); + client[idx].vc_IPA.start(IPA_Emulation.main_client(mp_oml_ip, mp_oml_port, "", 10000 + idx, client[idx].ccm_pars)); + + T_oml_guard.start; + + OML[idx].receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_UP)); + OML[idx].receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_ID_ACK)); + + activate(as_IPA_evt(idx)); + } +} + +function f_oml_send_swact(integer idx := 0) runs on BTS_OML_CT +{ + OML[idx].send(ts_OML_SwActivatedRep(NM_OC_SITE_MANAGER, {255, 255, 255})); + OML[idx].send(ts_OML_SwActivatedRep(NM_OC_BTS, {0, 255, 255})); + OML[idx].send(ts_OML_SwActivatedRep(NM_OC_BASEB_TRANSC, {0, 0, 255})); + OML[idx].send(ts_OML_SwActivatedRep(NM_OC_RADIO_CARRIER, {0, 0, 255})); + for (var uint8_t i := 0; i < 8; i := i + 1) { + OML[idx].send(ts_OML_SwActivatedRep(NM_OC_CHANNEL, {0, 0, i})); + } +} + +function f_oml_send_state_chg_evt_rep( + integer idx, + template (value) OML_FOM_OperationalState opstate, + template (value) OML_FOM_AvailabilityStatus avstate) runs on BTS_OML_CT +{ + OML[idx].send(ts_OML_StateChgEvtRep(NM_OC_SITE_MANAGER, {255, 255, 255}, opstate, avstate)); + OML[idx].send(ts_OML_StateChgEvtRep(NM_OC_BTS, {0, 255, 255}, opstate, avstate)); + OML[idx].send(ts_OML_StateChgEvtRep(NM_OC_BASEB_TRANSC, {0, 0, 255}, opstate, avstate)); + OML[idx].send(ts_OML_StateChgEvtRep(NM_OC_RADIO_CARRIER, {0, 0, 255}, opstate, avstate)); + for (var uint8_t i := 0; i < 8; i := i + 1) { + OML[idx].send(ts_OML_StateChgEvtRep(NM_OC_CHANNEL, {0, 0, i}, opstate, avstate)); + } +} + + +/* Send an OML message and expect no response at all */ +private function f_oml_send_exp_no_resp(template (value) OML_PDU tx, charstring err_msg, + float tout := 5.0, integer idx := 0) runs on BTS_OML_CT +{ + timer T := tout; + + OML[idx].send(tx); + T.start; + alt { + [] OML[idx].receive { + setverdict(fail, err_msg); + } + [] T.timeout { + setverdict(pass); + } + } +} + +private function f_oml_exp_rx(template OML_PDU exp_rx, charstring err_msg, integer idx := 0) + runs on BTS_OML_CT return OML_PDU +{ + var OML_PDU rx; + timer T := 5.0; + + T.start; + alt { + [] OML[idx].receive(exp_rx) -> value rx { + setverdict(pass); + } + [] OML[idx].receive { repeat; } + [] T.timeout { + setverdict(fail, "Timeout waiting for ", err_msg); + } + } + return rx; +} + +/* Send an OML message and expect a failure event report in response */ +private function f_oml_send_exp_fail_rep(template (value) OML_PDU tx, charstring err_msg, + template OML_FOM_EventType evt := ?, + template OML_FOM_Severity severity := ?, + template OML_FOM_ProbableCause cause := ?, + float tout := 5.0, integer idx := 0) runs on BTS_OML_CT +{ + var template OML_FOM_ObjectClass obj_class := ?; + var template OML_FOM_ObjectInstance obj_inst := ?; + if (ischosen(tx.u.fom)) { + obj_class := tx.u.fom.hdr.obj_class; + obj_inst := tx.u.fom.hdr.obj_inst; + } + var template OML_PDU exp_fail := tr_OML_FailureEvtRep(obj_class,obj_inst, evt, severity, cause); + + OML[idx].send(tx); + f_oml_exp_rx(exp_fail, "Failure Event Report"); +} + +/* Send an OML message and expect it to be NACKed with specified cause */ +private function f_oml_send_exp_nack(template (value) OML_PDU tx, template OML_FOM_NackCause exp_cause, + float tout := 5.0, integer idx := 0) runs on BTS_OML_CT +{ + timer T := 5.0; + + var template OML_PDU exp_nack := f_OML_make_nack_exp(valueof(tx), exp_cause); + var template OML_PDU exp_ack := f_OML_make_ack_exp(valueof(tx)); + var OML_PDU rx; + + OML[idx].send(tx); + T.start; + alt { + [] OML[idx].receive(exp_ack) -> value rx { + setverdict(fail, "Unexpected ACK ", rx); + } + [] OML[idx].receive(exp_nack) -> value rx { + setverdict(pass); + } + [] OML[idx].receive { repeat; } + [] T.timeout { + setverdict(fail, "Timeout waiting for NACK ", exp_nack); + } + } +} + +testcase TC_oml_nothing() runs on BTS_OML_CT { + f_init_oml(testcasename()); + f_sleep(40.0); + setverdict(pass); +} + +/* Test bts setup ramping. + * Enable bts setup ramping (limit how many BTS will be setuped within a time interval. + * 1. Send 3x BTS to configure + * 2. Wait until BTS0 and BTS1 is configured (need both to be sure, when the bts setup ramp interval got restartet). + * 3. BTS2 must setup within a time window (it should be 10 seconds, but have -+ 3 seconds to be on the save side). + */ +testcase TC_oml_bts_setup_ramp() runs on BTS_OML_CT { + var template (value) OML_PDU ts_nm_site_change_event := ts_OML_StateChgEvtRep(NM_OC_SITE_MANAGER, {255, 255, 255}, NM_OPSTATE_DISABLED, NM_AVSTATE_OFF_LINE); + var template OML_PDU tr_nm_site_op_start := tr_OML_Opstart(NM_OC_SITE_MANAGER, {255, 255, 255}); + + f_init_vty(); + + f_vty_enter_config(BSCVTY); + f_vty_transceive(BSCVTY, "bsc"); + f_vty_transceive(BSCVTY, "bts-setup-ramping"); + f_vty_transceive(BSCVTY, "bts-setup-ramping-step-size 1"); + f_vty_transceive(BSCVTY, "bts-setup-ramping-step-interval 10"); + f_vty_transceive(BSCVTY, "end"); + + f_init_oml(testcasename(), 3); + + f_oml_send_swact(0); + f_oml_send_swact(1); + f_oml_send_swact(2); + f_sleep(1.0); + OML[0].send(ts_nm_site_change_event); + OML[1].send(ts_nm_site_change_event); + OML[2].send(ts_nm_site_change_event); + OML[0].receive(tr_nm_site_op_start); + + /* OML[2]: we expect at least no OP start for 7 seconds */ + timer T_no_op := 7.0; + /* OML[2] we expect at least the OP start within 13 seconds */ + timer T_op := 13.0; + alt { + [] OML[1].receive(tr_nm_site_op_start) { T_no_op.start; T_op.start; repeat; } + [] OML[2].receive(tr_nm_site_op_start) { + if (T_no_op.running) { + setverdict(fail, "OP Start came to early. T_no_op is still running"); + } else if (T_op.running) { + setverdict(pass); + } else { + setverdict(fail, "OP Start came far too early."); + } + } + [] T_op.timeout { setverdict(fail, "Timeout. No OP Start PDU for OML[2]."); } + } +} + +control { + /* execute( TC_oml_nothing() ); */ + execute( TC_oml_bts_setup_ramp() ); +} + +/* BTS: + * - Evt: Disabled/Locked + * - SW ACT + * - Evt: Disabled/Dependency + * - SET BTS ATTR + * - Opstart + * - Chg Adm State Unlocked + * - Evt: Disabled/Dependency/Unlocked + * - Evt: Enabled/0 (after last channel unlocked?) + */ + +/* Radio Carrier: + * - Evt: Disabled/Offline after SW ACT + * - Set Radio Carrier Attributes ? (->NACL) + * - Evt: Disabled/Dependency + * - Set Radio Carrier Attributes ? + * - Opstart + * - Chg Adm State Unlocked + * - Evt: + */ + +/* Baseband Transceiver: + * - Evt: Disabled/Locked + * - SW Activation + * - Evt: Disabled/Dependency after SW ACT + * - IPA RSL Connect + * - Opstart + * - Chg Admin Unlocked + * - Evt: Disabled/Dependency/Unlocked + */ + +/* Channel: + * - Evt: Not Installed/Locked + * - Evt: Disabled/Dependency (after SW ACT Rep on BB Transc) + * - Set Channel Attr + * - Opstart + * - Evt: Disabled/Offline + * - Chg Admin Unlocked + * - Evt: Disabled/OK/Unlocked + * - Evt: Enabled/OK (after BB TRANSC Opstart) + */ + +}; diff --git a/bsc/gen_links.sh b/bsc/gen_links.sh index f316509..538824d 100755 --- a/bsc/gen_links.sh +++ b/bsc/gen_links.sh @@ -72,6 +72,7 @@ FILES+="CBSP_CodecPort.ttcn CBSP_CodecPort_CtrlFunct.ttcn CBSP_CodecPort_CtrlFunctdef.cc CBSP_Adapter.ttcn " FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcn " FILES+="BSSAP_LE_CodecPort.ttcn BSSAP_LE_Emulation.ttcn BSSAP_LE_Types.ttcn BSSAP_LE_Adapter.ttcn BSSLAP_Types.ttcn BSSMAP_LE_Templates.ttcn " +FILES+="AbisOML_Types.ttcn" gen_links $DIR $FILES diff --git a/bsc/regen_makefile.sh b/bsc/regen_makefile.sh index 9e69bef..fc53e30 100755 --- a/bsc/regen_makefile.sh +++ b/bsc/regen_makefile.sh @@ -27,6 +27,7 @@ -DIPA_EMULATION_CTRL -DIPA_EMULATION_MGCP -DIPA_EMULATION_RSL + -DIPA_EMULATION_OML -DIPA_EMULATION_SCCP -DRAN_EMULATION_BSSAP -DRAN_EMULATION_CTRL -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0934ea26db359b0a6649c613f01de134a3a372ee Gerrit-Change-Number: 30356 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: implement Ready-to-Receive PHYIF API

by Hoernchen

Attention is currently required from: fixeria, msuraev. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30262 ) Change subject: trxcon: implement Ready-to-Receive PHYIF API ...................................................................... Patch Set 2: (1 comment) File src/host/trxcon/src/sched_trx.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30262/comment/f1cb3baa_aad3999c PS2, Line 832: probe->flags |= L1SCHED_PROBE_F_ACTIVE; The unexpected part here is that is ors the flags. I as the caller know this is the passed _output_ arg, so I expect the function to set it. Right now the caller needs to initialize the output arg so random crap does not get "or"ed, which is unexpected... -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9a71b8a59733f4dd908b760c5e23ea3d624afb1a Gerrit-Change-Number: 30262 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:35:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: l1ctl_tx_traffic_req(): cosmetic: drop dead code

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30324 ) Change subject: layer23: l1ctl_tx_traffic_req(): cosmetic: drop dead code ...................................................................... layer23: l1ctl_tx_traffic_req(): cosmetic: drop dead code Change-Id: I941899ab27282a495f965ae9a0f41076dceef953 Related: OS#5599 --- M src/host/layer23/src/common/l1ctl.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c index d520403..ae7be6e 100644 --- a/src/host/layer23/src/common/l1ctl.c +++ b/src/host/layer23/src/common/l1ctl.c @@ -910,8 +910,6 @@ DEBUGP(DL1C, "TRAFFIC REQ len=%zu (%s)\n", frame_len, osmo_hexdump(frame, frame_len)); -// printf("TX %s\n", osmo_hexdump(frame, frame_len)); - /* prepend uplink info header */ l1i_ul = (struct l1ctl_info_ul *) msgb_push(msg, sizeof(*l1i_ul)); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I941899ab27282a495f965ae9a0f41076dceef953 Gerrit-Change-Number: 30324 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: add MNCC socket path to settings

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30325 ) Change subject: mobile: add MNCC socket path to settings ...................................................................... mobile: add MNCC socket path to settings Previously the MNCC socket path was generated automatically, using concatenation of the '/tmp/ms_mncc_' prefix and MS name. Let's allow the user to specify this manually, keeping the same naming generation method for default value. Change-Id: I643356ac579bc5e765f668265ec803b22a73739c Related: OS#3400 --- M doc/examples/mobile/default.cfg M doc/examples/mobile/multi_ms.cfg M src/host/layer23/include/osmocom/bb/mobile/settings.h M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/settings.c M src/host/layer23/src/mobile/vty_interface.c 6 files changed, 33 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/doc/examples/mobile/default.cfg b/doc/examples/mobile/default.cfg index f14e900..d78bef5 100644 --- a/doc/examples/mobile/default.cfg +++ b/doc/examples/mobile/default.cfg @@ -14,6 +14,7 @@ ms 1 layer2-socket /tmp/osmocom_l2 sap-socket /tmp/osmocom_sap + mncc-socket /tmp/ms_mncc_1 sim reader network-selection-mode auto imei 000000000000000 0 diff --git a/doc/examples/mobile/multi_ms.cfg b/doc/examples/mobile/multi_ms.cfg index c72817f..4ccdb10 100644 --- a/doc/examples/mobile/multi_ms.cfg +++ b/doc/examples/mobile/multi_ms.cfg @@ -14,6 +14,7 @@ ms one layer2-socket /tmp/osmocom_l2.one sap-socket /tmp/osmocom_sap.one + mncc-socket /tmp/ms_mncc_one sim reader network-selection-mode auto imei 000000000000000 0 @@ -66,6 +67,7 @@ ms two layer2-socket /tmp/osmocom_l2.two sap-socket /tmp/osmocom_sap.two + mncc-socket /tmp/ms_mncc_two sim reader network-selection-mode auto imei 000000000000000 0 diff --git a/src/host/layer23/include/osmocom/bb/mobile/settings.h b/src/host/layer23/include/osmocom/bb/mobile/settings.h index 57f23ee..6f4f59c 100644 --- a/src/host/layer23/include/osmocom/bb/mobile/settings.h +++ b/src/host/layer23/include/osmocom/bb/mobile/settings.h @@ -22,6 +22,7 @@ struct gsm_settings { char layer2_socket_path[128]; char sap_socket_path[128]; + char mncc_socket_path[128]; /* Audio settings */ struct audio_settings audio; diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index 7b28bb4..5016582 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -269,6 +269,14 @@ *other_name = tmp->name; return -2; } + if (!strcmp(ms->settings.mncc_socket_path, + tmp->settings.mncc_socket_path)) { + LOGP(DMOB, LOGL_ERROR, "Cannot start MS '%s', because MS '%s' " + "is using the same mncc-socket.\nPlease shutdown " + "MS '%s' first.\n", ms->name, tmp->name, tmp->name); + *other_name = tmp->name; + return -3; + } } rc = mobile_init(ms); @@ -291,7 +299,6 @@ struct osmocom_ms *mobile_new(char *name) { static struct osmocom_ms *ms; - char *mncc_name; ms = talloc_zero(l23_ctx, struct osmocom_ms); if (!ms) { @@ -313,12 +320,8 @@ mobile_set_shutdown(ms, MS_SHUTDOWN_COMPL); if (mncc_recv_app) { - mncc_name = talloc_asprintf(ms, "/tmp/ms_mncc_%s", ms->name); - ms->mncc_entity.mncc_recv = mncc_recv_app; - ms->mncc_entity.sock_state = mncc_sock_init(ms, mncc_name); - - talloc_free(mncc_name); + ms->mncc_entity.sock_state = mncc_sock_init(ms, ms->settings.mncc_socket_path); } else if (ms->settings.ch_cap == GSM_CAP_SDCCH) ms->mncc_entity.mncc_recv = mncc_recv_dummy; else diff --git a/src/host/layer23/src/mobile/settings.c b/src/host/layer23/src/mobile/settings.c index 23da620..769fad6 100644 --- a/src/host/layer23/src/mobile/settings.c +++ b/src/host/layer23/src/mobile/settings.c @@ -28,6 +28,7 @@ static char *layer2_socket_path = "/tmp/osmocom_l2"; static char *sap_socket_path = "/tmp/osmocom_sap"; +static char *mncc_socket_path = "/tmp/ms_mncc"; int gsm_settings_init(struct osmocom_ms *ms) { @@ -37,6 +38,10 @@ strcpy(set->layer2_socket_path, layer2_socket_path); strcpy(set->sap_socket_path, sap_socket_path); + /* Compose MNCC socket path using MS name */ + snprintf(set->mncc_socket_path, sizeof(set->mncc_socket_path) - 1, + "%s_%s", mncc_socket_path, ms->name); + /* Audio settings: drop TCH frames by default */ set->audio.io_handler = AUDIO_IOH_NONE; diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index d6f6cd1..7c757a6 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -1324,6 +1324,7 @@ vty_out(vty, " layer2-socket %s%s", set->layer2_socket_path, VTY_NEWLINE); vty_out(vty, " sap-socket %s%s", set->sap_socket_path, VTY_NEWLINE); + vty_out(vty, " mncc-socket %s%s", set->mncc_socket_path, VTY_NEWLINE); switch(set->sim_type) { case GSM_SIM_TYPE_NONE: vty_out(vty, " sim none%s", VTY_NEWLINE); @@ -1604,6 +1605,19 @@ return CMD_SUCCESS; } +DEFUN(cfg_ms_mncc, cfg_ms_mncc_cmd, "mncc-socket PATH", + "Define socket path for the MNCC interface\n" + "UNIX socket path (default '/tmp/ms_mncc_' + MS_NAME)") +{ + struct osmocom_ms *ms = vty->index; + struct gsm_settings *set = &ms->settings; + + OSMO_STRLCPY_ARRAY(set->mncc_socket_path, argv[0]); + + vty_restart(vty, ms); + return CMD_SUCCESS; +} + DEFUN(cfg_ms_sim, cfg_ms_sim_cmd, "sim (none|reader|test|sap)", "Set SIM card to attach when powering on\nAttach no SIM\n" "Attach SIM from reader\nAttach build in test SIM\n" @@ -2933,6 +2947,7 @@ install_element(MS_NODE, &cfg_ms_show_this_cmd); install_element(MS_NODE, &cfg_ms_layer2_cmd); install_element(MS_NODE, &cfg_ms_sap_cmd); + install_element(MS_NODE, &cfg_ms_mncc_cmd); install_element(MS_NODE, &cfg_ms_sim_cmd); install_element(MS_NODE, &cfg_ms_mode_cmd); install_element(MS_NODE, &cfg_ms_imei_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I643356ac579bc5e765f668265ec803b22a73739c Gerrit-Change-Number: 30325 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: add MNCC socket path to settings

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30325 ) Change subject: mobile: add MNCC socket path to settings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I643356ac579bc5e765f668265ec803b22a73739c Gerrit-Change-Number: 30325 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:19:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible inventory: we don't have slaves on admin2 for a long time

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30354 ) Change subject: ansible inventory: we don't have slaves on admin2 for a long time ...................................................................... ansible inventory: we don't have slaves on admin2 for a long time Change-Id: Ib5f07f7d854220bd006079b49af701c13d93b7bd --- M ansible/hosts 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/54/30354/1 diff --git a/ansible/hosts b/ansible/hosts index e1756be..0d965fa 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -3,12 +3,10 @@ osmo-gsm-tester-prod ansible_host=10.9.25.107 [coverity-slaves] -admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300 build2-deb9build-ansible ansible_host=2a01:4f8:10b:2ad9::1:6 host2-deb9build-ansible ansible_host=2a01:4f8:120:8470::1:3 [jenkins-slaves] -admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300 osmocom_jenkins_slave_fstrim=True build2-deb9build-ansible ansible_host=2a01:4f8:10b:2ad9::1:6 osmocom_jenkins_slave_fstrim=True build2-deb10build-ansible ansible_host=2a01:4f8:10b:2ad9::1:10 osmocom_jenkins_slave_fstrim=True build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 osmocom_jenkins_slave_fstrim=True -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib5f07f7d854220bd006079b49af701c13d93b7bd Gerrit-Change-Number: 30354 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible inventory: We have recently killed gtp0-deb11build-i586

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30355 ) Change subject: ansible inventory: We have recently killed gtp0-deb11build-i586 ...................................................................... ansible inventory: We have recently killed gtp0-deb11build-i586 Change-Id: I15cb177e75f73fb8a06b17e42c99a6b573dc7574 --- M ansible/hosts 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/55/30355/1 diff --git a/ansible/hosts b/ansible/hosts index 0d965fa..0ff7cd4 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -15,7 +15,6 @@ host2-deb11build-ansible ansible_host=2a01:4f8:120:8470::1:4 osmocom_jenkins_slave_fstrim=True gtp0-deb9build ansible_host=10.34.2.102 osmocom_jenkins_slave_fstrim=True gtp0-deb10build ansible_host=10.34.2.101 osmocom_jenkins_slave_fstrim=True -gtp0-deb11build-i586 ansible_host=10.34.2.104 osmocom_jenkins_slave_fstrim=True rpi4-raspbian11build-ansible-1 ansible_host=10.9.25.50 docker_max_image_space="20 GB" rpi4-raspbian11build-ansible-2 ansible_host=10.9.25.60 docker_max_image_space="20 GB" rpi4-raspbian11build-ansible-3 ansible_host=10.9.25.70 docker_max_image_space="20 GB" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I15cb177e75f73fb8a06b17e42c99a6b573dc7574 Gerrit-Change-Number: 30355 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in libosmocore[master]: osmo-ns-dummy: add ctrl interface

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30300 ) Change subject: osmo-ns-dummy: add ctrl interface ...................................................................... Patch Set 1: (2 comments) File utils/osmo-ns-dummy.c: https://gerrit.osmocom.org/c/libosmocore/+/30300/comment/760e455d_5185f23f PS1, Line 56: Set the ctrl port to listen on spacing issues https://gerrit.osmocom.org/c/libosmocore/+/30300/comment/aef21d32_ecf7947c PS1, Line 286: return -1; exit(1), like it's done above -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If6e06d9433e438b92f1ed1ef0f892308e031779b Gerrit-Change-Number: 30300 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:08:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Replace reqs waiting for retransmission with new incoming ini...

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30347 ) Change subject: paging: Replace reqs waiting for retransmission with new incoming inital req if queue is full ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/ee3eee7b_82e4b455 PS1, Line 14: is it . https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/160daa10_655e3584 PS1, Line 16: than that Patchset: PS2: The description of X3113 in the vty doc needs to change now, right? because we no longer drop new paging requests but rather attempt to drop retransmissions of paging? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d Gerrit-Change-Number: 30347 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 15:59:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Introduce VTY configurable X3113 (Maximum Paging Request Tran...

by neels

Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30345 ) Change subject: paging: Introduce VTY configurable X3113 (Maximum Paging Request Transmit Delay Threshold) ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File src/osmo-bsc/net_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/92d8f4c9_0fe37eb5 PS1, Line 78: PAGING_THRESHOLD_X3113_DEFAULT_SEC > I prefer keeping it in a define in paging. […] IMHO write "see X3113"; we can agree to disagree File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/406131fc_24ad99c8 PS1, Line 415: struct osmo_tdef *td_x3113 > const Done https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/fa41ef74_71b8f3e9 PS1, Line 415: struct osmo_tdef *td_x3113 = osmo_tdef_get_entry(bts->network->T_defs, -3113); > actually it is documented […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia556ef4e474e6a2d0d1618bab680a3330a3c062b Gerrit-Change-Number: 30345 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 15:58:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in libosmocore[master]: osmo_tdef_get(): clarify API doc on val_if_not_present

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30353 ) Change subject: osmo_tdef_get(): clarify API doc on val_if_not_present ...................................................................... osmo_tdef_get(): clarify API doc on val_if_not_present Change-Id: I2301aad86d6d165a3b51c6849bcd8fe02972e0a3 --- M src/tdef.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tdef.c b/src/tdef.c index 7741a44..abbe581 100644 --- a/src/tdef.c +++ b/src/tdef.c @@ -200,8 +200,10 @@ * \param[in] tdefs Array of timer definitions, last entry must be fully zero initialized. * \param[in] T Timer number to get the value for. * \param[in] as_unit Return timeout value in this unit. - * \param[in] val_if_not_present Fallback value to return if no timeout is defined. + * \param[in] val_if_not_present Fallback value to return if no timeout is defined; if this is a negative number, a + * missing T timer definition aborts the program via OSMO_ASSERT(). * \return Timeout value in the unit given by as_unit, rounded up if necessary, or val_if_not_present. + * If val_if_not_present is negative and no T timer is defined, trigger OSMO_ASSERT() and do not return. */ unsigned long osmo_tdef_get(const struct osmo_tdef *tdefs, int T, enum osmo_tdef_unit as_unit, long val_if_not_present) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30353 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2301aad86d6d165a3b51c6849bcd8fe02972e0a3 Gerrit-Change-Number: 30353 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-pcu[master]: pdch: Initial support Handling PktResReq with ID_TYPE=UL/DL_TFI

by lynxis lazus

Attention is currently required from: pespin, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30293 ) Change subject: pdch: Initial support Handling PktResReq with ID_TYPE=UL/DL_TFI ...................................................................... Patch Set 3: (3 comments) Patchset: PS3: LGTM except our linter is sleeping again. I guess we don't have tttcn3 or unit tests covering this? File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30293/comment/a5548643_fdbdd6b0 PS3, Line 740: /* If MS identified by TLLI sent us a PktResReq through SBA, it means it came some small indention errors. https://gerrit.osmocom.org/c/osmo-pcu/+/30293/comment/08131f92_521a143b PS3, Line 750: /* Similarly, it is for sure not using any DL-TBF. We some small indention errors. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie6b1b438d26cd977f88ddb4eff6b3041e0739d92 Gerrit-Change-Number: 30293 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 15:49:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: vty: Fix lost 'no timer-dynamic T3113' config when writing current co...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30344 ) Change subject: vty: Fix lost 'no timer-dynamic T3113' config when writing current config ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/30344/comment/0c6906ae_c637abc6 PS1, Line 9: whished > typo: wished Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d Gerrit-Change-Number: 30344 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 15:42:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Replace reqs waiting for retransmission with new incoming ini...

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30347 to look at the new patch set (#2). Change subject: paging: Replace reqs waiting for retransmission with new incoming inital req if queue is full ...................................................................... paging: Replace reqs waiting for retransmission with new incoming inital req if queue is full If queue size (in transmit delay of requests) is too long (above threshold) when a new initial incoming request arrives, instead of directly discarding it, see if we can drop a pending retransmission and insert the new one instead, in order to avoid losing initial requests. This is done under the assumption that is it more important to transmit intial requests than to retransmit already transmitted ones. The rationale is that there's lower chances than an MS which didn't answer lately will answer now (aka being reachable at the cell), so it's better to allocate resources for new requests (new MS) which may be available in the cell. Related: OS#5552 Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d --- M src/osmo-bsc/paging.c 1 file changed, 41 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/30347/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d Gerrit-Change-Number: 30347 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: vty: Fix lost 'no timer-dynamic T3113' config when writing current co...

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, neels, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344 to look at the new patch set (#2). Change subject: vty: Fix lost 'no timer-dynamic T3113' config when writing current config ...................................................................... vty: Fix lost 'no timer-dynamic T3113' config when writing current config The default is to have a dynamic T3113. However, if the user wished to set it statically, it would show up when writing the current VTY config. Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d --- M src/osmo-bsc/bts_vty.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/30344/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d Gerrit-Change-Number: 30344 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Introduce VTY configurable X3113 (Maximum Paging Request Tran...

by pespin

Attention is currently required from: neels. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30345 to look at the new patch set (#2). Change subject: paging: Introduce VTY configurable X3113 (Maximum Paging Request Transmit Delay Threshold) ...................................................................... paging: Introduce VTY configurable X3113 (Maximum Paging Request Transmit Delay Threshold) This allows configuring the maximum delay of paging requests to be queued according to other parameters, such as MSC paging request timeouts, etc. Related: OS#5552 Change-Id: Ia556ef4e474e6a2d0d1618bab680a3330a3c062b --- M include/osmocom/bsc/paging.h M src/osmo-bsc/net_init.c M src/osmo-bsc/paging.c M tests/timer.vty 4 files changed, 25 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/45/30345/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia556ef4e474e6a2d0d1618bab680a3330a3c062b Gerrit-Change-Number: 30345 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: pysim: don't use deb9 lxc

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30352 ) Change subject: jobs/master-builds: pysim: don't use deb9 lxc ...................................................................... jobs/master-builds: pysim: don't use deb9 lxc Don't require the debian 9 lxc anymore for publishing docs, the ssh key problem that made this necessary has been solved. Closes: OS#5767 Change-Id: Ia4ee524db059a978bedc1d92804fb59d7513d2cb --- M jobs/master-builds.yml 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index af36148..17f576b 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -419,14 +419,13 @@ - pysim: concurrent: false - # OS#5767: only build2-deb9build-ansible is able to upload docs - slave_axis: !!python/tuple [simtester,osmocom-master,build2-deb9build-ansible] + slave_axis: !!python/tuple [simtester,osmocom-master] a2_name: JOB_TYPE a2: !!python/tuple ["test", "pylint", "docs"] combination_filter: > (JOB_TYPE == "test" && label == "simtester") || (JOB_TYPE == "pylint" && label == "osmocom-master") || - (JOB_TYPE == "docs" && label == "build2-deb9build-ansible") + (JOB_TYPE == "docs" && label == "osmocom-master") cmd: | case "$JOB_TYPE" in "test") -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4ee524db059a978bedc1d92804fb59d7513d2cb Gerrit-Change-Number: 30352 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: don't only use debian 9 lxcs

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30351 ) Change subject: jobs/master-builds: don't only use debian 9 lxcs ...................................................................... jobs/master-builds: don't only use debian 9 lxcs Change-Id: I62bf0b968103724ec676900de6cee65fdb00b9e4 --- M jobs/master-builds.yml 1 file changed, 22 insertions(+), 22 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index cc5f925..af36148 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -5,9 +5,9 @@ # following default values can be overridden by each repo disabled: false concurrent: true - node: 'osmocom-master-debian9' + node: 'osmocom-master' # axes related defaults - slave_axis: !!python/tuple [osmocom-master-debian9] + slave_axis: !!python/tuple [osmocom-master] a1_name: a1 a1: !!python/tuple [default] a2_name: a2 @@ -211,7 +211,7 @@ - osmo-bsc-nat - osmo-bts: - slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian11] + slave_axis: !!python/tuple [osmocom-master, rpi4-raspbian11] a1_name: FIRMWARE_VERSION a1: !!python/tuple [master, femtobts_v2.7, superfemto_v2.4, superfemto_v3.0.1pre, superfemto_v3.1, superfemto_v5.1, v2017.01, origin/nrw/litecell15, origin/nrw/oc2g] a2_name: BTS_MODEL @@ -219,16 +219,16 @@ a3_name: WITH_MANUALS a3: !!python/tuple ["1", "0"] combination_filter: > - (FIRMWARE_VERSION == "master" && WITH_MANUALS == "1" && label == "osmocom-master-debian9") || + (FIRMWARE_VERSION == "master" && WITH_MANUALS == "1" && label == "osmocom-master") || (FIRMWARE_VERSION == "master" && BTS_MODEL == "trx" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") || - (FIRMWARE_VERSION == "femtobts_v2.7" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (FIRMWARE_VERSION == "superfemto_v2.4" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (FIRMWARE_VERSION == "superfemto_v3.0.1pre" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (FIRMWARE_VERSION == "superfemto_v3.1" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (FIRMWARE_VERSION == "superfemto_v5.1" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (FIRMWARE_VERSION == "v2017.01" && BTS_MODEL == "lc15" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (FIRMWARE_VERSION == "origin/nrw/litecell15" && BTS_MODEL == "lc15" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (FIRMWARE_VERSION == "origin/nrw/oc2g" && BTS_MODEL == "oc2g" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") + (FIRMWARE_VERSION == "femtobts_v2.7" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master") || + (FIRMWARE_VERSION == "superfemto_v2.4" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master") || + (FIRMWARE_VERSION == "superfemto_v3.0.1pre" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master") || + (FIRMWARE_VERSION == "superfemto_v3.1" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master") || + (FIRMWARE_VERSION == "superfemto_v5.1" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master") || + (FIRMWARE_VERSION == "v2017.01" && BTS_MODEL == "lc15" && WITH_MANUALS == "0" && label == "osmocom-master") || + (FIRMWARE_VERSION == "origin/nrw/litecell15" && BTS_MODEL == "lc15" && WITH_MANUALS == "0" && label == "osmocom-master") || + (FIRMWARE_VERSION == "origin/nrw/oc2g" && BTS_MODEL == "oc2g" && WITH_MANUALS == "0" && label == "osmocom-master") concurrent: false cmd: | {docker_run} \ @@ -285,7 +285,7 @@ email: jenkins-notifications(a)lists.osmocom.org 246tnt(a)gmail.com - osmo-gsm-manuals: - node: 'osmocom-master-debian9' + node: 'osmocom-master' - osmo-gsm-tester: cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins-build-manuals.sh' @@ -323,7 +323,7 @@ - osmo-pcap - osmo-pcu: - slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian11] + slave_axis: !!python/tuple [osmocom-master, rpi4-raspbian11] a1_name: FIRMWARE_VERSION a1: !!python/tuple [master, v2017.01, origin/nrw/litecell15] a2_name: with_vty @@ -333,11 +333,11 @@ a4_name: WITH_MANUALS a4: !!python/tuple ["1", "0"] combination_filter: > - (with_vty == "True" && with_dsp == "sysmo" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="v2017.01" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="origin/nrw/litecell15" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "1" && label == "osmocom-master-debian9") || + (with_vty == "True" && with_dsp == "sysmo" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "0" && label == "osmocom-master") || + (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "0" && label == "osmocom-master") || + (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="v2017.01" && WITH_MANUALS == "0" && label == "osmocom-master") || + (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="origin/nrw/litecell15" && WITH_MANUALS == "0" && label == "osmocom-master") || + (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "1" && label == "osmocom-master") || (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") cmd: | {docker_run} \ @@ -368,14 +368,14 @@ email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org 246tnt(a)gmail.com - osmo-trx: - slave_axis: !!python/tuple [osmocom-master-debian9,rpi4-raspbian11] + slave_axis: !!python/tuple [osmocom-master,rpi4-raspbian11] a1_name: INSTR a1: !!python/tuple [--with-sse, --without-sse, --with-neon, --with-neon-vfpv4] a2_name: WITH_MANUALS a2: !!python/tuple ["1", "0"] combination_filter: > - (INSTR == "--without-sse" && WITH_MANUALS == "1" && label == "osmocom-master-debian9") || - (INSTR == "--with-sse" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || + (INSTR == "--without-sse" && WITH_MANUALS == "1" && label == "osmocom-master") || + (INSTR == "--with-sse" && WITH_MANUALS == "0" && label == "osmocom-master") || (INSTR == "--with-neon" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") || (INSTR == "--with-neon-vfpv4" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") cmd: | -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I62bf0b968103724ec676900de6cee65fdb00b9e4 Gerrit-Change-Number: 30351 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: pass ssh agent sock to docker

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30350 ) Change subject: jobs/master-builds: pass ssh agent sock to docker ...................................................................... jobs/master-builds: pass ssh agent sock to docker Pass the ssh agent to docker for master builds, so we can publish manuals and other files generated during the builds. This used to work with the .ssh directory where each lxc had its own key. But we are changing that to have the keys in jenkins and use the ssh agent, so it works without additional configuration when adding new nodes/lxcs (such as the two deb11 lxcs we just added). Change-Id: I6dc1fd5d7e81ec135f805562608f06cf03a1baeb --- M jobs/master-builds.yml 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 3ef3f03..cc5f925 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -36,15 +36,16 @@ -e OSMO_GSM_MANUALS_DIR="/opt/osmo-gsm-manuals" \ -e PARALLEL_MAKE="$PARALLEL_MAKE" \ -e PUBLISH="1" \ + -e SSH_AUTH_SOCK=/ssh-agent \ -e WITH_MANUALS="1" \ -w /build -i -u build \ + -v $(readlink -f $SSH_AUTH_SOCK):/ssh-agent \ -v "$PWD:/build" \ -v "$ARTIFACT_STORE:/artifact_store" \ -v "$HOME/.ssh:/home/build/.ssh:ro" \ docker_img: '$USER/debian-buster-jenkins' timeout_cmd: '/usr/bin/timeout 30m' cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh' - wrappers: [] trigger: email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org git_base_url: https://gerrit.osmocom.org @@ -531,6 +532,9 @@ - email: recipients: '{obj:email}' send-to-individuals: true - wrappers: '{obj:wrappers}' + wrappers: + - ssh-agent-credentials: + users: + - 97634b9d-a867-4f6d-825d-1da99813e93d # vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6dc1fd5d7e81ec135f805562608f06cf03a1baeb Gerrit-Change-Number: 30350 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

2024

2023

2022

gerrit-log November 2022