November 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: release-tarball-build-dist: fix permission errors

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30389 ) Change subject: release-tarball-build-dist: fix permission errors ...................................................................... release-tarball-build-dist: fix permission errors Run all commands inside the docker containers as a user with the same UID as on the host system, not as root. This is a good idea in general and also fixes permission problems when jenkins tries to wipe the workspace. Related: OS#5793 Change-Id: I0d949e5ab4b1a709d18a316def0a98c3b244457e --- M release-tarball-build-dist/Dockerfile 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/89/30389/1 diff --git a/release-tarball-build-dist/Dockerfile b/release-tarball-build-dist/Dockerfile index 678efd4..dcfea51 100644 --- a/release-tarball-build-dist/Dockerfile +++ b/release-tarball-build-dist/Dockerfile @@ -1,6 +1,7 @@ ARG USER FROM $USER/debian-bullseye-obs-latest # Arguments used after FROM must be specified again +ARG UID RUN apt-get update && \ apt-get install -y --no-install-recommends \ @@ -71,3 +72,6 @@ xsltproc \ && \ apt-get clean + +RUN useradd --uid=${UID} -m user +USER user -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0d949e5ab4b1a709d18a316def0a98c3b244457e Gerrit-Change-Number: 30389 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in dahdi-linux[master]: kernel 6.1 API change: netif_napi_add() uses weight==64 by default

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/30384 ) Change subject: kernel 6.1 API change: netif_napi_add() uses weight==64 by default ...................................................................... kernel 6.1 API change: netif_napi_add() uses weight==64 by default Change-Id: I7e70659e43c930a4c220eaef29cfb4e8d7a6eb0d --- M drivers/dahdi/voicebus/voicebus_net.c M drivers/dahdi/wctc4xxp/base.c 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/84/30384/1 diff --git a/drivers/dahdi/voicebus/voicebus_net.c b/drivers/dahdi/voicebus/voicebus_net.c index c17627c..c621b89 100644 --- a/drivers/dahdi/voicebus/voicebus_net.c +++ b/drivers/dahdi/voicebus/voicebus_net.c @@ -202,7 +202,12 @@ netdev->promiscuity = 0; netdev->flags |= IFF_NOARP; +#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 1, 0) + /* 64 is NAPI_POLL_WEIGHT, i.e. the default */ + netif_napi_add(netdev, &vb->napi, vb_net_poll); +#else netif_napi_add(netdev, &vb->napi, vb_net_poll, 64); +#endif skb_queue_head_init(&vb->captured_packets); res = register_netdev(netdev); diff --git a/drivers/dahdi/wctc4xxp/base.c b/drivers/dahdi/wctc4xxp/base.c index 223bbbd..90c4efc 100644 --- a/drivers/dahdi/wctc4xxp/base.c +++ b/drivers/dahdi/wctc4xxp/base.c @@ -656,7 +656,12 @@ netdev->promiscuity = 0; netdev->flags |= IFF_NOARP; +#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 1, 0) + /* 64 is NAPI_POLL_WEIGHT, i.e. the default */ + netif_napi_add(netdev, &wc->napi, &wctc4xxp_poll); +#else netif_napi_add(netdev, &wc->napi, &wctc4xxp_poll, 64); +#endif res = register_netdev(netdev); if (res) { -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/30384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I7e70659e43c930a4c220eaef29cfb4e8d7a6eb0d Gerrit-Change-Number: 30384 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-docker-run.sh: Use interface "up" flag, not operstate

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30383 ) Change subject: ttcn3-docker-run.sh: Use interface "up" flag, not operstate ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib5c3bbe470ce874217437c2518df5ae07f0d8301 Gerrit-Change-Number: 30383 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 15:09:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: trau_sync: Add the V.110 sync pattern

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30375 ) Change subject: trau_sync: Add the V.110 sync pattern ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File include/osmocom/trau/trau_sync.h: https://gerrit.osmocom.org/c/libosmo-abis/+/30375/comment/6d9fe58c_76161e62 PS2, Line 5: enum osmo_tray_sync_pat_id { did you see this typo here? "tray". Do you mind submitting an extra patch for it? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3aab5c3f494f6ea2b11f3cf69fb09bc77ea941d8 Gerrit-Change-Number: 30375 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: mobile: integrate GAPK based audio (voice) I/O support

by pespin

Attention is currently required from: Hoernchen, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30337 ) Change subject: mobile: integrate GAPK based audio (voice) I/O support ...................................................................... Patch Set 6: (4 comments) File src/host/layer23/src/mobile/gapk_io.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/820c166b_77d5fcf1 PS6, Line 52: tch > we have msgb_dequeue_count() fro this. Ack https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/cede15b7_71f3dbd8 PS6, Line 90: ms > we have msgb_enqueue_count() for this. Ack https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/d4a44fe7_a3be7235 PS6, Line 525: ms > msgb_enqueue_count() Ack https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/4e5e71c9_845269e8 PS6, Line 561: tch > we have msgb_dequeue_count() for this. Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:51:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after...

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 ) Change subject: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after X2002 ...................................................................... Patch Set 2: (1 comment) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371/comment/cfc5a006_3491… PS2, Line 1094: for (i := 0; i < 10; i := i + 1) { : f_rx_rlcmac_dl_block(dl_block, fn); : : if (not match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL)) { : /* Received first data, starting processing: */ : break; : } : } > there seems to be a lot of copy+paste of this with the other 2 patches in this series. […] I thought about it, but decided to do it this way to avoid encapsulating more stuff, since in the end the last dl_block needs to be used by follow-up code. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If7121473a3580b40d3a658dc38b9bb1421196127 Gerrit-Change-Number: 30371 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:50:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmocore[master]: WIP: create libosmoisdn sub-library

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30376 ) Change subject: WIP: create libosmoisdn sub-library ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: this is marked as Active but commit message states "WIP". -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 Gerrit-Change-Number: 30376 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 14:47:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): fix sprintf() formatting

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30378 ) Change subject: mobile: timeout_rr_meas(): fix sprintf() formatting ...................................................................... mobile: timeout_rr_meas(): fix sprintf() formatting Change-Id: Ia8a101005d027fb5d0ddc2566f92ab2060f21c36 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index b42ab3a..8e3b61b 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -655,9 +655,9 @@ gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); if (rr->state == GSM48_RR_ST_DEDICATED) { sprintf(text + strlen(text), " TA=%d pwr=%d", - rr->cd_now.ind_ta - set->alter_delay, - (set->alter_tx_power) ? set->alter_tx_power_value - : rr->cd_now.ind_tx_power); + rr->cd_now.ind_ta - set->alter_delay, + (set->alter_tx_power) ? set->alter_tx_power_value + : rr->cd_now.ind_tx_power); if (rsl_dec_chan_nr(rr->cd_now.chan_nr, &ch_type, &ch_subch, &ch_ts) == 0) { sprintf(text + strlen(text), " TS=%d", ch_ts); if (ch_type == RSL_CHAN_SDCCH8_ACCH -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia8a101005d027fb5d0ddc2566f92ab2060f21c36 Gerrit-Change-Number: 30378 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): use osmo_strbuf API

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30379 ) Change subject: mobile: timeout_rr_meas(): use osmo_strbuf API ...................................................................... mobile: timeout_rr_meas(): use osmo_strbuf API Change-Id: I0c505b753bcfb06d9f2f085d56d7d56fb1c44d50 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 16 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 8e3b61b..08242ee 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -636,34 +636,37 @@ struct gsm_settings *set = &rr->ms->settings; int rxlev, berr, snr; uint8_t ch_type, ch_subch, ch_ts; + struct osmo_strbuf sb; char text[256]; + sb = (struct osmo_strbuf) { .buf = text, .len = sizeof(text) }; + /* don't monitor if no cell is selected or if we scan neighbour cells */ if (!cs->selected || cs->neighbour) { - sprintf(text, "MON: not camping on serving cell"); + OSMO_STRBUF_PRINTF(sb, "MON: not camping on serving cell"); goto restart; } else if (!meas->frames) { - sprintf(text, "MON: no cell info"); + OSMO_STRBUF_PRINTF(sb, "MON: no cell info"); } else { rxlev = (meas->rxlev + meas->frames / 2) / meas->frames; berr = (meas->berr + meas->frames / 2) / meas->frames; snr = (meas->snr + meas->frames / 2) / meas->frames; - sprintf(text, "MON: f=%d lev=%s snr=%2d ber=%3d " - "LAI=%s %s %04x ID=%04x", cs->sel_arfcn, - gsm_print_rxlev(rxlev), snr, berr, - gsm_print_mcc(cs->sel_mcc), - gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); + OSMO_STRBUF_PRINTF(sb, "MON: f=%d lev=%s snr=%2d ber=%3d " + "LAI=%s %s %04x ID=%04x", cs->sel_arfcn, + gsm_print_rxlev(rxlev), snr, berr, + gsm_print_mcc(cs->sel_mcc), + gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); if (rr->state == GSM48_RR_ST_DEDICATED) { - sprintf(text + strlen(text), " TA=%d pwr=%d", - rr->cd_now.ind_ta - set->alter_delay, - (set->alter_tx_power) ? set->alter_tx_power_value - : rr->cd_now.ind_tx_power); + OSMO_STRBUF_PRINTF(sb, " TA=%d pwr=%d", + rr->cd_now.ind_ta - set->alter_delay, + (set->alter_tx_power) ? set->alter_tx_power_value + : rr->cd_now.ind_tx_power); if (rsl_dec_chan_nr(rr->cd_now.chan_nr, &ch_type, &ch_subch, &ch_ts) == 0) { - sprintf(text + strlen(text), " TS=%d", ch_ts); + OSMO_STRBUF_PRINTF(sb, " TS=%d", ch_ts); if (ch_type == RSL_CHAN_SDCCH8_ACCH || ch_type == RSL_CHAN_SDCCH4_ACCH || ch_type == RSL_CHAN_Lm_ACCHs) - sprintf(text + strlen(text), "/%d", ch_subch); + OSMO_STRBUF_PRINTF(sb, "/%d", ch_subch); } } else gsm322_meas(rr->ms, rxlev); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0c505b753bcfb06d9f2f085d56d7d56fb1c44d50 Gerrit-Change-Number: 30379 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): fix uninitialized variable

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30377 ) Change subject: mobile: timeout_rr_meas(): fix uninitialized variable ...................................................................... mobile: timeout_rr_meas(): fix uninitialized variable Change-Id: I956a1cafe9fed1a881574f59d0532e5cf931a1f7 Fixes: c9e579cea137fd147173434b7fa128d37685011 Fixes: CID#300084 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 41aa7b8..b42ab3a 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -654,11 +654,12 @@ gsm_print_mcc(cs->sel_mcc), gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); if (rr->state == GSM48_RR_ST_DEDICATED) { - sprintf(text + strlen(text), " TA=%d pwr=%d TS=%d", + sprintf(text + strlen(text), " TA=%d pwr=%d", rr->cd_now.ind_ta - set->alter_delay, (set->alter_tx_power) ? set->alter_tx_power_value - : rr->cd_now.ind_tx_power, ch_ts); + : rr->cd_now.ind_tx_power); if (rsl_dec_chan_nr(rr->cd_now.chan_nr, &ch_type, &ch_subch, &ch_ts) == 0) { + sprintf(text + strlen(text), " TS=%d", ch_ts); if (ch_type == RSL_CHAN_SDCCH8_ACCH || ch_type == RSL_CHAN_SDCCH4_ACCH || ch_type == RSL_CHAN_Lm_ACCHs) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I956a1cafe9fed1a881574f59d0532e5cf931a1f7 Gerrit-Change-Number: 30377 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022