Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30318 ) Change subject: trxcon: trxcon_fsm: permit loop [P]DCH transitions ...................................................................... Patch Set 2: (1 comment) File src/host/trxcon/src/trxcon_fsm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30318/comment/9dc875d9_ef6dd329 PS1, Line 626: | S(TRXCON_ST_PACKET_DATA),

No, it's not a separate patch. 3GPP TS 44.004, Figure 5. […] But how can you end up transitioning TRXCON_ST_PACKET_DATA -> TRXCON_ST_PACKET_DATA in current code? I see in this patch you have trxcon_st_dedicated_action() calling trxcon_st_dedicated_action() calling handle_dcch_est_req() which ends up calling osmo_fsm_inst_state_chg(fi, TRXCON_ST_DEDICATED, 0, 0);.

But for TRXCON_ST_PACKET_DATA I'm unable to see such path? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3b402ec84610a5df744d9b06e5f7dab7a9a3ddad Gerrit-Change-Number: 30318 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 10:43:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment