November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): print strerror(errno) if read() fails

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30289 ) Change subject: trxcon: trx_data_rx_cb(): print strerror(errno) if read() fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I78658a706e5bfda446e3929e33abcdee3f08845b Gerrit-Change-Number: 30289 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Nov 2022 14:28:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): properly parse timeslot number

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30288 ) Change subject: trxcon: trx_data_rx_cb(): properly parse timeslot number ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1010cf39f61b8845acce632c19c74df892fc5acb Gerrit-Change-Number: 30288 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Nov 2022 14:28:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in pysim[master]: OTA: Adjust IV length for AES

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/30305 ) Change subject: OTA: Adjust IV length for AES ...................................................................... OTA: Adjust IV length for AES Change-Id: I854c844418244c100c328f9e76c0f37850d3db00 --- M pySim/ota.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/ota.py b/pySim/ota.py index bc4b0a7..80c823e 100644 --- a/pySim/ota.py +++ b/pySim/ota.py @@ -154,7 +154,7 @@ from Crypto.Hash import CMAC class OtaAlgo(abc.ABC): - iv = b'\x00\x00\x00\x00\x00\x00\x00\x00' + iv = property(lambda self: bytes([0] * self.blocksize)) blocksize = None enum_name = None -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I854c844418244c100c328f9e76c0f37850d3db00 Gerrit-Change-Number: 30305 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in pysim[master]: OTA: Adjust IV length for AES

by laforge

Attention is currently required from: Christian Amsüss. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/30305 ) Change subject: OTA: Adjust IV length for AES ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I854c844418244c100c328f9e76c0f37850d3db00 Gerrit-Change-Number: 30305 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Comment-Date: Fri, 25 Nov 2022 14:27:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: fixup: firmware/layer1: introduce experimental PDCH support

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30306 ) Change subject: fixup: firmware/layer1: introduce experimental PDCH support ...................................................................... fixup: firmware/layer1: introduce experimental PDCH support This regression was introduced with the experimental PDCH support back in 2020. In particular, I made a mistake in the l1s_nb_resp() resetting rxnb.dl->link_id to 0x00 if MF_F_PTCCH is not set, which is of course not set for non-PDCH channels. Change-Id: I8593f9b001e669e7cd10cc42c05221a6037e8ae1 Fixes: 67c49ba664f7d7d7f07986a20e6d6363a27e3fc4 Fixes: OS#5791, OS#5133 --- M src/target/firmware/layer1/prim_rx_nb.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Hoernchen: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/firmware/layer1/prim_rx_nb.c b/src/target/firmware/layer1/prim_rx_nb.c index 9656cf9..d6dd82a 100644 --- a/src/target/firmware/layer1/prim_rx_nb.c +++ b/src/target/firmware/layer1/prim_rx_nb.c @@ -122,7 +122,7 @@ /* Set SACCH indication in Link IDentifier */ if (mf_task_flags & MF_F_SACCH) rxnb.dl->link_id = 0x40; - if (mf_task_flags & MF_F_PTCCH) + else if (mf_task_flags & MF_F_PTCCH) rxnb.dl->link_id = 0x80; else rxnb.dl->link_id = 0x00; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8593f9b001e669e7cd10cc42c05221a6037e8ae1 Gerrit-Change-Number: 30306 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: fixup: firmware/layer1: introduce experimental PDCH support

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30306 ) Change subject: fixup: firmware/layer1: introduce experimental PDCH support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8593f9b001e669e7cd10cc42c05221a6037e8ae1 Gerrit-Change-Number: 30306 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Nov 2022 13:53:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: fixup: firmware/layer1: introduce experimental PDCH support

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30306 ) Change subject: fixup: firmware/layer1: introduce experimental PDCH support ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8593f9b001e669e7cd10cc42c05221a6037e8ae1 Gerrit-Change-Number: 30306 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Nov 2022 13:28:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: fixup: firmware/layer1: introduce experimental PDCH support

by Hoernchen

Attention is currently required from: fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30306 ) Change subject: fixup: firmware/layer1: introduce experimental PDCH support ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8593f9b001e669e7cd10cc42c05221a6037e8ae1 Gerrit-Change-Number: 30306 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Nov 2022 13:17:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: fixup: firmware/layer1: introduce experimental PDCH support

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30306 ) Change subject: fixup: firmware/layer1: introduce experimental PDCH support ...................................................................... fixup: firmware/layer1: introduce experimental PDCH support This regression was introduced with the experimental PDCH support back in 2020. In particular, I made a mistake in the l1s_nb_resp() resetting rxnb.dl->link_id to 0x00 if MF_F_PTCCH is not set, which is of course not set for non-PDCH channels. Change-Id: I8593f9b001e669e7cd10cc42c05221a6037e8ae1 Fixes: 67c49ba664f7d7d7f07986a20e6d6363a27e3fc4 Fixes: OS#5791, OS#5133 --- M src/target/firmware/layer1/prim_rx_nb.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/06/30306/1 diff --git a/src/target/firmware/layer1/prim_rx_nb.c b/src/target/firmware/layer1/prim_rx_nb.c index 9656cf9..d6dd82a 100644 --- a/src/target/firmware/layer1/prim_rx_nb.c +++ b/src/target/firmware/layer1/prim_rx_nb.c @@ -122,7 +122,7 @@ /* Set SACCH indication in Link IDentifier */ if (mf_task_flags & MF_F_SACCH) rxnb.dl->link_id = 0x40; - if (mf_task_flags & MF_F_PTCCH) + else if (mf_task_flags & MF_F_PTCCH) rxnb.dl->link_id = 0x80; else rxnb.dl->link_id = 0x00; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8593f9b001e669e7cd10cc42c05221a6037e8ae1 Gerrit-Change-Number: 30306 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: paging: paging: Drop unneeded extra param in paging_remove_request()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30299 ) Change subject: paging: paging: Drop unneeded extra param in paging_remove_request() ...................................................................... paging: paging: Drop unneeded extra param in paging_remove_request() The BTS can be obtained easily from the backpointer in req->bts. Having the extra param can only lead to confusion and introduction of bugs, as happened in bug fixed by Change-Id I8c6828f86b7ccbb2c4a09ca1aec859a2c597b679. Related: SYS#6200 Change-Id: I545fd853fdffce7f23f0d99203c66c3b39144e4b --- M src/osmo-bsc/paging.c 1 file changed, 18 insertions(+), 15 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index b9f2e54..0395c14 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -83,17 +83,20 @@ /* * Kill one paging request update the internal list... */ -static void paging_remove_request(struct gsm_bts_paging_state *paging_bts, - struct gsm_paging_request *to_be_deleted) +static void paging_remove_request(struct gsm_paging_request *req) { - osmo_timer_del(&to_be_deleted->T3113); - llist_del(&to_be_deleted->entry); - paging_bts->pending_requests_len--; - osmo_stat_item_dec(osmo_stat_item_group_get_item(to_be_deleted->bts->bts_statg, BTS_STAT_PAGING_REQ_QUEUE_LENGTH), 1); - bsc_subscr_remove_active_paging_request(to_be_deleted->bsub, to_be_deleted); - talloc_free(to_be_deleted); - if (llist_empty(&paging_bts->pending_requests)) - osmo_timer_del(&paging_bts->work_timer); + struct gsm_bts *bts = req->bts; + struct gsm_bts_paging_state *bts_pag_st = &bts->paging; + + osmo_timer_del(&req->T3113); + llist_del(&req->entry); + bts_pag_st->pending_requests_len--; + osmo_stat_item_dec(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_PAGING_REQ_QUEUE_LENGTH), 1); + bsc_subscr_remove_active_paging_request(req->bsub, req); + talloc_free(req); + + if (llist_empty(&bts_pag_st->pending_requests)) + osmo_timer_del(&bts_pag_st->work_timer); } static void page_ms(struct gsm_paging_request *request) @@ -342,7 +345,7 @@ rate_ctr_inc(rate_ctr_group_get_ctr(bsc_gsmnet->bsc_ctrs, BSC_CTR_PAGING_EXPIRED)); /* destroy it now. Do not access req afterwards */ - paging_remove_request(&req->bts->paging, req); + paging_remove_request(req); log_set_context(LOG_CTX_BSC_SUBSCR, NULL); } @@ -559,7 +562,7 @@ LOG_PAGING_BTS(req, bts, DPAG, LOGL_DEBUG, "Stop paging\n"); rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_PAGING_RESPONDED)); rate_ctr_inc(rate_ctr_group_get_ctr(bts->network->bsc_ctrs, BSC_CTR_PAGING_RESPONDED)); - paging_remove_request(&bts->paging, req); + paging_remove_request(req); remaining--; } @@ -575,7 +578,7 @@ * pending on a different BTS. But why not return an MSC when we found one. */ paged_from_msc = req->msc; } - paging_remove_request(&req->bts->paging, req); + paging_remove_request(req); remaining--; } @@ -604,7 +607,7 @@ continue; } /* No reason to keep the paging, remove it: */ - paging_remove_request(&req->bts->paging, req); + paging_remove_request(req); remaining--; if (remaining == 0) break; @@ -642,7 +645,7 @@ continue; /* now give up the data structure */ LOG_PAGING_BTS(req, bts, DPAG, LOGL_DEBUG, "Stop paging (flush)\n"); - paging_remove_request(&bts->paging, req); + paging_remove_request(req); num_cancelled++; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I545fd853fdffce7f23f0d99203c66c3b39144e4b Gerrit-Change-Number: 30299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022