November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: layer23: add 'src/modem/modem' to .gitignore

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30308 ) Change subject: layer23: add 'src/modem/modem' to .gitignore ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I37e536493ddfd3bff1674d5bc85f40a0bbd0f317 Gerrit-Change-Number: 30308 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Nov 2022 16:45:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: add a spec. reference for the trxcon_fsm

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30309 ) Change subject: trxcon: add a spec. reference for the trxcon_fsm ...................................................................... trxcon: add a spec. reference for the trxcon_fsm Change-Id: I184abe10f874d97f047a3720c776fdef08d880e6 --- M src/host/trxcon/src/trxcon_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/09/30309/1 diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index d3420f2..164d6fb 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -1,5 +1,6 @@ /* * OsmocomBB <-> SDR connection bridge + * The trxcon state machine (see 3GPP TS 44.004, section 5.1) * * (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * Author: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I184abe10f874d97f047a3720c776fdef08d880e6 Gerrit-Change-Number: 30309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: layer23: add 'src/modem/modem' to .gitignore

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30308 ) Change subject: layer23: add 'src/modem/modem' to .gitignore ...................................................................... layer23: add 'src/modem/modem' to .gitignore Change-Id: I37e536493ddfd3bff1674d5bc85f40a0bbd0f317 --- M src/host/layer23/.gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/08/30308/1 diff --git a/src/host/layer23/.gitignore b/src/host/layer23/.gitignore index 8fb93f7..301e2c0 100644 --- a/src/host/layer23/.gitignore +++ b/src/host/layer23/.gitignore @@ -34,3 +34,4 @@ src/misc/ccch_scan src/misc/layer23 src/mobile/mobile +src/modem/modem -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I37e536493ddfd3bff1674d5bc85f40a0bbd0f317 Gerrit-Change-Number: 30308 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: fsms: use configurable timers instead of T23042

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30307 ) Change subject: fsms: use configurable timers instead of T23042 ...................................................................... fsms: use configurable timers instead of T23042 It looks like T23042 was a placeholder for timers to be filled in later, it cannot be configured via VTY and I cannot find it mentioned in any specs on etsi.org. git blame shows it first appeard in 31f525e ("large refactoring: use FSMs for lchans; add inter-BSC HO"). Replace T23042 with timers that can be configured via VTY. Previous timeout for the states was 5s. * ASSIGNMENT_ST_WAIT_MGW_ENDPOINT_TO_MSC and HO_ST_WAIT_MGW_ENDPOINT_TO_MSC: * Runs gscon_connect_mgw_to_msc() on enter, which waits for one MGCP CRCX or MDCX response (or changes state immediatelly) * Use existing X9 ("Timeout for availability of MGW endpoint"), 5s, which is already being used by lchan_rtp_fsm for a similar purpose * HO_ST_WAIT_LCHAN_ACTIVE: * Runs lchan_activate() on enter, and waits for the lchan fsm to go through LCHAN_ST_WAIT_TS_READY (X5) and LCHAN_ST_WAIT_ACTIV_ACK (X6). * Use new X29, 10s (5s from X5 + 5s from X6) * HO_ST_WAIT_RR_HO_DETECT: * Handover initiation as described in 3GPP TS 04.08 § 3.4.4.1: "The network initiates the handover procedure by sending a HANDOVER COMMAND message to the mobile station on the main DCCH. It then starts timer T3103." * Use existing but unused timer T3103 ("Handover"), 5s * HO_ST_WAIT_RR_HO_COMPLETE: * Handover completion as described in 3GPP TS 04.08 § 3.4.4.3: "When receiving the HANDOVER COMPLETE message, the network stops timer T3103 and releases the old channels." * Continue using T3103 with keep_timer = true * HO_ST_WAIT_LCHAN_ESTABLISHED: * Waits for HO_EV_LCHAN_ESTABLISHED from the lchan fsm (if it was not received yet, otherwise the state gets skipped without wait) * Use new X30, 5s Closes: OS#5787 Change-Id: Id0d4d0788f609f3272fc81c80a754383dde25c16 --- M src/osmo-bsc/assignment_fsm.c M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/net_init.c M tests/timer.vty 4 files changed, 12 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/30307/1 diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index f00b26d..3a832a4 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -54,7 +54,7 @@ [ASSIGNMENT_ST_WAIT_LCHAN_ACTIVE] = { .T = 10 }, [ASSIGNMENT_ST_WAIT_RR_ASS_COMPLETE] = { .keep_timer = true }, [ASSIGNMENT_ST_WAIT_LCHAN_ESTABLISHED] = { .keep_timer = true }, - [ASSIGNMENT_ST_WAIT_MGW_ENDPOINT_TO_MSC] = { .T = 23042 }, + [ASSIGNMENT_ST_WAIT_MGW_ENDPOINT_TO_MSC] = { .T = -9 }, }; /* Transition to a state, using the T timer defined in assignment_fsm_timeouts. diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 0d888e0..558dcd4 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -193,11 +193,11 @@ } static const struct osmo_tdef_state_timeout ho_fsm_timeouts[32] = { - [HO_ST_WAIT_LCHAN_ACTIVE] = { .T = 23042 }, - [HO_ST_WAIT_MGW_ENDPOINT_TO_MSC] = { .T = 23042 }, - [HO_ST_WAIT_RR_HO_DETECT] = { .T = 23042 }, - [HO_ST_WAIT_RR_HO_COMPLETE] = { .T = 23042 }, - [HO_ST_WAIT_LCHAN_ESTABLISHED] = { .T = 23042 }, + [HO_ST_WAIT_LCHAN_ACTIVE] = { .T = -29 }, + [HO_ST_WAIT_MGW_ENDPOINT_TO_MSC] = { .T = -9 }, + [HO_ST_WAIT_RR_HO_DETECT] = { .T = 3103 }, + [HO_ST_WAIT_RR_HO_COMPLETE] = { .keep_timer = true }, + [HO_ST_WAIT_LCHAN_ESTABLISHED] = { .T = -30 }, [HO_OUT_ST_WAIT_HO_COMMAND] = { .T = 7 }, [HO_OUT_ST_WAIT_CLEAR] = { .T = 8 }, }; diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c index ad2f9bf..fdfe3ac 100644 --- a/src/osmo-bsc/net_init.c +++ b/src/osmo-bsc/net_init.c @@ -73,6 +73,8 @@ " after this amount of idle time, forget internally cumulated time remainders. Zero to always" " keep remainders. See also X16, X17." }, { .T = -25, .default_val = 5, .desc = "Timeout for initial user data after an MSC initiated an SCCP connection to the BSS" }, + { .T = -29, .default_val = 10, .desc = "Timeout for activating an lchan for handover (should be X5 + X6)" }, + { .T = -30, .default_val = 5, .desc = "Timeout for establishing new lchan at the end of handover" }, { .T = -3111, .default_val = 4, .desc = "Wait time after lchan was released in error (should be T3111 + 2s)" }, { .T = -3210, .default_val = 20, .desc = "After L3 Complete, wait for MSC to confirm" }, {} diff --git a/tests/timer.vty b/tests/timer.vty index 04c9872..01d51fb 100644 --- a/tests/timer.vty +++ b/tests/timer.vty @@ -34,6 +34,8 @@ net: X17 = 0 ms Rounding threshold for all_allocated:* rate counters: round up to the next counter increment after this many milliseconds. If set to half of X16 (or 0), employ the usual round() behavior: round up after half of a granularity period. If set to 1, behave like ceil(): already increment the counter immediately when all channels are allocated. If set >= X16, behave like floor(): only increment after a full X16 period of all channels being occupied. See also X16, X18 (default: 0 ms) net: X18 = 60000 ms Forget-sum period for all_allocated:* rate counters: after this amount of idle time, forget internally cumulated time remainders. Zero to always keep remainders. See also X16, X17. (default: 60000 ms) net: X25 = 5 s Timeout for initial user data after an MSC initiated an SCCP connection to the BSS (default: 5 s) +net: X29 = 10 s Timeout for activating an lchan for handover (should be X5 + X6) (default: 10 s) +net: X30 = 5 s Timeout for establishing new lchan at the end of handover (default: 5 s) net: X3111 = 4 s Wait time after lchan was released in error (should be T3111 + 2s) (default: 4 s) net: X3210 = 20 s After L3 Complete, wait for MSC to confirm (default: 20 s) mgw: X2427 = 5 s timeout for MGCP response from MGW (default: 5 s) @@ -88,6 +90,8 @@ net: X17 = 0 ms Rounding threshold for all_allocated:* rate counters: round up to the next counter increment after this many milliseconds. If set to half of X16 (or 0), employ the usual round() behavior: round up after half of a granularity period. If set to 1, behave like ceil(): already increment the counter immediately when all channels are allocated. If set >= X16, behave like floor(): only increment after a full X16 period of all channels being occupied. See also X16, X18 (default: 0 ms) net: X18 = 60000 ms Forget-sum period for all_allocated:* rate counters: after this amount of idle time, forget internally cumulated time remainders. Zero to always keep remainders. See also X16, X17. (default: 60000 ms) net: X25 = 5 s Timeout for initial user data after an MSC initiated an SCCP connection to the BSS (default: 5 s) +net: X29 = 10 s Timeout for activating an lchan for handover (should be X5 + X6) (default: 10 s) +net: X30 = 5 s Timeout for establishing new lchan at the end of handover (default: 5 s) net: X3111 = 4 s Wait time after lchan was released in error (should be T3111 + 2s) (default: 4 s) net: X3210 = 20 s After L3 Complete, wait for MSC to confirm (default: 20 s) mgw: X2427 = 5 s timeout for MGCP response from MGW (default: 5 s) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id0d4d0788f609f3272fc81c80a754383dde25c16 Gerrit-Change-Number: 30307 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): support parsing 8-PSK modulated bursts

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30291 ) Change subject: trxcon: trx_data_rx_cb(): support parsing 8-PSK modulated bursts ...................................................................... trxcon: trx_data_rx_cb(): support parsing 8-PSK modulated bursts Change-Id: I78b1a79c329299ab65eb339e9447a47382983cd9 --- M src/host/trxcon/src/trx_if.c 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c index c938fc0..078f71b 100644 --- a/src/host/trxcon/src/trx_if.c +++ b/src/host/trxcon/src/trx_if.c @@ -43,6 +43,9 @@ #include <osmocom/bb/trxcon/trx_if.h> #include <osmocom/bb/trxcon/logging.h> +#define TRXDv0_HDR_LEN 8 +#define GMSK_BURST_LEN 148 + #define S(x) (1 << (x)) static void trx_fsm_cleanup_cb(struct osmo_fsm_inst *fi, @@ -642,7 +645,7 @@ return read_len; } - if (read_len < (8 + 148)) { /* TRXDv0 header + GMSK burst */ + if (read_len < (TRXDv0_HDR_LEN + GMSK_BURST_LEN)) { LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, "Got data message with invalid length '%zd'\n", read_len); return -EINVAL; @@ -661,8 +664,8 @@ .fn = osmo_load32be(buf + 1), .rssi = -(int8_t) buf[5], .toa256 = (int16_t) (buf[6] << 8) | buf[7], - .burst = burst, - .burst_len = 148, + .burst = burst, /* at least GMSK_BURST_LEN */ + .burst_len = read_len - TRXDv0_HDR_LEN, }; /* Convert ubits {254..0} to sbits {-127..127} in-place */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I78b1a79c329299ab65eb339e9447a47382983cd9 Gerrit-Change-Number: 30291 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): check TRXD PDU version

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30290 ) Change subject: trxcon: trx_data_rx_cb(): check TRXD PDU version ...................................................................... trxcon: trx_data_rx_cb(): check TRXD PDU version Change-Id: If5687d7d87619c0da02cc81ab26d63e61484bc06 --- M src/host/trxcon/src/trx_if.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c index c8e7a93..c938fc0 100644 --- a/src/host/trxcon/src/trx_if.c +++ b/src/host/trxcon/src/trx_if.c @@ -648,6 +648,12 @@ return -EINVAL; } + if ((buf[0] >> 4) != 0) { + LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, + "Got TRXD PDU with unexpected version\n"); + return -ENOTSUP; + } + burst = (sbit_t *)&buf[8]; bi = (struct trxcon_phyif_burst_ind) { -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If5687d7d87619c0da02cc81ab26d63e61484bc06 Gerrit-Change-Number: 30290 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): properly parse timeslot number

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30288 ) Change subject: trxcon: trx_data_rx_cb(): properly parse timeslot number ...................................................................... trxcon: trx_data_rx_cb(): properly parse timeslot number Remove the range check because it makes no sense anymore. Change-Id: I1010cf39f61b8845acce632c19c74df892fc5acb --- M src/host/trxcon/src/trx_if.c 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c index 2c0b286..06f0a07 100644 --- a/src/host/trxcon/src/trx_if.c +++ b/src/host/trxcon/src/trx_if.c @@ -648,7 +648,7 @@ burst = (sbit_t *)&buf[8]; bi = (struct trxcon_phyif_burst_ind) { - .tn = buf[0], + .tn = buf[0] & 0x07, .fn = osmo_load32be(buf + 1), .rssi = -(int8_t) buf[5], .toa256 = (int16_t) (buf[6] << 8) | buf[7], @@ -664,11 +664,6 @@ burst[i] = 127 - buf[8 + i]; } - if (bi.tn >= 8) { - LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, "Illegal TS %d\n", bi.tn); - return -EINVAL; - } - if (bi.fn >= 2715648) { LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, "Illegal FN %u\n", bi.fn); return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1010cf39f61b8845acce632c19c74df892fc5acb Gerrit-Change-Number: 30288 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): print strerror(errno) if read() fails

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30289 ) Change subject: trxcon: trx_data_rx_cb(): print strerror(errno) if read() fails ...................................................................... trxcon: trx_data_rx_cb(): print strerror(errno) if read() fails Change-Id: I78658a706e5bfda446e3929e33abcdee3f08845b --- M src/host/trxcon/src/trx_if.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c index 06f0a07..c8e7a93 100644 --- a/src/host/trxcon/src/trx_if.c +++ b/src/host/trxcon/src/trx_if.c @@ -635,7 +635,10 @@ read_len = read(ofd->fd, buf, sizeof(buf)); if (read_len <= 0) { - LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, "read() failed with rc=%zd\n", read_len); + strerror_r(errno, (char *)buf, sizeof(buf)); + LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, + "read() failed on TRXD with rc=%zd (%s)\n", + read_len, (const char *)buf); return read_len; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I78658a706e5bfda446e3929e33abcdee3f08845b Gerrit-Change-Number: 30289 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): support parsing 8-PSK modulated bursts

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30291 ) Change subject: trxcon: trx_data_rx_cb(): support parsing 8-PSK modulated bursts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I78b1a79c329299ab65eb339e9447a47382983cd9 Gerrit-Change-Number: 30291 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Nov 2022 14:29:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trx_data_rx_cb(): check TRXD PDU version

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30290 ) Change subject: trxcon: trx_data_rx_cb(): check TRXD PDU version ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If5687d7d87619c0da02cc81ab26d63e61484bc06 Gerrit-Change-Number: 30290 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Nov 2022 14:28:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022