November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: trxcon_fsm: shorten DCCH related event names

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30316 ) Change subject: trxcon: trxcon_fsm: shorten DCCH related event names ...................................................................... trxcon: trxcon_fsm: shorten DCCH related event names Purely cosmetic change, making the lines using these events shorter. Change-Id: Ie388e251677da63306e9e53d98cbcc7c34777980 Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/trxcon_fsm.c 3 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/16/30316/1 diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h index bb57d25..162770d 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h @@ -31,8 +31,8 @@ TRXCON_EV_TX_ACCESS_BURST_REQ, TRXCON_EV_TX_ACCESS_BURST_CNF, TRXCON_EV_UPDATE_SACCH_CACHE_REQ, - TRXCON_EV_DEDICATED_ESTABLISH_REQ, - TRXCON_EV_DEDICATED_RELEASE_REQ, + TRXCON_EV_DCCH_EST_REQ, + TRXCON_EV_DCCH_REL_REQ, TRXCON_EV_TX_DATA_REQ, TRXCON_EV_TX_DATA_CNF, TRXCON_EV_RX_DATA_IND, @@ -135,8 +135,8 @@ uint32_t frame_nr; }; -/* param of TRXCON_EV_DEDICATED_ESTABLISH_REQ */ -struct trxcon_param_dedicated_establish_req { +/* param of TRXCON_EV_DCCH_EST_REQ */ +struct trxcon_param_dcch_est_req { uint8_t chan_nr; uint8_t tch_mode; uint8_t tsc; diff --git a/src/host/trxcon/src/l1ctl.c b/src/host/trxcon/src/l1ctl.c index 47998d6..a56c687 100644 --- a/src/host/trxcon/src/l1ctl.c +++ b/src/host/trxcon/src/l1ctl.c @@ -542,7 +542,7 @@ } static int l1ctl_proc_est_req_h0(struct osmo_fsm_inst *fi, - struct trxcon_param_dedicated_establish_req *req, + struct trxcon_param_dcch_est_req *req, const struct l1ctl_h0 *h) { req->h0.band_arfcn = ntohs(h->band_arfcn); @@ -556,7 +556,7 @@ } static int l1ctl_proc_est_req_h1(struct osmo_fsm_inst *fi, - struct trxcon_param_dedicated_establish_req *req, + struct trxcon_param_dcch_est_req *req, const struct l1ctl_h1 *h) { unsigned int i; @@ -597,7 +597,7 @@ ul = (struct l1ctl_info_ul *) msg->l1h; est_req = (struct l1ctl_dm_est_req *) ul->payload; - struct trxcon_param_dedicated_establish_req req = { + struct trxcon_param_dcch_est_req req = { .chan_nr = ul->chan_nr, .tch_mode = est_req->tch_mode, .tsc = est_req->tsc, @@ -617,7 +617,7 @@ if (rc) goto exit; - osmo_fsm_inst_dispatch(fi, TRXCON_EV_DEDICATED_ESTABLISH_REQ, &req); + osmo_fsm_inst_dispatch(fi, TRXCON_EV_DCCH_EST_REQ, &req); exit: msgb_free(msg); @@ -630,7 +630,7 @@ LOGPFSMSL(fi, g_logc_l1c, LOGL_NOTICE, "Received L1CTL_DM_REL_REQ\n"); - osmo_fsm_inst_dispatch(fi, TRXCON_EV_DEDICATED_RELEASE_REQ, NULL); + osmo_fsm_inst_dispatch(fi, TRXCON_EV_DCCH_REL_REQ, NULL); msgb_free(msg); return 0; diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index 2c59e8d..ba7f429 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -321,9 +321,9 @@ req->applied = true; break; } - case TRXCON_EV_DEDICATED_ESTABLISH_REQ: + case TRXCON_EV_DCCH_EST_REQ: { - const struct trxcon_param_dedicated_establish_req *req = data; + const struct trxcon_param_dcch_est_req *req = data; enum gsm_phys_chan_config config; config = l1sched_chan_nr2pchan_config(req->chan_nr); @@ -406,7 +406,7 @@ case TRXCON_EV_TX_ACCESS_BURST_CNF: l1ctl_tx_rach_conf(trxcon, (const struct trxcon_param_tx_access_burst_cnf *)data); break; - case TRXCON_EV_DEDICATED_RELEASE_REQ: + case TRXCON_EV_DCCH_REL_REQ: l1sched_reset(trxcon->sched, false); osmo_fsm_inst_state_chg(fi, TRXCON_ST_RESET, 0, 0); break; @@ -526,7 +526,7 @@ LOGPFSML(fi, LOGL_NOTICE, "Rx PTCCH/D message\n"); break; } - case TRXCON_EV_DEDICATED_RELEASE_REQ: + case TRXCON_EV_DCCH_REL_REQ: l1sched_reset(trxcon->sched, false); osmo_fsm_inst_state_chg(fi, TRXCON_ST_RESET, 0, 0); break; @@ -591,14 +591,14 @@ | S(TRXCON_EV_SET_CCCH_MODE_REQ) | S(TRXCON_EV_TX_ACCESS_BURST_REQ) | S(TRXCON_EV_TX_ACCESS_BURST_CNF) - | S(TRXCON_EV_DEDICATED_ESTABLISH_REQ), + | S(TRXCON_EV_DCCH_EST_REQ), .action = &trxcon_st_bcch_ccch_action, }, [TRXCON_ST_DEDICATED] = { .name = "DEDICATED", .out_state_mask = S(TRXCON_ST_RESET) | S(TRXCON_ST_FBSB_SEARCH), - .in_event_mask = S(TRXCON_EV_DEDICATED_RELEASE_REQ) + .in_event_mask = S(TRXCON_EV_DCCH_REL_REQ) | S(TRXCON_EV_TX_ACCESS_BURST_REQ) | S(TRXCON_EV_TX_ACCESS_BURST_CNF) | S(TRXCON_EV_SET_TCH_MODE_REQ) @@ -612,7 +612,7 @@ .name = "PACKET_DATA", .out_state_mask = S(TRXCON_ST_RESET) | S(TRXCON_ST_FBSB_SEARCH), - .in_event_mask = S(TRXCON_EV_DEDICATED_RELEASE_REQ) + .in_event_mask = S(TRXCON_EV_DCCH_REL_REQ) | S(TRXCON_EV_TX_ACCESS_BURST_REQ) | S(TRXCON_EV_TX_ACCESS_BURST_CNF) | S(TRXCON_EV_RX_DATA_IND), @@ -635,8 +635,8 @@ OSMO_VALUE_STRING(TRXCON_EV_TX_ACCESS_BURST_REQ), OSMO_VALUE_STRING(TRXCON_EV_TX_ACCESS_BURST_CNF), OSMO_VALUE_STRING(TRXCON_EV_UPDATE_SACCH_CACHE_REQ), - OSMO_VALUE_STRING(TRXCON_EV_DEDICATED_ESTABLISH_REQ), - OSMO_VALUE_STRING(TRXCON_EV_DEDICATED_RELEASE_REQ), + OSMO_VALUE_STRING(TRXCON_EV_DCCH_EST_REQ), + OSMO_VALUE_STRING(TRXCON_EV_DCCH_REL_REQ), OSMO_VALUE_STRING(TRXCON_EV_TX_DATA_REQ), OSMO_VALUE_STRING(TRXCON_EV_TX_DATA_CNF), OSMO_VALUE_STRING(TRXCON_EV_RX_DATA_IND), -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie388e251677da63306e9e53d98cbcc7c34777980 Gerrit-Change-Number: 30316 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size procedure

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30314 ) Change subject: WIP: ns: Add test for SNS Size procedure ...................................................................... WIP: ns: Add test for SNS Size procedure Related: OS#5208 Change-Id: Ica8f6334afadb741180eeb5eb40d8192e61a2e67 --- M ns/NS_Tests.ttcn 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/30314/1 diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index 722f8ec..565945c 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -558,6 +558,40 @@ /* 48.016 SNS test cases */ +/* Send an SNS Size(-ish) PDU, i.e. an SNS Size or an SNS Size with erroneous payload */ +function f_outgoing_sns_size_wrong_ip_family(template (omit) PDU_NS base) +runs on RAW_NS_CT { + const integer IDX := 0; + const integer NUM_IP := 1; + log("f_outgoing_sns_sizeish_pdu(idx=", IDX, ")"); + var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[IDX]; + var template (omit) NsCause cause := omit; + + if (nsvc_cfg.provider.ip.address_family == AF_INET) { + base.pDU_SNS_Size.numberOfIP6_Endpoints := + {iEI := '09'O, numberOfIP_Endpoints := int2oct(valueof(NUM_IP), 2)}; + cause := NS_CAUSE_INVALID_NR_OF_IPv4_ENDPOINTS; + } else { + base.pDU_SNS_Size.numberOfIP4_Endpoints := + {iEI := '08'O, numberOfIP_Endpoints := int2oct(valueof(NUM_IP), 2)}; + cause := NS_CAUSE_INVALID_NR_OF_IPv6_ENDPOINTS; + } + log("expected cause: ", cause); + NSCP[IDX].send(base); + f_ns_exp(tr_SNS_SIZE_ACK(g_nsconfig.nsei, cause), IDX); +} + +testcase TC_sgsn_sns_size_payload() runs on RAW_Test_CT { + f_init_ns_codec(mp_nsconfig); + /* Template that would be accepted, only missing the number of IP endpoints + * (since there are no ternary operators in TTCN-3...) */ + template (omit) PDU_NS ts_base_SNS_SIZE_configured := ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := 1, + num_v4 := omit, num_v6 := omit); + f_outgoing_sns_size_wrong_ip_family(ts_base_SNS_SIZE_configured); + setverdict(pass); + f_clean_ns_codec(); +} + /* do a succesful SNS configuration */ testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); @@ -1098,6 +1132,7 @@ execute( TC_sns_sgsn_add_change_del() ); execute( TC_sns_sgsn_size_correct_port() ); execute( TC_sns_sgsn_size_after_success() ); + execute( TC_sgsn_sns_size_payload() ); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica8f6334afadb741180eeb5eb40d8192e61a2e67 Gerrit-Change-Number: 30314 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump*.sh: Log stderr separately to file

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30311 ) Change subject: ttcn3-tcpdump*.sh: Log stderr separately to file ...................................................................... ttcn3-tcpdump*.sh: Log stderr separately to file The old output is preserved, too, in order to ensure compatibility with expectations regarding legacy behavior. Related: OS#5736 Change-Id: Ia92ff32c8ce09ab7805c5509837ec88fa4b864c5 --- M ttcn3-tcpdump-start.sh M ttcn3-tcpdump-stop.sh 2 files changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/30311/1 diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index 8bba72f..aa42e62 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -71,9 +71,28 @@ PID=$! echo $PID > $PIDFILE_NETCAT -$CMD -s 1500 -n -i any -w "$TTCN3_PCAP_PATH/$TESTCASE.pcap" >$TTCN3_PCAP_PATH/$TESTCASE.pcap.stdout 2>&1 & +CMD_OUTFILE=$TTCN3_PCAP_PATH/$TESTCASE.pcap.stdout +CMD_OUTFILE_ERR=$TTCN3_PCAP_PATH/$TESTCASE.pcap.stderr +FIFO=/tmp/cmderr +if ! [ -e $FIFO ]; then + mkfifo $FIFO +else + echo "Warning: Named pipe already exists: $FIFO" +fi + +# Log stderr to CMD_OUTFILE and a dedicated error log file +tee $CMD_OUTFILE < $FIFO > $CMD_OUTFILE_ERR & +CMD_STR="$CMD -s 1500 -n -i any -w \"$TTCN3_PCAP_PATH/$TESTCASE.pcap\" >$CMD_OUTFILE 2>$FIFO &" +eval $CMD_STR +# $CMD -s 1500 -n -i any -w \"$TTCN3_PCAP_PATH/$TESTCASE.pcap\" >$CMD_OUTFILE & PID=$! echo $PID > $PIDFILE_PCAP +if [ -f $CMD_OUTFILE_ERR ] && [ $(wc -l $CMD_OUTFILE_ERR | awk '{print $1}') -ne 0 ]; then + echo "Warnings or error messages from command:" >&2 + echo " $CMD_STR" >&2 + echo "Message:" >&2 + echo "$(cat $CMD_OUTFILE_ERR)" | sed 's/^/\t/' >&2 +fi # Wait until packet dumper creates the pcap file and starts recording. # We generate some traffic until we see packet dumper catches it. diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index 6796612..829ed2b 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -2,6 +2,7 @@ PIDFILE_PCAP=/tmp/pcap.pid PIDFILE_NETCAT=/tmp/netcat.pid +FIFO=/tmp/cmderr TESTCASE=$1 VERDICT="$2" @@ -68,5 +69,6 @@ kill_rm_pidfile "$PIDFILE_PCAP" kill_rm_pidfile "$PIDFILE_NETCAT" +rm $FIFO gzip -f "$TTCN3_PCAP_PATH/$TESTCASE.pcap" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia92ff32c8ce09ab7805c5509837ec88fa4b864c5 Gerrit-Change-Number: 30311 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump*.sh: Fix output of special chars

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30312 ) Change subject: ttcn3-tcpdump*.sh: Fix output of special chars ...................................................................... ttcn3-tcpdump*.sh: Fix output of special chars Don't print '-e' option in non-bash shells. Related: OS#5736 Change-Id: Idac0f902d2f5eb142a3f130409451c8f77b111f6 --- M ttcn3-tcpdump-stop.sh 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/30312/1 diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index 829ed2b..0568054 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -24,10 +24,17 @@ date -if [ x"$VERDICT" = x"pass" ]; then - echo -e "\033[1;32m====== $TESTCASE $VERDICT ======\033[0m" +# -e only works/is required only in Bash; in dash/POSIX shells it isn't required and will be part of the output +if (lsof -p $$ | grep -q /usr/bin/bash); then + ESCAPE_OPT="-e" else - echo -e "\033[1;31m------ $TESTCASE $VERDICT ------\033[0m" + ESCAPE_OPT="" +fi + +if [ x"$VERDICT" = x"pass" ]; then + echo $ESCAPE_OPT "\033[1;32m====== $TESTCASE $VERDICT ======\033[0m" +else + echo $ESCAPE_OPT "\033[1;31m------ $TESTCASE $VERDICT ------\033[0m" fi echo -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idac0f902d2f5eb142a3f130409451c8f77b111f6 Gerrit-Change-Number: 30312 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: Don't use lsof

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30313 ) Change subject: ttcn3-tcpdump-stop.sh: Don't use lsof ...................................................................... ttcn3-tcpdump-stop.sh: Don't use lsof `lsof` isn't available in the docker image, use /proc fs instead to get the shell type Related: OS#5736 Change-Id: I38e132f49b0711d611d08b61c28b3092c991a191 --- M ttcn3-tcpdump-stop.sh 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/13/30313/1 diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index 0568054..b479530 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -25,7 +25,9 @@ date # -e only works/is required only in Bash; in dash/POSIX shells it isn't required and will be part of the output -if (lsof -p $$ | grep -q /usr/bin/bash); then +# SHELL environment variable doesn't always give name of current shell (e.g. for dash run inside bash...) +SHELL_NAME="$(cat /proc/$$/cmdline | tr -d '\0')" +if [ "$SHELL_NAME" = "bash" ]; then ESCAPE_OPT="-e" else ESCAPE_OPT="" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I38e132f49b0711d611d08b61c28b3092c991a191 Gerrit-Change-Number: 30313 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump*.sh: Fix scripts hanging on sudo prompt

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30310 ) Change subject: ttcn3-tcpdump*.sh: Fix scripts hanging on sudo prompt ...................................................................... ttcn3-tcpdump*.sh: Fix scripts hanging on sudo prompt Related: OS#5736 Change-Id: I05687f9bc0bb87c6f1d5c42ba235dbb90a49aeb6 --- M ttcn3-tcpdump-start.sh M ttcn3-tcpdump-stop.sh 2 files changed, 23 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/30310/1 diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index 8433c80..8bba72f 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -10,9 +10,19 @@ TESTCASE=$1 + +SUDOSTR="" +if ! [ "$(id -u)" = "0" ]; then + SUDOSTR="sudo -n" + # Otherwise, if sudo /usr/bin/kill, sudo /usr/bin/tcpdump cannot be run without a password prompt, + # and this script will hang indefinitely +fi + kill_rm_pidfile() { - if [ -e $1 ]; then - kill "$(cat "$1")" + # NOTE: This requires you to be root or something like + # "laforge ALL=NOPASSWD: /usr/sbin/tcpdump, /bin/kill" in your sudoers file + if ! [ -e "$1" ] && [ -s "$1" ]; then + $SUDOSTR kill "$(cat "$1")" 2>&1 | grep -v "No such process" rm $1 fi } @@ -27,13 +37,7 @@ kill_rm_pidfile $PIDFILE_NETCAT kill_rm_pidfile $PIDFILE_PCAP -if [ "$(id -u)" = "0" ]; then - CMD="$TCPDUMP -U" -else -# NOTE: This requires you to be root or something like -# "laforge ALL=NOPASSWD: /usr/sbin/tcpdump, /bin/kill" in your sudoers file - CMD="sudo $TCPDUMP -U" -fi +CMD="$SUDOSTR $TCPDUMP -U" if [ -x "$DUMPCAP" ]; then CAP_ERR="1" diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index faf5b2b..6796612 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -5,18 +5,20 @@ TESTCASE=$1 VERDICT="$2" +SUDOSTR="" +if ! [ "$(id -u)" = "0" ]; then + SUDOSTR="sudo -n" + # Otherwise, if sudo /usr/bin/kill, sudo /usr/bin/tcpdump cannot be run without a password prompt, + # and this script will hang indefinitely +fi + kill_rm_pidfile() { -if [ -e $1 ]; then - PSNAME="$(ps -q "$(cat "$1")" -o comm=)" - if [ "$PSNAME" != "sudo" ]; then - kill "$(cat "$1")" - else # NOTE: This requires you to be root or something like # "laforge ALL=NOPASSWD: /usr/sbin/tcpdump, /bin/kill" in your sudoers file - sudo kill "$(cat "$1")" + if ! [ -e "$1" ] && [ -s "$1" ]; then + $SUDOSTR kill "$(cat "$1")" 2>&1 | grep -v "No such process" + rm $1 fi - rm $1 -fi } date -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I05687f9bc0bb87c6f1d5c42ba235dbb90a49aeb6 Gerrit-Change-Number: 30310 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: layer23: add 'src/modem/modem' to .gitignore

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30308 ) Change subject: layer23: add 'src/modem/modem' to .gitignore ...................................................................... layer23: add 'src/modem/modem' to .gitignore Change-Id: I37e536493ddfd3bff1674d5bc85f40a0bbd0f317 --- M src/host/layer23/.gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/layer23/.gitignore b/src/host/layer23/.gitignore index 8fb93f7..301e2c0 100644 --- a/src/host/layer23/.gitignore +++ b/src/host/layer23/.gitignore @@ -34,3 +34,4 @@ src/misc/ccch_scan src/misc/layer23 src/mobile/mobile +src/modem/modem -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I37e536493ddfd3bff1674d5bc85f40a0bbd0f317 Gerrit-Change-Number: 30308 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: add a spec. reference for the trxcon_fsm

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30309 ) Change subject: trxcon: add a spec. reference for the trxcon_fsm ...................................................................... trxcon: add a spec. reference for the trxcon_fsm Change-Id: I184abe10f874d97f047a3720c776fdef08d880e6 --- M src/host/trxcon/src/trxcon_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index d3420f2..164d6fb 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -1,5 +1,6 @@ /* * OsmocomBB <-> SDR connection bridge + * The trxcon state machine (see 3GPP TS 44.004, section 5.1) * * (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * Author: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I184abe10f874d97f047a3720c776fdef08d880e6 Gerrit-Change-Number: 30309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: add a spec. reference for the trxcon_fsm

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30309 ) Change subject: trxcon: add a spec. reference for the trxcon_fsm ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I184abe10f874d97f047a3720c776fdef08d880e6 Gerrit-Change-Number: 30309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Nov 2022 17:27:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: add a spec. reference for the trxcon_fsm

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30309 ) Change subject: trxcon: add a spec. reference for the trxcon_fsm ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I184abe10f874d97f047a3720c776fdef08d880e6 Gerrit-Change-Number: 30309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Nov 2022 16:45:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022