July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714
by fixeria 31 Jul '23

31 Jul '23

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34029 ) Change subject: ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee4cc0fbf03e7ca4b53424f7f52ed9d599f96e49 Gerrit-Change-Number: 34029 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:10:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: layer23: modem: gmm: Log allocated TLLI on Attach Success
by fixeria 31 Jul '23

31 Jul '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34030 ) Change subject: layer23: modem: gmm: Log allocated TLLI on Attach Success ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I29242873ebec173c430e6d413e6c533ec1e2b97a Gerrit-Change-Number: 34030 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:06:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: layer23: modem: Fix newline character typo in log line
by fixeria 31 Jul '23

31 Jul '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34028 ) Change subject: layer23: modem: Fix newline character typo in log line ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ff9b71ff469e339aadff643b582efb06d5efb6c Gerrit-Change-Number: 34028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:05:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: layer23: modem: gmm: Log allocated TLLI on Attach Success
by pespin 31 Jul '23

31 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34030 ) Change subject: layer23: modem: gmm: Log allocated TLLI on Attach Success ...................................................................... layer23: modem: gmm: Log allocated TLLI on Attach Success Change-Id: I29242873ebec173c430e6d413e6c533ec1e2b97a --- M src/host/layer23/src/modem/gmm.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/30/34030/1 diff --git a/src/host/layer23/src/modem/gmm.c b/src/host/layer23/src/modem/gmm.c index 17cc228..b8df38b 100644 --- a/src/host/layer23/src/modem/gmm.c +++ b/src/host/layer23/src/modem/gmm.c @@ -60,8 +60,9 @@ switch (OSMO_PRIM_HDR(&gmm_prim->oph)) { case OSMO_PRIM(OSMO_GPRS_GMM_GMMREG_ATTACH, PRIM_OP_CONFIRM): if (gmm_prim->gmmreg.attach_cnf.accepted) { - LOGP(DGMM, LOGL_NOTICE, "%s(): Rx %s: Attach success P-TMSI=0x%08x\n", - __func__, pdu_name, gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi); + LOGP(DGMM, LOGL_NOTICE, "%s(): Rx %s: Attach success P-TMSI=0x%08x TLLI=0x%08x\n", + __func__, pdu_name, gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi, + gmm_prim->gmmreg.attach_cnf.acc.allocated_tlli); ms->subscr.gprs.ptmsi = gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi; ms->gmmlayer.tlli = gmm_prim->gmmreg.attach_cnf.acc.allocated_tlli; app_data.modem_state = MODEM_ST_ATTACHED; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I29242873ebec173c430e6d413e6c533ec1e2b97a Gerrit-Change-Number: 34030 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714
by jolly 31 Jul '23

31 Jul '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34029 ) Change subject: ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714 ...................................................................... ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714 Change-Id: Iee4cc0fbf03e7ca4b53424f7f52ed9d599f96e49 --- M src/osmo-bsc/vgcs_fsm.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/34029/1 diff --git a/src/osmo-bsc/vgcs_fsm.c b/src/osmo-bsc/vgcs_fsm.c index 6b78933..8969d4f 100644 --- a/src/osmo-bsc/vgcs_fsm.c +++ b/src/osmo-bsc/vgcs_fsm.c @@ -539,8 +539,10 @@ /* Create VGCS FSM. */ conn->vgcs_call.fi = osmo_fsm_inst_alloc(&vgcs_call_fsm, conn->network, conn, LOGL_DEBUG, NULL); - if (!conn->vgcs_call.fi) + if (!conn->vgcs_call.fi) { + cause = GSM0808_CAUSE_INCORRECT_VALUE; goto reject; + } /* Init list of cells that are used by the call. */ INIT_LLIST_HEAD(&conn->vgcs_call.chan_list); @@ -1080,7 +1082,7 @@ }; uint8_t cause; struct gsm_bts *bts; - struct gsm_lchan *lchan; + struct gsm_lchan *lchan = NULL; int rc; int i; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee4cc0fbf03e7ca4b53424f7f52ed9d599f96e49 Gerrit-Change-Number: 34029 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: layer23: modem: Fix newline character typo in log line
by pespin 31 Jul '23

31 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34028 ) Change subject: layer23: modem: Fix newline character typo in log line ...................................................................... layer23: modem: Fix newline character typo in log line Change-Id: I3ff9b71ff469e339aadff643b582efb06d5efb6c --- M src/host/layer23/src/modem/gmm.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/28/34028/1 diff --git a/src/host/layer23/src/modem/gmm.c b/src/host/layer23/src/modem/gmm.c index 5ea2b43..17cc228 100644 --- a/src/host/layer23/src/modem/gmm.c +++ b/src/host/layer23/src/modem/gmm.c @@ -161,7 +161,7 @@ } } else { if (old_tlli != OSMO_GPRS_GMM_TLLI_UNASSIGNED) - LOGP(DGMM, LOGL_ERROR, "%s(): Unexpected Rx %s with unknown TLLI=0x%08xn", + LOGP(DGMM, LOGL_ERROR, "%s(): Unexpected Rx %s with unknown TLLI=0x%08x\n", __func__, pdu_name, old_tlli); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ff9b71ff469e339aadff643b582efb06d5efb6c Gerrit-Change-Number: 34028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: llc,sndcp: Add missing hex prefix to log line printing TLLI
by pespin 31 Jul '23

31 Jul '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 to look at the new patch set (#2). Change subject: llc,sndcp: Add missing hex prefix to log line printing TLLI ...................................................................... llc,sndcp: Add missing hex prefix to log line printing TLLI Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f --- M src/llc/llc_llgmm.c M src/sndcp/sndcp_prim.c M tests/llc/llc_prim_test.err M tests/sndcp/sndcp_prim_test.err 4 files changed, 27 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/27/34027/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f Gerrit-Change-Number: 34027 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-gprs[master]: llc: Add missing hex prefix to log line printing TLLI
by pespin 31 Jul '23

31 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 ) Change subject: llc: Add missing hex prefix to log line printing TLLI ...................................................................... llc: Add missing hex prefix to log line printing TLLI Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f --- M src/llc/llc_llgmm.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/27/34027/1 diff --git a/src/llc/llc_llgmm.c b/src/llc/llc_llgmm.c index 438de51..27150cc 100644 --- a/src/llc/llc_llgmm.c +++ b/src/llc/llc_llgmm.c @@ -166,7 +166,7 @@ goto ret_free; } - LOGLLME(llme, LOGL_NOTICE, "LLGM Assign pre (%08x => %08x)\n", old_tlli, new_tlli); + LOGLLME(llme, LOGL_NOTICE, "LLGM Assign pre (0x%08x => 0x%08x)\n", old_tlli, new_tlli); if (old_tlli == TLLI_UNASSIGNED && new_tlli != TLLI_UNASSIGNED) { /* TLLI Assignment 8.3.1 */ @@ -221,7 +221,7 @@ free = true; } - LOGLLME(llme, LOGL_NOTICE, "LLGM Assign post (%08x => %08x)\n", old_tlli, new_tlli); + LOGLLME(llme, LOGL_NOTICE, "LLGM Assign post (0x%08x => 0x%08x)\n", old_tlli, new_tlli); if (free) gprs_llc_llme_free(llme); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f Gerrit-Change-Number: 34027 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI
by pespin 31 Jul '23

31 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34026 ) Change subject: rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI ...................................................................... rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI Change-Id: If0bbd9989413a550243a6496bce16b6eb04508db --- M src/rlcmac/rlcmac.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/26/34026/1 diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index a6d0e71..212b801 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -701,13 +701,14 @@ { struct gprs_rlcmac_ul_tbf *ul_tbf; int rc; + const Packet_Uplink_Ack_Nack_t *pkt_ul_ack = &dl_block->u.Packet_Uplink_Ack_Nack; - ul_tbf = gprs_rlcmac_find_ul_tbf_by_tfi(dl_block->TFI); + ul_tbf = gprs_rlcmac_find_ul_tbf_by_tfi(pkt_ul_ack->UPLINK_TFI); if (!ul_tbf) { LOGRLCMAC(LOGL_INFO, "TS=%u FN=%u Rx Pkt UL ACK/NACK: UL_TBF TFI=%u not found\n", rlcmac_prim->l1ctl.pdch_data_ind.ts_nr, rlcmac_prim->l1ctl.pdch_data_ind.fn, - dl_block->TFI); + pkt_ul_ack->UPLINK_TFI); return -ENOENT; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If0bbd9989413a550243a6496bce16b6eb04508db Gerrit-Change-Number: 34026 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: llc: Silently dicard UI Dummy commands
by pespin 31 Jul '23

31 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 ) Change subject: llc: Silently dicard UI Dummy commands ...................................................................... llc: Silently dicard UI Dummy commands Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 --- M src/llc/llc.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/25/34025/1 diff --git a/src/llc/llc.c b/src/llc/llc.c index be1ebec..dc1a7b6 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -53,6 +53,11 @@ { 0, NULL } }; +/* 3GPP TS 44.064 6.4.2.2 */ +static const uint8_t gprs_llc_ui_dummy_command[] = { + 0x43, 0xc0, 0x01, 0x2b, 0x2b, 0x2b +}; + /* Section 8.9.9 LLC layer parameter default values */ static const struct gprs_llc_params llc_default_params[NUM_SAPIS] = { [1] = { @@ -844,6 +849,15 @@ if (~pdu_dec->flags & OSMO_GPRS_LLC_PDU_F_PROT_MODE) crc_length = OSMO_MIN(crc_length, UI_HDR_LEN + N202); if (pdu_dec->fcs != gprs_llc_fcs(ll_pdu, crc_length)) { + if (ll_pdu_len >= sizeof(gprs_llc_ui_dummy_command) || + memcmp(ll_pdu, gprs_llc_ui_dummy_command, sizeof(gprs_llc_ui_dummy_command)) == 0) { + /* 6.4.2.2: "If the LLC entity at the MS receives a UI Dummy command, it shall discard + * it without any further actions" [...] + * "The format specified for the UI Dummy command ensures that a receiving LLC entity + * will always discard it, since the FCS field check always fails" "*/ + LOGLLE(lle, LOGL_DEBUG, "Dropping UI Dummy command len=%zu\n", ll_pdu_len); + return 0; + } LOGLLE(lle, LOGL_NOTICE, "Dropping frame with invalid FCS 0x%06x vs exp 0x%06x: %s\n", pdu_dec->fcs, gprs_llc_fcs(ll_pdu, crc_length), osmo_hexdump(ll_pdu, ll_pdu_len)); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 Gerrit-Change-Number: 34025 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0