Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34022 )
Change subject: jobs/osmo-gsm-tester: disable
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think we should at least keep _run-virtual working for now.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34022
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I5f7468a402d82e3b6ee03b4f792ae7e3aae3942b
Gerrit-Change-Number: 34022
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jul 2023 13:45:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34022 )
Change subject: jobs/osmo-gsm-tester: disable
......................................................................
jobs/osmo-gsm-tester: disable
After _run-prod, _run-rnd, _ttcn3 had already been disabled in
I8db4fbe2c695e28eb9f7e738c5a848fb0071714a, also disable _run-virtual
and the jobs that build the artifacts (as there is no point in building
them if all run jobs are disabled).
osmo-gsm-tester has been unmaintained for a while now, and after
migrating most of the CI infrastructure to debian 12, the virtual job
started failing because it depends on the debian-buster-jenkins
container (debian 10) that we don't build anymore.
While we could still build debian-buster-jenkins, I think it makes more
sense to just disable this. The job breaks from time to time, and we
don't need to spend time fixing it if it is not really used.
Related: OS#6057
Change-Id: I5f7468a402d82e3b6ee03b4f792ae7e3aae3942b
---
M jobs/osmo-gsm-tester-builder.yml
M jobs/osmo-gsm-tester-runner.yml
2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/22/34022/1
diff --git a/jobs/osmo-gsm-tester-builder.yml b/jobs/osmo-gsm-tester-builder.yml
index cd50cb8..c128959 100644
--- a/jobs/osmo-gsm-tester-builder.yml
+++ b/jobs/osmo-gsm-tester-builder.yml
@@ -46,6 +46,7 @@
- job-template:
name: 'osmo-gsm-tester_build-{repo}'
+ disabled: true
project-type: freestyle
node: osmo-gsm-tester-build
builders:
diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml
index db0a491..ead0676 100644
--- a/jobs/osmo-gsm-tester-runner.yml
+++ b/jobs/osmo-gsm-tester-runner.yml
@@ -212,6 +212,7 @@
# virtual tester job
- job:
name: 'osmo-gsm-tester_virtual'
+ disabled: true
defaults: runner
node: 'osmocom-master'
scm:
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34022
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I5f7468a402d82e3b6ee03b4f792ae7e3aae3942b
Gerrit-Change-Number: 34022
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: laforge, tnt.
manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27579 )
Change subject: usb: Deal with truncated ISO IN transfers
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This still isn't merged, but it probably should be.
I don't feel qualified to comment on USB changes (as I have absolutely 0 knowledge about USB), but I've been running this change for a while now and it seems to work fine.
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27579
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ic453325b93b0e12727625a1495a948d96df4b542
Gerrit-Change-Number: 27579
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Mon, 31 Jul 2023 12:52:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 )
Change subject: ASCI: Add tests for voice group/broadcast calls at MSC
......................................................................
Patch Set 2:
(1 comment)
File msc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/c1f203c9_8cc7…
PS2, Line 68: inout charstring, CallParameters, ASCI_Event;
> ... Sounds simple, but then also means that they need their own f_init* etc. functions wrapping those of the components derived of to set up that port.
Adding module-local f_init* etc. functions is not really needed if you derive a new component from an already existing component (using the `extends` keyword). For instance:
```
type component FooBarCT extends FooCT, BarCT { ... };
function f_foo() runs on FooCT { ... }
```
In this example function `f_foo` can not only be called from component `FooCT`, but also from component `FooBarCT`, because the later inherits all fields/ports from the former. So all `f_init*` functions and altsteps from module `MSC_Tests` would still be usable for `MSC_Tests_ASCI`, even if it derives its own `TestCT`.
Furthermore, AFAICS, setting up the COORD ports currently needs to be done manually in each testcase spawning more than one child component. The `f_init*` functions are not involved in this process.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8
Gerrit-Change-Number: 33979
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jul 2023 11:48:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment