osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/33986 )
Change subject: Cosmetic: jobs/gerrit: update pipeline comment
......................................................................
Cosmetic: jobs/gerrit: update pipeline comment
Change-Id: If06af0e955240e1b9d678f1020767bbfb70b1d96
---
M jobs/gerrit-verifications.yml
1 file changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/86/33986/1
diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index 7b6c1f8..2bbe261 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -24,7 +24,8 @@
# NOTE: after updating the job with Jenkins Job Builder as usual, check if a
# new pipeline script was generated and approve it here:
# https://jenkins.osmocom.org/jenkins/scriptApproval/
-# This happens when changing the pipeline script, when adding new projects etc.
+# This used to be necessary when changing the pipeline script, adding new
+# projects etc. But it seems to get auto-approved now.
- project:
name: gerrit
@@ -466,11 +467,6 @@
name: PIPELINE_ENDIANNESS
description: Run struct_endianness.py from libosmocore.git
default: '{obj:pipeline_endianness}'
- # NOTE: jenkins pipelines don't run unless the dsl-script was approved.
- # Sadly this doesn't happen automatically when updating the job with
- # Jenkins Job Builder. So if you change the pipeline script, update the job
- # as usually with JJB and then approve the scripts here:
- # https://jenkins.osmocom.org/jenkins/scriptApproval/
dsl: |
pipeline {{
agent none
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33986
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: If06af0e955240e1b9d678f1020767bbfb70b1d96
Gerrit-Change-Number: 33986
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33954 )
Change subject: utils: tolerate uninitialized fields in dec_addr_tlv
......................................................................
utils: tolerate uninitialized fields in dec_addr_tlv
TLV fields holding an address may still be uninitialized and hence
filled with 0xff bytes. Lets interpret those fields in the same way as
we interpret empty fields.
Related: OS#6094
Change-Id: Idc0a92ea88756266381c8da2ad62de061a8ea7a1
---
M pySim/utils.py
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/pySim/utils.py b/pySim/utils.py
index 735468e..1541e2e 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -771,6 +771,10 @@
if tlv[1] == 0:
continue
+ # Uninitialized field
+ if all([v == 0xff for v in tlv[2]]):
+ continue
+
# First byte in the value has the address type
addr_type = tlv[2][0]
# TODO: Support parsing of IPv6
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idc0a92ea88756266381c8da2ad62de061a8ea7a1
Gerrit-Change-Number: 33954
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33963 )
Change subject: tests: add test script for pySim-trace
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
this is good for a very basic test, but *not raising an exception* is of course a rather vague "pass criteria". I guess we have to think about what can be done in terms of further result verification (in follow-up patches). A low-hanging fruit would be to match the number of APDUs received.
One *could* match the console output (similar to our autotest unit-tests in the osmo-{bts,bsc,msc,...} software. However, as we also know from there, every minor whitespace or cosmetic change will then require updating of the test results. Given that it should be simple to implement (famous last words), I think it might be worth a shot to have an expected stdout/stderr text file against we compare the pySim-trace output.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33963
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icfabfa7c59968021eef0399991bd05b92467d8d2
Gerrit-Change-Number: 33963
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 09:06:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33960 )
Change subject: pySim-trace: mark card reset in the trace
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33960
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia550a8bd2f45d2ad622cb2ac2a2905397db76bce
Gerrit-Change-Number: 33960
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 09:02:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: dexter.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/33963
to look at the new patch set (#4).
Change subject: tests: add test script for pySim-trace
......................................................................
tests: add test script for pySim-trace
pySim-trace has no test coverage yet. Let's use a script to run a
GSAMTAP pcacp through it and check that no exceptions are raised.
Related: OS#6094
Change-Id: Icfabfa7c59968021eef0399991bd05b92467d8d2
---
M contrib/jenkins.sh
A pysim-testdata/pySim-trace_test_gsmtap.pcapng
A tests/pySim-trace_test.sh
3 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/63/33963/4
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33963
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icfabfa7c59968021eef0399991bd05b92467d8d2
Gerrit-Change-Number: 33963
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/33960
to look at the new patch set (#2).
Change subject: pySim-trace: mark card reset in the trace
......................................................................
pySim-trace: mark card reset in the trace
The trace log currently does not contain any information about card
resets. This makes the trace difficult to follow. Let's use the
CardReset object to display the ATR in the trace.
Related: OS#6094
Change-Id: Ia550a8bd2f45d2ad622cb2ac2a2905397db76bce
---
M pySim-trace.py
M pySim/apdu/__init__.py
M pySim/apdu_source/gsmtap.py
M pySim/apdu_source/pyshark_gsmtap.py
M pySim/apdu_source/pyshark_rspro.py
5 files changed, 32 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/33960/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33960
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia550a8bd2f45d2ad622cb2ac2a2905397db76bce
Gerrit-Change-Number: 33960
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
Hello Jenkins Builder, laforge, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/33954
to look at the new patch set (#2).
Change subject: utils: tolerate uninitialized fields in dec_addr_tlv
......................................................................
utils: tolerate uninitialized fields in dec_addr_tlv
TLV fields holding an address may still be uninitialized and hence
filled with 0xff bytes. Lets interpret those fields in the same way as
we interpret empty fields.
Related: OS#6094
Change-Id: Idc0a92ea88756266381c8da2ad62de061a8ea7a1
---
M pySim/utils.py
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/54/33954/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idc0a92ea88756266381c8da2ad62de061a8ea7a1
Gerrit-Change-Number: 33954
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33954 )
Change subject: utils: tolerate uninitialized fields in dec_addr_tlv
......................................................................
Patch Set 2:
(1 comment)
File pySim/utils.py:
https://gerrit.osmocom.org/c/pysim/+/33954/comment/c6a3fb52_0e55bc8c
PS1, Line 775: if tlv[2] == [0xff] * len(tlv[2]):
> Not critical: I would recommend doing `if all([v == 0xff for v in tlv[2]]):`, as it's more self-expl […]
Self explanatory is in the eye of the beholder.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idc0a92ea88756266381c8da2ad62de061a8ea7a1
Gerrit-Change-Number: 33954
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 08:37:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
Hello Jenkins Builder, laforge, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/33962
to look at the new patch set (#2).
Change subject: pySim-trace: catch StopIteration exception on trace file end
......................................................................
pySim-trace: catch StopIteration exception on trace file end
When the trace file end is reaced, pyShark raises a StopIteration
exception. Let's catch this exception and exit gracefully.
Related: OS#6094
Change-Id: I6ab5689b909333531d08bf46e5dfea59b161a79e
---
M pySim-trace.py
1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/33962/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33962
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6ab5689b909333531d08bf46e5dfea59b161a79e
Gerrit-Change-Number: 33962
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33959 )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: pySim-trace: add commandline option --show-raw-apdu
......................................................................
pySim-trace: add commandline option --show-raw-apdu
The trace log currently only shows the parsed APDU. However, depending
on the problem to investigate it may be required to see the raw APDU
string as well. Let's add an option for this.
Related: OS#6094
Change-Id: I1a3bc54c459e45ed3154479759ceecdc26db9d37
---
M pySim-trace.py
1 file changed, 24 insertions(+), 4 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/pySim-trace.py b/pySim-trace.py
index d457bf4..453ee43 100755
--- a/pySim-trace.py
+++ b/pySim-trace.py
@@ -83,10 +83,13 @@
# parameters
self.suppress_status = kwargs.get('suppress_status', True)
self.suppress_select = kwargs.get('suppress_select', True)
+ self.show_raw_apdu = kwargs.get('show_raw_apdu', False)
self.source = kwargs.get('source', None)
- def format_capdu(self, inst: ApduCommand):
+ def format_capdu(self, apdu: Apdu, inst: ApduCommand):
"""Output a single decoded + processed ApduCommand."""
+ if self.show_raw_apdu:
+ print(apdu)
print("%02u %-16s %-35s %-8s %s %s" % (inst.lchan_nr, inst._name, inst.path_str, inst.col_id, inst.col_sw, inst.processed))
print("===============================")
@@ -95,7 +98,6 @@
while True:
# obtain the next APDU from the source (blocking read)
apdu = self.source.read()
- #print(apdu)
if isinstance(apdu, CardReset):
self.rs.reset()
@@ -113,7 +115,7 @@
if self.suppress_status and isinstance(inst, UiccStatus):
continue
#print(inst)
- self.format_capdu(inst)
+ self.format_capdu(apdu, inst)
option_parser = argparse.ArgumentParser(description='Osmocom pySim high-level SIM card trace decoder',
formatter_class=argparse.ArgumentDefaultsHelpFormatter)
@@ -128,6 +130,9 @@
help="""
Don't suppress displaying STATUS APDUs. We normally suppress them as they don't provide any
information that was not already received in resposne to the most recent SEELCT.""")
+global_group.add_argument('--show-raw-apdu', action='store_true', dest='show_raw_apdu',
+ help="""Show the raw APDU in addition to its parsed form.""")
+
subparsers = option_parser.add_subparsers(help='APDU Source', dest='source', required=True)
@@ -172,7 +177,8 @@
elif opts.source == 'gsmtap-pyshark-pcap':
s = PysharkGsmtapPcap(opts.pcap_file)
- tracer = Tracer(source=s, suppress_status=opts.suppress_status, suppress_select=opts.suppress_select)
+ tracer = Tracer(source=s, suppress_status=opts.suppress_status, suppress_select=opts.suppress_select,
+ show_raw_apdu=opts.show_raw_apdu)
logger.info('Entering main loop...')
tracer.main()
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33959
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1a3bc54c459e45ed3154479759ceecdc26db9d37
Gerrit-Change-Number: 33959
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33981 )
Change subject: rlcmac: Use enum gprs_rlcmac_radio_priority internally everywhere
......................................................................
Patch Set 2:
(2 comments)
File src/rlcmac/gre.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33981/comment/81395015_3aadbc26
PS2, Line 226: ll_pdu_len, get_value_string(osmo_gprs_rlcmac_llc_sapi_names, sapi), radio_prio + 1);
I wonder if it made sense to adjust the enum in types_private.h:
```
/* TS 44.060 Table Table 11.2.5. "Radio Priority" */
enum gprs_rlcmac_radio_priority {
GPRS_RLCMAC_RADIO_PRIORITY_1 = 0, /* Radio Priority 1 (Highest priority) */
GPRS_RLCMAC_RADIO_PRIORITY_2 = 1, /* Radio Priority 2 */
GPRS_RLCMAC_RADIO_PRIORITY_3 = 2, /* Radio Priority 3 */
GPRS_RLCMAC_RADIO_PRIORITY_4 = 3, /* Radio Priority 4 (Lower priority) */
};
```
to add GPRS_RLCMAC_RADIO_PRIORITY_INVALID = 0 and shift the rest. Then it wouldn't be necessary to add the +1 here. What do you think about that?
File tests/rlcmac/rlcmac_prim_test.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33981/comment/b951568f_6e6e67da
PS2, Line 991: 2
2 instead of 1 on purpose?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33981
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: If2d1946522bc4a1c19d65acb23605f1a3f05ab45
Gerrit-Change-Number: 33981
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:45:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33970 )
Change subject: sm: Introduce APIs to enc/dec QoS Profile
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Regarding endianness, should we disable the check? it will keep on failing in all future patches if either it's fixed or we disable the check.
Related: https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/thread/…
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33970
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I6c0676e55bb1f0f424f41d8d04d4f5e5bf376f4f
Gerrit-Change-Number: 33970
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 )
Change subject: ASCI: Add tests for voice group/broadcast calls at MSC
......................................................................
Patch Set 1:
(1 comment)
File msc/MSC_Tests_ASCI.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/11ca1583_6a84…
PS1, Line 50: type integer ASCI_TEST;
: const ASCI_TEST ASCI_TEST_NO_CALLREF := 1;
: const ASCI_TEST ASCI_TEST_SETUP_REFUSE := 2;
: const ASCI_TEST ASCI_TEST_ASSIGN_FAIL := 3;
: const ASCI_TEST ASCI_TEST_COMPLETE_VGCS := 4;
: const ASCI_TEST ASCI_TEST_COMPLETE_VBS := 5;
> Looks like it's done this way because the `BSC_ConnHdlr_Coord_PT` can only deliver charstrings and i […]
one could also simply add the new enum type as something that can be sent over the existing port coord_pt instead of the "int".
I will also try to revisit the existing code sending chartering over it. if it is a similar usage, it should also be modified (not in this patch series, of course)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8
Gerrit-Change-Number: 33979
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33949 )
Change subject: llc: Submit LL-XID-IND to L3 if N201-U or N201-I changes
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/llc/llc_ll.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33949/comment/b946c778_d29f517a
PS3, Line 182:
can you fix the indentation here while at it?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33949
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I8135c5cef4df69a7c3a540050da0837bf2059df2
Gerrit-Change-Number: 33949
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:25:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33947 )
Change subject: llc: Introduce function to log XID fields and use upon Rx/Tx
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33947
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I8c6b07305c0bcecb4e1681967884a3e62c813592
Gerrit-Change-Number: 33947
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:22:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33947 )
Change subject: llc: Introduce function to log XID fields and use upon Rx/Tx
......................................................................
Patch Set 3:
(1 comment)
File src/llc/llc_xid.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33947/comment/f18b7053_b6bece32
PS3, Line 325: void gprs_llc_dump_xid_fields(const struct gprs_llc_xid_field *xid_fields,
> We have such markers (one being line and one end line) in osmo-pcu and I became to really dislike th […]
Ack
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33947
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I8c6b07305c0bcecb4e1681967884a3e62c813592
Gerrit-Change-Number: 33947
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:22:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: lynxis lazus.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33985 )
Change subject: Reimplement ust_service_activate and ust_service_deactivate for USIM/EF.UST
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
nice catch. I'm most surprised that our tests don't cover this, so we should definitely extend those to cover it.
in terms of binascii: we have our own b2h/h2b functions in pySim.utils, and all other code uses that. might be best to align with it?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33985
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7a6a77b872a6f5d8c478ca75dcff8ea067b8203e
Gerrit-Change-Number: 33985
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:20:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly, laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 )
Change subject: ASCI: Add tests for voice group/broadcast calls at MSC
......................................................................
Patch Set 1:
(3 comments)
File msc/MSC_Tests_ASCI.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/b85e6ea8_377e…
PS1, Line 50: type integer ASCI_TEST;
: const ASCI_TEST ASCI_TEST_NO_CALLREF := 1;
: const ASCI_TEST ASCI_TEST_SETUP_REFUSE := 2;
: const ASCI_TEST ASCI_TEST_ASSIGN_FAIL := 3;
: const ASCI_TEST ASCI_TEST_COMPLETE_VGCS := 4;
: const ASCI_TEST ASCI_TEST_COMPLETE_VBS := 5;
> I think this could/should go into an enum, not an integer?
Looks like it's done this way because the `BSC_ConnHdlr_Coord_PT` can only deliver charstrings and integers (added by preceding patch). I propose to add a new port definition, dedicated/specific to this module, which would allow sending/receiving enumerate types (also specific to this module).
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/85622915_b2e1…
PS1, Line 58: type component asci_CT extends MTC_CT {
Just a friendly note (not critical): it's better to mark module-local types, altsteps, and functions as such (using the `private` keyword). This improves the compilation time, especially if some other module imports something from this one. And generally good for readability.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/b4235e1b_0971…
PS1, Line 65: const charstring COORD_SETUP := "SETUP";
> you don't really need to do this with charstring. […]
full ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8
Gerrit-Change-Number: 33979
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 27 Jul 2023 21:44:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33977 )
Change subject: ASCI: Add integer type to BSC_ConnHdlr_Coord_PT port
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Agree, I don't see why do we need that. Simply send strings?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33977
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2bb9bec5b084ad5e2a46caa91d1908d2c6781132
Gerrit-Change-Number: 33977
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 27 Jul 2023 21:23:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment