Attention is currently required from: arehbein.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/33892 )
Change subject: bsc (WIP): Make socket queue max. length configurable
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/2bc3f473_df100096
PS4, Line 7: bsc (WIP): Make socket queue max. length configurable
is the patch WIP? then it should be marked WIP in gerrit, imho. Or is it something
scheduled for merge? Then it shoudln't contain WIP in the subject/commitlog.
IMHO a patch should never contain WIP in the commit message at the point you push it to
gerrit. Either it's local WIP (and hence shouldn't go to gerrit). Or it is
gerrit-WIP and marked with the related status.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/33892
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic5f19f4613bccaf582997a4d02b689adee083a0b
Gerrit-Change-Number: 33892
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jul 2023 11:32:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment