Attention is currently required from: jolly, fixeria, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 )
Change subject: ASCI: Add tests for voice group/broadcast calls at MSC
......................................................................
Patch Set 2:
(1 comment)
File msc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/b924d7bb_0382…
PS2, Line 68: inout charstring, CallParameters, ASCI_Event;
What I don't like in the current patch revision is
that we end up having testsuite specific stuff in a common module: `ASCI_Event` in this
case. IMO, it's cleaner if each testsuite (`MSC_Tests`, `MSC_Tests_Iu`, and the new
`BSC_Tests_ASCI`) would define its own COORD port and the related enums/types internally.
This may not apply to the `MSC_Tests_Iu`, because it's mostly re-using the test logic
from `MSC_Tests`, but I don't see the need for the `MSC_Tests[_Iu]` to have access to
ASCI specific port messages.
So this would mean that every user of the coordination port would have to derive their own
component types with a private port definition, then referring to the private enum type
for the messages over that port. Sounds simple, but then also means that they need their
own f_init* etc. functions wrapping those of the components derived of to set up that
port.
It is definitely much cleaner but might be significant additional work. I guess one would
have to try it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8
Gerrit-Change-Number: 33979
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jul 2023 11:30:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment