Attention is currently required from: jolly, fixeria, pespin.

View Change

1 comment:

• File msc/BSC_ConnectionHandler.ttcn:

  • Patch Set #2, Line 68: inout charstring, CallParameters, ASCI_Event;

    What I don't like in the current patch revision is that we end up having testsuite specific stuff in a common module: `ASCI_Event` in this case. IMO, it's cleaner if each testsuite (`MSC_Tests`, `MSC_Tests_Iu`, and the new `BSC_Tests_ASCI`) would define its own COORD port and the related enums/types internally. This may not apply to the `MSC_Tests_Iu`, because it's mostly re-using the test logic from `MSC_Tests`, but I don't see the need for the `MSC_Tests[_Iu]` to have access to ASCI specific port messages.

    So this would mean that every user of the coordination port would have to derive their own component types with a private port definition, then referring to the private enum type for the messages over that port. Sounds simple, but then also means that they need their own f_init* etc. functions wrapping those of the components derived of to set up that port.

    It is definitely much cleaner but might be significant additional work. I guess one would have to try it.

To view, visit change 33979. To unsubscribe, or for help writing mail filters, visit settings.