- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: card_key_provider: add a static method to parse --column-keys args
by laforge 11 May '26

11 May '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42736?usp=email ) Change subject: card_key_provider: add a static method to parse --column-keys args ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42736?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic955f271b1de1b1b855b21c82ed10343044e45fa Gerrit-Change-Number: 42736 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 10 May 2026 17:56:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: card_key_provider: pass CardKeyFieldCryptor to constructor
by laforge 11 May '26

11 May '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42735?usp=email ) Change subject: card_key_provider: pass CardKeyFieldCryptor to constructor ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If43552740aadacab9126f8a002749a9582eef8f4 Gerrit-Change-Number: 42735 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 10 May 2026 17:56:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: card_key_provider: move boiler-plate code into helper functions
by laforge 11 May '26

11 May '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42734?usp=email ) Change subject: card_key_provider: move boiler-plate code into helper functions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6d095cbb644e608f4a751a1d0749b1484cdc781d Gerrit-Change-Number: 42734 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 10 May 2026 17:55:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-bts[master]: trx, bts: add optional WebSDR backend (callback-based transport)
by Timur Davydov 10 May '26

10 May '26

Attention is currently required from: Timur Davydov, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Code-Review-1 by laforge, Verified+1 by Jenkins Builder Change subject: trx, bts: add optional WebSDR backend (callback-based transport) ...................................................................... trx, bts: add optional WebSDR backend (callback-based transport) Introduce WebSDR backend enabled via ENABLE_WEBSDR, adding an alternative callback-based transport alongside existing socket-based TRX/OSMUX I/O Implement: - TRX control via osmotrxlib_process_command() - TRXD data via apitrx_tx_call()/trx_data_read() - clock handling via apibts_clock_ind() and external timers - Osmux integration via ws_osmux_* helpers Adapt scheduler to support API-based burst submission and external timer callbacks in WebSDR mode Disable signal handling, stats and socket I/O when building with ENABLE_WEBSDR Add WebSDR API entrypoint, Emscripten build target and example configuration Enables running BTS/TRX stack in WebAssembly environments Change-Id: Idebd588f33afd85021813ad5821391781db683a9 --- M .gitignore A doc/examples/trx/osmo-bts-trx-websdr.cfg M src/common/main.c M src/common/osmux.c M src/osmo-bts-trx/Makefile.am M src/osmo-bts-trx/main.c A src/osmo-bts-trx/osmo-bts-trx-websdr.c A src/osmo-bts-trx/osmo-bts-trx-websdr.h M src/osmo-bts-trx/scheduler_trx.c M src/osmo-bts-trx/trx_if.c M src/osmo-bts-trx/trx_vty.c 11 files changed, 722 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/03/42703/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9 Gerrit-Change-Number: 42703 Gerrit-PatchSet: 12 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in pysim[master]: card_key_provider: add a static method to parse --column-keys args
by dexter 09 May '26

09 May '26

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42736?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: card_key_provider: add a static method to parse --column-keys args ...................................................................... card_key_provider: add a static method to parse --column-keys args The contents of the --column-keys arguments are currently parsed in init_card_key_provider. Let's add a static method in CardKeyFieldCryptor to simplify re-usage of the CardKeyFieldCryptor Related: SYS#6959 Change-Id: Ic955f271b1de1b1b855b21c82ed10343044e45fa --- M pySim/card_key_provider.py 1 file changed, 19 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/42736/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42736?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic955f271b1de1b1b855b21c82ed10343044e45fa Gerrit-Change-Number: 42736 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in pysim[master]: card_key_provider: move boiler-plate code into helper functions
by dexter 09 May '26

09 May '26

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42734?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: card_key_provider: move boiler-plate code into helper functions ...................................................................... card_key_provider: move boiler-plate code into helper functions in pySim-shell.py we add the commandline options for the card key provider and do the setup accordingly. Let's put this boilerplate code into helper functions instead, so that we can re-use it in other pySim programs as well. Let's use pySim.transport as a pattern. Related: SYS#6959 Change-Id: I6d095cbb644e608f4a751a1d0749b1484cdc781d --- M pySim-shell.py M pySim/card_key_provider.py 2 files changed, 53 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/34/42734/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6d095cbb644e608f4a751a1d0749b1484cdc781d Gerrit-Change-Number: 42734 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: card_key_provider: pass CardKeyFieldCryptor to constructor
by dexter 09 May '26

09 May '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42735?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: card_key_provider: pass CardKeyFieldCryptor to constructor ...................................................................... card_key_provider: pass CardKeyFieldCryptor to constructor We currently create the CardKeyFieldCryptor object inside the constructor of the concrete CardKeyProvider classes. There is currently no problem with that, but when we create the CardKeyFieldCryptor object first and then pass it as parameter to the constructor, we gain more flexibility in case we want to support other CardKeyFieldCryptor variants in the future. Related: SYS#6959 Change-Id: If43552740aadacab9126f8a002749a9582eef8f4 --- M pySim/card_key_provider.py M tests/unittests/test_card_key_provider.py 2 files changed, 11 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/42735/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If43552740aadacab9126f8a002749a9582eef8f4 Gerrit-Change-Number: 42735 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in pysim[master]: card_key_provider: move boiler-plate code into helper functions
by dexter 09 May '26

09 May '26

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42734?usp=email ) Change subject: card_key_provider: move boiler-plate code into helper functions ...................................................................... Patch Set 2: (2 comments) File pySim/card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/42734/comment/e3184fda_128a1aca?usp=em… : PS1, Line 337: def argparse_add_card_key_provider_args(arg_parser: argparse.ArgumentParser): > to be consistent with other methods I would call it card_key_provider_argparse_add_args or something […] I took the scheme from pySim/transport/__init__.py. There we use the prefixes argparse_add_ and init_. But I see, there is already card_key_provider_register. Now everything falls apart. I would say the consistency inside the file weighs more then the consistency throughout modules. https://gerrit.osmocom.org/c/pysim/+/42734/comment/e6b32bfa_0b3b1024?usp=em… : PS1, Line 344: init_card_key_provider > likewise here I'd call it card_key_provider_init similar to card_key_provider_{get,get_field} above Yes, let's use the card_key_provider_ prefix. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6d095cbb644e608f4a751a1d0749b1484cdc781d Gerrit-Change-Number: 42734 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 08 May 2026 15:55:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: ConfigurableParameter: safer val length check
by laforge 08 May '26

08 May '26

Attention is currently required from: fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42260?usp=email ) Change subject: ConfigurableParameter: safer val length check ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibe91722ed1477b00d20ef5e4e7abd9068ff2f3e4 Gerrit-Change-Number: 42260 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 May 2026 08:37:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: UppAudit: better indicate exception cause
by laforge 08 May '26

08 May '26

Attention is currently required from: fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42259?usp=email ) Change subject: UppAudit: better indicate exception cause ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4d986b89a473a5b12ed56b4710263b034876a33e Gerrit-Change-Number: 42259 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 May 2026 08:36:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log