- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: ss7_xua_server_destroy(): Disconnect streams properly
by pespin 25 Nov '25

25 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41500?usp=email ) Change subject: ss7_xua_server_destroy(): Disconnect streams properly ...................................................................... ss7_xua_server_destroy(): Disconnect streams properly destroying ASPs is wrong, since that'd also destroy non-dynamic ASPs, hence erasing the configuration. Instead, close oly the stream, and dynamic ASPs get destroyed as a consequence. Change-Id: I1309015053d2bd22d8fdf6298f8918a47527340e --- M src/ss7_xua_srv.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/00/41500/1 diff --git a/src/ss7_xua_srv.c b/src/ss7_xua_srv.c index 077eea0..a97b07f 100644 --- a/src/ss7_xua_srv.c +++ b/src/ss7_xua_srv.c @@ -397,11 +397,13 @@ if (xs->server) { osmo_stream_srv_link_close(xs->server); osmo_stream_srv_link_destroy(xs->server); + xs->server = NULL; } - /* iterate and close all connections established in relation - * with this server */ + + /* iterate and close all connections established in relation with this server. + * Dynamic ASPs in SCTP=server are destroyed when connection is closed. */ llist_for_each_entry_safe(asp, asp2, &xs->asp_list, siblings) - osmo_ss7_asp_destroy(asp); + ss7_asp_disconnect_stream(asp); llist_del(&xs->list); talloc_free(xs); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41500?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1309015053d2bd22d8fdf6298f8918a47527340e Gerrit-Change-Number: 41500 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: ss7_asp: Do AS-eSLS table cleanup during osmo_ss7_asp_destroy()
by pespin 25 Nov '25

25 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41499?usp=email ) Change subject: ss7_asp: Do AS-eSLS table cleanup during osmo_ss7_asp_destroy() ...................................................................... ss7_asp: Do AS-eSLS table cleanup during osmo_ss7_asp_destroy() Use the existing API to cleanly remove the association between ASP and AS. Change-Id: I2c1b25d3e76703b88111b9935685a58d039b8e23 --- M src/ss7_asp.c 1 file changed, 3 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/99/41499/1 diff --git a/src/ss7_asp.c b/src/ss7_asp.c index 644c192..5325de9 100644 --- a/src/ss7_asp.c +++ b/src/ss7_asp.c @@ -760,13 +760,9 @@ llist_del(&asp->siblings); /* unlink from all ASs we are part of */ - llist_for_each_entry(as, &asp->inst->as_list, list) { - unsigned int i; - for (i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { - if (as->cfg.asps[i] == asp) - as->cfg.asps[i] = NULL; - } - } + llist_for_each_entry(as, &asp->inst->as_list, list) + ss7_as_del_asp(as, asp); + /* unlink from ss7_instance */ asp->inst = NULL; llist_del(&asp->list); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2c1b25d3e76703b88111b9935685a58d039b8e23 Gerrit-Change-Number: 41499 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_rkm: Avoid unnecesary ASP lookup by name
by osmith 25 Nov '25

25 Nov '25

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41498?usp=email ) Change subject: xua_rkm: Avoid unnecesary ASP lookup by name ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5ca8f0180a0389d5de7b495cfe9f769985296383 Gerrit-Change-Number: 41498 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Nov 2025 12:05:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing
by osmith 25 Nov '25

25 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email ) Change subject: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b29d00befa94412bef56a4b8e4d788674028b12 Gerrit-Change-Number: 41497 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Nov 2025 12:03:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-dev[master]: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap
by osmith 25 Nov '25

25 Nov '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email ) Change subject: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Gerrit-Change-Number: 41496 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Nov 2025 12:01:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_rkm: Avoid unnecesary ASP lookup by name
by pespin 25 Nov '25

25 Nov '25

Attention is currently required from: daniel, fixeria, lynxis lazus, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41498?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: xua_rkm: Avoid unnecesary ASP lookup by name ...................................................................... xua_rkm: Avoid unnecesary ASP lookup by name Change-Id: I5ca8f0180a0389d5de7b495cfe9f769985296383 --- M src/ss7_as.c M src/ss7_as.h M src/xua_rkm.c 3 files changed, 19 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/98/41498/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5ca8f0180a0389d5de7b495cfe9f769985296383 Gerrit-Change-Number: 41498 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: xua_rkm: Avoid unnecesary ASP lookup by name
by pespin 25 Nov '25

25 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41498?usp=email ) Change subject: xua_rkm: Avoid unnecesary ASP lookup by name ...................................................................... xua_rkm: Avoid unnecesary ASP lookup by name Change-Id: I5ca8f0180a0389d5de7b495cfe9f769985296383 --- M src/ss7_as.c M src/ss7_as.h M src/xua_rkm.c 3 files changed, 20 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/98/41498/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index c2dee9d..e580dd3 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -194,16 +194,10 @@ * \param[in] as Application Server from which \ref asp is deleted * \param[in] asp Application Server Process to delete from \ref as * \returns 0 on success; negative in case of error */ -int osmo_ss7_as_del_asp(struct osmo_ss7_as *as, const char *asp_name) +int ss7_as_del_asp(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp) { - struct osmo_ss7_asp *asp; unsigned int i; - OSMO_ASSERT(ss7_initialized); - asp = osmo_ss7_asp_find_by_name(as->inst, asp_name); - if (!asp) - return -ENODEV; - LOGPAS(as, DLSS7, LOGL_INFO, "Removing ASP %s from AS\n", asp->cfg.name); /* Remove route from AS-eSLS table: */ @@ -224,6 +218,23 @@ return -EINVAL; } +/*! \brief Delete given ASP from given AS + * \param[in] as Application Server from which \ref asp is deleted + * \param[in] asp Name of the Application Server Process to delete from \ref as + * \returns 0 on success; negative in case of error */ +int osmo_ss7_as_del_asp(struct osmo_ss7_as *as, const char *asp_name) +{ + struct osmo_ss7_asp *asp; + unsigned int i; + + OSMO_ASSERT(ss7_initialized); + asp = osmo_ss7_asp_find_by_name(as->inst, asp_name); + if (!asp) + return -ENODEV; + + return ss7_as_del_asp(as, asp); +} + /*! \brief Destroy given Application Server * \param[in] as Application Server to destroy */ void osmo_ss7_as_destroy(struct osmo_ss7_as *as) diff --git a/src/ss7_as.h b/src/ss7_as.h index 4f5db78..bb7b1b2 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -137,6 +137,7 @@ unsigned int osmo_ss7_as_count_asp(const struct osmo_ss7_as *as); int ss7_as_add_asp(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp); +int ss7_as_del_asp(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp); int ss7_as_get_local_role(const struct osmo_ss7_as *as); void ss7_as_loadshare_binding_table_reset(struct osmo_ss7_as *as); diff --git a/src/xua_rkm.c b/src/xua_rkm.c index 8817f49..7c98a3f 100644 --- a/src/xua_rkm.c +++ b/src/xua_rkm.c @@ -423,7 +423,7 @@ rctx, osmo_ss7_pointcode_print(inst, as->cfg.routing_key.pc)); /* remove ASP from AS */ - osmo_ss7_as_del_asp(as, asp->cfg.name); + osmo_ss7_as_del_asp(as, asp); /* FIXME: Rather than spoofing teh ASP-DOWN.ind to the AS here, * we should refuse RKM DEREG if the ASP is still ACTIVE */ osmo_fsm_inst_dispatch(as->fi, XUA_ASPAS_ASP_DOWN_IND, asp); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5ca8f0180a0389d5de7b495cfe9f769985296383 Gerrit-Change-Number: 41498 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-dev[master]: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap
by lynxis lazus 25 Nov '25

25 Nov '25

Attention is currently required from: daniel, fixeria, laforge, osmith, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email ) Change subject: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Gerrit-Change-Number: 41496 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Nov 2025 11:47:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing
by pespin 25 Nov '25

25 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email ) Change subject: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing ...................................................................... testenv: Build libosmo-sigtran with --enable-tcap-loadsharing STP_Tests_TCAP use this feature. Depends: osmo-dev.git Change-Id Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Change-Id: I7b29d00befa94412bef56a4b8e4d788674028b12 --- M _testenv/data/osmo-dev/testenv.opts 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/41497/1 diff --git a/_testenv/data/osmo-dev/testenv.opts b/_testenv/data/osmo-dev/testenv.opts index 15ab331..123d8be 100644 --- a/_testenv/data/osmo-dev/testenv.opts +++ b/_testenv/data/osmo-dev/testenv.opts @@ -1,2 +1,3 @@ osmo-bts --enable-trx osmo-remsim --disable-remsim-client-ifdhandler +libosmo-sigtran --enable-tcap-loadsharing -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b29d00befa94412bef56a4b8e4d788674028b12 Gerrit-Change-Number: 41497 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-dev[master]: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap
by pespin 25 Nov '25

25 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email ) Change subject: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap ...................................................................... all.desp: libosmo-sigtran depends on libosmo-asn1-tcap When built with --enable-tcap-loadsharing, libosmo-sigtran requires libosmo-asn1-tcap. Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e --- M all.deps 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/96/41496/1 diff --git a/all.deps b/all.deps index 3439de7..f0e99a1 100644 --- a/all.deps +++ b/all.deps @@ -1,9 +1,10 @@ # project build these first libosmocore +libosmo-asn1-tcap libosmo-netif libosmocore libosmo-abis libosmocore libosmo-netif libosmo-gprs libosmocore -libosmo-sigtran libosmo-netif +libosmo-sigtran libosmo-netif libosmo-asn1-tcap libsmpp34 libasn1c osmo-ggsn libosmocore libgtpnl -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Gerrit-Change-Number: 41496 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log