- gerrit-log - lists.osmocom.org

[M] Change in osmo-mgw[master]: mgw: rtp-patch rfc5993hr: convert to each end's respective format
by pespin 04 Nov '25

04 Nov '25

Attention is currently required from: falconia, laforge, neels. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email ) Change subject: mgw: rtp-patch rfc5993hr: convert to each end's respective format ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b446ad83c540fb8b7e1aae24b78c27010212d64 Gerrit-Change-Number: 39869 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Nov 2025 11:13:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: SMS UX optimisation: Deliver rx'd SMS right away
by pespin 04 Nov '25

04 Nov '25

Attention is currently required from: keith. pespin has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28342?usp=email ) Change subject: SMS UX optimisation: Deliver rx'd SMS right away ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I'm not really involved into the big picture/roadmap regarding SMS, but I'd argue it makes more sense to send SMS in order in the queue instead of reordering SMS (what would happen if we send the SMS directly upon receive). Think for example 2 SMS sent by Alice to Bob where the 2nd SMS provides contradictory information wrt 1st SMS (eg. "I'm arriving on time" vs "I'm late", or eg. 2-factor authentication codes). Without looking in detail, may it be that the delay @keith@rhizomatica.org is mentioning comes from the fact that when we run the queue we try to lookup for SMS for all subscribers and retrigger them? AFAIU the sane approach would be to lookup SMS for that specific subscriber, not sure if we are doing that already. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c Gerrit-Change-Number: 28342 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 04 Nov 2025 11:10:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-ttcn3-hacks[master]: stp: Introduce STP_Tests_TCAP
by pespin 04 Nov '25

04 Nov '25

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email ) Change subject: stp: Introduce STP_Tests_TCAP ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e Gerrit-Change-Number: 41136 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 04 Nov 2025 10:45:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo-release: debian_patch_apply: handle empty dir
by osmith 04 Nov '25

04 Nov '25

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/41296?usp=email ) Change subject: osmo-release: debian_patch_apply: handle empty dir ...................................................................... osmo-release: debian_patch_apply: handle empty dir Don't fail with the following bogus error message if the debian/patches directory exists but is empty: error: can't open patch '…/git/libosmocore/debian/patches/*.patch': No such file or directory Fixes: OS#6873 Change-Id: I6656602c58fd221c8bb933890712d1392a1dfdab --- M osmo-release.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/96/41296/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6656602c58fd221c8bb933890712d1392a1dfdab Gerrit-Change-Number: 41296 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in libosmocore[master]: osmo-release: debian_patch_apply: handle empty dir
by osmith 04 Nov '25

04 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41296?usp=email ) Change subject: osmo-release: debian_patch_apply: handle empty dir ...................................................................... osmo-release: debian_patch_apply: handle empty dir Don't fail with the following bogus error message if the debian/patches directory exists but is empty: error: can't open patch '/crypt/space/home/laforge/projects/git/libosmocore/debian/patches/*.patch': No such file or directory Fixes: OS#6873 Change-Id: I6656602c58fd221c8bb933890712d1392a1dfdab --- M osmo-release.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/96/41296/1 diff --git a/osmo-release.sh b/osmo-release.sh index 14790da..5a9584c 100755 --- a/osmo-release.sh +++ b/osmo-release.sh @@ -151,10 +151,10 @@ # Make sure that patches under debian/patches/ apply: check_debian_patch_apply() { - if [ ! -d "${GIT_TOPDIR}/debian/patches" ]; then - return - fi for patch in ${GIT_TOPDIR}/debian/patches/*.patch; do + if ! [ -e "$patch" ]; then + continue + fi git apply --check $patch if [ $? -ne 0 ]; then error "patch no longer applies! $patch" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6656602c58fd221c8bb933890712d1392a1dfdab Gerrit-Change-Number: 41296 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XL] Change in osmo-ttcn3-hacks[master]: stp: Introduce STP_Tests_TCAP
by lynxis lazus 03 Nov '25

03 Nov '25

Attention is currently required from: fixeria, pespin. lynxis lazus has uploaded a new patch set (#8) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: stp: Introduce STP_Tests_TCAP ...................................................................... stp: Introduce STP_Tests_TCAP The network topology and test infrastructure already allows testing TCAP forwarding at STP over IPA<->IPA, M3UA<->IPA and M3UA<->M3UA. Co-authored-by: Alexander Couzens <lynxis(a)fe80.eu> Related: SYS#5423 Change-Id: I4340bdf126118c66af861f5a447e90883783920e --- M stp/STP_Tests_Common.ttcn A stp/STP_Tests_TCAP.cfg A stp/STP_Tests_TCAP.ttcn M stp/expected-results.xml M stp/gen_links.sh A stp/osmo-stp-tcap.confmerge M stp/regen_makefile.sh A stp/testenv_tcap.cfg 8 files changed, 1,087 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/41136/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e Gerrit-Change-Number: 41136 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XL] Change in osmo-ttcn3-hacks[master]: stp: Introduce STP_Tests_TCAP
by lynxis lazus 03 Nov '25

03 Nov '25

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email ) Change subject: stp: Introduce STP_Tests_TCAP ...................................................................... Patch Set 7: (2 comments) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136/comment/7047a9a1_1f32… : PS6, Line 48: import from STP_Tests_Common all; > duplicate (already imported above) Done File stp/expected-results.xml: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136/comment/01cd2082_5681… : PS6, Line 75: <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : > This should IMHO be fixed, ie we shouldn't have a test being run multiple times with the same name. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e Gerrit-Change-Number: 41136 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Nov 2025 15:31:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-ttcn3-hacks[master]: stp: Introduce STP_Tests_TCAP
by lynxis lazus 03 Nov '25

03 Nov '25

Attention is currently required from: fixeria, lynxis lazus. lynxis lazus has uploaded a new patch set (#7) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: stp: Introduce STP_Tests_TCAP ...................................................................... stp: Introduce STP_Tests_TCAP The network topology and test infrastructure already allows testing TCAP forwarding at STP over IPA<->IPA, M3UA<->IPA and M3UA<->M3UA. Co-authored: Alexander Couzens <lynxis(a)fe80.eu> Related: SYS#5423 Change-Id: I4340bdf126118c66af861f5a447e90883783920e --- M stp/STP_Tests_Common.ttcn A stp/STP_Tests_TCAP.cfg A stp/STP_Tests_TCAP.ttcn M stp/expected-results.xml M stp/gen_links.sh A stp/osmo-stp-tcap.confmerge M stp/regen_makefile.sh A stp/testenv_tcap.cfg 8 files changed, 1,081 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/41136/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e Gerrit-Change-Number: 41136 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmocore[master]: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954)
by laforge 03 Nov '25

03 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email ) Change subject: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) ...................................................................... gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) So far we've supported R-GSM (ARFCN 955-974) and E-GSM (ARFCN 975..1023) but not yet the ER-GSM range (ARFCN 940..954) in the gsm_arfcn2freq10() and gsm_freq102arfcn() functions. This patch fixes this. Change-Id: I2f17bca405403ee12cfe7c5c804c135ab021b369 --- M src/gsm/gsm_utils.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index 64fbd63..3ca6812 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -739,7 +739,7 @@ } else if (arfcn <= 124) { *band = GSM_BAND_900; return 0; - } else if (arfcn >= 955 && arfcn <= 1023) { + } else if (arfcn >= 940 && arfcn <= 1023) { *band = GSM_BAND_900; return 0; } else if (arfcn >= 128 && arfcn <= 251) { @@ -787,10 +787,11 @@ uint16_t flags; }; +/* See 3GPP TS 45.005 Section 2 Table 2-2 */ static struct gsm_freq_range gsm_ranges[] = { { 512, 810, 18502, 800, ARFCN_PCS }, /* PCS 1900 */ { 0, 124, 8900, 450, 0 }, /* P-GSM + E-GSM ARFCN 0 */ - { 955, 1023, 8762, 450, 0 }, /* E-GSM + R-GSM */ + { 940, 1023, 8732, 450, 0 }, /* E-GSM + R-GSM + ER-GSM */ { 128, 251, 8242, 450, 0 }, /* GSM 850 */ { 512, 885, 17102, 950, 0 }, /* DCS 1800 */ { 259, 293, 4506, 100, 0 }, /* GSM 450 */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2f17bca405403ee12cfe7c5c804c135ab021b369 Gerrit-Change-Number: 41295 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954)
by laforge 03 Nov '25

03 Nov '25

Attention is currently required from: jolly. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email ) Change subject: gsm/gsm_utils: Support the ER-GSM band (ARFCN 940..954) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2f17bca405403ee12cfe7c5c804c135ab021b369 Gerrit-Change-Number: 41295 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 03 Nov 2025 13:16:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log