- gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: sqlite optimisation: Avoid unneeded database operation

by fixeria

Attention is currently required from: keith, pespin. fixeria has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email ) Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/3398893b_f0566a9e?usp… : PS4, Line 303: DB_STMT_SMS_DEL_EXPIRED > I'd prefer to keep you happy in this patch. I can remove the LIMIT clause. Thanks. > I'd propose to get rid of this one (EXPIRED) an replace its use in the code with the other one, just plain old: DB_STMT_SMS_DEL_BY_ID Ack, this is exactly what I had in mind. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 7 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 14 Oct 2025 08:34:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: keith <keith(a)rhizomatica.org>

1 hour, 12 minutes

1
0
0 0

[S] Change in osmo-msc[master]: sqlite optimisation: Avoid unneeded database operation

by keith

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email to look at the new patch set (#7). Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... sqlite optimisation: Avoid unneeded database operation It is pointless to mark an SMS as sent immediatly before deleting it. Let's avoid the extra database overhead involved in doing this operation. We change the db function which is used to delete SMS, changing the where clause, so let's also remove the word "sent" in the function name, now: db_sms_delete_message_by_id() This function is only called from one place; when deleting sent messages, but better the name reflects what it actually does. By the same logic, the database statement is now called "DEL_BY_ID" and ends up being a duplicate of what was denoted as DEL_EXPIRED, so remove this later, which in itself has nothing to do with the validity or expiration, but was called from delete_expired_sms(). Call the DEL_BY_ID statement there instead, which is a more accurate descrption of the actual statement being run. The unit test is changed now that we cannot delete based on sent status anymore. Change-Id: I777155c0f818b979c636bb59953719e472771603 --- M include/osmocom/msc/db.h M src/libmsc/db.c M src/libmsc/gsm_04_11.c M src/libmsc/sms_queue.c M tests/db_sms/db_sms_test.c M tests/db_sms/db_sms_test.ok 6 files changed, 12 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/28340/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 7 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

7 hours, 51 minutes

1
0
0 0

[S] Change in osmo-msc[master]: sqlite optimisation: Avoid unneeded database operation

by keith

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... sqlite optimisation: Avoid unneeded database operation It is pointless to mark an SMS as sent immediatly before deleting it. Let's avoid the extra database overhead involved in doing this operation. We change the db function which is used to delete SMS, changing the where clause, so let's also remove the word "sent" in the function name, now: db_sms_delete_message_by_id() This function is only called from one place; when deleting sent messages, but better the name reflects what it actually does. On the same logic, the database statement is now called "DEL_BY_ID" and ends up being a duplicate of what was denoted as DEL_EXPIRED, so remove this later, which it itself has to do with the validity or expiration, but was called from delete_expired_sms(). Call the DEL_BY_ID statement there instead, which is a more accurate descrption of the actual statement being run. The unit test is changed now that we cannot delete based on sent status anymore. Change-Id: I777155c0f818b979c636bb59953719e472771603 --- M include/osmocom/msc/db.h M src/libmsc/db.c M src/libmsc/gsm_04_11.c M src/libmsc/sms_queue.c M tests/db_sms/db_sms_test.c M tests/db_sms/db_sms_test.ok 6 files changed, 12 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/28340/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 6 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

7 hours, 58 minutes

1
0
0 0

[S] Change in osmo-msc[master]: sqlite optimisation: Avoid unneeded database operation

by keith

Attention is currently required from: fixeria, pespin. keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email ) Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... Patch Set 5: (1 comment) File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/766d0755_3d775ae1?usp… : PS4, Line 303: DB_STMT_SMS_DEL_EXPIRED > I believe this was already brought up here by other reviewers: we now have two identical queries in […] It was in relation to a different "duplicate" which wasn't really a duplicate. Anyway, I didn't notice this one, and I see now. You are correct, these are two essentially the same queries. I'd prefer to keep you happy in this patch. I can remove the LIMIT clause. I'd also say that DB_STMT_SMS_DEL_*EXPIRED* is inaccurate, there's nothing in the query that limits it to "expired" SMS. I'd propose to get rid of this one (EXPIRED) an replace its use in the code with the other one, just plain old: DB_STMT_SMS_DEL_BY_ID By the way, I feel you're nitpicking a little :-) It's OK and I appreciate it, but let me just say that the state of the SMS database (and the insane beast that is the code that interacts with it) is hardly something perfect to be precious about. It's likely nobody else has ever run this code with 10s of SMS per second going on. Believe me, I've scrutinised it. I think it was probably initially hacked quickly into nitb at a CCC event or something. You know, like.. we define a column as TIMESTAMP and yet it is, after all, sqlite3 :-) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 5 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Oct 2025 00:37:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 hours, 9 minutes

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: sgsn/SGSN_Tests_SNS.cfg: adjust to recent changes

by pespin

pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41223?usp=email ) Change subject: sgsn/SGSN_Tests_SNS.cfg: adjust to recent changes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I62a1188aa3346fda3f0674296629ade51a02088f Gerrit-Change-Number: 41223 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Oct 2025 20:40:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

13 hours, 6 minutes

1
0
0 0

[S] Change in libosmocore[master]: gsm/protocol/gsm_48_103.h: new header file

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41211?usp=email ) Change subject: gsm/protocol/gsm_48_103.h: new header file ...................................................................... gsm/protocol/gsm_48_103.h: new header file 3GPP TS 48.103 prescribes a set of fixed RTP payload type numbers for use on GSM AoIP interface - however, until now there was no Osmocom header file that formally captures these spec definitions. Fix this omission. Change-Id: Id41d4dffd0eb562df4fc948b237d629e858e495b --- M include/osmocom/gsm/protocol/Makefile.am A include/osmocom/gsm/protocol/gsm_48_103.h 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/Makefile.am b/include/osmocom/gsm/protocol/Makefile.am index 23429dc..ada2ce2 100644 --- a/include/osmocom/gsm/protocol/Makefile.am +++ b/include/osmocom/gsm/protocol/Makefile.am @@ -22,6 +22,7 @@ gsm_44_318.h \ gsm_48_049.h \ gsm_48_071.h \ + gsm_48_103.h \ gsm_49_031.h \ ipaccess.h \ smpp34_osmocom.h \ diff --git a/include/osmocom/gsm/protocol/gsm_48_103.h b/include/osmocom/gsm/protocol/gsm_48_103.h new file mode 100644 index 0000000..d40acac --- /dev/null +++ b/include/osmocom/gsm/protocol/gsm_48_103.h @@ -0,0 +1,21 @@ +/* + * This header file captures the set of fixed RTP payload type definitions + * specified in 3GPP TS 48.103 (GSM AoIP interface) Table 5.4.2.2.1. + */ + +#pragma once + +/* uncompressed speech */ +#define OSMO_AOIP_RTP_PT_PCMU 0 +#define OSMO_AOIP_RTP_PT_PCMA 8 + +/* compressed speech */ +#define OSMO_AOIP_RTP_PT_FR1 3 +#define OSMO_AOIP_RTP_PT_EFR 110 +#define OSMO_AOIP_RTP_PT_HR1 111 +#define OSMO_AOIP_RTP_PT_AMR 112 +#define OSMO_AOIP_RTP_PT_AMRWB 113 + +/* circuit-switched data */ +#define OSMO_AOIP_RTP_PT_CSD 120 /* without redundancy */ +#define OSMO_AOIP_RTP_PT_CSD_RED 121 /* with redundancy */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id41d4dffd0eb562df4fc948b237d629e858e495b Gerrit-Change-Number: 41211 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

16 hours, 44 minutes

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hlr: add MSC to ccm_pars.name

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41219?usp=email ) Change subject: hlr: add MSC to ccm_pars.name ...................................................................... hlr: add MSC to ccm_pars.name Fix an immediate disconnect from pyHSS: [ERROR] 127.0.0.1:9999: Role not found in tags. 'sgsn' or 'msc' must appear in one of there tags: TYPE, UNIT, UNITNAME. Closing connection. Related: OS#6862 Change-Id: I1813e49ec286892c1a637deb99908903613696aa --- M hlr/HLR_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn index 806f45e..3b1b03e 100644 --- a/hlr/HLR_Tests.ttcn +++ b/hlr/HLR_Tests.ttcn @@ -178,7 +178,7 @@ } ccm_pars := c_IPA_default_ccm_pars; - ccm_pars.name := "Osmocom TTCN-3 GSUP Simulator"; + ccm_pars.name := "Osmocom TTCN-3 GSUP Simulator (MSC)"; ccm_pars.ser_nr := "MSC-00-00-00-00-00-00"; vc_IPA := IPA_Emulation_CT.create(id & "-IPA"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1813e49ec286892c1a637deb99908903613696aa Gerrit-Change-Number: 41219 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

22 hours, 5 minutes

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: set PYTHONUNBUFFERED=1

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41216?usp=email ) Change subject: testenv: set PYTHONUNBUFFERED=1 ...................................................................... testenv: set PYTHONUNBUFFERED=1 Prepare to run PyHSS, which needs this variable to be set or else no log messages are printed. This problem exists with potentially all python scripts that testenv would run, so set the env var for all commands. Change-Id: I155f7c7bd9b985094e36fee6c6a2acfe556f580d --- M _testenv/testenv/cmd.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index d637129..c14f694 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -106,6 +106,7 @@ ret["PATH"] = path ret["HOME"] = os.environ.get("HOME") + ret["PYTHONUNBUFFERED"] = "1" for var in env: ret[var] = env[var] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I155f7c7bd9b985094e36fee6c6a2acfe556f580d Gerrit-Change-Number: 41216 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

22 hours, 5 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: add HLR_IMPL_PYHSS

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41217?usp=email ) Change subject: hlr: add HLR_IMPL_PYHSS ...................................................................... hlr: add HLR_IMPL_PYHSS Prepare to run the HLR testsuite against PyHSS. Related: OS#6862 Change-Id: I0989374d777aabf5afaf224faeb0cb2ff4e603e6 --- M hlr/HLR_Tests.ttcn 1 file changed, 21 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn index 45a8fb3..f86a6bc 100644 --- a/hlr/HLR_Tests.ttcn +++ b/hlr/HLR_Tests.ttcn @@ -37,6 +37,11 @@ import from MSLookup_mDNS_Templates all; import from DNS_Helpers all; +type enumerated HLR_Impl { + HLR_IMPL_OSMOCOM, + HLR_IMPL_PYHSS +}; + type component test_CT extends CTRL_Adapter_CT { /* emulated GSUP client (MSC/SGSN) */ var IPA_Emulation_CT vc_IPA; @@ -71,6 +76,8 @@ /* emulated GSUP server (second HLR) */ charstring mp_hlr_ts_ip := "127.0.0.99"; integer mp_hlr_ts_port := 4222; + + HLR_Impl m_hlr_impl := HLR_IMPL_OSMOCOM; }; type record HlrSubscrAud2G { @@ -235,14 +242,19 @@ activate(as_Tguard()); f_init_gsup("HLR_Test", legacy); - f_init_vty(); - f_init_mslookup(); + + if (m_hlr_impl == HLR_IMPL_OSMOCOM) { + f_init_vty(); + f_init_mslookup(); + } if (gsup_server) { f_init_gsup_server("HLR_Test"); } - f_ipa_ctrl_start_client(mp_hlr_ip, mp_hlr_ctrl_port); + if (m_hlr_impl == HLR_IMPL_OSMOCOM) { + f_ipa_ctrl_start_client(mp_hlr_ip, mp_hlr_ctrl_port); + } } /*! Start HLR_ConnHdlr from testCT in a separate thread. @@ -258,7 +270,9 @@ vc_conn := HLR_ConnHdlr.create(id); connect(vc_conn:GSUP, vc_GSUP:GSUP_CLIENT); connect(vc_conn:GSUP_PROC, vc_GSUP:GSUP_PROC); - connect(vc_conn:mDNS, vc_MSLookup_mDNS:mDNS); + if (m_hlr_impl == HLR_IMPL_OSMOCOM) { + connect(vc_conn:mDNS, vc_MSLookup_mDNS:mDNS); + } if (gsup_server) { connect(vc_conn:GSUP, vc_GSUP_server:GSUP_CLIENT); @@ -296,7 +310,9 @@ g_pars := valueof(pars); f_create_gsup_expect_explicit(hex2str(g_pars.sub.imsi), vc_GSUP_client); } - f_handler_init_vty(); + if (m_hlr_impl == HLR_IMPL_OSMOCOM) { + f_handler_init_vty(); + } fn.apply(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0989374d777aabf5afaf224faeb0cb2ff4e603e6 Gerrit-Change-Number: 41217 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

22 hours, 5 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: don't test OsmoHLR-only features with PyHSS

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41218?usp=email ) Change subject: hlr: don't test OsmoHLR-only features with PyHSS ...................................................................... hlr: don't test OsmoHLR-only features with PyHSS Proxy, mslookup and creating subscriber on demand are not implemented in PyHSS, so don't test these features when testing PyHSS. Related: OS#6862 Change-Id: I0c4905dd3f73abfe9f7cc77fc045368b9499aade --- M hlr/HLR_Tests.ttcn 1 file changed, 18 insertions(+), 13 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn index f86a6bc..806f45e 100644 --- a/hlr/HLR_Tests.ttcn +++ b/hlr/HLR_Tests.ttcn @@ -2115,11 +2115,9 @@ execute( TC_gsup_sai_num_auth_vectors() ); execute( TC_gsup_sai_eps() ); execute( TC_gsup_ul_unknown_imsi() ); - execute( TC_gsup_ul_unknown_imsi_via_proxy() ); execute( TC_gsup_ul_unknown_imsi_roaming_not_allowed() ); execute( TC_gsup_sai_err_unknown_imsi() ); execute( TC_gsup_ul() ); - execute( TC_gsup_ul_via_proxy() ); execute( TC_gsup_ul_subscriber_data() ); execute( TC_vty() ); execute( TC_vty_msisdn_isd() ); @@ -2130,9 +2128,7 @@ execute( TC_mo_ussd_unknown() ); execute( TC_mo_ussd_euse_disc() ); execute( TC_mo_ussd_iuse_imsi() ); - execute( TC_mo_ussd_iuse_imsi_via_proxy() ); execute( TC_mo_ussd_iuse_msisdn() ); - execute( TC_mo_ussd_iuse_msisdn_via_proxy() ); execute( TC_mo_ussd_euse() ); execute( TC_mo_ussd_euse_continue() ); execute( TC_mo_ussd_euse_defaultroute() ); @@ -2141,18 +2137,27 @@ execute( TC_mo_sss_reject() ); execute( TC_gsup_check_imei() ); - execute( TC_gsup_check_imei_via_proxy() ); execute( TC_gsup_check_imei_invalid_len() ); execute( TC_gsup_check_imei_unknown_imsi() ); - execute( TC_subscr_create_on_demand_check_imei_early() ); - execute( TC_subscr_create_on_demand_ul() ); - execute( TC_subscr_create_on_demand_sai() ); - execute( TC_MSLookup_mDNS_service_other_home() ); - execute( TC_MSLookup_GSUP_proxy() ); - execute( TC_MSLookup_mDNS_service_GSUP_HLR_home() ); - execute( TC_MSLookup_mDNS_service_GSUP_HLR_proxy() ); - execute( TC_MSLookup_mDNS_service_other_proxy() ); + /* Test features that are only implemented in OsmoHLR */ + if (m_hlr_impl == HLR_IMPL_OSMOCOM) { + execute( TC_gsup_ul_unknown_imsi_via_proxy() ); + execute( TC_gsup_ul_via_proxy() ); + execute( TC_mo_ussd_iuse_imsi_via_proxy() ); + execute( TC_mo_ussd_iuse_msisdn_via_proxy() ); + execute( TC_gsup_check_imei_via_proxy() ); + + execute( TC_subscr_create_on_demand_check_imei_early() ); + execute( TC_subscr_create_on_demand_ul() ); + execute( TC_subscr_create_on_demand_sai() ); + + execute( TC_MSLookup_mDNS_service_other_home() ); + execute( TC_MSLookup_GSUP_proxy() ); + execute( TC_MSLookup_mDNS_service_GSUP_HLR_home() ); + execute( TC_MSLookup_mDNS_service_GSUP_HLR_proxy() ); + execute( TC_MSLookup_mDNS_service_other_proxy() ); + } }; }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c4905dd3f73abfe9f7cc77fc045368b9499aade Gerrit-Change-Number: 41218 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

22 hours, 5 minutes

1
0
0 0

2025

2024

2023

2022

gerrit-log