- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: Fix bankd connection at RemsimClient_Tests.TC_bank_disconnect_reconnect
by jolly 20 Apr '26

20 Apr '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42646?usp=email ) Change subject: Fix bankd connection at RemsimClient_Tests.TC_bank_disconnect_reconnect ...................................................................... Fix bankd connection at RemsimClient_Tests.TC_bank_disconnect_reconnect After each connection (initial connection and reconnect), the test must wait for the bankd connection to be fully established. Previously the IPA/RSPRO emulation failed, because the socket was closed before sending the acknowledgemen, leading to a 'Broken pipe' error. Change-Id: I0a8b339bcc4136442994b8825904df8aaf9aa95d --- M remsim/RemsimClient_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/42646/1 diff --git a/remsim/RemsimClient_Tests.ttcn b/remsim/RemsimClient_Tests.ttcn index d747eef..5d6db82 100644 --- a/remsim/RemsimClient_Tests.ttcn +++ b/remsim/RemsimClient_Tests.ttcn @@ -170,6 +170,7 @@ /* expect inbound connectClientReq on simulated bankd */ as_connectClientReq(i := 1); + /* Wait for bankd connection to be established. */ f_sleep(1.0); /* configure client to disconnect from [simulated] bankd */ @@ -190,6 +191,9 @@ /* expect inbound connect on simulated bankd */ as_connectClientReq(i := 1); + /* Wait for bankd connection to be established. */ + f_sleep(1.0); + setverdict(pass); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a8b339bcc4136442994b8825904df8aaf9aa95d Gerrit-Change-Number: 42646 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Fix access pcscd in various RemsimBankd_Tests
by jolly 20 Apr '26

20 Apr '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42647?usp=email ) Change subject: Fix access pcscd in various RemsimBankd_Tests ...................................................................... Fix access pcscd in various RemsimBankd_Tests Access to pcscd was denied, so that bankd never conneced to the reader. This caused TC_createMapping_exchangeTPDU to fail, because it requires connection to virtual smart card for this test Change-Id: Ibae1c5167daa0157058bc40ce1857c1e6bb9da31 --- M remsim/testenv_bankd.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/42647/1 diff --git a/remsim/testenv_bankd.cfg b/remsim/testenv_bankd.cfg index b8ebaa7..62df381 100644 --- a/remsim/testenv_bankd.cfg +++ b/remsim/testenv_bankd.cfg @@ -5,7 +5,7 @@ [pcscd] prepare=require_vsmartcard_vpcd.sh -program=pcscd -f -d +program=pcscd -f -d --disable-polkit make=no package=pcscd -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibae1c5167daa0157058bc40ce1857c1e6bb9da31 Gerrit-Change-Number: 42647 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in osmo-remsim[master]: Fix: Remove slot mapping at bankd when client disconnects
by jolly 20 Apr '26

20 Apr '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42645?usp=email ) Change subject: Fix: Remove slot mapping at bankd when client disconnects ...................................................................... Fix: Remove slot mapping at bankd when client disconnects If a client disconnects before removing the slot mapping, the slotmap entry will not be removed automatically. A subsequent client connection for the same mapping will then trigger the the error: “ignoring identical slotmap.” In a setup with multiple readers, there are multiple bankd worker threads. If a client re-connects, but if its connection is accepted by a different thread, subsequent reader access or unmapping will fail. There will be no mapping at the new thread. The approach of this fix is to remove the slot mapping, if the client connection to the worker thread terminates. Change-Id: I2fd03490e2506c55104309a0ef952389119023b8 --- M src/bankd/bankd_main.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/45/42645/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 5e33b41..99a5949 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -1102,6 +1102,16 @@ close(g_worker->client.fd); memset(&g_worker->client.peer_addr, 0, sizeof(g_worker->client.peer_addr)); g_worker->client.fd = -1; + if (g_worker->state >= BW_ST_CONN_CLIENT_MAPPED) { + struct slot_mapping *slmap; + slmap = slotmap_by_client(g_worker->bankd->slotmaps, &g_worker->client.clslot); + if (slmap) { + slotmap_del(g_bankd->slotmaps, slmap); + g_worker->slot.bank_id = 0xffff; + g_worker->slot.slot_nr = 0xffff; + worker_set_state(g_worker, BW_ST_CONN_CLIENT_UNMAPPED, true); + } + } g_worker->client.clslot.client_id = g_worker->client.clslot.slot_nr = 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2fd03490e2506c55104309a0ef952389119023b8 Gerrit-Change-Number: 42645 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in osmo-ci[master]: ansible/simtest: remove pip install logic
by laforge 20 Apr '26

20 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42644?usp=email ) Change subject: ansible/simtest: remove pip install logic ...................................................................... ansible/simtest: remove pip install logic The pip install logic fails with: :stderr: error: externally-managed-environment Remove this. Dependencies are installed venv/virtualenv: https://gitea.osmocom.org/sim-card/pysim/src/commit/c50f4b4a0222a964710ce31… Change-Id: I460e22d78966d14e02b639efc4f74d7356e22f28 --- M ansible/setup-simtest.yml 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ansible/setup-simtest.yml b/ansible/setup-simtest.yml index 7c95183..aa9abeb 100644 --- a/ansible/setup-simtest.yml +++ b/ansible/setup-simtest.yml @@ -21,16 +21,6 @@ cache_valid_time: 3600 update_cache: yes - - name: "pysim: get requirements.txt" - get_url: - url: https://gitea.osmocom.org/sim-card/pysim/raw/branch/master/requirements.txt - dest: /tmp/pysim_requirements.txt - - - name: "pysim: install deps from requirements.txt" - pip: - executable: pip3 - requirements: /tmp/pysim_requirements.txt - roles: - name: osmocom-jenkins-slave generic_slave: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I460e22d78966d14e02b639efc4f74d7356e22f28 Gerrit-Change-Number: 42644 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible: openjdk: add mkdir ~/jenkins
by laforge 20 Apr '26

20 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42643?usp=email ) Change subject: ansible: openjdk: add mkdir ~/jenkins ...................................................................... ansible: openjdk: add mkdir ~/jenkins Ensure the JDK can always be installed to /home/{{ jenkins_user }}/jenkins/jdk/bin/java, even if ~/jenkins does not exist yet at this point. This could be because jenkins didn't connect to the node yet, or because the jenkins dir isn't set to ~/jenkins. Related: OS#6998#note-4 Change-Id: I384398e2fe45988eaac32d61095c989914699245 --- M ansible/roles/osmocom-jenkins-slave/tasks/debian.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml index f8009bb..16cc6ab 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml @@ -27,6 +27,7 @@ become: true become_user: "{{ jenkins_user }}" shell: | + mkdir -p ~/jenkins cd ~/jenkins case "$(arch)" in x86_64) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I384398e2fe45988eaac32d61095c989914699245 Gerrit-Change-Number: 42643 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible/setup-simtest: add sudo and wget
by laforge 20 Apr '26

20 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42642?usp=email ) Change subject: ansible/setup-simtest: add sudo and wget ...................................................................... ansible/setup-simtest: add sudo and wget Both are needed for the new openjdk install logic. Related: OS#6998#note-3 Change-Id: I4d5c400daec9c74d069c60a6221ae57e8c6f7953 --- M ansible/setup-simtest.yml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ansible/setup-simtest.yml b/ansible/setup-simtest.yml index 0832b13..7c95183 100644 --- a/ansible/setup-simtest.yml +++ b/ansible/setup-simtest.yml @@ -12,9 +12,11 @@ - python3-pyscard - python3-serial - python3-setuptools + - sudo - tshark - vim - virtualenv + - wget install_recommends: no cache_valid_time: 3600 update_cache: yes -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d5c400daec9c74d069c60a6221ae57e8c6f7953 Gerrit-Change-Number: 42642 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible/setup-simtest: sort packages
by laforge 20 Apr '26

20 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42641?usp=email ) Change subject: ansible/setup-simtest: sort packages ...................................................................... ansible/setup-simtest: sort packages Change-Id: I9fac58407b7c5a38e2ed56e6e5718ce13ed23973 --- M ansible/setup-simtest.yml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ansible/setup-simtest.yml b/ansible/setup-simtest.yml index 33bdda8..0832b13 100644 --- a/ansible/setup-simtest.yml +++ b/ansible/setup-simtest.yml @@ -6,14 +6,14 @@ - name: install common utilities apt: name: - - vim - ca-certificates - python3-minimal - - python3-setuptools - python3-pip - - python3-serial - python3-pyscard + - python3-serial + - python3-setuptools - tshark + - vim - virtualenv install_recommends: no cache_valid_time: 3600 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9fac58407b7c5a38e2ed56e6e5718ce13ed23973 Gerrit-Change-Number: 42641 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible/setup-simtest: merge apt tasks
by laforge 20 Apr '26

20 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42640?usp=email ) Change subject: ansible/setup-simtest: merge apt tasks ...................................................................... ansible/setup-simtest: merge apt tasks Do apt update and installing packages in one task, similar to how we do it in other ansible yml files. Change-Id: I269b368fdca682814976b2cda1c14c33529650b7 --- M ansible/setup-simtest.yml 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ansible/setup-simtest.yml b/ansible/setup-simtest.yml index eb37186..33bdda8 100644 --- a/ansible/setup-simtest.yml +++ b/ansible/setup-simtest.yml @@ -3,11 +3,6 @@ hosts: simtester user: root tasks: - - name: apt-get update - apt: - cache_valid_time: 3600 - update_cache: yes - - name: install common utilities apt: name: @@ -21,6 +16,8 @@ - tshark - virtualenv install_recommends: no + cache_valid_time: 3600 + update_cache: yes - name: "pysim: get requirements.txt" get_url: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I269b368fdca682814976b2cda1c14c33529650b7 Gerrit-Change-Number: 42640 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible/hosts: update simtest
by laforge 20 Apr '26

20 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42639?usp=email ) Change subject: ansible/hosts: update simtest ...................................................................... ansible/hosts: update simtest Change-Id: Ica3c229ddf617b61e88774d3b330263307f84e97 --- M ansible/hosts M ansible/util/known_hosts 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ansible/hosts b/ansible/hosts index f1432bb..c65dd40 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -20,7 +20,7 @@ lx2-raspbian13build-ansible ansible_host=10.9.25.28 docker_max_image_space="20 GB" jenkins_tmpfs=True [simtester] -simtest ansible_host=10.9.25.80 +simtest ansible_host=10.9.25.94 [obs_workers] build4-obsworker ansible_host=2a01:4f8:121:200a::1:2 obs_worker_instances=8 obs_worker_jobs=8 diff --git a/ansible/util/known_hosts b/ansible/util/known_hosts index 0222bf7..c397642 100644 --- a/ansible/util/known_hosts +++ b/ansible/util/known_hosts @@ -13,3 +13,4 @@ build4.osmocom.org ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIHdLymAofmutYuXMgiWQaNiFUHfu+2j60pmWemd5hddw 10.9.25.26 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAICHw8f7STEM6tZj/14dMG0aPcOLzpC0uSwoOlwAMv7Z3 10.9.25.28 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAINEWffWCaHxwMs1W+m55WDHJSIR4O0eiTtcteJCBjKZK +10.9.25.94 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAINnBQkBViNy6CyHbwOtyLBV5bG7yFxI93DJOfwIHDd/N -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42639?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ica3c229ddf617b61e88774d3b330263307f84e97 Gerrit-Change-Number: 42639 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: ansible/simtest: remove pip install logic
by laforge 20 Apr '26

20 Apr '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42644?usp=email ) Change subject: ansible/simtest: remove pip install logic ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I460e22d78966d14e02b639efc4f74d7356e22f28 Gerrit-Change-Number: 42644 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Apr 2026 11:32:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log