Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email )
Change subject: msc: Initial implementation of N-PCSTATE.ind
......................................................................
Patch Set 1:
(1 comment)
File src/libmsc/sccp_ran.c:
https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/791783a0_0dec76a7?usp… :
PS1, Line 84: LOGP(DMSC, LOGL_DEBUG, "N-PCSTATE ind: affected_pc=%u sp_status=%s remote_sccp_status=%s\n",
> as usual, please print pointcodes in the user-configured point-code format, not [just?] as integer.
Ack, I just used the osmo-bsc func handler as a base, which has the same problem. I'll submit a fix for osmo-bsc too.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf
Gerrit-Change-Number: 40630
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 10 Jul 2025 19:57:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636?usp=email )
Change subject: msc: Introduce test TC_stat_bsc_sctp_disconnected
......................................................................
Patch Set 1:
(2 comments)
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636/comment/e1621850_0da2… :
PS1, Line 7699: disconnect
> Why you're connecting and disconnecting this port several times? […]
In here is not yet relevant, but I'm following the same as done already in bsc-test, because usually vc_STATSD:STATSD_PROC is plugged into the BSC_ConnHdlr when it is run, so here I disconnect to avoid collisions if later we add such connection in this testsuite too.
File msc/expected-results.xml:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636/comment/fa528389_fdfa… :
PS1, Line 2: 228
> You're adding 2 new testcase items, so `227 + 2 = 229`.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4cf30ea09cb1d1286bd5ab6975f3f27e39b9c183
Gerrit-Change-Number: 40636
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jul 2025 19:57:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: msc: Introduce test TC_stat_bsc_sctp_disconnected
......................................................................
msc: Introduce test TC_stat_bsc_sctp_disconnected
Related: OS#5917
Depends: osmo-msc.git Change-Id Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf
Change-Id: I4cf30ea09cb1d1286bd5ab6975f3f27e39b9c183
---
M msc/MSC_Tests.default
M msc/MSC_Tests.ttcn
M msc/MSC_Tests_Iu.ttcn
M msc/expected-results.xml
4 files changed, 196 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/40636/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4cf30ea09cb1d1286bd5ab6975f3f27e39b9c183
Gerrit-Change-Number: 40636
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40634?usp=email )
Change subject: RAN_Emulation: Fix handling of IMSI in RANAP Paging
......................................................................
RAN_Emulation: Fix handling of IMSI in RANAP Paging
The IMSI in RANAP Paging messages is encoded in octetstring BCD format.
We need to decode it before using it, since we use plain hexstrings
everywhere in the module to manage IMSIs.
Take the chance to clean up and improve logging on related lines, both
for BSSAP and RANAP.
Change-Id: Ia892a52bad41a4e331703bbab438d8c811b2025e
---
M library/Osmocom_Types.ttcn
M library/RAN_Emulation.ttcnpp
2 files changed, 24 insertions(+), 7 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn
index a7e37e6..690535c 100644
--- a/library/Osmocom_Types.ttcn
+++ b/library/Osmocom_Types.ttcn
@@ -265,6 +265,22 @@
return ret;
}
+function imsi_oct2hex(octetstring imsi) return hexstring {
+ var hexstring ret := ''H
+ var integer i;
+
+ /* swap nibbles and skip F */
+ for (i := 0; i < lengthof(imsi); i := i+1) {
+ var hexstring h := oct2hex(imsi[i]);
+ if (h[0] == 'F'H) {
+ ret := ret & h[1];
+ } else {
+ ret := ret & h[1] & h[0];
+ }
+ }
+ return ret;
+}
+
function f_pad_oct(octetstring str, integer len, OCT1 pad) return octetstring {
var integer strlen := lengthof(str);
for (var integer i := 0; i < len-strlen; i := i+1) {
diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp
index 9401ed6..4e28ab2 100644
--- a/library/RAN_Emulation.ttcnpp
+++ b/library/RAN_Emulation.ttcnpp
@@ -565,18 +565,19 @@
runs on RAN_Emulation_CT return template PDU_BSSAP {
if (match(bssap, tr_BSSMAP_Paging)) {
var RAN_ConnHdlr client := null;
- var template OCT4 tmsi := omit;
+ var hexstring imsi := bssap.pdu.bssmap.paging.iMSI.digits;
+ var template (omit) OCT4 tmsi := omit;
if (ispresent(bssap.pdu.bssmap.paging.tMSI)) {
tmsi := bssap.pdu.bssmap.paging.tMSI.tmsiOctets;
}
- client := f_imsi_table_find(bssap.pdu.bssmap.paging.iMSI.digits, tmsi);
+ client := f_imsi_table_find(imsi, tmsi);
if (client != null) {
log("CommonBssmapUnitdataCallback: IMSI/TMSI found in table, dispatching to ",
client);
CLIENT.send(bssap) to client;
return omit;
}
- log("CommonBssmapUnitdataCallback: IMSI/TMSI not found in table");
+ log("CommonBssmapUnitdataCallback: IMSI=", imsi, ", TMSI=", tmsi, " not found in table");
} else {
log("CommonBssmapUnitdataCallback: Not a paging message");
}
@@ -719,8 +720,8 @@
if (match(ranap, tr_RANAP_Paging(?, ?))) {
var RAN_ConnHdlr client := null;
/* extract IMSI and (if present) TMSI */
- var IMSI imsi := ranap.initiatingMessage.value_.paging.protocolIEs[1].value_.permanentNAS_UE_ID.iMSI;
- var template OCT4 tmsi := omit;
+ var hexstring imsi := imsi_oct2hex(ranap.initiatingMessage.value_.paging.protocolIEs[1].value_.permanentNAS_UE_ID.iMSI);
+ var template (omit) OCT4 tmsi := omit;
if (lengthof(ranap.initiatingMessage.value_.paging.protocolIEs) > 2 and
ranap.initiatingMessage.value_.paging.protocolIEs[2].id == id_TemporaryUE_ID) {
var TemporaryUE_ID ue_id;
@@ -731,14 +732,14 @@
tmsi := ue_id.p_TMSI;
}
}
- client := f_imsi_table_find(oct2hex(imsi), tmsi);
+ client := f_imsi_table_find(imsi, tmsi);
if (client != null) {
log("CommonRanapUnitdataCallback: IMSI/TMSI found in table, dispatching to ",
client);
CLIENT.send(ranap) to client;
return omit;
}
- log("CommonRanapUnitdataCallback: IMSI/TMSI not found in table");
+ log("CommonRanapUnitdataCallback: IMSI=", imsi, ", TMSI=", tmsi, " not found in table");
} else if (match(ranap, tr_RANAP_ResetResource(?, ?, ?))) {
/* extract IuSigConId */
if (lengthof(ranap.initiatingMessage.value_.resetResource.protocolIEs) > 2 and
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40634?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia892a52bad41a4e331703bbab438d8c811b2025e
Gerrit-Change-Number: 40634
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636?usp=email )
Change subject: msc: Introduce test TC_stat_bsc_sctp_disconnected
......................................................................
Patch Set 1:
(2 comments)
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636/comment/77f0a16e_dcb7… :
PS1, Line 7699: disconnect
Why you're connecting and disconnecting this port several times?
Why not connecting just once and keeping it connected?
File msc/expected-results.xml:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636/comment/43ca2c51_19a3… :
PS1, Line 2: 228
You're adding 2 new testcase items, so `227 + 2 = 229`.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4cf30ea09cb1d1286bd5ab6975f3f27e39b9c183
Gerrit-Change-Number: 40636
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jul 2025 19:54:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email )
Change subject: ran_peer: Add specific API to free object
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I721de21a68a4e336ae508a995e3cfcca05d57efe
Gerrit-Change-Number: 40632
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jul 2025 19:07:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes