- gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: smf: Implement PFCP Sess Est and Sess Del procedures
by fixeria 28 Aug '26

28 Aug '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email ) Change subject: smf: Implement PFCP Sess Est and Sess Del procedures ...................................................................... Patch Set 9: Code-Review+2 (1 comment) File smf/SMF_Session_CT.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378/comment/0cbf30d5_755e… : PS7, Line 680: f_pfcp_sess_del_resp > No, I meant the function body is somehow tabulated twice... Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d Gerrit-Change-Number: 43378 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Aug 2026 20:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: smf: Implement PFCP Sess Est and Sess Del procedures
by pespin 28 Aug '26

28 Aug '26

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: smf: Implement PFCP Sess Est and Sess Del procedures ...................................................................... smf: Implement PFCP Sess Est and Sess Del procedures With these in place, the following tests now pass: TC_createSession_deleteSession f_TC_deleteSession_unknown TC_s2b_createSession_v4_noapco TC_s2b_createSession_v4_apco Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d --- M library/PFCP_Templates.ttcn M smf/SMF_Session_CT.ttcn M smf/SMF_Tests.ttcn M smf/expected-results.xml M smf/gen_links.sh 5 files changed, 395 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/43378/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d Gerrit-Change-Number: 43378 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: smf: Implement TC_gy_ccr_update_rejected
by pespin 28 Aug '26

28 Aug '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43436?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: smf: Implement TC_gy_ccr_update_rejected ...................................................................... smf: Implement TC_gy_ccr_update_rejected Add missing code to have a successful TC_gy_ccr_update_rejected. Change-Id: I9ad9fb1520f8a2163ed90e8ca5c121edcb267006 --- M library/PFCP_Templates.ttcn M smf/SMF_Session_CT.ttcn M smf/SMF_Tests.ttcn 3 files changed, 489 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/43436/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43436?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ad9fb1520f8a2163ed90e8ca5c121edcb267006 Gerrit-Change-Number: 43436 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[L] Change in osmo-ttcn3-hacks[master]: smf: Implement PFCP Sess Est and Sess Del procedures
by fixeria 28 Aug '26

28 Aug '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email ) Change subject: smf: Implement PFCP Sess Est and Sess Del procedures ...................................................................... Patch Set 8: (1 comment) File smf/SMF_Session_CT.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378/comment/1da8d0f4_1839… : PS7, Line 680: f_pfcp_sess_del_resp > Done No, I meant the function body is somehow tabulated twice... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d Gerrit-Change-Number: 43378 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Aug 2026 16:18:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: smf: Implement PFCP Sess Est and Sess Del procedures
by pespin 28 Aug '26

28 Aug '26

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: smf: Implement PFCP Sess Est and Sess Del procedures ...................................................................... smf: Implement PFCP Sess Est and Sess Del procedures With these in place, the following tests now pass: TC_createSession_deleteSession f_TC_deleteSession_unknown TC_s2b_createSession_v4_noapco TC_s2b_createSession_v4_apco Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d --- M library/PFCP_Templates.ttcn M smf/SMF_Session_CT.ttcn M smf/SMF_Tests.ttcn M smf/expected-results.xml M smf/gen_links.sh 5 files changed, 395 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/43378/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d Gerrit-Change-Number: 43378 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: smf: Implement PFCP Sess Est and Sess Del procedures
by pespin 28 Aug '26

28 Aug '26

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email ) Change subject: smf: Implement PFCP Sess Est and Sess Del procedures ...................................................................... Patch Set 7: (2 comments) File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378/comment/c5b3a12e_f255… : PS7, Line 217: template (value) BIT1 spare7_7 := '0'B, : > Do we really want to parametrize spare fields? Done File smf/SMF_Session_CT.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378/comment/6c706dd1_36d0… : PS7, Line 680: f_pfcp_sess_del_resp > cosmetic: indention Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I661a1893a3f7c3659753c82b009398763a06a92d Gerrit-Change-Number: 43378 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Aug 2026 16:17:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: smf: Introduce test TC_gy_charging_cc_time
by pespin 28 Aug '26

28 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43441?usp=email ) Change subject: smf: Introduce test TC_gy_charging_cc_time ...................................................................... smf: Introduce test TC_gy_charging_cc_time Similar to the existing one in PGW_Tests. Change-Id: I1d1c8983d390b65fd156eb56dc9c8ca09bcea2a8 --- M deps/Makefile M library/PFCP_Templates.ttcn M smf/SMF_Session_CT.ttcn M smf/SMF_Tests.ttcn M smf/expected-results.xml 5 files changed, 102 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/43441/1 diff --git a/deps/Makefile b/deps/Makefile index 521c0ea..17943f9 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -107,7 +107,7 @@ titan.ProtocolModules.SUA_commit= R.5.A-5-gcf1137a titan.ProtocolModules.TCP_commit= R.3.A-5-g39e5f45 titan.ProtocolModules.UDP_commit= R.4.A-5-geea8aa3 -titan.ProtocolModules.PFCP_v15.1.0_commit= 38b209571697a0ae659609fa8b629edacd7dde9f +titan.ProtocolModules.PFCP_v15.1.0_commit= bdd91b0a255afdb737afe9084b8ebc7b3cabc5f6 titan.TestPorts.AF_PACKET_commit= 0.1-5-g89ebea6 titan.TestPorts.Common_Components.Socket-API_commit= R.6.A-6-gf4380d0 titan.TestPorts.Common_Components.Abstract_Socket_commit= R.9.B-4-gbd41994 diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index 9d6bcfc..ce0465a 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -438,6 +438,31 @@ spare7_8 := spare7_8 } +/* 8.2.44 Volume Measurement */ +template (value) Volume_Measurement +ts_PFCP_Volume_Measurement(template (value) LIN8_BO_LAST total_volume := 0, + template (value) LIN8_BO_LAST uplink_volume := 0, + template (value) LIN8_BO_LAST downlink_volume := 0, + template (value) LIN8_BO_LAST total_packets := 0, + template (value) LIN8_BO_LAST uplink_packets := 0, + template (value) LIN8_BO_LAST downlink_packets := 0) := { + elementIdentifier := 66, + lengthIndicator := 0, /* overwritten */ + tovol := '1'B, + ulvol := '1'B, + dlvol := '1'B, + tonop := '1'B, + ulnop := '1'B, + dlnop := '1'B, + spare := '00'B, + total_volume := total_volume, + uplink_volume := uplink_volume, + downlink_volume := downlink_volume, + total_packets := total_packets, + uplink_packets := uplink_packets, + downlink_packets := downlink_packets +} + /* 8.2.45 Duration Measurement */ template (value) Duration_Measurement ts_PFCP_Duration_Measurement(template (value) LIN4_BO_LAST duration) := { diff --git a/smf/SMF_Session_CT.ttcn b/smf/SMF_Session_CT.ttcn index 9d301cf..f02e155 100644 --- a/smf/SMF_Session_CT.ttcn +++ b/smf/SMF_Session_CT.ttcn @@ -112,7 +112,12 @@ URR_ID urr_id, integer ur_seqn, integer start_time, /* In system clock */ - integer last_report_time /* In system clock */ + integer last_report_time, /* In system clock */ + /* Relative to last report sent: */ + uint64_t ul_bytes, + uint64_t dl_bytes, + uint64_t ul_pkts, + uint64_t dl_pkts } type record of Session_URR Session_URR_List; template (value) Session_URR @@ -120,7 +125,11 @@ urr_id := urr_id, ur_seqn := 0, start_time := start_time, - last_report_time := start_time + last_report_time := start_time, + ul_bytes := 0, + dl_bytes := 0, + ul_pkts := 0, + dl_pkts := 0 } type record PfcpParameters { charstring pfcp_local_addr, @@ -586,6 +595,14 @@ return valueof(ts_PFCP_Start_Time(int2oct(f_time_to_ntp32(urr.start_time), 4))); } +private function f_Session_URR_Volume_Measurement(Session_URR urr) +return Volume_Measurement { + return valueof(ts_PFCP_Volume_Measurement(urr.ul_bytes + urr.dl_bytes, + urr.ul_bytes, urr.dl_bytes, + urr.ul_pkts + urr.dl_pkts, + urr.ul_pkts, urr.dl_pkts)); +} + private function f_Session_URR_Duration_Measurement(inout Session_URR urr) return Duration_Measurement { var integer now := f_time(); @@ -613,6 +630,7 @@ ts_PFCP_Usage_Report_Trigger(quvti := '1'B), start_time := f_Session_URR_Start_Time(urr), end_time := f_End_Time_now(), + volume_measurement := f_Session_URR_Volume_Measurement(urr), duration_measurement := f_Session_URR_Duration_Measurement(urr)); return valueof(usage_report); } diff --git a/smf/SMF_Tests.ttcn b/smf/SMF_Tests.ttcn index bb4d231..b452bd9 100644 --- a/smf/SMF_Tests.ttcn +++ b/smf/SMF_Tests.ttcn @@ -325,6 +325,60 @@ vc_conn.done; } +/* Test charging over Gy interface. */ +private function f_TC_gy_charging_cc_time() runs on SMF_Session_CT { + var default d; + + f_s5s8_create_session(); + + f_sleep(int2float(g_pars.gy.validity_time)); + f_pfcp_sess_report_req(); + + /* We should receive an update even if no traffic is sent: */ + as_DIA_Gy_CCR(UPDATE_REQUEST); + f_validate_gy_cc_report(g_rx_gy, VALIDITY_TIME, (3..4), 0, 0); + /* SMF updates new Volume quota obtained from OCS on UPF: */ + as_pfcp_sess_mod_req(); + + /* Emulate some traffic happening at the UPF: */ + g_pars.pfcp_pars.urr_list[0].ul_bytes := 29; + g_pars.pfcp_pars.urr_list[0].dl_bytes := 50; + g_pars.pfcp_pars.urr_list[0].ul_pkts := 2; + g_pars.pfcp_pars.urr_list[0].dl_pkts := 1; + f_sleep(int2float(g_pars.gy.validity_time)); + f_pfcp_sess_report_req(); + + as_DIA_Gy_CCR(UPDATE_REQUEST) + f_validate_gy_cc_report(g_rx_gy, VALIDITY_TIME, (3..4), 29, 50); + /* SMF updates new Volume quota obtained from OCS on UPF: */ + as_pfcp_sess_mod_req(); + + /* Emulate some traffic happening at the UPF: */ + g_pars.pfcp_pars.urr_list[0].ul_bytes := 400; + g_pars.pfcp_pars.urr_list[0].dl_bytes := 500; + g_pars.pfcp_pars.urr_list[0].ul_pkts := 30; + g_pars.pfcp_pars.urr_list[0].dl_pkts := 31; + f_sleep(int2float(g_pars.gy.validity_time)); + f_pfcp_sess_report_req(); + + as_DIA_Gy_CCR(UPDATE_REQUEST); + f_validate_gy_cc_report(g_rx_gy, VALIDITY_TIME, (3..4), 400, 500); + /* SMF updates new Volume quota obtained from OCS on UPF: */ + as_pfcp_sess_mod_req(); + + f_delete_session(omit, Request_accepted); + f_validate_gy_cc_report(g_rx_gy, FINAL, (0..1), 0, 0); + setverdict(pass); +} +testcase TC_gy_charging_cc_time() runs on SMF_Test_CT { + var SMF_Session_CT vc_conn; + var SessionPars pars := valueof(t_SessionPars('001010123456789'H)); + pars.gy.validity_time := 3; /* Grant access for 3 seconds, needs to be re-validated afterwards */ + f_init(); + vc_conn := f_start_handler(refers(f_TC_gy_charging_cc_time), pars); + vc_conn.done; +} + /* Test Gy CCR rejected with CCA Result-Code DIAMETER_AUTHORIZATION_REJECTED (5003) */ private function f_TC_gy_ccr_update_rejected() runs on SMF_Session_CT { var default d; @@ -402,6 +456,7 @@ execute( TC_tx_echo() ); execute( TC_createSession_deleteSession() ); execute( TC_deleteSession_unknown() ); + execute( TC_gy_charging_cc_time() ); execute( TC_gy_ccr_update_rejected() ); execute( TC_s2b_createSession_v4_noapco() ); execute( TC_s2b_createSession_v4_apco() ); diff --git a/smf/expected-results.xml b/smf/expected-results.xml index 32dd281..eba5484 100644 --- a/smf/expected-results.xml +++ b/smf/expected-results.xml @@ -3,6 +3,7 @@ <testcase classname='SMF_Tests' name='TC_tx_echo' time='MASKED'/> <testcase classname='SMF_Tests' name='TC_createSession_deleteSession' time='MASKED'/> <testcase classname='SMF_Tests' name='TC_deleteSession_unknown' time='MASKED'/> + <testcase classname='SMF_Tests' name='TC_gy_charging_cc_time' time='MASKED'/> <testcase classname='SMF_Tests' name='TC_gy_ccr_update_rejected' time='MASKED'/> <testcase classname='SMF_Tests' name='TC_s2b_createSession_v4_noapco' time='MASKED'/> <testcase classname='SMF_Tests' name='TC_s2b_createSession_v4_apco' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d1c8983d390b65fd156eb56dc9c8ca09bcea2a8 Gerrit-Change-Number: 43441 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: smf: Implement TC_gy_ccr_update_rejected
by pespin 28 Aug '26

28 Aug '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43436?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: smf: Implement TC_gy_ccr_update_rejected ...................................................................... smf: Implement TC_gy_ccr_update_rejected Add missing code to have a successful TC_gy_ccr_update_rejected. Change-Id: I9ad9fb1520f8a2163ed90e8ca5c121edcb267006 --- M library/PFCP_Templates.ttcn M smf/SMF_Session_CT.ttcn M smf/SMF_Tests.ttcn 3 files changed, 489 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/43436/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43436?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ad9fb1520f8a2163ed90e8ca5c121edcb267006 Gerrit-Change-Number: 43436 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in osmo-sgsn[master]: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach
by fixeria 28 Aug '26

28 Aug '26

Attention is currently required from: lynxis lazus, osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email ) Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > Ack, makes sense. Marking as unresolved because it's not. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43440 is a work in progress TTCN-3 testcase. It's currently failing due to Tguard timeout, because re-attach is somewhat broken. I am leaving it sitting WIP in Gerrit until this is resolved. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Gerrit-Change-Number: 42594 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 28 Aug 2026 16:10:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_reattach_drops_stale_pdp
by fixeria 28 Aug '26

28 Aug '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43440?usp=email ) Change subject: sgsn: add TC_attach_reattach_drops_stale_pdp ...................................................................... sgsn: add TC_attach_reattach_drops_stale_pdp Verify that on a re-Attach with a known IMSI/P-TMSI, the SGSN drops stale PDP contexts left over from before the MS restarted, but only once the re-Attach has actually been authenticated. Change-Id: I4a0b6cfbb46f673e3037c0fbf3e8c03a8b6316ad Related: osmo-sgsn.git I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Related: OS#6922 --- M sgsn/SGSN_Tests.ttcn M sgsn/expected-results.xml 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/43440/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 1d58b46..78d2103 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -1267,6 +1267,42 @@ f_cleanup(); } +/* ATTACH + PDP CTX ACT + re-ATTACH (with the P-TMSI allocated by the first + * Attach): the SGSN must recognize the known identity and release the stale + * PDP context left over from before towards the GGSN, but only once the + * re-Attach has actually been authenticated. */ +private function f_TC_attach_reattach_drops_stale_pdp(charstring id) runs on BSSGP_ConnHdlr { + var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip)); + timer T := 5.0; + + /* first perform regular attach + activate a PDP context */ + f_TC_attach(id); + f_pdp_ctx_act(apars); + + /* MS "restarts" and sends a re-Attach Request using the P-TMSI it was + * assigned before. + * XXX: the test is getting stuck here :/ */ + f_gmm_attach(false, false, 0, omit, true); + + /* the stale PDP context must have been released towards the GGSN */ + T.start; + alt { + [] as_ggsn_gtp_ctx_del_req(apars) { + setverdict(pass); + } + [] T.timeout { + setverdict(fail, "SGSN did not release stale PDP context towards GGSN after re-Attach"); + } + } +} +testcase TC_attach_reattach_drops_stale_pdp() runs on test_CT { + var BSSGP_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_attach_reattach_drops_stale_pdp), testcasename(), g_gb, 74); + vc_conn.done; + f_cleanup(); +} + private function f_TC_attach_echo_timeout(charstring id) runs on BSSGP_ConnHdlr { var Gtp1cUnitdata g_ud; var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip)); @@ -3423,6 +3459,7 @@ execute( TC_attach_pdp_act_user_deact_mt() ); execute( TC_attach_pdp_act_deact_dup() ); execute( TC_attach_second_attempt() ); + execute( TC_attach_reattach_drops_stale_pdp() ); execute( TC_attach_echo_timeout() ); execute( TC_attach_restart_ctr_echo() ); execute( TC_attach_restart_ctr_create() ); diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml index e2e099b..06352cd 100644 --- a/sgsn/expected-results.xml +++ b/sgsn/expected-results.xml @@ -61,6 +61,7 @@ SGSN_Tests.ttcn:MASKED TC_attach_second_attempt testcase </failure> </testcase> + <testcase classname='SGSN_Tests' name='TC_attach_reattach_drops_stale_pdp' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_echo_timeout' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_restart_ctr_echo' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_restart_ctr_create' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43440?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a0b6cfbb46f673e3037c0fbf3e8c03a8b6316ad Gerrit-Change-Number: 43440 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log