- gerrit-log - lists.osmocom.org

[M] Change in ...osmo-s1gw[master]: [REST] osmo-s1gw-cli.py skeleton

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41097?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: [REST] osmo-s1gw-cli.py skeleton ...................................................................... [REST] osmo-s1gw-cli.py skeleton This is an interactive shell based on Python's cmd2 library, providing an alternative to the traditional VTY interface used in many Osmocom projects. It communicates with the main process via the REST interface. Currently there's only one command fetching the OpenAPI specification. More commands will be introduced in follow-up commits. Change-Id: I05600f2fa6d213b9cee28871761231722ff5b876 Related: SYS#7066 --- M Makefile M README.md A contrib/osmo-s1gw-cli.py M debian/control M debian/copyright A debian/osmo-s1gw-cli.install A debian/osmo-s1gw.install 7 files changed, 214 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/97/41097/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I05600f2fa6d213b9cee28871761231722ff5b876 Gerrit-Change-Number: 41097 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

10 hours, 22 minutes

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: contrib/generate_build_dep.sh: pass '-f' to mv

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41109?usp=email ) Change subject: contrib/generate_build_dep.sh: pass '-f' to mv ...................................................................... contrib/generate_build_dep.sh: pass '-f' to mv It may happen that the same directory is present in both `_build/default/lib` and `_build/default/plugins` directories. In this case the `mv` command will fail, and this is exactly what happens when adding a new dependency in a follow-up patch: mv: cannot move './_build/default/plugins/ncalendar' to '_checkouts/ncalendar': Directory not empty mv: cannot move './_build/default/plugins/ndto' to '_checkouts/ndto': Directory not empty mv: cannot move './_build/default/plugins/njson' to '_checkouts/njson': Directory not empty Pass `-f` to allow overwriting already existing checkouts. Change-Id: I9a95afcac54dec9684f34224a912574bb387e96c --- M contrib/generate_build_dep.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/09/41109/1 diff --git a/contrib/generate_build_dep.sh b/contrib/generate_build_dep.sh index 08efac9..c91b8e3 100755 --- a/contrib/generate_build_dep.sh +++ b/contrib/generate_build_dep.sh @@ -13,9 +13,9 @@ REBAR_PROFILE=default rebar3 get-deps REBAR_PROFILE=test rebar3 get-deps mkdir _checkouts -mv ./_build/default/lib/* _checkouts/ -mv ./_build/default/plugins/* _checkouts/ -mv ./_build/test/lib/meck _checkouts/ +mv -f ./_build/default/lib/* _checkouts/ +mv -f ./_build/default/plugins/* _checkouts/ +mv -f ./_build/test/lib/meck _checkouts/ # delete erlang bytecode find _checkouts/ -iname '*beam' -delete tar czf build_dep.tar.gz ./_checkouts -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I9a95afcac54dec9684f34224a912574bb387e96c Gerrit-Change-Number: 41109 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

10 hours, 22 minutes

1
0
0 0

[S] Change in ...osmo-s1gw[master]: README.md: document installation

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41108?usp=email ) Change subject: README.md: document installation ...................................................................... README.md: document installation Change-Id: I383d1d0aa89e6c3c68985464f727aaadbb7d35ce --- M README.md 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/08/41108/1 diff --git a/README.md b/README.md index cfb6f52..e1723e9 100644 --- a/README.md +++ b/README.md @@ -110,6 +110,29 @@ ``` +Installation +------------ + +OsmoS1GW is built for common versions of Debian, Ubuntu and other distributions as a part of +the [Osmocom binary packages](https://osmocom.org/projects/cellular-infrastructure/wiki/Binary_…. +If you're not doing development, it is suggested to simply use those binary packages, rather +than building from source. Otherwise, you can invoke the `install` target: + +``` +$ sudo make install +``` + +This will install the following: + +* `/usr/lib/osmo-s1gw` - complete OTP release package +* `/usr/bin/osmo-s1gw` - convenience script for running `osmo-s1gw` +* `/lib/systemd/system/osmo-s1gw.service` - systemd unit file +* `/etc/osmocom/osmo-s1gw.config` - the configuration file + +The installation paths can be adjusted using `DESTDIR`, `LIBDIR`, `BINDIR`, +`CONFDIR`, and `SYSTEMDUNITDIR` variables. + + Configuration ------------- -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I383d1d0aa89e6c3c68985464f727aaadbb7d35ce Gerrit-Change-Number: 41108 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

18 hours, 15 minutes

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: README.md: cosmetic: s/osmo_s1gw/OsmoS1GW/

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41106?usp=email ) Change subject: README.md: cosmetic: s/osmo_s1gw/OsmoS1GW/ ...................................................................... README.md: cosmetic: s/osmo_s1gw/OsmoS1GW/ Change-Id: I0346123cccf78c85d36ce71e68e83204178a5ee9 --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/06/41106/1 diff --git a/README.md b/README.md index b85bbbc..d26c505 100644 --- a/README.md +++ b/README.md @@ -97,7 +97,7 @@ Running ------- -Once `osmo_s1gw` is built, you can start it this way: +Once OsmoS1GW is built, you can start it this way: ``` $ make run -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I0346123cccf78c85d36ce71e68e83204178a5ee9 Gerrit-Change-Number: 41106 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

18 hours, 15 minutes

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: README.md: mention 'make analyze'

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41107?usp=email ) Change subject: README.md: mention 'make analyze' ...................................................................... README.md: mention 'make analyze' Change-Id: I5af11dc51ccb514918dd145975bed55381d4b76b --- M README.md 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/07/41107/1 diff --git a/README.md b/README.md index d26c505..cfb6f52 100644 --- a/README.md +++ b/README.md @@ -93,6 +93,12 @@ $ make check ``` +Additionally, you can run the static analyser (Dialyzer): + +``` +$ make analyze +``` + Running ------- -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5af11dc51ccb514918dd145975bed55381d4b76b Gerrit-Change-Number: 41107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

18 hours, 15 minutes

1
0
0 0

[M] Change in ...osmo-s1gw[master]: [REST] OpenAPI specification skeleton

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41096?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: [REST] OpenAPI specification skeleton ...................................................................... [REST] OpenAPI specification skeleton Change-Id: I84e6ef5cc67cd26b11f7bed8510420e43e18c69b Related: SYS#7066 --- M Makefile M README.md A contrib/openapi.yaml A contrib/yaml2json.py M debian/copyright A priv/openapi.json 6 files changed, 55 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/96/41096/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I84e6ef5cc67cd26b11f7bed8510420e43e18c69b Gerrit-Change-Number: 41096 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

18 hours, 15 minutes

1
0
0 0

[M] Change in ...osmo-s1gw[master]: [REST] osmo-s1gw-cli.py skeleton

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41097?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: [REST] osmo-s1gw-cli.py skeleton ...................................................................... [REST] osmo-s1gw-cli.py skeleton This is an interactive shell based on Python's cmd2 library, providing an alternative to the traditional VTY interface used in many Osmocom projects. It communicates with the main process via the REST interface. Currently there's only one command fetching the OpenAPI specification. More commands will be introduced in follow-up commits. Change-Id: I05600f2fa6d213b9cee28871761231722ff5b876 Related: SYS#7066 --- M Makefile M README.md A contrib/osmo-s1gw-cli.py M debian/control M debian/copyright A debian/osmo-s1gw-cli.install A debian/osmo-s1gw.install 7 files changed, 213 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/97/41097/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I05600f2fa6d213b9cee28871761231722ff5b876 Gerrit-Change-Number: 41097 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

18 hours, 15 minutes

1
0
0 0

[M] Change in ...osmo-s1gw[master]: [REST] Integrate Erlang REST Framework

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41098?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: [REST] Integrate Erlang REST Framework ...................................................................... [REST] Integrate Erlang REST Framework Change-Id: I20ad3208b8cd4f5483992e3bf22af30ff62b0311 Related: SYS#7066 --- M README.md M config/sys.config M rebar.config M rebar.lock M src/osmo_s1gw.app.src M src/osmo_s1gw.erl M src/osmo_s1gw_sup.erl A src/rest_server.erl 8 files changed, 109 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/98/41098/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41098?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I20ad3208b8cd4f5483992e3bf22af30ff62b0311 Gerrit-Change-Number: 41098 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

18 hours, 15 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: S1GW: Add test case to test release of failed e-RABs during handover ...

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email ) Change subject: S1GW: Add test case to test release of failed e-RABs during handover resource allocation ...................................................................... Patch Set 2: (5 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/2ce934ba_5a6e… : PS2, Line 1706: var ERabIdxList erabs_admitted; : for (var integer i := 0; i < lengthof(g_pars.erabs); i := i + 1) { : erabs_admitted[i] := i; : } See my comment about `f_ERabList_compose()` in previous patch. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/aa4db8fc_d9b3… : PS2, Line 1720: f_ConnHdlr_tx_handover_ack(erabs_admitted, mme_ue_id, enb_ue_id, erabs_failed); : log("[eNB -> S1GW] -> MME: HANDOVER REQUEST ACKNOWLEDGE"); We usually log first: ```suggestion log("[eNB -> S1GW] -> MME: HANDOVER REQUEST ACKNOWLEDGE"); f_ConnHdlr_tx_handover_ack(erabs_admitted, mme_ue_id, enb_ue_id, erabs_failed); ``` https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/95bc691b_7daf… : PS2, Line 1726: for (var integer i := 0; i < lengthof(erabs_admitted); i := i + 1) { : var ERabIdx idx := erabs_admitted[i]; : erabs[i] := g_pars.erabs[idx]; : } See my comment about `f_ERabList_compose()` in previous patch. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/690d213b_e6d6… : PS2, Line 1736: for (var integer i := 0; i < lengthof(erabs_failed); i := i + 1) { : var ERabIdx idx := erabs_failed[i]; : erabs[i] := g_pars.erabs[idx]; : See my comment about `f_ERabList_compose()` in previous patch. File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/5e6ae4a5_7a78… : PS2, Line 962: for (var integer i := 0; i < lengthof(erabs_admitted); i := i + 1) { : var ERabIdx idx := erabs_admitted[i]; : erabs_left[i] := g_pars.erabs[idx]; : See my comment about `f_ERabList_compose()` in previous patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic14f560ae16b8386e58ac85f8af53b19d7c7a5c9 Gerrit-Change-Number: 41095 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Sat, 13 Sep 2025 08:29:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

20 hours, 11 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: S1GW: Add test case to test release of e-RABs during handover prepera...

by fixeria

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email ) Change subject: S1GW: Add test case to test release of e-RABs during handover preperation ...................................................................... Patch Set 2: (5 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/8539cb30_2d35… : PS2, Line 1210: in ERabIdxList erabs_release := {}) > I vote for stopping adding more "in" churn :D For `ERabIdxList`, yes, we don't really need `in/out`. However we should keep using them for `ERabList`, to let the caller know if the given list is going to be modified or not. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/d9b9440a_5010… : PS2, Line 1720: in ERabIdxList erabs_forward, > No more "in" churn please. Why are you so obsessed with this? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/af12930b_322f… : PS2, Line 1718: function f_ConnHdlr_handover_cmd(MME_UE_S1AP_ID mme_ue_id, : ENB_UE_S1AP_ID enb_ue_id, : in ERabIdxList erabs_forward, : Nitpick: in the existing API, arguments `mme_ue_id` and `enb_ue_id` usually follow `ERabList`/`ERabIdxList` arguments. For the sake of consistency, I suggest: ```suggestion function f_ConnHdlr_handover_cmd(ERabIdxList erabs_forward, ERabIdxList erabs_release, MME_UE_S1AP_ID mme_ue_id, ENB_UE_S1AP_ID enb_ue_id) ``` File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/702e923f_fce6… : PS2, Line 911: for (var integer i := 0; i < lengthof(erabs_forward); i := i + 1) { I see this logic repeated in several places, so I think it's worth having a function in `S1GW_ConnHdlr` (next to `f_ERabList_find_by_pdu()`): ``` function f_ERabList_compose(ERabIdxList idx_list) runs on ConnHdlr return ERabList { var ERabList erabs; for (var integer i := 0; i < lengthof(idx_list); i := i + 1) { var ERabIdx idx := idx_list[i]; erabs[i] := g_pars.erabs[idx]; } return erabs; } ``` This way here you could do: ``` if (lengthof(erabs_forward) > 0) { var ERabList erabs := f_ERabList_compose(erabs_forward); f_ConnHdlr_erab_release_cmd(erabs, g_pars.mme_ue_id, g_pars.idx); f_ConnHdlr_erab_release_rsp(erabs, g_pars.mme_ue_id, g_pars.idx); } ``` https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/49ea8775_882e… : PS2, Line 912: tabs vs spaces -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic70ba19c0a6e349f63aae124607d075b6d19e779 Gerrit-Change-Number: 41094 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 13 Sep 2025 08:21:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

20 hours, 20 minutes

1
0
0 0

2025

2024

2023

2022

gerrit-log