Attention is currently required from: laforge, lynxis lazus.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41579?usp=email )
Change subject: pySim.runtime: Fix file selection by upper case hex FID
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
As far as I can see this patch looks good. I have left one comment with an idea to make this approach more general.
File pySim/runtime.py:
https://gerrit.osmocom.org/c/pysim/+/41579/comment/255ce142_ced8e17d?usp=em… :
PS1, Line 488: name = name.lower()
I think this is ok. I see lines like this in select also. However, it might be worth checking if is possible to generalize this with a method or function that just gets us the file object either by name or by FID. This function would then accept case insensitive FIDs and case sensitive file names.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41579?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idd0db1f4bbd3ee9eec20f5fd0f4371c2882950cd
Gerrit-Change-Number: 41579
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:59:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/meta-telephony/+/41638?usp=email )
Change subject: Update osmo-sgsn and libosmo-sigtran to last patch releases
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/41638?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I6a55fa1d29c6cbb67d4da55863db3d6bfc161d55
Gerrit-Change-Number: 41638
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:54:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/meta-telephony/+/41638?usp=email )
Change subject: Update osmo-sgsn and libosmo-sigtran to last patch releases
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/41638?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I6a55fa1d29c6cbb67d4da55863db3d6bfc161d55
Gerrit-Change-Number: 41638
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:53:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: falconia, neels.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41630?usp=email )
Change subject: MGW control: migrate to new API for codecs and payload types
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I think this might benefit from a TODO-RELEASE entry specifying explicitly that a new/future tagged […]
ACK
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41630?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iafc38a3da64ce7c2f060a32864174dcde9f57b56
Gerrit-Change-Number: 41630
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: laforge.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41528?usp=email )
Change subject: contrib/saip-tool: Use repr() on security domain keys
......................................................................
Patch Set 1: Code-Review+2 Verified+1
(1 comment)
Patchset:
PS1:
I have given this a quick test. The output looks fine. I think we can merge this.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41528?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iaead4a02f07130fd00bcecc43e1c843f1c221e63
Gerrit-Change-Number: 41528
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:35:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41527?usp=email )
Change subject: pySim.esim.saip: Hex representation of SecurityDomainKey
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
As far as I can see the patch is correct. However, I didn't test it though but the code looks correct.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41527?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic9a92d53d73378eafca1760dd8351215bce1157a
Gerrit-Change-Number: 41527
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:26:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41633?usp=email )
Change subject: gsm/protocol/gsm_48_103.h: add definition for TW-TS-007
......................................................................
gsm/protocol/gsm_48_103.h: add definition for TW-TS-007
TW-TS-007 is a Themyscira/Osmocom extension to AoIP interface
that provides a much more compact payload format for CSD, matching
the size of compressed speech payloads. Clause 9 in this spec
fixes the payload type on AoIP interface for this pseudo-codec
as 127, distinguishing it from CLEARMODE and from all speech
codecs.
Osmocom applications that may need payload type numbers for the
standard set of codecs defined in TS 48.103 may also need the
payload type for TW-TS-007 if they implement this extension,
as this payload format is intended to "stand on equal footing"
with standard AoIP payload types. Therefore, add it to the same
header file.
Change-Id: I74c9e76ebcce32ad20501134ec5089794acb4f62
---
M include/osmocom/gsm/protocol/gsm_48_103.h
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gsm/protocol/gsm_48_103.h b/include/osmocom/gsm/protocol/gsm_48_103.h
index d40acac..6fe461b 100644
--- a/include/osmocom/gsm/protocol/gsm_48_103.h
+++ b/include/osmocom/gsm/protocol/gsm_48_103.h
@@ -19,3 +19,6 @@
/* circuit-switched data */
#define OSMO_AOIP_RTP_PT_CSD 120 /* without redundancy */
#define OSMO_AOIP_RTP_PT_CSD_RED 121 /* with redundancy */
+
+/* Osmocom and Themyscira extensions */
+#define OSMO_AOIP_RTP_PT_TWTS007 127 /* compressed form of CSD */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41633?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I74c9e76ebcce32ad20501134ec5089794acb4f62
Gerrit-Change-Number: 41633
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>