- gerrit-log - lists.osmocom.org

[XS] Change in osmo-trx[master]: Transceiver52M: use lround() for TRXD rssi rounding
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: Hoernchen, fixeria, tnt. Hello Hoernchen, Jenkins Builder, laforge, pespin, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43162?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Transceiver52M: use lround() for TRXD rssi rounding ...................................................................... Transceiver52M: use lround() for TRXD rssi rounding trxd_fill_v0_specific() assigned bi->rssi to v0->rssi via a bare narrowing double->uint8_t cast, silently truncating towards zero instead of rounding to nearest. Use lround(), consistent with the toa/ci rounding fixed in the preceding commit. Change-Id: Ibdfe9f1b84c797bd7a50b4ee3f395c2af0ee88fd Related: OS#5283 --- M Transceiver52M/proto_trxd.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/62/43162/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43162?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibdfe9f1b84c797bd7a50b4ee3f395c2af0ee88fd Gerrit-Change-Number: 43162 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-trx[master]: Transceiver52M: use lround() for TRXD toa/ci rounding
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: Hoernchen, fixeria, tnt. Hello Hoernchen, Jenkins Builder, laforge, pespin, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43161?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Transceiver52M: use lround() for TRXD toa/ci rounding ...................................................................... Transceiver52M: use lround() for TRXD toa/ci rounding trxd_fill_v0_specific() and trxd_fill_v1_specific() rounded bi->toa and bi->ci to the nearest integer using the "+ 0.5, then truncate" idiom. That only rounds correctly for non-negative inputs: for negative values (toa can be negative for an early burst, ci can be negative under poor C/I conditions) it biases towards zero instead of rounding to nearest, e.g. -1.3 + 0.5 = -0.8, truncated to 0 instead of the correct -1. Use lround() instead, which rounds-half-away-from-zero correctly for both signs. Change-Id: I0c52f1b91070e4750a8a0ffbccb222454e694c3b Related: OS#5283 --- M Transceiver52M/proto_trxd.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/61/43161/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0c52f1b91070e4750a8a0ffbccb222454e694c3b Gerrit-Change-Number: 43161 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: debian: add packaging for libosmo-trx
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43114?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: debian: add packaging for libosmo-trx ...................................................................... debian: add packaging for libosmo-trx Add the usual Debian packaging files, closely following the ones in libosmocore.git: the shared library package libosmo-trx0, as well as the -dev, -doc, and -dbg packages. Change-Id: I56f0074ad121ecacb076b508d1adfdd71cce99ec --- M debian/control A debian/libosmo-trx-dev.install A debian/libosmo-trx-doc.doc-base A debian/libosmo-trx-doc.install A debian/libosmo-trx0.install M debian/rules 6 files changed, 77 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/14/43114/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43114?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I56f0074ad121ecacb076b508d1adfdd71cce99ec Gerrit-Change-Number: 43114 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XL] Change in osmo-trx[master]: libosmo-trx: generate Doxygen API documentation
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: libosmo-trx: generate Doxygen API documentation ...................................................................... libosmo-trx: generate Doxygen API documentation Add Doxyfile.trx.in (based on Doxyfile.core.in from libosmocore.git, upgraded using 'doxygen -u' to get rid of obsolete tags) and the usual rules to build and install the HTML documentation, as well as the --disable-doxygen configure option, like in other libosmo-* projects. Change-Id: I54cf8c0c60215c666d8fa55dafec53379a2382d5 --- M .gitignore M configure.ac A libosmo-trx/Doxyfile.trx.in M libosmo-trx/Makefile.am 4 files changed, 3,027 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/43113/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I54cf8c0c60215c666d8fa55dafec53379a2382d5 Gerrit-Change-Number: 43113 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-trx[master]: .checkpatch.c++.conf: --ignore LEADING_SPACE
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43602?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: .checkpatch.c++.conf: --ignore LEADING_SPACE ...................................................................... .checkpatch.c++.conf: --ignore LEADING_SPACE checkpatch complains about leading spaces in C++ header files. For instance, the following code: ``` class Transceiver { public: Transceiver(const struct trx_cfg *cfg, ...); ``` fails with: WARNING:LEADING_SPACE: please, no spaces at the start of a line Ignore it for C++, like the other rules already excluded there. Change-Id: I542cd4e393c218979e78f56c7d3f9d2ed6d6f379 --- M .checkpatch.c++.conf 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/02/43602/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I542cd4e393c218979e78f56c7d3f9d2ed6d6f379 Gerrit-Change-Number: 43602 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: libosmo-trx/ep: allow ctrl socket to accept/reply to any peer
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43601?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: libosmo-trx/ep: allow ctrl socket to accept/reply to any peer ...................................................................... libosmo-trx/ep: allow ctrl socket to accept/reply to any peer By default, the socket stays connect()ed to the configured peer, so the kernel silently drops datagrams from anyone else. This is fine for the normal osmo-bts/osmo-trx/trxcon use case, where both ends of the link are fixed and known ahead of time. Add an optional promiscuous mode that enables ttcn3-bts-test to inject path simulation TRXC commands from its own source port: when enabled, leave the ctrl socket unconnected and always reply to the actual sender of the last received CMD (tracked in chan->ctrl_peer), rather than only the configured peer. This mode will be used by the upcoming osmo-trx-proxy. Change-Id: I97075eb350e4270f4e909d493ba692e6b65be750 Related: OS#6672 --- M libosmo-trx/include/osmocom/trx/ep.h M libosmo-trx/src/trx_ep.c M tests/libosmo-trx/trx_ep_test.c M tests/libosmo-trx/trx_ep_test.err M tests/libosmo-trx/trx_ep_test.ok 5 files changed, 171 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/01/43601/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I97075eb350e4270f4e909d493ba692e6b65be750 Gerrit-Change-Number: 43601 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XL] Change in osmo-trx[master]: libosmo-trx/ep: add TRX endpoint module
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: libosmo-trx/ep: add TRX endpoint module ...................................................................... libosmo-trx/ep: add TRX endpoint module Add the osmo_trx_ep module, encapsulating the clock/ctrl/data UDP socket management of the TRX protocol on top of osmo_io. One endpoint serves an (optional) clock socket plus N channels, each channel being a ctrl + data socket pair. The module is role-neutral: struct osmo_trx_ep_cfg carries a mode (OSMO_TRX_EP_MODE_{L1,TRX}) selecting which side of the protocol the endpoint implements. The mode is needed to parse datagrams received on the data sockets, as the wire format alone does not identify the direction (BURST.ind vs BURST.req). All local and remote ports are derived from a single base port (default: 5700). To avoid indirect calls on the hot path, the decoded Rx handlers (osmo_trx_ep_rx_*) are plain function prototypes bound at link-time, not function pointers. The library provides weak default stubs to stay link-complete (-no-undefined), so applications only implement the handlers for the directions they consume, overriding the stubs. The Tx path implements TRXDv2 PDU batching for burst requests: osmo_trx_ep_send_burst_req() accumulates PDUs until it is called with br == NULL (the batching breaker), like in osmo-bts-trx. osmo-trx itself will not adopt this module: its per-channel/thread socket ownership model (dedicated blocking-read threads per socket) is incompatible with osmo_io's single-select-loop dispatch. It is meant for osmo-bts, osmocom-bb/trxcon, and the upcoming C rewrite of fake_trx (osmo-trx-proxy). Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3 --- M .gitignore M libosmo-trx/include/Makefile.am A libosmo-trx/include/osmocom/trx/ep.h M libosmo-trx/src/Makefile.am A libosmo-trx/src/trx_ep.c M tests/libosmo-trx/Makefile.am A tests/libosmo-trx/trx_ep_test.c A tests/libosmo-trx/trx_ep_test.err A tests/libosmo-trx/trx_ep_test.ok M tests/testsuite.at 10 files changed, 1,270 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/43111/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3 Gerrit-Change-Number: 43111 Gerrit-PatchSet: 9 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: libosmo-trx/ep: make TRXDv2+ PDU batching configurable
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43627?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: libosmo-trx/ep: make TRXDv2+ PDU batching configurable ...................................................................... libosmo-trx/ep: make TRXDv2+ PDU batching configurable Change-Id: I60b8337db4ec8e70d37b2d9c0b75da338386ec47 Related: OS#6672 --- M libosmo-trx/include/osmocom/trx/ep.h M libosmo-trx/src/trx_ep.c M tests/libosmo-trx/trx_ep_test.c M tests/libosmo-trx/trx_ep_test.ok 4 files changed, 57 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/27/43627/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43627?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I60b8337db4ec8e70d37b2d9c0b75da338386ec47 Gerrit-Change-Number: 43627 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: libosmo-trx/client: add optional limit for retransmissions
by fixeria 14 Sep '26

14 Sep '26

Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43109?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: libosmo-trx/client: add optional limit for retransmissions ...................................................................... libosmo-trx/client: add optional limit for retransmissions The client used to retransmit an unacknowledged command forever, like osmo-bts-trx does. trxcon, however, gives up after 3 retransmission attempts, concluding that the transceiver is offline. Add a new API function osmo_trxc_client_set_max_retrans() enabling this behavior: once a command has been retransmitted the given number of times without a response, the client escalates to the fatal_error call-back (with rsp == NULL) and freezes the command queue. The default (0) retains the old behavior (no limit). This is a preparation for porting trxcon to libosmo-trx. Change-Id: Ib90a032b38c69ae26023e726992d3f5f7e502fcf --- M libosmo-trx/include/osmocom/trx/trxc_client.h M libosmo-trx/src/trxc_client.c M tests/libosmo-trx/trxc_client_test.c M tests/libosmo-trx/trxc_client_test.err M tests/libosmo-trx/trxc_client_test.ok 5 files changed, 118 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/09/43109/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib90a032b38c69ae26023e726992d3f5f7e502fcf Gerrit-Change-Number: 43109 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-trx[master]: libosmo-trx/client: add TRXC client (command queue) API
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: libosmo-trx/client: add TRXC client (command queue) API ...................................................................... libosmo-trx/client: add TRXC client (command queue) API Add the osmo_trxc_client module: a transport-agnostic generalization of the TRXC command handling logic in osmo-bts-trx (trx_if.c): * command queue with a single command in flight; * retransmission on response timeout (default: 2 s); * suppression of consecutive duplicate commands; * RSP<->CMD matching, optionally including the parameters; * filtering of duplicate responses caused by retransmissions; * escalation of NACKed critical commands (OSMO_TRXC_F_CRITICAL) to the fatal_error call-back; * TRXD PDU version negotiation (SETFORMAT), incl. the fallback to version 0 for old transceivers rejecting it with 'RSP ERR 1'. The client neither opens nor owns a socket: the application transmits serialized messages in the tx_msg call-back and feeds received datagrams into osmo_trxc_client_rx(). The response call-back may return N > 0 to request a re-transmission of the same command after N seconds (e.g. POWERON retry, as implemented in osmo-bts-trx). Change-Id: I817e394f74a10e3adae4a0b58342c82acdf0794e --- M .gitignore M libosmo-trx/include/Makefile.am A libosmo-trx/include/osmocom/trx/trxc_client.h M libosmo-trx/src/Makefile.am A libosmo-trx/src/trxc_client.c M tests/libosmo-trx/Makefile.am A tests/libosmo-trx/trxc_client_test.c A tests/libosmo-trx/trxc_client_test.err A tests/libosmo-trx/trxc_client_test.ok M tests/testsuite.at 10 files changed, 1,117 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/08/43108/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I817e394f74a10e3adae4a0b58342c82acdf0794e Gerrit-Change-Number: 43108 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log