- gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: Lb: Log stop of Lb link
by pespin 30 Jan '26

30 Jan '26

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41994?usp=email ) Change subject: Lb: Log stop of Lb link ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41994?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8537874cf6b70791aa0fee9f1c94b472113ccf6 Gerrit-Change-Number: 41994 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in osmo-bsc[master]: Lb: Log stop of Lb link
by pespin 30 Jan '26

30 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41994?usp=email ) Change subject: Lb: Log stop of Lb link ...................................................................... Lb: Log stop of Lb link Change-Id: If8537874cf6b70791aa0fee9f1c94b472113ccf6 --- M src/osmo-bsc/lb.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/41994/1 diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index a413d2d..b934055 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -570,6 +570,7 @@ static void lb_stop_reset_fsm(void) { + LOGP(DLCS, LOGL_INFO, "Stopping Lb link\n"); bssmap_reset_term_and_free(bsc_gsmnet->smlc->bssmap_reset); bsc_gsmnet->smlc->bssmap_reset = NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41994?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8537874cf6b70791aa0fee9f1c94b472113ccf6 Gerrit-Change-Number: 41994 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sccp_scrc: Improve logging unable to find SCCP user
by pespin 30 Jan '26

30 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41991?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sccp_scrc: Improve logging unable to find SCCP user ...................................................................... sccp_scrc: Improve logging unable to find SCCP user Change-Id: I9277624a260ee2f94f8cd059211aff53cfb50574 --- M src/sccp_scrc.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/91/41991/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9277624a260ee2f94f8cd059211aff53cfb50574 Gerrit-Change-Number: 41991 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-bsc[master]: Lb: Handle SCCP N-NOTICE.ind
by pespin 30 Jan '26

30 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email ) Change subject: Lb: Handle SCCP N-NOTICE.ind ...................................................................... Lb: Handle SCCP N-NOTICE.ind Change-Id: I689bf2f2c4311fbc1da92f02c27078a1c00dda1a --- M src/osmo-bsc/lb.c 1 file changed, 49 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/41992/1 diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index d4f645a..14e3bd8 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -21,6 +21,8 @@ * */ +#include <osmocom/sccp/sccp_types.h> + #include <osmocom/bsc/lb.h> #include <osmocom/gsm/bssmap_le.h> @@ -131,6 +133,48 @@ } } +/* Find an SMLC by its remote SCCP address */ +static struct smlc_config *get_smlc_by_addr(const struct osmo_sccp_addr *smlc_addr) +{ + struct smlc_config *smlc = bsc_gsmnet->smlc; + if (osmo_sccp_addr_ri_cmp(smlc_addr, &smlc->smlc_addr) == 0) + return smlc; + LOGP(DMSC, LOGL_ERROR, "Unable to find SMLC data under address: %s\n", + osmo_sccp_addr_dump(smlc_addr)); + return NULL; +} + +static int handle_notice_ind(const struct osmo_scu_notice_param *ni) +{ + int rc = 0; + struct smlc_config *smlc = get_smlc_by_addr(&ni->calling_addr); + if (!smlc) { + LOGP(DLCS, LOGL_DEBUG, "(calling_addr=%s) N-NOTICE.ind cause=%u='%s' importance=%u didn't match SMLC, ignoring\n", + osmo_sccp_addr_dump(&ni->calling_addr), + ni->cause, osmo_sccp_return_cause_name(ni->cause), + ni->importance); + return -EINVAL; + } + + LOGP(DLCS, LOGL_NOTICE, "(calling_addr=%s) N-NOTICE.ind cause=%u='%s' importance=%u\n", + osmo_sccp_addr_dump(&ni->calling_addr), + ni->cause, osmo_sccp_return_cause_name(ni->cause), + ni->importance); + + switch (ni->cause) { + case SCCP_RETURN_CAUSE_SUBSYSTEM_CONGESTION: + case SCCP_RETURN_CAUSE_NETWORK_CONGESTION: + /* Transient failures (hopefully), keep going. */ + return rc; + default: + break; + } + + /* Messages are not arriving to MSC. Kick the BSSMAP back to DISC state. */ + bssmap_reset_set_disconnected(smlc->bssmap_reset); + return rc; +} + static int sccp_sap_up(struct osmo_prim_hdr *oph, void *_scu) { struct osmo_scu_prim *scu_prim = (struct osmo_scu_prim *)oph; @@ -147,6 +191,11 @@ rc = handle_unitdata_from_smlc(&scu_prim->u.unitdata.calling_addr, oph->msg, scu); break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_NOTICE, PRIM_OP_INDICATION): + DEBUGP(DMSC, "N-NOTICE.ind(%s)\n", osmo_hexdump(msgb_l2(oph->msg), msgb_l2len(oph->msg))); + rc = handle_notice_ind(&scu_prim->u.notice); + break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_CONNECT, PRIM_OP_INDICATION): /* Handle inbound connections. A Location Request is always started on the A interface, and OsmoBSC * forwards this to the SMLC by performing an N-CONNECT from BSC -> SMLC. This is the reverse -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I689bf2f2c4311fbc1da92f02c27078a1c00dda1a Gerrit-Change-Number: 41992 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: Lb: Handle N-PCSTATE.ind
by pespin 30 Jan '26

30 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41993?usp=email ) Change subject: Lb: Handle N-PCSTATE.ind ...................................................................... Lb: Handle N-PCSTATE.ind Change-Id: I16900b9c2b840d4c7d8471c1f69b19601e892b2d --- M src/osmo-bsc/lb.c 1 file changed, 104 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/41993/1 diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index 14e3bd8..a413d2d 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -144,6 +144,17 @@ return NULL; } +/* Find an SMLC by its remote sigtran point code on a given cs7 instance. */ +static struct smlc_config *get_smlc_by_pc(uint32_t pc) +{ + struct smlc_config *smlc = bsc_gsmnet->smlc; + if ((smlc->smlc_addr.presence & OSMO_SCCP_ADDR_T_PC) == 0) + return NULL; + if (smlc->smlc_addr.pc != pc) + return NULL; + return smlc; +} + static int handle_notice_ind(const struct osmo_scu_notice_param *ni) { int rc = 0; @@ -175,6 +186,95 @@ return rc; } +static void handle_pcstate_ind(struct osmo_ss7_instance *cs7, const struct osmo_scu_pcstate_param *pcst) +{ + struct smlc_config *smlc; + bool connected; + bool disconnected; + + LOGP(DLCS, LOGL_DEBUG, "N-PCSTATE ind: affected_pc=%u=%s sp_status=%s remote_sccp_status=%s\n", + pcst->affected_pc, osmo_ss7_pointcode_print(cs7, pcst->affected_pc), + osmo_sccp_sp_status_name(pcst->sp_status), + osmo_sccp_rem_sccp_status_name(pcst->remote_sccp_status)); + + /* If we don't care about that point-code, ignore PCSTATE. */ + smlc = get_smlc_by_pc(pcst->affected_pc); + if (!smlc) + return; + + /* See if this marks the point code to have become available, or to have been lost. + * + * I want to detect two events: + * - connection event (both indicators say PC is reachable). + * - disconnection event (at least one indicator says the PC is not reachable). + * + * There are two separate incoming indicators with various possible values -- the incoming events can be: + * + * - neither connection nor disconnection indicated -- just indicating congestion + * connected == false, disconnected == false --> do nothing. + * - both incoming values indicate that we are connected + * --> trigger connected + * - both indicate we are disconnected + * --> trigger disconnected + * - one value indicates 'connected', the other indicates 'disconnected' + * --> trigger disconnected + * + * Congestion could imply that we're connected, but it does not indicate that a PC's reachability changed, so no need to + * trigger on that. + */ + connected = false; + disconnected = false; + + switch (pcst->sp_status) { + case OSMO_SCCP_SP_S_ACCESSIBLE: + connected = true; + break; + case OSMO_SCCP_SP_S_INACCESSIBLE: + disconnected = true; + break; + default: + case OSMO_SCCP_SP_S_CONGESTED: + /* Neither connecting nor disconnecting */ + break; + } + + switch (pcst->remote_sccp_status) { + case OSMO_SCCP_REM_SCCP_S_AVAILABLE: + if (!disconnected) + connected = true; + break; + case OSMO_SCCP_REM_SCCP_S_UNAVAILABLE_UNKNOWN: + case OSMO_SCCP_REM_SCCP_S_UNEQUIPPED: + case OSMO_SCCP_REM_SCCP_S_INACCESSIBLE: + disconnected = true; + connected = false; + break; + default: + case OSMO_SCCP_REM_SCCP_S_CONGESTED: + /* Neither connecting nor disconnecting */ + break; + } + + if (disconnected && bssmap_reset_is_conn_ready(smlc->bssmap_reset)) { + LOGP(DLCS, LOGL_NOTICE, + "now unreachable: N-PCSTATE ind: pc=%u=%s sp_status=%s remote_sccp_status=%s\n", + pcst->affected_pc, osmo_ss7_pointcode_print(cs7, pcst->affected_pc), + osmo_sccp_sp_status_name(pcst->sp_status), + osmo_sccp_rem_sccp_status_name(pcst->remote_sccp_status)); + /* A previously usable MSC has disconnected. Kick the BSSMAP back to DISC state. */ + bssmap_reset_set_disconnected(smlc->bssmap_reset); + } else if (connected && !bssmap_reset_is_conn_ready(smlc->bssmap_reset)) { + LOGP(DLCS, LOGL_NOTICE, + "now available: N-PCSTATE ind: pc=%u=%s sp_status=%s remote_sccp_status=%s\n", + pcst->affected_pc, osmo_ss7_pointcode_print(cs7, pcst->affected_pc), + osmo_sccp_sp_status_name(pcst->sp_status), + osmo_sccp_rem_sccp_status_name(pcst->remote_sccp_status)); + /* A previously unusable MSC has become reachable. Trigger immediate BSSMAP RESET -- we would resend a + * RESET either way, but we might as well do it now to speed up connecting. */ + bssmap_reset_resend_reset(smlc->bssmap_reset); + } +} + static int sccp_sap_up(struct osmo_prim_hdr *oph, void *_scu) { struct osmo_scu_prim *scu_prim = (struct osmo_scu_prim *)oph; @@ -257,6 +357,10 @@ } break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_PCSTATE, PRIM_OP_INDICATION): + handle_pcstate_ind(osmo_sccp_get_ss7(sccp), &scu_prim->u.pcstate); + break; + default: LOGP(DLCS, LOGL_ERROR, "Unhandled SIGTRAN primitive %s.%s\n", osmo_scu_prim_type_name(oph->primitive), -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I16900b9c2b840d4c7d8471c1f69b19601e892b2d Gerrit-Change-Number: 41993 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sccp_scrc: Log Point code in integer format too
by pespin 30 Jan '26

30 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41991?usp=email ) Change subject: sccp_scrc: Log Point code in integer format too ...................................................................... sccp_scrc: Log Point code in integer format too Change-Id: I9277624a260ee2f94f8cd059211aff53cfb50574 --- M src/sccp_scrc.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/91/41991/1 diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c index 92f7818..36b704e 100644 --- a/src/sccp_scrc.c +++ b/src/sccp_scrc.c @@ -371,8 +371,8 @@ /* Is subsystem equipped? */ if (!scu) { /* Error: unequipped user */ - LOGPSCI(inst, LOGL_NOTICE, "Unable to find user for SSN=%u PC=%s\n", - called->ssn, osmo_ss7_pointcode_print(inst->ss7, called->pc)); + LOGPSCI(inst, LOGL_NOTICE, "Unable to find user for SSN=%u PC=%u=%s\n", + called->ssn, called->pc, osmo_ss7_pointcode_print(inst->ss7, called->pc)); return scrc_node_4(inst, xua, SCCP_RETURN_CAUSE_UNEQUIPPED_USER); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9277624a260ee2f94f8cd059211aff53cfb50574 Gerrit-Change-Number: 41991 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-trace: pySim.apdu_source.stdin_hex
by dexter 30 Jan '26

30 Jan '26

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email ) Change subject: pySim-trace: pySim.apdu_source.stdin_hex ...................................................................... Patch Set 7: Code-Review+2 Verified+1 (1 comment) Patchset: PS7: works fine here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Jan 2026 16:07:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: es9p_client: MAke install notification code execute at all
by dexter 30 Jan '26

30 Jan '26

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41974?usp=email ) Change subject: es9p_client: MAke install notification code execute at all ...................................................................... Patch Set 1: Code-Review+2 Verified+1 (1 comment) Patchset: PS1: I stumbled upon this too ;-) - This patch looks correct to me. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41974?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2d441cfbc1457688eb163301d3d91a1f1fdc7a8c Gerrit-Change-Number: 41974 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 30 Jan 2026 15:42:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: es9p_client: Fix type conversion in installation result notification
by dexter 30 Jan '26

30 Jan '26

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41973?usp=email ) Change subject: es9p_client: Fix type conversion in installation result notification ...................................................................... Patch Set 1: Code-Review+1 Verified+1 (2 comments) Patchset: PS1: > @pmaier@sysmocom.de would be good if you could test this actually against our smdpp code base. I have tested it. There were some hiccups (unrelated to this patch), but I fixed those. PS1: From what I can see this patch looks ok. The fields get properly parsed on the SMDP+ side and I can see the profile lifecycle change when the notification is received. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I83ad047e043dc6b3462b188ce6dd0b2cc0e52e87 Gerrit-Change-Number: 41973 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 30 Jan 2026 15:40:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: es9p_client: smdpOid is optional in download/install notification
by dexter 30 Jan '26

30 Jan '26

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41972?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: es9p_client: smdpOid is optional in download/install notification ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Patchset: PS1: With the patch itself, everything looks good, but I have problems to understand why smdpOid is suddenly optional. Let's double check this first. Commit Message: https://gerrit.osmocom.org/c/pysim/+/41972/comment/e9414046_e6208a3e?usp=em… : PS1, Line 14: smdpOid OBJECT IDENTIFIER OPTIONAL, -- SM-DP+ OID (same value as in CERT.DPpb.ECDSA) This field is not marked as optional in V.2.5 (At least not in my copy RSP Technical Specification Version 2.5 26 May 2023). I have also checked against SGP.22 v3.1 (RSP Technical Specification Version 3.1 Final 01 December 2023) and there it is also not optional. Now I am confused. Can you point me to the spec where this is coming from? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41972?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5df54df2ddc0590a5eca31d4f37ae94053d20067 Gerrit-Change-Number: 41972 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 30 Jan 2026 15:15:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log