- gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: iu_client: rename symbols to prevent clashes with libosmo-ranap

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40849?usp=email ) Change subject: iu_client: rename symbols to prevent clashes with libosmo-ranap ...................................................................... iu_client: rename symbols to prevent clashes with libosmo-ranap While moving the iu_client into osmoSGSN, it's not allowed to have the same global symbols in the library as in osmoSGSN. Change-Id: I2af29b38f110b80f69ef598c8e2700ff323a9d7c --- M include/osmocom/sgsn/iu_client.h M src/sgsn/iu_client.c 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/49/40849/1 diff --git a/include/osmocom/sgsn/iu_client.h b/include/osmocom/sgsn/iu_client.h index 7b5c1b4..8277886 100644 --- a/include/osmocom/sgsn/iu_client.h +++ b/include/osmocom/sgsn/iu_client.h @@ -54,10 +54,10 @@ RANAP_IU_EVENT_NEW_AREA, /* Either a new LAC/RAC has been detected */ }; -extern const struct value_string ranap_iu_event_type_names[]; -static inline const char *ranap_iu_event_type_str(enum ranap_iu_event_type e) +extern const struct value_string iu_client_event_type_names[]; +static inline const char *iu_client_event_type_str(enum ranap_iu_event_type e) { - return get_value_string(ranap_iu_event_type_names, e); + return get_value_string(iu_client_event_type_names, e); } /* Implementations of iu_recv_cb_t shall find the ranap_ue_conn_ctx in msg->dst. */ diff --git a/src/sgsn/iu_client.c b/src/sgsn/iu_client.c index 8d20602..0536e8c 100644 --- a/src/sgsn/iu_client.c +++ b/src/sgsn/iu_client.c @@ -102,7 +102,7 @@ /* This rac will be used internally. RAC with 0xff will be rejected */ #define OSMO_RESERVED_RAC 0xff -const struct value_string ranap_iu_event_type_names[] = { +const struct value_string iu_client_event_type_names[] = { OSMO_VALUE_STRING(RANAP_IU_EVENT_RAB_ASSIGN), OSMO_VALUE_STRING(RANAP_IU_EVENT_SECURITY_MODE_COMPLETE), OSMO_VALUE_STRING(RANAP_IU_EVENT_IU_RELEASE), @@ -121,7 +121,7 @@ if (ue_ctx && !ue_ctx->notification) return 0; - LOGPIU(LOGL_DEBUG, "Submit Iu event to upper layer: %s\n", ranap_iu_event_type_str(type)); + LOGPIU(LOGL_DEBUG, "Submit Iu event to upper layer: %s\n", iu_client_event_type_str(type)); return global_iu_event_cb(ue_ctx, type, data); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2af29b38f110b80f69ef598c8e2700ff323a9d7c Gerrit-Change-Number: 40849 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

2 days, 19 hours

1
0
0 0

[XS] Change in osmo-iuh[master]: move talloc_asn1_ctx into tests/test_common.c

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email ) Change subject: move talloc_asn1_ctx into tests/test_common.c ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: Even it looks, talloc_asn1_ctx is only used by tests, it's actually used by libasn1c. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I79fe6d3e3ac92df70ec536d85d9cf1434252ba8c Gerrit-Change-Number: 40843 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Aug 2025 17:52:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 days, 19 hours

1
0
0 0

[S] Change in osmo-iuh[master]: move enum ranap_nsap_addr_enc into ranap_common.h

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40845?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: move enum ranap_nsap_addr_enc into ranap_common.h ...................................................................... move enum ranap_nsap_addr_enc into ranap_common.h The enum defines how an IP address in a RAB assignment is encoded. This is part of RANAP. Related: OS#5487 Change-Id: Ie281bcf6b03d4cc431902cb0f6b0d5f722c80c74 --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M include/osmocom/ranap/ranap_common.h M src/iu_client_vty.c 4 files changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/45/40845/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ie281bcf6b03d4cc431902cb0f6b0d5f722c80c74 Gerrit-Change-Number: 40845 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

2 days, 20 hours

1
0
0 0

[S] Change in osmo-iuh[master]: move vty functions into own vty.h

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40846?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: move vty functions into own vty.h ...................................................................... move vty functions into own vty.h In preparation to remove iu_client from osmo-iuh, move all non-iu_client stuff out of iu_client files. Related: OS#5487 Change-Id: I8d393d17aa5f004dc4aa4e916bee68f44339e138 --- M TODO-RELEASE M include/osmocom/ranap/Makefile.am M include/osmocom/ranap/iu_client.h A include/osmocom/ranap/vty.h M src/iu_client_vty.c 5 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/46/40846/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8d393d17aa5f004dc4aa4e916bee68f44339e138 Gerrit-Change-Number: 40846 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

2 days, 20 hours

1
0
0 0

[XL] Change in osmo-iuh[master]: Drop iu_client - adopted by osmo-sgsn

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Drop iu_client - adopted by osmo-sgsn ...................................................................... Drop iu_client - adopted by osmo-sgsn The only remaining use of iu_client is osmo-sgsn. iu_client was originally meant to be used by osmo-msc and osmo-sgsn. But the abstraction didn't hold up and osmo-msc stopped using iu_client for a long time. Move iu_client to osmo-sgsn until it got replaced by a more direct implementation (similar to IUCS in osmo-msc). Related: OS#5487 Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M src/Makefile.am D src/iu_client.c 4 files changed, 4 insertions(+), 1,371 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/40847/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de Gerrit-Change-Number: 40847 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

2 days, 20 hours

1
0
0 0

[XL] Change in osmo-iuh[master]: Drop iu_client - adopted by osmo-sgsn

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Drop iu_client - adopted by osmo-sgsn ...................................................................... Drop iu_client - adopted by osmo-sgsn The only remaining use of iu_client is osmo-sgsn. iu_client was originally meant to be used by osmo-msc and osmo-sgsn. But the abstraction didn't hold up and osmo-msc stopped using iu_client for a long time. Move iu_client to osmo-sgsn until it got replaced by a more direct implementation (similar to IUCS in osmo-msc). Related: OS#5487 Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M src/Makefile.am D src/iu_client.c 4 files changed, 4 insertions(+), 1,371 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/40847/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de Gerrit-Change-Number: 40847 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

2 days, 23 hours

1
0
0 0

[S] Change in osmo-iuh[master]: iu_client: fix linter issues

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40848?usp=email ) Change subject: iu_client: fix linter issues ...................................................................... iu_client: fix linter issues Before removing the iu_client. Fix linter issues to make jenkins more happy. Related: OS#5487 Change-Id: Ia8b3405701ed62eac39b9510d34da4ba1987146c --- M include/osmocom/ranap/iu_client.h M src/iu_client.c 2 files changed, 12 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/48/40848/1 diff --git a/include/osmocom/ranap/iu_client.h b/include/osmocom/ranap/iu_client.h index 9fd399e..193c049 100644 --- a/include/osmocom/ranap/iu_client.h +++ b/include/osmocom/ranap/iu_client.h @@ -61,14 +61,14 @@ } /* Implementations of iu_recv_cb_t shall find the ranap_ue_conn_ctx in msg->dst. */ -typedef int (* ranap_iu_recv_cb_t )(struct msgb *msg, struct gprs_ra_id *ra_id, - uint16_t *sai); +typedef int (*ranap_iu_recv_cb_t)(struct msgb *msg, struct gprs_ra_id *ra_id, + uint16_t *sai); -typedef int (* ranap_iu_event_cb_t )(struct ranap_ue_conn_ctx *ue_ctx, - enum ranap_iu_event_type type, void *data); +typedef int (*ranap_iu_event_cb_t)(struct ranap_ue_conn_ctx *ue_ctx, + enum ranap_iu_event_type type, void *data); -typedef int (* ranap_iu_rab_ass_resp_cb_t )(struct ranap_ue_conn_ctx *ue_ctx, uint8_t rab_id, - struct RANAP_RAB_SetupOrModifiedItemIEs_s *setup_ies); +typedef int (*ranap_iu_rab_ass_resp_cb_t)(struct ranap_ue_conn_ctx *ue_ctx, uint8_t rab_id, + struct RANAP_RAB_SetupOrModifiedItemIEs_s *setup_ies); int ranap_iu_init(void *ctx, int log_subsystem, const char *sccp_user_name, struct osmo_sccp_instance *sccp, ranap_iu_recv_cb_t iu_recv_cb, ranap_iu_event_cb_t iu_event_cb); diff --git a/src/iu_client.c b/src/iu_client.c index d2b00e9..34d960b 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -387,7 +387,7 @@ struct msgb *msg; /* create RANAP message */ - msg = ranap_new_msg_sec_mod_cmd(vec->ik, send_ck? vec->ck : NULL, + msg = ranap_new_msg_sec_mod_cmd(vec->ik, send_ck ? vec->ck : NULL, new_key ? RANAP_KeyStatus_new : RANAP_KeyStatus_old); msg->l2h = msg->data; /* wrap RANAP message in SCCP N-DATA.req */ @@ -431,7 +431,7 @@ } #if 0 - -- not used at present -- +/* not used at present */ static int iu_grnc_id_compose(struct iu_grnc_id *src, struct RANAP_GlobalRNC_ID *dst) { /* The caller must ensure proper size */ @@ -515,9 +515,9 @@ return -1; } ra_id = &_ra_id; - if (ies->presenceMask & DIRECTTRANSFERIES_RANAP_RAC_PRESENT) { + if (ies->presenceMask & DIRECTTRANSFERIES_RANAP_RAC_PRESENT) _ra_id.rac = asn1str_to_u8(&ies->rac); - } + if (ies->presenceMask & DIRECTTRANSFERIES_RANAP_SAI_PRESENT) { _sai = asn1str_to_u16(&ies->sai.sAC); sai = &_sai; @@ -656,8 +656,7 @@ " procedureCode 'InitialUE_Message', instead got %u and %u\n", message->direction, message->procedureCode); rc = -1; - } - else + } else rc = ranap_handle_co_initial_ue(ctx, &message->msg.initialUE_MessageIEs); if (rc) { @@ -862,7 +861,7 @@ if (rnc) LOGPIUC(log_level, " at SCCP-addr %s", osmo_sccp_addr_dump(&rnc->sccp_addr)); if (tmsi_or_ptmsi) - LOGPIUC(log_level, ", for %s %08x\n", is_ps? "PTMSI" : "TMSI", *tmsi_or_ptmsi); + LOGPIUC(log_level, ", for %s %08x\n", is_ps ? "PTMSI" : "TMSI", *tmsi_or_ptmsi); else LOGPIUC(log_level, ", for IMSI %s\n", imsi); -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ia8b3405701ed62eac39b9510d34da4ba1987146c Gerrit-Change-Number: 40848 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

2 days, 23 hours

1
0
0 0

[S] Change in osmo-iuh[master]: move general asn debug options into iu_helpers

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40844?usp=email to look at the new patch set (#4). Change subject: move general asn debug options into iu_helpers ...................................................................... move general asn debug options into iu_helpers In prepration to remove iu_client. Move debug variables asn_debug and asn1_xer_print which are not related to iu_client into common part. Related: OS#5487 Change-Id: If5175c449af13fe81e89488df71fcd8192091659 --- M TODO-RELEASE M include/osmocom/iuh/iu_common.h M include/osmocom/ranap/iu_client.h M src/iu_client.c M src/iu_client_vty.c M src/iu_helpers.c 6 files changed, 15 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/44/40844/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40844?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: If5175c449af13fe81e89488df71fcd8192091659 Gerrit-Change-Number: 40844 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

2 days, 23 hours

1
0
0 0

[S] Change in osmo-iuh[master]: move vty functions into own vty.h

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40846?usp=email to look at the new patch set (#3). Change subject: move vty functions into own vty.h ...................................................................... move vty functions into own vty.h In preparation to remove iu_client from osmo-iuh, move all non-iu_client stuff out of iu_client files. Related: OS#5487 Change-Id: I8d393d17aa5f004dc4aa4e916bee68f44339e138 --- M TODO-RELEASE M include/osmocom/ranap/Makefile.am M include/osmocom/ranap/iu_client.h A include/osmocom/ranap/vty.h M src/iu_client_vty.c 5 files changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/46/40846/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8d393d17aa5f004dc4aa4e916bee68f44339e138 Gerrit-Change-Number: 40846 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

2 days, 23 hours

1
0
0 0

[XL] Change in osmo-iuh[master]: Drop iu_client - adopted by osmo-sgsn

by lynxis lazus

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email ) Change subject: Drop iu_client - adopted by osmo-sgsn ...................................................................... Drop iu_client - adopted by osmo-sgsn The only remaining use of iu_client is osmo-sgsn. iu_client was originally meant to be used by osmo-msc and osmo-sgsn. But the abstraction didn't hold up and osmo-msc stopped using iu_client for a long time. Move iu_client to osmo-sgsn until it got replaced by a more direct implementation (similar to IUCS in osmo-msc). Related: OS#5487 Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M src/Makefile.am D src/iu_client.c 4 files changed, 4 insertions(+), 1,372 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/40847/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de Gerrit-Change-Number: 40847 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder

2 days, 23 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log