- gerrit-log - lists.osmocom.org

[XL] Change in osmo-trx[master]: libosmo-trx/client: add TRXC client (command queue) API
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: libosmo-trx/client: add TRXC client (command queue) API ...................................................................... libosmo-trx/client: add TRXC client (command queue) API Add the osmo_trxc_client module: a transport-agnostic generalization of the TRXC command handling logic in osmo-bts-trx (trx_if.c): * command queue with a single command in flight; * retransmission on response timeout (default: 2 s); * suppression of consecutive duplicate commands; * RSP<->CMD matching, optionally including the parameters; * filtering of duplicate responses caused by retransmissions; * escalation of NACKed critical commands (OSMO_TRXC_F_CRITICAL) to the fatal_error call-back; * TRXD PDU version negotiation (SETFORMAT), incl. the fallback to version 0 for old transceivers rejecting it with 'RSP ERR 1'. The client neither opens nor owns a socket: the application transmits serialized messages in the tx_msg call-back and feeds received datagrams into osmo_trxc_client_rx(). The response call-back may return N > 0 to request a re-transmission of the same command after N seconds (e.g. POWERON retry, as implemented in osmo-bts-trx). Change-Id: I817e394f74a10e3adae4a0b58342c82acdf0794e --- M .gitignore M libosmo-trx/include/Makefile.am A libosmo-trx/include/osmocom/trx/trxc_client.h M libosmo-trx/src/Makefile.am A libosmo-trx/src/trxc_client.c M tests/libosmo-trx/Makefile.am A tests/libosmo-trx/trxc_client_test.c A tests/libosmo-trx/trxc_client_test.err A tests/libosmo-trx/trxc_client_test.ok M tests/testsuite.at 10 files changed, 1,117 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/08/43108/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I817e394f74a10e3adae4a0b58342c82acdf0794e Gerrit-Change-Number: 43108 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: libosmo-trx/client: make public API operate on parsed messages
by fixeria 14 Sep '26

14 Sep '26

Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43110?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: libosmo-trx/client: make public API operate on parsed messages ...................................................................... libosmo-trx/client: make public API operate on parsed messages The TRXC client engine and the TRX endpoint module did not compose: osmo_trx_ep_rx_ctrl_msg() delivers a parsed struct osmo_trxc_msg, while osmo_trxc_client_rx() accepts a raw datagram only; likewise, the tx_msg call-back used to emit a serialized string, while osmo_trx_ep_send_ctrl_msg() takes the parsed structure. An osmo_trx_ep user would have to needlessly re-parse and re-serialize TRXC messages when gluing both modules together. Make struct osmo_trxc_msg the currency at both module boundaries: * add osmo_trxc_client_rx_msg(), accepting a parsed message; osmo_trxc_client_rx() becomes a parse-first convenience wrapper for applications managing the TRXC socket themselves; * change the tx_msg call-back to take a parsed message: it's now up to the transport to serialize it (osmo_trx_ep users simply call osmo_trx_ep_send_ctrl_msg(), others osmo_trxc_msg_build()). This is a preparation for porting trxcon to libosmo-trx. Change-Id: Idf53513d06be2337383601494b225b5722c93129 --- M libosmo-trx/include/osmocom/trx/trxc_client.h M libosmo-trx/src/trxc_client.c M tests/libosmo-trx/trxc_client_test.c 3 files changed, 57 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/10/43110/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idf53513d06be2337383601494b225b5722c93129 Gerrit-Change-Number: 43110 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-shell: use verify_adm command for commandline ADM auth
by dexter 14 Sep '26

14 Sep '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/43637?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-shell: use verify_adm command for commandline ADM auth ...................................................................... pySim-shell: use verify_adm command for commandline ADM auth since the very early days, pySim-shell.py has a commandline option where the user may supply an ADM pin as commandline parameter. (-a / --pin-adm and -A --pin-adm-hex) This was introduced to simplify the usage of pySim-shell.py with shellscripts. Unfortunately the code that handles those commandline options duplicates the code of the verify_adm commmand. Fortunately it is very easy to call pySim-shell command methods directly, so we can just replace the handler by calling the do_verify_adm method in the app object. So far we are only able to use ADM1 pins from the commandline, since we now practically use the verify_adm commnad, we can add another parameter to allow the verification of ADM as well. Related: SYS#8239 Change-Id: I7164fad757048774aa7186a84041febde75c351c --- M pySim-shell.py 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/43637/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7164fad757048774aa7186a84041febde75c351c Gerrit-Change-Number: 43637 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XL] Change in osmo-trx[master]: libosmo-trx/ep: add TRX endpoint module
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email ) Change subject: libosmo-trx/ep: add TRX endpoint module ...................................................................... Patch Set 8: (1 comment) File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/e324288d_2c0e6cf2?usp… : PS8, Line 675: * For TRXDv2, the PDUs are batched: they get accumulated until this > I wonder what's the point in having the breaker case (bi=NULL) included into this same function, ins […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3 Gerrit-Change-Number: 43111 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Sep 2026 13:49:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-trx[master]: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email ) Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown ...................................................................... Patch Set 7: (1 comment) File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/24b512c5_5d0162de?usp… : PS6, Line 581: return !llist_empty(&ep->closing_flushes); > > P.S. I am really tired of re-working this patch over and over, and I […] Closing discussion. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56 Gerrit-Change-Number: 43112 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Sep 2026 13:37:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: proxy: queue BURST.req and dispatch per TDMA frame tick
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43612?usp=email ) Change subject: proxy: queue BURST.req and dispatch per TDMA frame tick ...................................................................... Patch Set 3: (2 comments) File proxy/src/burst_fwd.c: https://gerrit.osmocom.org/c/osmo-trx/+/43612/comment/09a2e166_c526f5ab?usp… : PS2, Line 151: llist_for_each_entry(cur, &c->tx_burst_queue, list) { > I guess 99. […] Acknowledged https://gerrit.osmocom.org/c/osmo-trx/+/43612/comment/2088c487_70972feb?usp… : PS2, Line 251: if (rc < 0) { /* br->fn is behind fn */ > OSMO_UNLIKELY() Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib147983e97638d2a2e487ccf76184912caf0941d Gerrit-Change-Number: 43612 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Sep 2026 13:35:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: libosmo-trx/ep: make TRXDv2+ PDU batching configurable
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43627?usp=email ) Change subject: libosmo-trx/ep: make TRXDv2+ PDU batching configurable ...................................................................... Patch Set 1: (1 comment) File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43627/comment/5a77834a_58f0905d?usp… : PS1, Line 823: return ~ep->flags & OSMO_TRX_EP_F_NO_PDU_BATCH; > better do !!(~ep->flags & OSMO_TRX_EP_F_NO_PDU_BATCH) here to convert to bool Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43627?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I60b8337db4ec8e70d37b2d9c0b75da338386ec47 Gerrit-Change-Number: 43627 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Sep 2026 13:35:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-shell: use verify_adm command for commandline ADM auth
by dexter 14 Sep '26

14 Sep '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43637?usp=email ) Change subject: pySim-shell: use verify_adm command for commandline ADM auth ...................................................................... pySim-shell: use verify_adm command for commandline ADM auth since the very early days, pySim-shell.py has a commandline option where the user may supply an ADM pin as commandline parameter. (-a / --pin-adm and -A --pin-adm-hex) This was introduced to simplify the usage of pySim-shell.py with shellscripts. Unfortunately the code that handles those commandline options duplicates the code of the verify_adm commmand. Fortunately it is very easy to call pySim-shell command methods directly, so we can just replace the handler by calling the do_verify_adm method in the app object. So far we are only able to use ADM1 pins from the commandline, since we now practically use the verify_adm commnad, we can add another parameter to allow the verification of ADM as well. Related: SYS#8239 Change-Id: I7164fad757048774aa7186a84041febde75c351c --- M pySim-shell.py 1 file changed, 11 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/43637/1 diff --git a/pySim-shell.py b/pySim-shell.py index d31cf6a..6b563ad 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -1131,8 +1131,11 @@ adm_group = global_group.add_mutually_exclusive_group() adm_group.add_argument('-a', '--pin-adm', metavar='PIN_ADM1', dest='pin_adm', default=None, help='ADM PIN used for provisioning (overwrites default)') -adm_group.add_argument('-A', '--pin-adm-hex', metavar='PIN_ADM1_HEX', dest='pin_adm_hex', default=None, +adm_group.add_argument('-A', '--pin-adm-hex', metavar='PIN_ADM_HEX', dest='pin_adm_hex', default=None, help='ADM PIN used for provisioning, as hex string (16 characters long)') +global_group.add_argument('--pin-adm-type', + choices=[x for x in pin_names.values() if x.startswith('ADM')], + help='Override ADM number. Default is card-model-specific, usually 1') option_parser.add_argument('-e', '--execute-command', action='append', default=[], help='A pySim-shell command that will be executed at startup') @@ -1182,18 +1185,13 @@ # If the user supplies an ADM PIN at via commandline args authenticate # immediately so that the user does not have to use the shell commands - pin_adm = sanitize_pin_adm(opts.pin_adm, opts.pin_adm_hex) - if pin_adm: - if not card: - print("Card error, cannot do ADM verification with supplied ADM pin now.") - try: - card._scc.verify_chv(card._adm_chv_num, h2b(pin_adm)) - except Exception as e: - startup_errors = True - print("ADM verification (%s) failed with an exception:" % str(pin_adm)) - print("---------------------8<---------------------") - print(e) - print("---------------------8<---------------------") + pin_adm_type = "" + if opts.pin_adm_type: + pin_adm_type = "--adm-type %s" % opts.pin_adm_type + if opts.pin_adm: + app.do_verify_adm("%s %s" % (opts.pin_adm, pin_adm_type)) + elif opts.pin_adm_hex: + app.do_verify_adm("%s --pin-is-hex %s" % (opts.pin_adm_hex, pin_adm_type)) # Run optional commands for c in opts.execute_command: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7164fad757048774aa7186a84041febde75c351c Gerrit-Change-Number: 43637 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: contrib/systemd: add a service file for osmo-trx-proxy
by fixeria 14 Sep '26

14 Sep '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43636?usp=email ) Change subject: contrib/systemd: add a service file for osmo-trx-proxy ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43636?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8c5bc092dc5bf6bf07d6e80f64ac7fc06f0cfb96 Gerrit-Change-Number: 43636 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Sep 2026 09:35:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: debian: add packaging for osmo-trx-proxy
by fixeria 14 Sep '26

14 Sep '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43635?usp=email ) Change subject: debian: add packaging for osmo-trx-proxy ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43635?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I995b44bf9a884cf5ba6db8333e6f08c9604a58a5 Gerrit-Change-Number: 43635 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 14 Sep 2026 09:35:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log