Attention is currently required from: laforge, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email )
Change subject: build: make sched_* usage optional
......................................................................
Patch Set 4:
(1 comment)
File src/common/main.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42690/comment/187d03e8_f3efbc57?usp… :
PS3, Line 322: #endif /* HAVE_SCHED_SETSCHEDULER */
> imho if user passes param to set rtprio and it is not supported, the program should at least inform […]
Good point. I updated this accordingly.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906
Gerrit-Change-Number: 42690
Gerrit-PatchSet: 4
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Apr 2026 20:30:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, pespin.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: build: remove unused sys/timerfd.h include
......................................................................
build: remove unused sys/timerfd.h include
The header is not used in scheduler_trx.c and breaks builds on
platforms where timerfd is not available (e.g. Web/emscripten).
Remove the unused include.
Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/42689/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a
Gerrit-Change-Number: 42689
Gerrit-PatchSet: 4
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: Timur Davydov, laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: build: make sched_* usage optional
......................................................................
build: make sched_* usage optional
Add configure checks for sched_* APIs and guard usage of
sched_setscheduler with HAVE_SCHED_SETSCHEDULER.
This avoids build/runtime issues on platforms without
scheduler support.
Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906
---
M configure.ac
M src/common/main.c
2 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/90/42690/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906
Gerrit-Change-Number: 42690
Gerrit-PatchSet: 4
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: trx, bts: add optional WebSDR backend (callback-based transport)
......................................................................
trx, bts: add optional WebSDR backend (callback-based transport)
Introduce WebSDR backend enabled via ENABLE_WEBSDR,
adding an alternative callback-based transport alongside
existing socket-based TRX/OSMUX I/O
Implement:
- TRX control via osmotrxlib_process_command()
- TRXD data via apitrx_tx_call()/trx_data_read()
- clock handling via apibts_clock_ind() and external timers
- Osmux integration via ws_osmux_* helpers
Adapt scheduler to support API-based burst submission and
external timer callbacks in WebSDR mode
Disable signal handling, stats and socket I/O when building
with ENABLE_WEBSDR
Add WebSDR API entrypoint, Emscripten build target and
example configuration
Enables running BTS/TRX stack in WebAssembly environments
Change-Id: Idebd588f33afd85021813ad5821391781db683a9
---
M .gitignore
A doc/examples/trx/osmo-bts-trx-websdr.cfg
M src/common/main.c
M src/common/osmux.c
M src/osmo-bts-trx/Makefile.am
M src/osmo-bts-trx/main.c
A src/osmo-bts-trx/osmo-bts-trx-websdr.c
A src/osmo-bts-trx/osmo-bts-trx-websdr.h
M src/osmo-bts-trx/scheduler_trx.c
M src/osmo-bts-trx/trx_if.c
M src/osmo-bts-trx/trx_vty.c
11 files changed, 715 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/03/42703/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9
Gerrit-Change-Number: 42703
Gerrit-PatchSet: 6
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42704?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: trx: add JSON stats export for WebSDR API
......................................................................
trx: add JSON stats export for WebSDR API
Introduce stats_json.c providing JSON serialization for:
- stats and counters
- rate counters
- BTS state
- TRX/transceiver state
- WebSDR runtime metrics
Add osmobts_get_stats() API to expose these via WebSDR
interface and export it in Emscripten build
This enables programmatic access to data previously available
via VTY (e.g. "show stats", "show bts")
Change-Id: Ifb82adfab879a65ecd222c45e06551983aa90a0f
---
M src/osmo-bts-trx/Makefile.am
M src/osmo-bts-trx/osmo-bts-trx-websdr.c
A src/osmo-bts-trx/stats_json.c
A src/osmo-bts-trx/stats_json.h
4 files changed, 752 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/04/42704/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42704?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifb82adfab879a65ecd222c45e06551983aa90a0f
Gerrit-Change-Number: 42704
Gerrit-PatchSet: 6
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Attention is currently required from: fixeria, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email )
Change subject: build: make timerfd usage optional
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bts-trx/scheduler_trx.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42689/comment/598ef953_14dc2f92?usp… :
PS3, Line 56: #endif
> so the code doesn't fail if this header is not included? why? is this header needed here?
Right, the code builds fine without this header.
None of the symbols from <sys/timerfd.h> are used in this file, so the include is not required. It was likely left over from earlier code or copied from somewhere else.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a
Gerrit-Change-Number: 42689
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Apr 2026 20:14:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email )
Change subject: convolve: avoid function pointer casts by adding wrapper functions
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> why are the wrappers not static?
Good point. These wrappers are not used outside of this compilation unit, so they can be made static. I’ll update them accordingly.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Idecb118be285eb3e4691d1761d0d8fa24fd80c75
Gerrit-Change-Number: 42655
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Apr 2026 19:57:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email )
Change subject: build: detect pthread_setname_np and sched_* APIs, guard usage
......................................................................
Patch Set 2:
(1 comment)
File CommonLibs/Threads.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42654/comment/4476c5bd_bb6b32a6?usp… :
PS1, Line 39:
> missing "#include "config. […]
Good catch, thanks. I’ll add the missing #include "config.h" to all files with HAVE_ stuff is added.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f1492544439d88c5e6683330c6696de1c2f85b
Gerrit-Change-Number: 42654
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Apr 2026 19:57:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen, fixeria, laforge.
Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: transceiver: add optional WebSDR device support
......................................................................
Patch Set 12:
(11 comments)
File Transceiver52M/Transceiver.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/583bde8c_2a92ac44?usp… :
PS12, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/1d0d29e3_100e0cc3?usp… :
PS12, Line 247: TIMESTAMP ts, unsigned samples_skipped);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/54d668bd_9982859b?usp… :
PS12, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/9634dc63_906b90d5?usp… :
PS12, Line 265: ssize_t driveReceiveFIFOBurst(size_t chan, char *burstBuffer, size_t burstBufferLen);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/14c3478c_5999ab1f?usp… :
PS12, Line 271: @brief modulation and sorting of GSM bursts from GSM core
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/2800b8e7_1bc0808a?usp… :
PS12, Line 272: @param chan channel number
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/d7dd61a6_479f626a?usp… :
PS12, Line 273: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/327dc68e_240e5eb9?usp… :
PS12, Line 274: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/45729f65_9659be64?usp… :
PS12, Line 277: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0);
please, no spaces at the start of a line
File Transceiver52M/radioInterface.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/48549833_b9f8280d?usp… :
PS12, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/ad38529c_4e5207b9?usp… :
PS12, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts);
please, no spaces at the start of a line
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
Gerrit-Change-Number: 42411
Gerrit-PatchSet: 12
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Apr 2026 19:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Timur Davydov.
Hello Hoernchen, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: convolve: avoid function pointer casts by adding wrapper functions
......................................................................
convolve: avoid function pointer casts by adding wrapper functions
Introduce _base_convolve_*_void() wrappers matching the expected
function pointer signatures and use them instead of casting
_base_convolve_* functions to (void *).
This removes unsafe function pointer casts and improves
type safety, which is required for stricter toolchains and
non-native targets (e.g. WebAssembly)
Change-Id: Idecb118be285eb3e4691d1761d0d8fa24fd80c75
---
M Transceiver52M/arch/x86/convolve.c
1 file changed, 27 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/55/42655/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Idecb118be285eb3e4691d1761d0d8fa24fd80c75
Gerrit-Change-Number: 42655
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>