- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: CCID: Add testenv.cfg to run tests using testenv
by jolly 10 Jun '26

10 Jun '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42827?usp=email ) Change subject: CCID: Add testenv.cfg to run tests using testenv ...................................................................... CCID: Add testenv.cfg to run tests using testenv Change-Id: I97c9da414facf438aa28d5200c4152730ff763a2 --- A ccid/testenv.cfg 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/42827/1 diff --git a/ccid/testenv.cfg b/ccid/testenv.cfg new file mode 100644 index 0000000..a895ff3 --- /dev/null +++ b/ccid/testenv.cfg @@ -0,0 +1,5 @@ +[testsuite] +program=CCID_Tests +config=CCID_Tests.cfg +podman_extra=--volume /dev/bus/usb:/dev/bus/usb + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97c9da414facf438aa28d5200c4152730ff763a2 Gerrit-Change-Number: 42827 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP: UESecurityCapabilities is optional in PathSwitchRequestAcknowledge
by jolly 10 Jun '26

10 Jun '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42826?usp=email ) Change subject: NGAP: UESecurityCapabilities is optional in PathSwitchRequestAcknowledge ...................................................................... NGAP: UESecurityCapabilities is optional in PathSwitchRequestAcknowledge Current master branch of Open5GS includes UESecurityCapabilities IE in PathSwitchRequestAcknowledge, older versions do not. In order to match message of all versions, replace the IE by an an asterisk. Change-Id: I4849709d2601505d9aa3ea6c85b718ec65540dff --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/42826/1 diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index ac351b0..3fb0b6d 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -5078,11 +5078,7 @@ criticality := ignore, value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } }, - { - id := id_UESecurityCapabilities, - criticality := reject, - value_ := { UESecurityCapabilities := p_uESecurityCapabilities } - }, + *, { id := id_SecurityContext, criticality := reject, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4849709d2601505d9aa3ea6c85b718ec65540dff Gerrit-Change-Number: 42826 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmo-ci[master]: coverity/jenkins: check if upload was successful
by laforge 09 Jun '26

09 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42820?usp=email ) Change subject: coverity/jenkins: check if upload was successful ...................................................................... coverity/jenkins: check if upload was successful When the server returns an error, the curl command does not fail - probably because the server sends a wrong http status code: curl \ --form token="$token" \ --form email=holger(a)freyther.de --form file=(a)Osmocom.tgz \ --form version=Version --form description=AutoUpload \ https://scan.coverity.com/builds?project=Osmocom + set +x % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed … <html> <head><title>413 Request Entity Too Large</title></head> <body> <center><h1>413 Request Entity Too Large</h1></center> <hr><center>nginx/1.19.10</center> </body> </html> Finished: SUCCESS Fail if the output doesn't contain the "Build successfully submitted" string, so the job fails if there was an error. (The request entity too large error is probably an error on their end, scan.coverity.com still says they are performing upgrades on their servers.) Change-Id: Ie63a33dfa7648b38f1f01cb8c87db76949f69e10 --- M coverity/jenkins.sh 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/coverity/jenkins.sh b/coverity/jenkins.sh index d19b93c..ca02f5f 100755 --- a/coverity/jenkins.sh +++ b/coverity/jenkins.sh @@ -40,4 +40,11 @@ exit 1 fi -eval "$curl_cmd" +eval "$curl_cmd" | tee output.html + +if ! grep -q "Build successfully submitted" output.html; then + set +x + echo + echo "ERROR: coverity upload has failed!" + exit 1 +fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie63a33dfa7648b38f1f01cb8c87db76949f69e10 Gerrit-Change-Number: 42820 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ci[master]: coverity/jenkins: check if upload was successful
by fixeria 09 Jun '26

09 Jun '26

Attention is currently required from: lynxis lazus, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42820?usp=email ) Change subject: coverity/jenkins: check if upload was successful ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie63a33dfa7648b38f1f01cb8c87db76949f69e10 Gerrit-Change-Number: 42820 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 18:14:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: Transceiver52M: fix viterbi-eq soft bits on platforms where char is u...
by manawyrm 09 Jun '26

09 Jun '26

manawyrm has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email ) Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ...................................................................... Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned The viterbi-eq demodulator stores soft bits into chars. "char" is signed on x86/amd64 but unsigned on arm64. On arm64 the stored byte 0x81 (== -127) is read back as +129, so after the sign flip and vectorSlicer() clamp every soft bit collapses to 0.0. The same issue also appears to be present in the MS code path, so it was (blindly) fixed there as well. The MS fixes are untested! Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/grgsm_vitac/grgsm_vitac.cpp M Transceiver52M/grgsm_vitac/grgsm_vitac.h M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_lower.cpp M Transceiver52M/ms/ms_upper.h M utils/va-test/burst-gen.cpp 7 files changed, 36 insertions(+), 18 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 17bf148..46d06db 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -623,7 +623,7 @@ std::complex<float> chan_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR]; float ncmax; const unsigned burst_len_bits = 148 + 8; - char demodded_softbits[burst_len_bits]; + sbit_t demodded_softbits[burst_len_bits]; SoftVector *bits = new SoftVector(burst_len_bits); if (type == CorrType::TSC) { diff --git a/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp b/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp index 2016541..9cba859 100644 --- a/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp +++ b/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp @@ -39,6 +39,10 @@ #include "viterbi_detector.h" #include "grgsm_vitac.h" +extern "C" { +#include <osmocom/core/bits.h> +} + gr_complex d_acc_training_seq[N_ACCESS_BITS]; ///<encoded training sequence of a RACH burst gr_complex d_sch_training_seq[N_SYNC_BITS]; ///<encoded training sequence of a SCH burst gr_complex d_norm_training_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS]; ///<encoded training sequences of a normal and dummy burst @@ -77,7 +81,7 @@ template <unsigned int burst_size> NO_UBSAN static void detect_burst_generic(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, - char *output_binary, int ss) + sbit_t *output_binary, int ss) { std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR); unsigned int stop_states[2] = { 4, 12 }; @@ -98,22 +102,22 @@ output_binary[i] = output[i] > 0 ? -127 : 127; // pre flip bits! } -NO_UBSAN void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary, +NO_UBSAN void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, sbit_t *output_binary, int ss) { return detect_burst_generic<BURST_SIZE>(input, chan_imp_resp, burst_start, output_binary, ss); } -NO_UBSAN void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary, +NO_UBSAN void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, sbit_t *output_binary, int ss) { return detect_burst_generic<8 + 41 + 36 + 3>(input, chan_imp_resp, burst_start, output_binary, ss); } -NO_UBSAN void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary) +NO_UBSAN void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, sbit_t *output_binary) { return detect_burst_nb(input, chan_imp_resp, burst_start, output_binary, 3); } -NO_UBSAN void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary) +NO_UBSAN void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, sbit_t *output_binary) { return detect_burst_ab(input, chan_imp_resp, burst_start, output_binary, 3); } diff --git a/Transceiver52M/grgsm_vitac/grgsm_vitac.h b/Transceiver52M/grgsm_vitac/grgsm_vitac.h index c1e470c..084fde2 100644 --- a/Transceiver52M/grgsm_vitac/grgsm_vitac.h +++ b/Transceiver52M/grgsm_vitac/grgsm_vitac.h @@ -24,6 +24,10 @@ #include <vector> #include "constants.h" +extern "C" { +#include <osmocom/core/bits.h> +} + /* may only be used for for the DEFINITIONS! * see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91664 */ @@ -63,10 +67,10 @@ int process_vita_burst(gr_complex *input, int tsc, unsigned char *output_binary); int process_vita_sc_burst(gr_complex *input, int tsc, unsigned char *output_binary, int *offset); -void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary, int ss); -void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary, int ss); -void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary); -void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary); +void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, sbit_t *output_binary, int ss); +void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, sbit_t *output_binary, int ss); +void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, sbit_t *output_binary); +void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, sbit_t *output_binary); void gmsk_mapper(const unsigned char *input, int nitems, gr_complex *gmsk_output, gr_complex start_point); gr_complex correlate_sequence(const gr_complex *sequence, int length, const gr_complex *input); diff --git a/Transceiver52M/ms/ms.h b/Transceiver52M/ms/ms.h index 2ad78de..70e7445 100644 --- a/Transceiver52M/ms/ms.h +++ b/Transceiver52M/ms/ms.h @@ -43,6 +43,9 @@ #include "itrq.h" #include "threadpool.h" #include "threadsched.h" +extern "C" { +#include <osmocom/core/bits.h> +} const unsigned int ONE_TS_BURST_LEN = (3 + 58 + 26 + 58 + 3 + 8.25) * 4 /*sps*/; const unsigned int SCH_LEN_SPS = (ONE_TS_BURST_LEN * 8 /*ts*/ * 12 /*frames*/); @@ -129,7 +132,7 @@ GSM::Time gsmts; union { blade_sample_type burst[ONE_TS_BURST_LEN]; - char sch_bits[148]; + sbit_t sch_bits[148]; }; }; diff --git a/Transceiver52M/ms/ms_rx_lower.cpp b/Transceiver52M/ms/ms_rx_lower.cpp index d894e96..1cc3ffb 100644 --- a/Transceiver52M/ms/ms_rx_lower.cpp +++ b/Transceiver52M/ms/ms_rx_lower.cpp @@ -34,6 +34,8 @@ extern "C" { #include "sch.h" + +#include <osmocom/core/bits.h> } #ifdef LOG @@ -123,7 +125,7 @@ gain_check = (gain_check + 1) % avgburst_num; } -static char sch_demod_bits[148]; +static sbit_t sch_demod_bits[148]; bool ms_trx::handle_sch_or_nb() { @@ -174,7 +176,7 @@ } detect_burst_nb(&ss[start], &channel_imp_resp[0], 0, sch_demod_bits); - auto sch_decode_success = decode_sch(sch_demod_bits, is_first_sch_acq); + auto sch_decode_success = decode_sch((char *)sch_demod_bits, is_first_sch_acq); #if 0 auto burst = new signalVector(buf_len, 50); const auto corr_type = is_first_sch_acq ? sch_detect_type::SCH_DETECT_BUFFER : sch_detect_type::SCH_DETECT_FULL; diff --git a/Transceiver52M/ms/ms_upper.h b/Transceiver52M/ms/ms_upper.h index 06f7c54..c35a67c 100644 --- a/Transceiver52M/ms/ms_upper.h +++ b/Transceiver52M/ms/ms_upper.h @@ -26,9 +26,13 @@ #include "GSMCommon.h" #include "ms.h" +extern "C" { +#include <osmocom/core/bits.h> +} + class upper_trx : public ms_trx { volatile bool mOn; - char demodded_softbits[444]; + sbit_t demodded_softbits[444]; // void driveControl(); bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset); diff --git a/utils/va-test/burst-gen.cpp b/utils/va-test/burst-gen.cpp index bdd0c4b..ee3b1f7 100644 --- a/utils/va-test/burst-gen.cpp +++ b/utils/va-test/burst-gen.cpp @@ -27,6 +27,7 @@ extern "C" { #include "convert.h" #include <convolve.h> +#include <osmocom/core/bits.h> } #define _CRT_SECURE_NO_WARNINGS @@ -291,7 +292,7 @@ std::cerr << "demod test va:" << std::endl; std::complex<float> chan_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR]; float ncmax; - char demodded_softbits[444]; + sbit_t demodded_softbits[444]; // demod at known offset { @@ -376,7 +377,7 @@ if (rs.ct == CorrType::RACH) { std::complex<float> chan_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR]; float ncmax; - char demodded_softbits[444]; + sbit_t demodded_softbits[444]; int normal_burst_start = 0; normal_burst_start = get_access_imp_resp(conved_beg, &chan_imp_resp[0], &ncmax, 0); normal_burst_start = std::max(normal_burst_start, 0); @@ -414,7 +415,7 @@ } else { std::complex<float> chan_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR]; float ncmax; - char demodded_softbits[444]; + sbit_t demodded_softbits[444]; auto normal_burst_start = get_norm_chan_imp_resp(conved_beg, &chan_imp_resp[0], &ncmax, tsc); detect_burst_nb(conved_beg, &chan_imp_resp[0], normal_burst_start + 0, demodded_softbits); @@ -431,7 +432,7 @@ } struct estim_burst_params ebp; - char demodded_softbits[444]; + sbit_t demodded_softbits[444]; complex *rx_sigproc_cfloat = reinterpret_cast<complex *>(conved_beg); signalVector sv(rx_sigproc_cfloat, 0, rs.convolved->size(), dummy_alloc, dummy_free); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 Gerrit-Change-Number: 42822 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: Transceiver52M: fix viterbi-eq soft bits on platforms where char is u...
by fixeria 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, laforge, manawyrm. fixeria has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email ) Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 Gerrit-Change-Number: 42822 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 09 Jun 2026 18:03:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: Transceiver52M: fix viterbi-eq soft bits on platforms where char is u...
by pespin 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, fixeria, laforge, manawyrm. pespin has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email ) Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 Gerrit-Change-Number: 42822 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jun 2026 16:58:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: for TCAP loadshare: use NI == national
by pespin 09 Jun '26

09 Jun '26

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42825?usp=email ) Change subject: stp: for TCAP loadshare: use NI == national ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: AFAIR we should be using International in general, why changing it to national? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I51ef302ad72ff3c434fddb39006ce50106a5918f Gerrit-Change-Number: 42825 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 16:56:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: tcap-loadshare: add TC_tcap_loadshare_m3ua_to_ipa_udts
by pespin 09 Jun '26

09 Jun '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42824?usp=email ) Change subject: stp: tcap-loadshare: add TC_tcap_loadshare_m3ua_to_ipa_udts ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42824/comment/ab7d1c16_7108… : PS1, Line 844: testcase TC_tcap_loadshare_m3ua_to_ipa_udts() runs on TCAP_CT { Can you please add a descritpion for the test here, like you did in the commit description? Otherwise it's time consuming trying to figure out what a test is exactly testing when was written. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I181b25aedfd70d156c08197d361560b6d055e65a Gerrit-Change-Number: 42824 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 16:56:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: m3ua: fix missing decoding of message priority & network indicator flag
by lynxis lazus 09 Jun '26

09 Jun '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email ) Change subject: m3ua: fix missing decoding of message priority & network indicator flag ...................................................................... m3ua: fix missing decoding of message priority & network indicator flag The missing parenthesis always or'ed with a 0x0 into the sio field because of operator precendence. Left shift is stronger than a binary and. Related: SYS#8061 Change-Id: I7a07363646f66c5c672a2c0d261ca33356b43031 --- M src/m3ua.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/m3ua.c b/src/m3ua.c index 243f5b9..583800b 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -324,8 +324,8 @@ param->sls = mdh->sls; /* re-construct SIO */ param->sio = (mdh->si & 0xF) | - (mdh->mp & 0x3 << 4) | - (mdh->ni & 0x3 << 6); + ((mdh->mp & 0x3) << 4) | + ((mdh->ni & 0x3) << 6); } struct msgb *m3ua_msgb_alloc(const char *name) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7a07363646f66c5c672a2c0d261ca33356b43031 Gerrit-Change-Number: 42823 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log