- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested
by dexter 18 Mar '26

18 Mar '26

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email ) Change subject: global_platform: install_cap_parser: argument groups cannot be nested ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I think claude has chased its own tail here a bit. It first detected that it if the --install-parameters-* are used, all must be used at once, but this was only because the gen_install_parameters had a wrong logical operator (and vs or). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579 Gerrit-Change-Number: 42310 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 15:29:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: global_platform: make --install-parameters-* independently optional
by dexter 18 Mar '26

18 Mar '26

Attention is currently required from: fixeria. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42378?usp=email ) Change subject: global_platform: make --install-parameters-* independently optional ...................................................................... Patch Set 3: Code-Review-1 (6 comments) Patchset: PS3: This patch looks correct to me but it needs polishing. File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42378/comment/22e1f0a3_9b8a25df?usp=em… : PS3, Line 901: # `--install-parameters-*` are all optional Better fix this in the patch before. File pySim/global_platform/install_param.py: https://gerrit.osmocom.org/c/pysim/+/42378/comment/d00b8813_e4d76196?usp=em… : PS3, Line 58: if non_volatile_memory_quota and volatile_memory_quota and stk_parameter: I think the error here is that it should be 'or' instead of 'and'. Only then the following code makes sense. https://gerrit.osmocom.org/c/pysim/+/42378/comment/b9231988_b76b76bc?usp=em… : PS3, Line 60: this looks correct, but I would add some comments to make the code easier to understand: # collect system specific parameters (optional) https://gerrit.osmocom.org/c/pysim/+/42378/comment/5e06b89d_f4093258?usp=em… : PS3, Line 67: system_specific_params.append({'stk_parameter': stk_parameter}) # If system specific parameters are present, add them to the install parameters File tests/unittests/test_globalplatform.py: https://gerrit.osmocom.org/c/pysim/+/42378/comment/c798f8f3_49d13fda?usp=em… : PS3, Line 298: load_parameters = gen_install_parameters() interesting that this does not change in behavior. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8756fb38016cdf0527fe2e21edb44381d1dc557f Gerrit-Change-Number: 42378 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 15:25:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested
by dexter 18 Mar '26

18 Mar '26

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email ) Change subject: global_platform: install_cap_parser: argument groups cannot be nested ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42310/comment/05344e8c_d2a12e07?usp=em… : PS2, Line 904: opts.install_parameters_stk is None: When one of the --install-parameters-* is missing we throw an exception. Maybe move this code part to the if branch above and compare with "not None"? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579 Gerrit-Change-Number: 42310 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 14:58:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested
by dexter 18 Mar '26

18 Mar '26

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email ) Change subject: global_platform: install_cap_parser: argument groups cannot be nested ...................................................................... Patch Set 2: Verified+1 (2 comments) Patchset: PS2: I have tested this patch, everything still works fine. File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42310/comment/529fa6d8_68998018?usp=em… : PS2, Line 905: raise ValueError("Either --install-parameters alone, or all --install-parameters-* must be specified") I would write "--install-parameters cannot be mixed with --install-parameters-* arguments.". Actually none of those --install-parameters-* is mandatory, see gen_install_parameters in install_param.py -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579 Gerrit-Change-Number: 42310 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 14:39:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT
by fixeria 18 Mar '26

18 Mar '26

Attention is currently required from: Timur Davydov, laforge, pespin. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email ) Change subject: transceiver: return -EINVAL for invalid SETSLOT ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/975d1d46_b617638d?usp… : PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ > Nevermind, I got confused and thought both parts of the diff belong to the same function. Reading the code again more carefully, I see that we **are** bypassing `transceiver->ctrl_sock_send()` if `ctrl_cmd_handle()` returns a negative. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53 Gerrit-Change-Number: 42421 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Mar 2026 13:50:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: 5gc: Update mobility procedure status
by osmith 18 Mar '26

18 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42423?usp=email ) Change subject: 5gc: Update mobility procedure status ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6bb8672fbd553a1a2a51b97a8360658afa0fddff Gerrit-Change-Number: 42423 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 13:46:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT
by fixeria 18 Mar '26

18 Mar '26

Attention is currently required from: Timur Davydov, laforge, pespin. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email ) Change subject: transceiver: return -EINVAL for invalid SETSLOT ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/2b5594b6_ac8e4964?usp… : PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ > If you return early, you bypass `transceiver->ctrl_sock_send()` and the error response is never sent […] Nevermind, I got confused and thought both parts of the diff belong to the same function. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53 Gerrit-Change-Number: 42421 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Mar 2026 13:46:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_ran_initiated_qos_flow_mobility
by osmith 18 Mar '26

18 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42417?usp=email ) Change subject: 5gc: Introduce test TC_ran_initiated_qos_flow_mobility ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1a1df29fa254496990d3d9099b3072433468ecb1 Gerrit-Change-Number: 42417 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 13:46:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix wrong IE id in n2_PDUSessionResourceModifyConfirm
by osmith 18 Mar '26

18 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42419?usp=email ) Change subject: NGAP_Templates: Fix wrong IE id in n2_PDUSessionResourceModifyConfirm ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iddcf4e3081d47f91e3b6ec52186116bf93e28c90 Gerrit-Change-Number: 42419 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 13:45:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_secondary_rat_data_usage_report
by osmith 18 Mar '26

18 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42418?usp=email ) Change subject: 5gc: Introduce test TC_secondary_rat_data_usage_report ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42418?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8a82b1a8bcea948356d819af5c4919ae3829e549 Gerrit-Change-Number: 42418 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 13:44:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log