- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Handle N-PCSTATE.ind to wait for peer availability
by pespin 30 Jan '26

30 Jan '26

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41968?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: RAN_Emulation: Handle N-PCSTATE.ind to wait for peer availability ...................................................................... RAN_Emulation: Handle N-PCSTATE.ind to wait for peer availability Take the chance to explicitly log and discard other .ind primitives which would otherwise block the processing of messages. Change-Id: I86b481fca9b7be84f3cda9fbce83e60820fe7fc1 Related: OS#6907 --- M bsc/BSC_Tests.ttcn M library/BSSAP_CodecPort.ttcn M library/RAN_Emulation.ttcnpp M library/ranap/RANAP_CodecPort.ttcn M msc/MSC_Tests.ttcn 5 files changed, 150 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/41968/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41968?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86b481fca9b7be84f3cda9fbce83e60820fe7fc1 Gerrit-Change-Number: 41968 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: es9p_client: smdpOid is optional in download/install notification
by dexter 30 Jan '26

30 Jan '26

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41972?usp=email ) Change subject: es9p_client: smdpOid is optional in download/install notification ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41972?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5df54df2ddc0590a5eca31d4f37ae94053d20067 Gerrit-Change-Number: 41972 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 30 Jan 2026 10:25:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: logging: Avoid infinite loop logging inside logging path
by pespin 30 Jan '26

30 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41978?usp=email ) Change subject: logging: Avoid infinite loop logging inside logging path ...................................................................... logging: Avoid infinite loop logging inside logging path If eg. gsmtap_log target is requested to log a message but the iofd wqueue is full, it may try to log an error message, which will create an infinite stack loop. Change-Id: If3b8c0ee97537242162558fdd1c99f03b32af811 --- M include/osmocom/core/logging_internal.h M src/core/logging.c 2 files changed, 22 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/core/logging_internal.h b/include/osmocom/core/logging_internal.h index 68d4c4b..0cc82a4 100644 --- a/include/osmocom/core/logging_internal.h +++ b/include/osmocom/core/logging_internal.h @@ -4,16 +4,25 @@ * @{ * \file logging_internal.h */ +#include <stdbool.h> #include <osmocom/core/logging.h> #include <osmocom/core/utils.h> /* maximum length of the log string of a single log event (typically line) */ #define MAX_LOG_SIZE 4096 +struct log_thread_state { + /* Whether we are inside a code path to generate logging output: */ + bool logging_active; + /* Cache TID: */ + long int tid; +}; + extern void *tall_log_ctx; extern struct log_info *osmo_log_info; extern const struct value_string loglevel_strs[]; extern struct llist_head osmo_log_target_list; +extern __thread struct log_thread_state log_thread_state; void assert_loginfo(const char *src); diff --git a/src/core/logging.c b/src/core/logging.c index af5698a..3e60597 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -84,7 +84,7 @@ void *tall_log_ctx = NULL; LLIST_HEAD(osmo_log_target_list); -static __thread long int logging_tid; +__thread struct log_thread_state log_thread_state; #if (!EMBEDDED) /*! One global copy that contains the union of log levels for all targets @@ -606,9 +606,9 @@ OSMO_STRBUF_PRINTF(sb, " "); } if (target->print_tid) { - if (logging_tid == 0) - logging_tid = (long int)osmo_gettid(); - OSMO_STRBUF_PRINTF(sb, "%ld ", logging_tid); + if (log_thread_state.tid == 0) + log_thread_state.tid = (long int)osmo_gettid(); + OSMO_STRBUF_PRINTF(sb, "%ld ", log_thread_state.tid); } if (target->print_category) OSMO_STRBUF_PRINTF(sb, "%s%s%s%s ", @@ -743,6 +743,14 @@ { struct log_target *tar; + if (OSMO_UNLIKELY(log_thread_state.logging_active)) { + /* Avoid re-entrant logging: If logging to log target generates + * extra logging (eg. an error log line due to some wqueue being full), + * we may end up in an infinite loop. */ + return; + } + log_thread_state.logging_active = true; + subsys = map_subsys(subsys); #if !defined(EMBEDDED) @@ -776,6 +784,7 @@ } log_tgt_mutex_unlock(); + log_thread_state.logging_active = false; } /*! logging function used by DEBUGP() macro -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If3b8c0ee97537242162558fdd1c99f03b32af811 Gerrit-Change-Number: 41978 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: logging: Avoid infinite loop logging inside logging path
by pespin 30 Jan '26

30 Jan '26

Attention is currently required from: daniel, fixeria, jolly, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41978?usp=email ) Change subject: logging: Avoid infinite loop logging inside logging path ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Readding +2 after fixing the typo in the comment and moving it further earlier in the patchset. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If3b8c0ee97537242162558fdd1c99f03b32af811 Gerrit-Change-Number: 41978 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Jan 2026 09:53:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: Modified to dynamically adjust the returned QoS length to ensure comp...
by pespin 30 Jan '26

30 Jan '26

Attention is currently required from: canghaiwuhen, fixeria, laforge. pespin has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email ) Change subject: Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 9: Code-Review-1 (1 comment) Patchset: PS9: This is clearly not yet ready for review since it contains an unresolved merge conflict in the file. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 9 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Fri, 30 Jan 2026 09:45:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: stats_tcp.c: Remove unneeded EMBEDDED check
by pespin 30 Jan '26

30 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41979?usp=email ) Change subject: stats_tcp.c: Remove unneeded EMBEDDED check ...................................................................... stats_tcp.c: Remove unneeded EMBEDDED check The HAVE_LINUX_TCP define check should be enough. Change-Id: I68cb49925aa49ad97b266638d41f38c22fc32000 --- M src/core/stats_tcp.c 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/core/stats_tcp.c b/src/core/stats_tcp.c index 282f306..5e0a25f 100644 --- a/src/core/stats_tcp.c +++ b/src/core/stats_tcp.c @@ -22,7 +22,6 @@ * \file stats_tcp.c */ #include "config.h" -#if !defined(EMBEDDED) #include <errno.h> @@ -350,6 +349,4 @@ #endif /* HAVE_LINUX_TCP_H */ -#endif /* !EMBEDDED */ - /* @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I68cb49925aa49ad97b266638d41f38c22fc32000 Gerrit-Change-Number: 41979 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: logging: Avoid infinite loop logging inside logging path
by pespin 30 Jan '26

30 Jan '26

Attention is currently required from: daniel, fixeria, jolly, laforge, osmith. Hello Jenkins Builder, daniel, fixeria, jolly, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41978?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: logging: Avoid infinite loop logging inside logging path ...................................................................... logging: Avoid infinite loop logging inside logging path If eg. gsmtap_log target is requested to log a message but the iofd wqueue is full, it may try to log an error message, which will create an infinite stack loop. Change-Id: If3b8c0ee97537242162558fdd1c99f03b32af811 --- M include/osmocom/core/logging_internal.h M src/core/logging.c 2 files changed, 22 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/78/41978/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If3b8c0ee97537242162558fdd1c99f03b32af811 Gerrit-Change-Number: 41978 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: logging: Avoid infinite loop logging inside logging path
by pespin 30 Jan '26

30 Jan '26

Attention is currently required from: daniel, fixeria, jolly, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41978?usp=email ) Change subject: logging: Avoid infinite loop logging inside logging path ...................................................................... Patch Set 2: (1 comment) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/41978/comment/4be6c2e1_b5297e23?… : PS2, Line 748: duet o > "due to", formatting Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If3b8c0ee97537242162558fdd1c99f03b32af811 Gerrit-Change-Number: 41978 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Jan 2026 09:42:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: logging_file: Avoid reopening file for stderr
by pespin 30 Jan '26

30 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41970?usp=email ) Change subject: logging_file: Avoid reopening file for stderr ...................................................................... logging_file: Avoid reopening file for stderr target->tgt_file.fname is NULL for stderr log target. Change-Id: I4a551b0c434c480e78852a0a4873700eac2f5853 --- M src/core/logging_file.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/core/logging_file.c b/src/core/logging_file.c index a9a1cb7..6e01c26 100644 --- a/src/core/logging_file.c +++ b/src/core/logging_file.c @@ -55,6 +55,9 @@ OSMO_ASSERT(target->type == LOG_TGT_TYPE_FILE || target->type == LOG_TGT_TYPE_STDERR); OSMO_ASSERT(target->tgt_file.out || target->tgt_file.wqueue); + if (target->type == LOG_TGT_TYPE_STDERR) + return -ENOTSUP; + if (target->tgt_file.out) { fclose(target->tgt_file.out); target->tgt_file.out = fopen(target->tgt_file.fname, "a"); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4a551b0c434c480e78852a0a4873700eac2f5853 Gerrit-Change-Number: 41970 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: logging_file: Fix log_target_file_switch_to_stream on stderr
by pespin 30 Jan '26

30 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41975?usp=email ) Change subject: logging_file: Fix log_target_file_switch_to_stream on stderr ...................................................................... logging_file: Fix log_target_file_switch_to_stream on stderr In stderr log target, the bfd of the wq was left registered despite freeing the wq, which ended up in the callback being called and the freed wq being used. Change-Id: I1c0d833fb8ae82d1dd54e44cc2fc8be80d5e1b4b --- M src/core/logging_file.c 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/core/logging_file.c b/src/core/logging_file.c index 6e01c26..99a797c 100644 --- a/src/core/logging_file.c +++ b/src/core/logging_file.c @@ -213,11 +213,10 @@ } /* now that everything succeeded, we can finally close the old output fd */ - if (target->type == LOG_TGT_TYPE_FILE) { - osmo_fd_unregister(&wq->bfd); + osmo_fd_unregister(&wq->bfd); + if (target->type == LOG_TGT_TYPE_FILE) close(wq->bfd.fd); - wq->bfd.fd = -1; - } + wq->bfd.fd = -1; /* release the queue itself */ talloc_free(wq); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c0d833fb8ae82d1dd54e44cc2fc8be80d5e1b4b Gerrit-Change-Number: 41975 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log