Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email )
Change subject: logging: change gsmtap target to use wqueue by default
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/core/logging.h:
https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/d6b2f693_7f4641ce?… :
PS1, Line 356: bool ofd_wq_mode;
> this is breaking ABI. […]
It's used outside of libosmocore, so I am not going to touch it.
Shall I add an entry to TODO-RELEASE?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9d8c953a5b467ce4396d2d20ca6fa72a749723c0
Gerrit-Change-Number: 41685
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Dec 2025 13:29:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email )
Change subject: logging: change gsmtap target to use wqueue by default
......................................................................
Patch Set 1:
(1 comment)
File src/vty/logging_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/b51d971e_7d41e010?… :
PS1, Line 1047: if (tgt->tgt_gsmtap.ofd_wq_mode)
> You don't need here the new field tgt->tgt_gsmtap.ofd_wq_mode: […]
I would do exactly that if `struct gsmtap_inst` were public, but it's not.
It's an opaque struct for us here and we cannot access its fields.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9d8c953a5b467ce4396d2d20ca6fa72a749723c0
Gerrit-Change-Number: 41685
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Dec 2025 13:25:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email )
Change subject: logging: change gsmtap target to use wqueue by default
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/048d35c2_ccf9e02c?… :
PS1, Line 12: target, which can also be blocking under some circumstances.
> which can also be blocking if UDP socket buffer becomes full.
"UDP socket send buffer"
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9d8c953a5b467ce4396d2d20ca6fa72a749723c0
Gerrit-Change-Number: 41685
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Dec 2025 13:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email )
Change subject: logging: change gsmtap target to use wqueue by default
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/184afbc5_ced71834?… :
PS1, Line 12: target, which can also be blocking under some circumstances.
which can also be blocking if UDP socket buffer becomes full.
File include/osmocom/core/logging.h:
https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/ee83b3d6_0605adc1?… :
PS1, Line 356: bool ofd_wq_mode;
this is breaking ABI.Can you check if log_target struct is used anywhere outside of libosmocore? If not, we can move this struct to an internal header.
File src/vty/logging_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/b6247ed3_1873a50e?… :
PS1, Line 1047: if (tgt->tgt_gsmtap.ofd_wq_mode)
You don't need here the new field tgt->tgt_gsmtap.ofd_wq_mode:
if (!target->tgt_gsmtap.gsmtap_inst || target->tgt_gsmtap.gsmtap_inst->osmo_io_mode)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9d8c953a5b467ce4396d2d20ca6fa72a749723c0
Gerrit-Change-Number: 41685
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Dec 2025 13:19:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
wbokslag has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-tetra/+/41682?usp=email )
Change subject: Added example keyfile
......................................................................
Added example keyfile
Added an example keyfile that people can use when trying to decrypt
TEA-encrypted traffic. Note that a legitimate 80-bit key is needed.
This is not a cracking tool.
Change-Id: I7e13dcd10546e118e2cf9845f14121862db0cca9
---
A src/example_keyfile.txt
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/82/41682/1
diff --git a/src/example_keyfile.txt b/src/example_keyfile.txt
new file mode 100644
index 0000000..93e2b06
--- /dev/null
+++ b/src/example_keyfile.txt
@@ -0,0 +1,2 @@
+network mcc 204 mnc 1337 ksg_type 1 security_class 2
+key mcc 204 mnc 1337 addr 00000000 key_type 1 key_num 1234 key 00112233445566778899
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/41682?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I7e13dcd10546e118e2cf9845f14121862db0cca9
Gerrit-Change-Number: 41682
Gerrit-PatchSet: 1
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>