- gerrit-log - lists.osmocom.org

[S] Change in osmo-ccid-firmware[master]: 7816fsm: reset stale cuart state on FSM RESET entry
by jolly 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. jolly has uploaded a new patch set (#2) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42779?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: 7816fsm: reset stale cuart state on FSM RESET entry ...................................................................... 7816fsm: reset stale cuart state on FSM RESET entry Reset paths reached without power-cycling (WTIME_EXP, HW_ERR, CARD_REMOVAL during a warm reset) leave the cuart with stale tx_busy, rx_threshold and wtime_etu from the prior transaction. The next ATR then hits card_uart_tx tx_busy assertion, or the ATR receive stalls because the 33-byte ATR can never reach a multi-byte rx_threshold left from a TPDU. The new card_uart_tx_abort() clears tx_busy + rx_after_tx_compl + WT, without driving a synthetic TX_COMPLETE through the FSM. iso7816_3_reset_onenter is the right place to do this alongside rx_threshold=1 and wtime_etu=default, this mirrors what card_uart_ctrl(POWER_*=0) already does, but for the warm-reset paths that don't touch power. Change-Id: Iac8bd7f4f0eecccc9acce149277a4f5016fec7c1 --- M ccid_common/ccid_slot_fsm.c M ccid_common/cuart.c M ccid_common/cuart.h M ccid_common/iso7816_fsm.c 4 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/79/42779/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iac8bd7f4f0eecccc9acce149277a4f5016fec7c1 Gerrit-Change-Number: 42779 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ci[master]: coverity/jenkins: check if upload was successful
by laforge 09 Jun '26

09 Jun '26

Attention is currently required from: daniel, fixeria, lynxis lazus, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42820?usp=email ) Change subject: coverity/jenkins: check if upload was successful ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie63a33dfa7648b38f1f01cb8c87db76949f69e10 Gerrit-Change-Number: 42820 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 11:43:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: 7816fsm: state_chg before card_uart_tx in tpdu_s_procedure_action
by jolly 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. jolly has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42781?usp=email ) Change subject: 7816fsm: state_chg before card_uart_tx in tpdu_s_procedure_action ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42781/comment/3f2b1452_b6… : PS1, Line 1397: card_uart_set_rx_threshold(ip->uart, 1); > What about here? It is also required to swap the state change with the uart control? Never mind. This is a card-uart_ctrl (not card_uart_tx). No need to swap things here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Id66f836452674209e25dc3ee4c37d616de30001b Gerrit-Change-Number: 42781 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 10:25:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix compare ignoring non-TCAP messages and remove ...
by lynxis lazus 09 Jun '26

09 Jun '26

Attention is currently required from: daniel. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42821?usp=email ) Change subject: tcap_as_loadshare: Fix compare ignoring non-TCAP messages and remove assert ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0831b289e4e4e94fd1b719e6c7164c3dd87c9f88 Gerrit-Change-Number: 42821 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jun 2026 10:18:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix compare ignoring non-TCAP messages and remove ...
by daniel 09 Jun '26

09 Jun '26

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42821?usp=email ) Change subject: tcap_as_loadshare: Fix compare ignoring non-TCAP messages and remove assert ...................................................................... tcap_as_loadshare: Fix compare ignoring non-TCAP messages and remove assert The previous check in asp_loadshare_tcap_sccp() was was never true because it checked msg class twice instead of class and type. Also remove the OSMO_ASSERT in send_back_udts() limiting the function to CL/DT messages. Related: SYS#5432 Change-Id: I0831b289e4e4e94fd1b719e6c7164c3dd87c9f88 --- M src/tcap_as_loadshare.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/21/42821/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index a9783f5..f3fd2f9 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -419,8 +419,6 @@ struct osmo_mtp_transfer_param new_mtp; uint32_t rctx; - OSMO_ASSERT(orig_sua->hdr.msg_class == SUA_MSGC_CL && orig_sua->hdr.msg_type == SUA_CL_CLDT); - if (!xua_msg_get_u32p(orig_sua, SUA_IEI_PROTO_CLASS, &spare_proto)) return -EINVAL; @@ -487,8 +485,9 @@ goto out_free_msgb; } + /* TODO: (How) should we route UDTS (CL/DR) messages containing TCAP? */ /* TCAP uses only connectionless SCCP messages */ - if (sua->hdr.msg_class != SUA_MSGC_CL && sua->hdr.msg_class != SUA_CL_CLDT) { + if (!(sua->hdr.msg_class == SUA_MSGC_CL && sua->hdr.msg_type == SUA_CL_CLDT)) { /* ignoring packets */ rc = -EPROTONOSUPPORT; goto out_free_sua; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0831b289e4e4e94fd1b719e6c7164c3dd87c9f88 Gerrit-Change-Number: 42821 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: coverity/jenkins: check if upload was successful
by osmith 09 Jun '26

09 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42820?usp=email ) Change subject: coverity/jenkins: check if upload was successful ...................................................................... coverity/jenkins: check if upload was successful When the server returns an error, the curl command does not fail - probably because the server sends a wrong http status code: curl \ --form token="$token" \ --form email=holger(a)freyther.de --form file=(a)Osmocom.tgz \ --form version=Version --form description=AutoUpload \ https://scan.coverity.com/builds?project=Osmocom + set +x % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed … <html> <head><title>413 Request Entity Too Large</title></head> <body> <center><h1>413 Request Entity Too Large</h1></center> <hr><center>nginx/1.19.10</center> </body> </html> Finished: SUCCESS Fail if the output doesn't contain the "Build successfully submitted" string, so the job fails if there was an error. (The request entity too large error is probably an error on their end, scan.coverity.com still says they are performing upgrades on their servers.) Change-Id: Ie63a33dfa7648b38f1f01cb8c87db76949f69e10 --- M coverity/jenkins.sh 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/20/42820/1 diff --git a/coverity/jenkins.sh b/coverity/jenkins.sh index d19b93c..ca02f5f 100755 --- a/coverity/jenkins.sh +++ b/coverity/jenkins.sh @@ -40,4 +40,11 @@ exit 1 fi -eval "$curl_cmd" +eval "$curl_cmd" | tee output.html + +if ! grep -q "Build successfully submitted" output.html; then + set +x + echo + echo "ERROR: coverity upload has failed!" + exit 1 +fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie63a33dfa7648b38f1f01cb8c87db76949f69e10 Gerrit-Change-Number: 42820 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix newline on log message
by daniel 09 Jun '26

09 Jun '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42819?usp=email ) Change subject: tcap_as_loadshare: Fix newline on log message ...................................................................... tcap_as_loadshare: Fix newline on log message Change-Id: Iad85ec2d4e6a64d84a865c23eb00fddcb6d767c9 --- M src/tcap_as_loadshare.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index b8941af..a9783f5 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -584,7 +584,7 @@ asp = tcap_trans_track_end(as, &called_addr, &parsed.dtid, &calling_addr, NULL); if (!asp) { - LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP End, dtid %u, using tcap route", parsed.dtid); + LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP End, dtid %u, using tcap route\n", parsed.dtid); rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_MISS); asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); if (!asp && as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iad85ec2d4e6a64d84a865c23eb00fddcb6d767c9 Gerrit-Change-Number: 42819 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix newline on log message
by lynxis lazus 09 Jun '26

09 Jun '26

Attention is currently required from: daniel. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42819?usp=email ) Change subject: tcap_as_loadshare: Fix newline on log message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iad85ec2d4e6a64d84a865c23eb00fddcb6d767c9 Gerrit-Change-Number: 42819 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jun 2026 08:17:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix newline on log message
by daniel 09 Jun '26

09 Jun '26

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42819?usp=email ) Change subject: tcap_as_loadshare: Fix newline on log message ...................................................................... tcap_as_loadshare: Fix newline on log message Change-Id: Iad85ec2d4e6a64d84a865c23eb00fddcb6d767c9 --- M src/tcap_as_loadshare.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/19/42819/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index b8941af..a9783f5 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -584,7 +584,7 @@ asp = tcap_trans_track_end(as, &called_addr, &parsed.dtid, &calling_addr, NULL); if (!asp) { - LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP End, dtid %u, using tcap route", parsed.dtid); + LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP End, dtid %u, using tcap route\n", parsed.dtid); rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_MISS); asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); if (!asp && as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iad85ec2d4e6a64d84a865c23eb00fddcb6d767c9 Gerrit-Change-Number: 42819 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Send a wrong procedure byte towards the reader
by Hoernchen 08 Jun '26

08 Jun '26

Attention is currently required from: jolly. Hoernchen has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42796?usp=email ) Change subject: CCID: Send a wrong procedure byte towards the reader ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: wait a second, READ BINARY is case 2, not 3? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa0bd8845b3408fba309874fe41c855d8e7efccc Gerrit-Change-Number: 42796 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 21:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log